Attention is currently required from: pespin.
jolly has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/43758?usp=email )
Change subject: sigtran.adoc: Document IPSP support
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/43758?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Change-Id: I5489b0ea485943b96038da49c81e812a6da22492
Gerrit-Change-Number: 43758
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 02 Oct 2026 12:09:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: jolly.
Hello Jenkins Builder, fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/43757?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: Add description for IP DSCP (QoS) support of libosmo-sigtran
......................................................................
Add description for IP DSCP (QoS) support of libosmo-sigtran
Related: OS#6753
Change-Id: I57e1fa47f811132116deefe769ed6b7e90d11e49
---
M common/chapters/sigtran-osmocom.adoc
M common/chapters/sigtran.adoc
2 files changed, 44 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/57/43757/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/43757?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Change-Id: I57e1fa47f811132116deefe769ed6b7e90d11e49
Gerrit-Change-Number: 43757
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Attention is currently required from: fixeria, jolly.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43753?usp=email )
Change subject: ss7_asp_peer: Improvements in ss7_asp_peer_snprintf()
......................................................................
Patch Set 3:
(1 comment)
File src/ss7_asp_peer.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43753/comment/11586266_0dcbc… :
PS2, Line 68: peer->host[0]
> Done
Please note
osmo_multiaddr_ip_and_port_snprintf() (the func I took as a reference) expects an array of buffers, not an array of pointers to buffers, hence why the NULL case isn't checked there.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43753?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I115951627adb0c6778a9a36159237c3eea130300
Gerrit-Change-Number: 43753
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 02 Oct 2026 11:42:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: jolly <andreas(a)eversberg.eu>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: fixeria, jolly.
Hello Jenkins Builder, fixeria, jolly,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43753?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+1 by fixeria, Verified+1 by Jenkins Builder
Change subject: ss7_asp_peer: Improvements in ss7_asp_peer_snprintf()
......................................................................
ss7_asp_peer: Improvements in ss7_asp_peer_snprintf()
Convert it to osmo_strbuf, which simplifies the logic of the function,
taking osmo_multiaddr_ip_and_port_snprintf() as reference to implement it.
As a result:
* Single IPv6 addresses now get properly enclosed in [], eg:
"[::]:2905".
* We avoid passing NULL to snprintf(), which is unspecified on some
platforms.
Change-Id: I115951627adb0c6778a9a36159237c3eea130300
---
M src/ss7_asp_peer.c
1 file changed, 24 insertions(+), 23 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/53/43753/3
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43753?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I115951627adb0c6778a9a36159237c3eea130300
Gerrit-Change-Number: 43753
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/43758?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: sigtran.adoc: Document IPSP support
......................................................................
sigtran.adoc: Document IPSP support
libosmo-sigtran has support for IPSP role since version 2.3.0, update
the documentation accordingly.
Mention that IPSP role is not yet supported for IPA ASPs.
Related SYS#6474
Change-Id: I5489b0ea485943b96038da49c81e812a6da22492
---
M common/chapters/sigtran.adoc
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/58/43758/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/43758?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Change-Id: I5489b0ea485943b96038da49c81e812a6da22492
Gerrit-Change-Number: 43758
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder