pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/41975?usp=email )
Change subject: logging_file: Fix log_target_file_switch_to_stream on stderr
......................................................................
logging_file: Fix log_target_file_switch_to_stream on stderr
In stderr log target, the bfd of the wq was left registered despite
freeing the wq, which ended up in the callback being called and the
freed wq being used.
Change-Id: I1c0d833fb8ae82d1dd54e44cc2fc8be80d5e1b4b
---
M src/core/logging_file.c
1 file changed, 3 insertions(+), 4 deletions(-)
Approvals:
fixeria: Looks good to me, approved
osmith: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/src/core/logging_file.c b/src/core/logging_file.c
index 6e01c26..99a797c 100644
--- a/src/core/logging_file.c
+++ b/src/core/logging_file.c
@@ -213,11 +213,10 @@
}
/* now that everything succeeded, we can finally close the old output fd */
- if (target->type == LOG_TGT_TYPE_FILE) {
- osmo_fd_unregister(&wq->bfd);
+ osmo_fd_unregister(&wq->bfd);
+ if (target->type == LOG_TGT_TYPE_FILE)
close(wq->bfd.fd);
- wq->bfd.fd = -1;
- }
+ wq->bfd.fd = -1;
/* release the queue itself */
talloc_free(wq);
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41975?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I1c0d833fb8ae82d1dd54e44cc2fc8be80d5e1b4b
Gerrit-Change-Number: 41975
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41962?usp=email )
Change subject: Osmocom_Types: Add API ro_integer_get_first_pos()
......................................................................
Osmocom_Types: Add API ro_integer_get_first_pos()
It is sometimes useful to find out the position of the 1st item (only
one if the list is expected to be a set of unique items), in order to
update extra state on an external list.t
Change-Id: Id70b2c7d6bf702489de03aed1c389ae892aee835
---
M library/Osmocom_Types.ttcn
1 file changed, 9 insertions(+), 3 deletions(-)
Approvals:
Jenkins Builder: Verified
osmith: Looks good to me, but someone else must approve
fixeria: Looks good to me, approved
diff --git a/library/Osmocom_Types.ttcn b/library/Osmocom_Types.ttcn
index 690535c..6fbcb39 100644
--- a/library/Osmocom_Types.ttcn
+++ b/library/Osmocom_Types.ttcn
@@ -401,13 +401,19 @@
type record of integer ro_integer;
-function ro_integer_contains(ro_integer r, integer x) return boolean {
+/* returns position of "x" in "r", -1 otherwise. */
+function ro_integer_get_first_pos(ro_integer r, integer x) return integer {
for (var integer j := 0; j < lengthof(r); j := j+1) {
if (r[j] == x) {
- return true;
+ return j;
}
}
- return false;
+ return -1;
+}
+
+
+function ro_integer_contains(ro_integer r, integer x) return boolean {
+ return ro_integer_get_first_pos(r, x) != -1;
}
function ro_integer_add_unique(inout ro_integer roi, integer new_entry)
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41962?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id70b2c7d6bf702489de03aed1c389ae892aee835
Gerrit-Change-Number: 41962
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41965?usp=email )
(
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
)Change subject: cosmetic: library/BSSAP_CodecPort.ttcn: Fix trailing whitespace
......................................................................
cosmetic: library/BSSAP_CodecPort.ttcn: Fix trailing whitespace
Change-Id: I3bbb035eda0690a862989a0ec4bda265b506db3a
---
M library/BSSAP_CodecPort.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
osmith: Looks good to me, approved
diff --git a/library/BSSAP_CodecPort.ttcn b/library/BSSAP_CodecPort.ttcn
index 2bb6ab6..ce9248e 100644
--- a/library/BSSAP_CodecPort.ttcn
+++ b/library/BSSAP_CodecPort.ttcn
@@ -354,7 +354,7 @@
} with {extension "prototype(fast)" }
-/*
+/*
type port BSSAP_CODEC_PT message map to SCCPasp_PT {
out BSSAP_N_CONNECT_req to ASP_SCCP_N_CONNECT_req with f_enc_ConnectReq(),
BSSAP_N_CONNECT_res to ASP_SCCP_N_CONNECT_res with f_enc_ConnectRes(),
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41965?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I3bbb035eda0690a862989a0ec4bda265b506db3a
Gerrit-Change-Number: 41965
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41966?usp=email )
(
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
)Change subject: smlc: Drop unused port BSSAP_LE in test_CT
......................................................................
smlc: Drop unused port BSSAP_LE in test_CT
Change-Id: If9e45e890d595f6ee837b30b947456bcf39f67c1
---
M smlc/SMLC_Tests.ttcn
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
osmith: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/smlc/SMLC_Tests.ttcn b/smlc/SMLC_Tests.ttcn
index 1d317bb..5dc86e5 100644
--- a/smlc/SMLC_Tests.ttcn
+++ b/smlc/SMLC_Tests.ttcn
@@ -61,7 +61,6 @@
type component test_CT extends CTRL_Adapter_CT, StatsD_ConnHdlr {
var BSSAP_LE_Adapter g_bssap_le[NUM_BSC];
- port BSSAP_LE_CODEC_PT BSSAP_LE;
port TELNETasp_PT SMLCVTY;
port TELNETasp_PT STPVTY;
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41966?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: If9e45e890d595f6ee837b30b947456bcf39f67c1
Gerrit-Change-Number: 41966
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Attention is currently required from: canghaiwuhen, fixeria, laforge, pespin.
canghaiwuhen has posted comments on this change by canghaiwuhen. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/41948?usp=email )
Change subject: Modified to dynamically adjust the returned QoS length to ensure compatibility with older modules.
......................................................................
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/41948?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I872d882de4ce186f644b1b3ab684963050709d4f
Gerrit-Change-Number: 41948
Gerrit-PatchSet: 9
Gerrit-Owner: canghaiwuhen <canghaiwuhen(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: canghaiwuhen <canghaiwuhen(a)gmail.com>
Gerrit-Comment-Date: Fri, 30 Jan 2026 07:04:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No