Attention is currently required from: laforge, pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41891?usp=email )
Change subject: logging: Make struct log_context and struct log_target private
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Indeed. […]
I am not strictly against breaking API at some point (ideally once, applying similar patches removing deprecated stuff). After all, there have been changes breaking old code in less obvious ways, like https://osmocom.org/issues/6728 (talloc parentship mess), so what's the point of ensuring that old code compiles given that it will just crash at run-time (referring to https://osmocom.org/issues/6728 again here).
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41891?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Iecbd07995ccb465a44be0debcc97458b2b240a0e
Gerrit-Change-Number: 41891
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 20 Jan 2026 14:36:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: fixeria, laforge.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41891?usp=email )
Change subject: logging: Make struct log_context and struct log_target private
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> I assume old code (still referencing this struct and its members) will no longer compile against lib […]
Indeed. We can break this once and make it private, or keep forever trying to fit new stuff and breaking it 20x times like we did in the past.
In any case, compiling older code against this new libosmocore is quite straighforward, it only needs the new APIs introduced in the previous patch (which can easily be backported), and some small fixes in some apps (most apps don't access those members, so they are fine).
For reference, I faced I needed this fixed once I wanted to switch the current file log_target to use osmo_io so it can benefit from io_uring (https://osmocom.org/issues/6918).
I'll add a reference to this patch next time somebody submits a patch with a public struct instead of adding proper APIs :P
PD: I'm fine with merging this after a while, early before doing a new release, or even after. In any case, that means delaying osmo_io support there.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41891?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Iecbd07995ccb465a44be0debcc97458b2b240a0e
Gerrit-Change-Number: 41891
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 20 Jan 2026 14:15:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: pespin.
Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41878?usp=email )
Change subject: build: move netns/tun conditionals to configure.ac Move Linux-/embedded-specific conditional compilation out of the sources and into configure.ac.
......................................................................
Patch Set 1:
(1 comment)
File configure.ac:
https://gerrit.osmocom.org/c/libosmocore/+/41878/comment/0ce0dba1_9ef31925?… :
PS1, Line 242: AM_CONDITIONAL(ENABLE_TUN, test "x$embedded" != "xyes")
> In this patch, ENABLE_TUN is a noop, so it doesn't make sense to have a patch containing that imho. […]
Agreed. I'll drop ENABLE_TUN from this patch and just use !EMBEDDED.
For Emscripten I'll add a proper configure-time capability check for the actual tun.c dependency and exclude it only when that check fails.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41878?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I2322eb2936bea35596f1fd6b6a713ea5f997b1ea
Gerrit-Change-Number: 41878
Gerrit-PatchSet: 1
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 20 Jan 2026 14:11:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: Timur Davydov <dtv.comp(a)gmail.com>