Attention is currently required from: pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41971?usp=email )
Change subject: logging_file: Clean log_target_file_reopen()
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
> Not blocking, but I find this variant without if-else less readable than the current code. […]
Acknowledged
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41971?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibcb50320ad80b034115cccc3b7ab90501ac1d091
Gerrit-Change-Number: 41971
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 29 Jan 2026 23:50:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: dexter.
laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41973?usp=email )
Change subject: es9p_client: Fix type conversion in installation result notification
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
@pmaier@sysmocom.de would be good if you could test this actually against our smdpp code base.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/41973?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I83ad047e043dc6b3462b188ce6dd0b2cc0e52e87
Gerrit-Change-Number: 41973
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 29 Jan 2026 23:48:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41971?usp=email )
Change subject: logging_file: Clean log_target_file_reopen()
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
Not blocking, but I find this variant without if-else less readable than the current code. Maybe use a switch statement?
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41971?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibcb50320ad80b034115cccc3b7ab90501ac1d091
Gerrit-Change-Number: 41971
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 29 Jan 2026 18:35:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No