Attention is currently required from: pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41980?usp=email )
Change subject: Use same queue length for gsmtap_log and gsmtap_file
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41980?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I3772d291f97626ee325731f3515a5110eda70d3d
Gerrit-Change-Number: 41980
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 29 Jan 2026 11:34:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: osmith.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41967?usp=email )
Change subject: BSSAP_LE_Emulation: Handle N-PCSTATE.ind to wait for peer availability
......................................................................
Patch Set 2:
(1 comment)
File library/BSSAP_LE_Emulation.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41967/comment/51e9a2c3_51f4… :
PS2, Line 566: /* Done, assume PCs for which we didn't receive an explicit "unavailable" are actually available. */
> see my comments about adding log messages here: https://gerrit.osmocom. […]
In here the log line 551 "is now available" already lets you infer this
information, so it's fine. I don't want to clog the log with more than
necessary.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41967?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I6a40d1ddcd3a7dbde9f6c8b51439e9ab4d1da469
Gerrit-Change-Number: 41967
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 29 Jan 2026 11:34:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Attention is currently required from: osmith.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41968?usp=email )
Change subject: RAN_Emulation: Handle N-PCSTATE.ind to wait for peer availability
......................................................................
Patch Set 2:
(2 comments)
File library/RAN_Emulation.ttcnpp:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41968/comment/bf18183c_3c86… :
PS2, Line 1423: /* Done, assume PCs for which we didn't receive an explicit "unavailable" are actually available. */
> See logging comments here: https://gerrit.osmocom. […]
In here the log line 1408 "is now available" already lets you infer this information, so it's fine. I don't want to clog the log with more than necessary.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41968/comment/8eb52cfa_1e4b… :
PS2, Line 1464: /* Done, assume PCs for which we didn't receive an explicit "unavailable" are actually available. */
> See logging comments here: https://gerrit.osmocom. […]
In here the log line 1449 "is now available" already lets you infer this
information, so it's fine. I don't want to clog the log with more than
necessary.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41968?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I86b481fca9b7be84f3cda9fbce83e60820fe7fc1
Gerrit-Change-Number: 41968
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 29 Jan 2026 11:33:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Attention is currently required from: osmith.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41963?usp=email )
Change subject: stp: Handle N-PCSTATE.ind in STP_Tests_TCAP.ttcn
......................................................................
Patch Set 1:
(2 comments)
File stp/STP_Tests_TCAP.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41963/comment/b7bd2d6c_1682… :
PS1, Line 142: /* All peers are explicitly available, we are done */
> Maybe log a message here too to be explicit that it didn't run into the timeout (which also causes i […]
See line 158. peer_st_list there tells you that information.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41963/comment/224a4c93_d42b… :
PS1, Line 155: /* Done, assume PCs for which we didn't receive an explicit "unavailable" are actually available. */
> Log a warning here when this happens?
See line 158. peer_st_list there tells you that information.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41963?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie1beb2cd69ce1847f3b3bd9917b42a2acaef57c8
Gerrit-Change-Number: 41963
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 29 Jan 2026 11:31:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Attention is currently required from: daniel, fixeria, pespin.
Hello Jenkins Builder, daniel, fixeria, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ci/+/41977?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: repo-install-test: debian 10: osmo-gbproxy only
......................................................................
repo-install-test: debian 10: osmo-gbproxy only
The debian 10 repository has been officially disabled:
https://osmocom.org/news/308
However we just re-enabled a subset of the packages, osmo-gbproxy +
dependencies, because currently they are relevant for a customer. Adjust
the repo-install-test to deal with this subset of packages for debian 10
to fix that it is currently failing.
I have verified that repo-install-test works with this change for debian
10, 11 and 12. It currently doesn't run for debian 13 yet (OS#6934).
Related: SYS#7859
Change-Id: Id8d8cda8e399719f06aeb1843eb8f5ab12a90e8f
---
M scripts/repo-install-test/run-inside.sh
1 file changed, 37 insertions(+), 38 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/77/41977/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41977?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Id8d8cda8e399719f06aeb1843eb8f5ab12a90e8f
Gerrit-Change-Number: 41977
Gerrit-PatchSet: 4
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Attention is currently required from: daniel, fixeria, pespin.
osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/41977?usp=email )
Change subject: repo-install-test: debian 10: osmo-gbproxy only
......................................................................
Patch Set 3:
(1 comment)
File scripts/repo-install-test/run-inside.sh:
https://gerrit.osmocom.org/c/osmo-ci/+/41977/comment/b05632d8_b92a1566?usp=… :
PS2, Line 366: # Get a list of all packages from the repository. Reference:
> Can't you leave the generic path for debian10 too here?
Done (and tested again)
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41977?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Id8d8cda8e399719f06aeb1843eb8f5ab12a90e8f
Gerrit-Change-Number: 41977
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 29 Jan 2026 11:29:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: daniel, fixeria, osmith.
Hello Jenkins Builder, daniel, fixeria, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ci/+/41977?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: repo-install-test: debian 10: osmo-gbproxy only
......................................................................
repo-install-test: debian 10: osmo-gbproxy only
The debian 10 repository has been officially disabled:
https://osmocom.org/news/308
However we just re-enabled a subset of the packages, osmo-gbproxy +
dependencies, because currently they are relevant for a customer. Adjust
the repo-install-test to deal with this subset of packages for debian 10
to fix that it is currently failing.
I have verified that repo-install-test works with this change for debian
10, 11 and 12. It currently doesn't run for debian 13 yet (OS#6934).
Related: SYS#7859
Change-Id: Id8d8cda8e399719f06aeb1843eb8f5ab12a90e8f
---
M scripts/repo-install-test/run-inside.sh
1 file changed, 37 insertions(+), 39 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/77/41977/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41977?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Id8d8cda8e399719f06aeb1843eb8f5ab12a90e8f
Gerrit-Change-Number: 41977
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>