January 2026 - gerrit-log - lists.osmocom.org

[S] Change in libosmocore[master]: build: control USE_NETNS via configure.ac
by pespin 21 Jan '26

21 Jan '26

Attention is currently required from: Timur Davydov. pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41878?usp=email ) Change subject: build: control USE_NETNS via configure.ac ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: > @dtv.comp@gmail.com so, the facts are, afaiu, in order (let me know if I understood correctly): […] So, in summary, first identify why netns code needs to be disabled at compile time in your system (when removing the defined(linux)). -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41878?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2322eb2936bea35596f1fd6b6a713ea5f997b1ea Gerrit-Change-Number: 41878 Gerrit-PatchSet: 3 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Wed, 21 Jan 2026 11:01:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[S] Change in libosmocore[master]: build: control USE_NETNS via configure.ac
by pespin 21 Jan '26

21 Jan '26

Attention is currently required from: Timur Davydov. pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41878?usp=email ) Change subject: build: control USE_NETNS via configure.ac ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: > No, I'm not claiming that netns functionality is usable at runtime on the Web. […] @dtv.comp@gmail.com so, the facts are, afaiu, in order (let me know if I understood correctly): * Code inside netns.c and netns.h is guarded by "defined(__linux__)", which effectively disables its code when building with emscripten * Currently netdev.c and/or tun.c fail to build if netns.c code is disabled (!defined(__linux)__) My proposal: * Try to remove the defined(__linux__) in netns.c ** if everything compiles fine with emscripten, submit a patch that way: using a netns in netdev/tun will simply fail at runtime ** if compilation files (eg. because unshare(), mount() or setns() are unavailable), then add a configure.ac block to check for any of those which fails and based on that, in netns.c change the code path with #ifdef HAVE_* to return -ENOSUP; or similar. ^ In your commit, please explain the result of all that, with explicit errors, missing functions, etc. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41878?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2322eb2936bea35596f1fd6b6a713ea5f997b1ea Gerrit-Change-Number: 41878 Gerrit-PatchSet: 3 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Wed, 21 Jan 2026 10:59:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[S] Change in libosmocore[master]: core: always build osmo_sock_multiaddr_* helpers
by pespin 21 Jan '26

21 Jan '26

Attention is currently required from: Timur Davydov, laforge. pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41895?usp=email ) Change subject: core: always build osmo_sock_multiaddr_* helpers ...................................................................... Patch Set 3: (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/41895/comment/d6091821_d14bde3b?… : PS1, Line 17: This fixes link failures in libosmo-netif when building with > Thanks, fixed. `when building with --disable-libsctp. […] Feel free to rebase -i the patches and reorder them and push again so we can merge this one already. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41895?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3e70b7cd6cb4d022252e6ddc70a42ca5eea72bb1 Gerrit-Change-Number: 41895 Gerrit-PatchSet: 3 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Wed, 21 Jan 2026 10:39:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[S] Change in libosmocore[master]: build: control USE_NETNS via configure.ac
by Timur Davydov 21 Jan '26

21 Jan '26

Attention is currently required from: pespin. Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41878?usp=email ) Change subject: build: control USE_NETNS via configure.ac ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: > So are you saying that once you build & run with emscripten you can really use the netns code just f […] No, I'm not claiming that netns functionality is usable at runtime on the Web. What actually fails without building netns support are compile-time errors in netdev.c. When netns.h is effectively disabled, netdev.c still references the netns API and types, which leads to build failures such as: - incomplete type `struct osmo_netns_switch_state` - implicit declaration of `osmo_netns_open_fd()` - implicit declaration of `osmo_netns_switch_enter()` - implicit declaration of `osmo_netns_switch_exit()` So the problem is not a runtime failure, but missing declarations when netns.h is excluded via conditional compilation. The change makes the availability of netns code explicit at configure time (`USE_NETNS`) instead of hard-wiring it to `__linux__`, so the build can be structured consistently across targets. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41878?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2322eb2936bea35596f1fd6b6a713ea5f997b1ea Gerrit-Change-Number: 41878 Gerrit-PatchSet: 3 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Jan 2026 10:27:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[XS] Change in docker-playground[master]: debian-trixie-obs-latest: fix signed-by= path
by fixeria 21 Jan '26

21 Jan '26

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/docker-playground/+/41896?usp=email ) Change subject: debian-trixie-obs-latest: fix signed-by= path ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/41896?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ib90abcdf96fc2b555f477899bac730c6f4a76fad Gerrit-Change-Number: 41896 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Jan 2026 10:14:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in docker-playground[master]: debian-trixie-obs-latest: fix signed-by= path
by osmith 21 Jan '26

21 Jan '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/41896?usp=email ) Change subject: debian-trixie-obs-latest: fix signed-by= path ...................................................................... debian-trixie-obs-latest: fix signed-by= path Fix for: Error: Failed to parse keyring "/usr/share/keyrings/osmocom-misc.asc" Fixes: 59d469 ("debian-trixie-build: install the osmocom:misc repo") Change-Id: Ib90abcdf96fc2b555f477899bac730c6f4a76fad --- M debian-trixie-obs-latest/Dockerfile 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/96/41896/1 diff --git a/debian-trixie-obs-latest/Dockerfile b/debian-trixie-obs-latest/Dockerfile index 4603e29..cd927db 100644 --- a/debian-trixie-obs-latest/Dockerfile +++ b/debian-trixie-obs-latest/Dockerfile @@ -11,7 +11,7 @@ # Copy from common dir COPY .common/respawn.sh /usr/local/bin/respawn.sh -COPY .common/Release.key /usr/share/keyrings/osmocom-latest.asc +COPY .common/Release.key /usr/share/keyrings/osmocom.asc # Configure build user, disable installing man pages # * /usr/local: osmo-python-tests's contrib/jenkins.sh writes there @@ -32,9 +32,9 @@ telnet \ && \ apt-get clean && \ - echo "deb [signed-by=/usr/share/keyrings/osmocom-latest.asc] $OSMOCOM_REPO_LATEST ./" \ + echo "deb [signed-by=/usr/share/keyrings/osmocom.asc] $OSMOCOM_REPO_LATEST ./" \ > /etc/apt/sources.list.d/osmocom-latest.list && \ - echo "deb [signed-by=/usr/share/keyrings/osmocom-misc.asc] $OSMOCOM_REPO_MISC ./" \ + echo "deb [signed-by=/usr/share/keyrings/osmocom.asc] $OSMOCOM_REPO_MISC ./" \ > /etc/apt/sources.list.d/osmocom-misc.list # Invalidate cache once the repository is updated -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/41896?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ib90abcdf96fc2b555f477899bac730c6f4a76fad Gerrit-Change-Number: 41896 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in libosmocore[master]: core: always build osmo_sock_multiaddr_* helpers
by Timur Davydov 21 Jan '26

21 Jan '26

Attention is currently required from: laforge, pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/41895?usp=email to look at the new patch set (#3). Change subject: core: always build osmo_sock_multiaddr_* helpers ...................................................................... core: always build osmo_sock_multiaddr_* helpers Always build the public osmo_sock_multiaddr_* helper functions, independent of HAVE_LIBSCTP. Move the HAVE_LIBSCTP checks inside the functions and limit them to the SCTP-specific code paths: when IPPROTO_SCTP is requested without libsctp support, return -ENOTSUP, while non-SCTP protocols continue to work as before. This fixes link failures in libosmo-netif when building with --disable-libsctp. Change-Id: I3e70b7cd6cb4d022252e6ddc70a42ca5eea72bb1 --- M src/core/socket.c 1 file changed, 6 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/95/41895/3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41895?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3e70b7cd6cb4d022252e6ddc70a42ca5eea72bb1 Gerrit-Change-Number: 41895 Gerrit-PatchSet: 3 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmocore[master]: core: always build osmo_sock_multiaddr_* helpers
by Timur Davydov 21 Jan '26

21 Jan '26

Attention is currently required from: laforge, pespin. Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41895?usp=email ) Change subject: core: always build osmo_sock_multiaddr_* helpers ...................................................................... Patch Set 2: (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/41895/comment/7059a760_155c408a?… : PS1, Line 17: This fixes link failures in libosmo-netif when building with > when building with? Thanks, fixed. `when building with --disable-libsctp.` -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41895?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3e70b7cd6cb4d022252e6ddc70a42ca5eea72bb1 Gerrit-Change-Number: 41895 Gerrit-PatchSet: 2 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Jan 2026 09:54:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmocore[master]: core: always build osmo_sock_multiaddr_* helpers
by Timur Davydov 21 Jan '26

21 Jan '26

Attention is currently required from: Timur Davydov, laforge, pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/41895?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+2 by pespin The change is no longer submittable: Code-Review is unsatisfied now. Change subject: core: always build osmo_sock_multiaddr_* helpers ...................................................................... core: always build osmo_sock_multiaddr_* helpers Always build the public osmo_sock_multiaddr_* helper functions, independent of HAVE_LIBSCTP. Move the HAVE_LIBSCTP checks inside the functions and limit them to the SCTP-specific code paths: when IPPROTO_SCTP is requested without libsctp support, return -ENOTSUP, while non-SCTP protocols continue to work as before. This fixes link failures in libosmo-netif when building with --disable-libsctp. Change-Id: I3e70b7cd6cb4d022252e6ddc70a42ca5eea72bb1 --- M src/core/socket.c 1 file changed, 6 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/95/41895/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41895?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3e70b7cd6cb4d022252e6ddc70a42ca5eea72bb1 Gerrit-Change-Number: 41895 Gerrit-PatchSet: 2 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[XS] Change in libosmocore[master]: Detect struct in6_addr.s6_addr32 via AC_CHECK_MEMBER and use HAVE_IN6...
by pespin 21 Jan '26

21 Jan '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/41887?usp=email ) Change subject: Detect struct in6_addr.s6_addr32 via AC_CHECK_MEMBER and use HAVE_IN6_ADDR_S6_ADDR32 instead of __linux__. ...................................................................... Detect struct in6_addr.s6_addr32 via AC_CHECK_MEMBER and use HAVE_IN6_ADDR_S6_ADDR32 instead of __linux__. No functional changes intended, this is a preparatory refactor to keep follow-up patches focused and easier to review. Change-Id: I29385fde0f1e6c6cc73cd1488befdef9040cc28e --- M configure.ac M src/core/socket.c 2 files changed, 8 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve diff --git a/configure.ac b/configure.ac index 64690f9..4a6a474 100644 --- a/configure.ac +++ b/configure.ac @@ -86,6 +86,13 @@ AC_CHECK_LIB(execinfo, backtrace, BACKTRACE_LIB=-lexecinfo, BACKTRACE_LIB=) AC_SUBST(BACKTRACE_LIB) +# check for struct in6_addr has s6_addr32 field +AC_CHECK_MEMBER([struct in6_addr.s6_addr32], + [AC_DEFINE([HAVE_IN6_ADDR_S6_ADDR32], [1], + [Define if struct in6_addr has s6_addr32 field])], + [], + [[#include <netinet/in.h>]]) + # check for pthread (PTHREAD_CFLAGS, PTHREAD_LIBS) AX_PTHREAD diff --git a/src/core/socket.c b/src/core/socket.c index bb32185..2de4bb3 100644 --- a/src/core/socket.c +++ b/src/core/socket.c @@ -1695,7 +1695,7 @@ static unsigned int in6_addr_netmask_to_prefixlen(const struct in6_addr *netmask) { - #if defined(__linux__) + #if (HAVE_IN6_ADDR_S6_ADDR32) #define ADDRFIELD(i) s6_addr32[i] #else #define ADDRFIELD(i) __u6_addr.__u6_addr32[i] -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41887?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I29385fde0f1e6c6cc73cd1488befdef9040cc28e Gerrit-Change-Number: 41887 Gerrit-PatchSet: 2 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log January 2026