January 2026 - gerrit-log - lists.osmocom.org

[XS] Change in libosmocore[master]: osmo_io: Reorder iofd_handle_segmented_read()
by pespin 23 Jan '26

23 Jan '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/41910?usp=email ) Change subject: osmo_io: Reorder iofd_handle_segmented_read() ...................................................................... osmo_io: Reorder iofd_handle_segmented_read() All other similar functions have first the int rc and later the struct msgb; fix this one being different. Change-Id: I88683334e77901776c806dad776ef46ea20b4480 --- M src/core/osmo_io.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: fixeria: Looks good to me, approved laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/core/osmo_io.c b/src/core/osmo_io.c index 41730b4..bd4f468 100644 --- a/src/core/osmo_io.c +++ b/src/core/osmo_io.c @@ -359,7 +359,7 @@ /*! Restore message boundaries on read() and pass individual messages to the read callback */ -static void iofd_handle_segmented_read(struct osmo_io_fd *iofd, struct msgb *msg, int rc) +static void iofd_handle_segmented_read(struct osmo_io_fd *iofd, int rc, struct msgb *msg) { int res; struct msgb *pending; @@ -425,7 +425,7 @@ { switch (iofd->mode) { case OSMO_IO_FD_MODE_READ_WRITE: - iofd_handle_segmented_read(iofd, msg, rc); + iofd_handle_segmented_read(iofd, rc, msg); break; case OSMO_IO_FD_MODE_RECVFROM_SENDTO: talloc_steal(iofd->msgb_alloc.ctx, msg); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41910?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I88683334e77901776c806dad776ef46ea20b4480 Gerrit-Change-Number: 41910 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: osmo_io: Assert osmo_iofd_set_alloc_info() params fit in a 16bit value
by pespin 23 Jan '26

23 Jan '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/41912?usp=email ) Change subject: osmo_io: Assert osmo_iofd_set_alloc_info() params fit in a 16bit value ...................................................................... osmo_io: Assert osmo_iofd_set_alloc_info() params fit in a 16bit value Related: SYS#7842 Change-Id: I32822574db8997a02bf18b71bf6ab596e726cb82 --- M src/core/osmo_io.c 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/core/osmo_io.c b/src/core/osmo_io.c index bd4f468..617155b 100644 --- a/src/core/osmo_io.c +++ b/src/core/osmo_io.c @@ -1068,6 +1068,7 @@ */ void osmo_iofd_set_alloc_info(struct osmo_io_fd *iofd, unsigned int size, unsigned int headroom) { + OSMO_ASSERT(size + headroom <= 0xffff); iofd->msgb_alloc.headroom = headroom; iofd->msgb_alloc.size = size; } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41912?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I32822574db8997a02bf18b71bf6ab596e726cb82 Gerrit-Change-Number: 41912 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: osmo_io: Assert osmo_iofd_set_alloc_info() params fit in a 16bit value
by pespin 23 Jan '26

23 Jan '26

Attention is currently required from: fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41912?usp=email ) Change subject: osmo_io: Assert osmo_iofd_set_alloc_info() params fit in a 16bit value ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/41912/comment/37d0338a_943ade48?… : PS2, Line 1071: 0xffff > cosmetic: use `UINT16_MAX`? I think it's fine this way too, the hex makes it easy to understand we are testing against a uint16_t, and there's already an assert like that in osmo_iofd_alloc2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41912?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I32822574db8997a02bf18b71bf6ab596e726cb82 Gerrit-Change-Number: 41912 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 22 Jan 2026 21:53:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in libosmocore[master]: osmo_io: Propagate segment_cb errors to the read_cb
by fixeria 23 Jan '26

23 Jan '26

Attention is currently required from: daniel, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41914?usp=email ) Change subject: osmo_io: Propagate segment_cb errors to the read_cb ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41914?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I572e68df6799b903507229a9beee6fa7d7d6d652 Gerrit-Change-Number: 41914 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 22 Jan 2026 21:03:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in libosmocore[master]: osmo_io: Support rx of segments up to ~UINT16_MAX
by fixeria 23 Jan '26

23 Jan '26

Attention is currently required from: daniel, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41911?usp=email ) Change subject: osmo_io: Support rx of segments up to ~UINT16_MAX ...................................................................... Patch Set 5: (4 comments) File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/41911/comment/8ae344fe_09cba592?… : PS5, Line 367: struct osmo_io_fd *iofd `const` https://gerrit.osmocom.org/c/libosmocore/+/41911/comment/ad530c95_d3f1eddd?… : PS5, Line 379: memcpy(msgb_put(iofd->pending, msgb_length(in_msg)), : msgb_data(in_msg), : cosmetic: formatting looks weird here, I find it confusing File tests/osmo_io/osmo_io_test.c: https://gerrit.osmocom.org/c/libosmocore/+/41911/comment/c4bb923d_fbb13aac?… : PS5, Line 413: 3 ```suggestion for (unsigned int i = 0; i < num_write_msgs; i++) { ``` https://gerrit.osmocom.org/c/libosmocore/+/41911/comment/cfad80c8_cfe3a4d8?… : PS5, Line 513: ; ```suggestion for (unsigned int i = 0; i < num_write_msgs; i++) { ``` -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41911?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8c11a7edbed2335ada40a1f93d081041974c3586 Gerrit-Change-Number: 41911 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 22 Jan 2026 21:01:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in libosmocore[master]: osmo_io: Assert osmo_iofd_set_alloc_info() params fit in a 16bit value
by fixeria 23 Jan '26

23 Jan '26

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41912?usp=email ) Change subject: osmo_io: Assert osmo_iofd_set_alloc_info() params fit in a 16bit value ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/41912/comment/fe565dcf_0dc43efb?… : PS2, Line 1071: 0xffff cosmetic: use `UINT16_MAX`? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41912?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I32822574db8997a02bf18b71bf6ab596e726cb82 Gerrit-Change-Number: 41912 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 22 Jan 2026 20:32:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: osmo_io: Reorder iofd_handle_segmented_read()
by fixeria 23 Jan '26

23 Jan '26

Attention is currently required from: daniel, jolly, osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41910?usp=email ) Change subject: osmo_io: Reorder iofd_handle_segmented_read() ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41910?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I88683334e77901776c806dad776ef46ea20b4480 Gerrit-Change-Number: 41910 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 22 Jan 2026 20:31:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: osmo_io: Make iofd_handle_segmented_read() static
by fixeria 23 Jan '26

23 Jan '26

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41915?usp=email ) Change subject: osmo_io: Make iofd_handle_segmented_read() static ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41915?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6671380ad071e23445c3e38c0b9700af66998af1 Gerrit-Change-Number: 41915 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 22 Jan 2026 20:30:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmocom-bb[master]: trxcon/l1sched: add API for reading/updating UL SACCH cache
by fixeria 23 Jan '26

23 Jan '26

Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41901?usp=email ) Change subject: trxcon/l1sched: add API for reading/updating UL SACCH cache ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41901?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ica42dbc28cfdd7af2e1becdcc5d45337b70da8a7 Gerrit-Change-Number: 41901 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 22 Jan 2026 20:30:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmocom-bb[master]: trxcon/l1sched: pre-populate MR cache during lchan allocation
by fixeria 23 Jan '26

23 Jan '26

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41902?usp=email ) Change subject: trxcon/l1sched: pre-populate MR cache during lchan allocation ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41902?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I079074a402f9c27fff7e25b49bfd1dd409c0f8c3 Gerrit-Change-Number: 41902 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 22 Jan 2026 20:29:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log January 2026