January 2026 - gerrit-log - lists.osmocom.org

[S] Change in libosmocore[master]: core: always build osmo_sock_multiaddr_* helpers
by pespin 23 Jan '26

23 Jan '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/41895?usp=email ) Change subject: core: always build osmo_sock_multiaddr_* helpers ...................................................................... core: always build osmo_sock_multiaddr_* helpers Always build the public osmo_sock_multiaddr_* helper functions, independent of HAVE_LIBSCTP. Move the HAVE_LIBSCTP checks inside the functions and limit them to the SCTP-specific code paths: when IPPROTO_SCTP is requested without libsctp support, return -ENOTSUP, while non-SCTP protocols continue to work as before. This fixes link failures in libosmo-netif when building with --disable-libsctp. Change-Id: I3e70b7cd6cb4d022252e6ddc70a42ca5eea72bb1 --- M src/core/socket.c 1 file changed, 6 insertions(+), 4 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/core/socket.c b/src/core/socket.c index 2de4bb3..6cd82f0 100644 --- a/src/core/socket.c +++ b/src/core/socket.c @@ -1895,7 +1895,6 @@ return 0; } -#ifdef HAVE_LIBSCTP /*! Get multiple IP addresses and/or port number on socket in separate string buffers * \param[in] fd file descriptor of socket. * \param[out] ip_proto IPPROTO of the socket, eg: IPPROTO_SCTP. @@ -1926,10 +1925,12 @@ int osmo_sock_multiaddr_get_ip_and_port(int fd, int ip_proto, char *ip, size_t *ip_cnt, size_t ip_len, char *port, size_t port_len, bool local) { +#ifdef HAVE_LIBSCTP struct sockaddr *addrs = NULL; unsigned int n_addrs, i; void *addr_buf; int rc; +#endif /* HAVE_LIBSCTP */ switch (ip_proto) { case IPPROTO_SCTP: @@ -1943,6 +1944,7 @@ return osmo_sock_get_ip_and_port(fd, ip, ip_len, port, port_len, local); } +#ifdef HAVE_LIBSCTP rc = local ? sctp_getladdrs(fd, 0, &addrs) : sctp_getpaddrs(fd, 0, &addrs); if (rc < 0) return rc; @@ -1983,8 +1985,10 @@ free_addrs_ret: local ? sctp_freeladdrs(addrs) : sctp_freepaddrs(addrs); return rc; +#else + return -ENOTSUP; +#endif /* HAVE_LIBSCTP */ } -#endif /*! Get local IP address on socket * \param[in] fd file descriptor of socket @@ -2047,7 +2051,6 @@ return talloc_asprintf(ctx, "(%s)", str); } -#ifdef HAVE_LIBSCTP /*! Format multiple IP addresses and/or port number into a combined string buffer * \param[out] str Destination string buffer. * \param[in] str_len sizeof(str), usually OSMO_SOCK_MULTIADDR_PEER_STR_MAXLEN. @@ -2153,7 +2156,6 @@ return sb.chars_needed; } -#endif /*! Get address/port information on socket in provided string buffer, like "r=1.2.3.4:5<->l=6.7.8.9:10". * This does not include braces like osmo_sock_get_name(). -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41895?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3e70b7cd6cb4d022252e6ddc70a42ca5eea72bb1 Gerrit-Change-Number: 41895 Gerrit-PatchSet: 5 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmocore[master]: build: keep netns API public and gate features with HAVE_*
by pespin 23 Jan '26

23 Jan '26

Attention is currently required from: Timur Davydov, laforge. pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41878?usp=email ) Change subject: build: keep netns API public and gate features with HAVE_* ...................................................................... Patch Set 9: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/41878/comment/172bc91a_59f9fd2e?… : PS9, Line 19: HAVE_MOUNT and HAVE_CLONE_NEWNET, and return -ENOSYS when the required return -ENOTSUP -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41878?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2322eb2936bea35596f1fd6b6a713ea5f997b1ea Gerrit-Change-Number: 41878 Gerrit-PatchSet: 9 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Fri, 23 Jan 2026 09:18:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmocore[master]: Add Emscripten build support and JS callback logging backend
by pespin 23 Jan '26

23 Jan '26

Attention is currently required from: Timur Davydov, laforge, neels. pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email ) Change subject: Add Emscripten build support and JS callback logging backend ...................................................................... Patch Set 20: (1 comment) File configure.ac: https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/2402e477_c5717334?… : PS16, Line 259: AM_CONDITIONAL(ENABLE_TUN, test "x$embedded" != "xyes" && test "x$emscripten" != "xyes") > Agreed, this likely needs an additional fix. This should follow the same […] Waiting for this to be addressed in a separate patch before this patch. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia8d5f4bb6570b5e055826f3a051e5e5896866e31 Gerrit-Change-Number: 41813 Gerrit-PatchSet: 20 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Fri, 23 Jan 2026 09:15:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[XS] Change in libosmocore[master]: vty: guard definition of _XOPEN_SOURCE
by pespin 23 Jan '26

23 Jan '26

Attention is currently required from: Timur Davydov, fixeria, laforge, osmith. pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41924?usp=email ) Change subject: vty: guard definition of _XOPEN_SOURCE ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41924?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4f53aff1afef02abce7cb70d1b29080ba900ff41 Gerrit-Change-Number: 41924 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Fri, 23 Jan 2026 09:12:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: core: fix printf format casts for struct timeval fields
by pespin 23 Jan '26

23 Jan '26

Attention is currently required from: Timur Davydov, fixeria, laforge, osmith. pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41923?usp=email ) Change subject: core: fix printf format casts for struct timeval fields ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41923?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icac9e392c728948a7976970658e37f5e0da41709 Gerrit-Change-Number: 41923 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Fri, 23 Jan 2026 09:11:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmocore[master]: core: guard TCP stats on availability of linux/tcp.h and struct tcp_info
by pespin 23 Jan '26

23 Jan '26

Attention is currently required from: Timur Davydov. pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41922?usp=email ) Change subject: core: guard TCP stats on availability of linux/tcp.h and struct tcp_info ...................................................................... Patch Set 1: (3 comments) Patchset: PS1: Since we are only talking about 2-3 public APIs, I think in this case it may make sense to wrap all of existing stats_tcp.c within a "if HAVE_LINUX_TCP_H", and then add a "else" section with stub functions for those public APIs, eg. _register() one returning -ENOTSUP. File src/core/stats_tcp.c: https://gerrit.osmocom.org/c/libosmocore/+/41922/comment/76b3162b_6c153b40?… : PS1, Line 315: osmo_timer_schedule(&stats_tcp_poll_timer, osmo_tcp_stats_config->interval, 0); I stats are not used, we should disable this too. https://gerrit.osmocom.org/c/libosmocore/+/41922/comment/f1a1f178_92b7975c?… : PS1, Line 328: osmo_timer_setup(&stats_tcp_poll_timer, stats_tcp_poll_timer_cb, NULL); I stats are not used, we can disable this function completelly afaiu. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41922?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibcd00f15131b0291f0b10eca51401c518b77cc39 Gerrit-Change-Number: 41922 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Fri, 23 Jan 2026 09:09:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in libosmocore[master]: core: guard SCTP include in osmo_io_internal.h
by pespin 23 Jan '26

23 Jan '26

Attention is currently required from: Timur Davydov, laforge. pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41921?usp=email ) Change subject: core: guard SCTP include in osmo_io_internal.h ...................................................................... Patch Set 1: (1 comment) File src/core/osmo_io_internal.h: https://gerrit.osmocom.org/c/libosmocore/+/41921/comment/0841a1b6_2cd44790?… : PS1, Line 10: #include <netinet/sctp.h> AFAICT this include is not really used in this header, so you can change this patch to simply remove it. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41921?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icd626d908192a954d55d76a46d7cc863ed332631 Gerrit-Change-Number: 41921 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Fri, 23 Jan 2026 09:02:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmocom-bb[master]: trxcon/fsm: handle_dch_est_req(): do not reset the scheduler
by fixeria 23 Jan '26

23 Jan '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41906?usp=email ) Change subject: trxcon/fsm: handle_dch_est_req(): do not reset the scheduler ...................................................................... trxcon/fsm: handle_dch_est_req(): do not reset the scheduler Calling l1sched_reset() results in resetting the UL SACCH cache, that may have been populated prior to sending L1CTL_DM_EST_REQ. Instead, do what the comment says - call l1sched_del_all_ts(). Change-Id: Iff03fa5b90ac1ec30b7937cea6bd09c6ececb5f6 Fixes: c6fe9c3f ("trxcon: trxcon_fsm: permit loop [P]DCH transitions") Related: 15877ba05 ("trxcon: allow populating global SACCH cache via L1CTL") Related: OS#6919 --- M src/host/trxcon/src/trxcon_fsm.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/src/host/trxcon/src/trxcon_fsm.c b/src/host/trxcon/src/trxcon_fsm.c index 34ca21b..fa0584d 100644 --- a/src/host/trxcon/src/trxcon_fsm.c +++ b/src/host/trxcon/src/trxcon_fsm.c @@ -352,7 +352,7 @@ } /* Remove all active timeslots */ - l1sched_reset(trxcon->sched); + l1sched_del_all_ts(trxcon->sched); rc = l1sched_configure_ts(trxcon->sched, req->chan_nr & 0x07, config); if (rc) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41906?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iff03fa5b90ac1ec30b7937cea6bd09c6ececb5f6 Gerrit-Change-Number: 41906 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmocom-bb[master]: trxcon/l1ctl: print an error for uhnandled DATA.req / TRAFFIC.req
by fixeria 23 Jan '26

23 Jan '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41900?usp=email ) Change subject: trxcon/l1ctl: print an error for uhnandled DATA.req / TRAFFIC.req ...................................................................... trxcon/l1ctl: print an error for uhnandled DATA.req / TRAFFIC.req Change-Id: I1d965c2882eb72dc845bea85a4ffaa26d37cee05 --- M src/host/trxcon/src/l1ctl.c 1 file changed, 9 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/host/trxcon/src/l1ctl.c b/src/host/trxcon/src/l1ctl.c index 0f6bd1b..7ce8c3d 100644 --- a/src/host/trxcon/src/l1ctl.c +++ b/src/host/trxcon/src/l1ctl.c @@ -685,9 +685,16 @@ osmo_fsm_inst_dispatch(fi, TRXCON_EV_TX_DATA_REQ, &req); break; default: - if (!traffic && req.link_id == 0x40) /* only for SACCH */ + if (!traffic && req.link_id == 0x40) { /* only for SACCH */ osmo_fsm_inst_dispatch(fi, TRXCON_EV_UPDATE_SACCH_CACHE_REQ, &req); - /* TODO: log an error about uhnandled DATA.req / TRAFFIC.req */ + break; + } + + LOGPFSMSL(fi, g_logc_l1d, LOGL_ERROR, + "Unhandled %s Req (chan_nr=0x%02x, link_id=0x%02x, len=%zu): %s\n", + traffic ? "TRAFFIC" : "DATA", req.chan_nr, req.link_id, req.data_len, + msgb_hexdump_l2(msg)); + break; } msgb_free(msg); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41900?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I1d965c2882eb72dc845bea85a4ffaa26d37cee05 Gerrit-Change-Number: 41900 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmocom-bb[master]: trxcon/l1sched: add API for reading/updating UL SACCH cache
by fixeria 23 Jan '26

23 Jan '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41901?usp=email ) Change subject: trxcon/l1sched: add API for reading/updating UL SACCH cache ...................................................................... trxcon/l1sched: add API for reading/updating UL SACCH cache Change-Id: Ica42dbc28cfdd7af2e1becdcc5d45337b70da8a7 Related: 15877ba05 ("trxcon: allow populating global SACCH cache via L1CTL") --- M src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h M src/host/trxcon/src/sched_prim.c M src/host/trxcon/src/sched_trx.c M src/host/trxcon/src/trxcon_fsm.c 4 files changed, 20 insertions(+), 8 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h b/src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h index 39400cf..283f388 100644 --- a/src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h +++ b/src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h @@ -337,6 +337,9 @@ void l1sched_reset(struct l1sched_state *sched, bool reset_clock); void l1sched_free(struct l1sched_state *sched); +void l1sched_sacch_cache_read(struct l1sched_state *sched, uint8_t *out); +void l1sched_sacch_cache_update(struct l1sched_state *sched, const uint8_t *in); + /* Timeslot management functions */ struct l1sched_ts *l1sched_add_ts(struct l1sched_state *sched, int tn); void l1sched_del_ts(struct l1sched_state *sched, int tn); diff --git a/src/host/trxcon/src/sched_prim.c b/src/host/trxcon/src/sched_prim.c index 4974557..fa46d91 100644 --- a/src/host/trxcon/src/sched_prim.c +++ b/src/host/trxcon/src/sched_prim.c @@ -102,11 +102,8 @@ cached = (lchan->sacch.mr_cache[2] != 0x00 && lchan->sacch.mr_cache[3] != 0x00 && lchan->sacch.mr_cache[4] != 0x00); - if (!cached) { - memcpy(&lchan->sacch.mr_cache[0], - &lchan->ts->sched->sacch_cache[0], - sizeof(lchan->sacch.mr_cache)); - } + if (!cached) /* populate from the global UL SACCH cache (if needed) */ + l1sched_sacch_cache_read(lchan->ts->sched, lchan->sacch.mr_cache); /* Compose a new Measurement Report primitive */ memcpy(msgb_put(msg, GSM_MACBLOCK_LEN), diff --git a/src/host/trxcon/src/sched_trx.c b/src/host/trxcon/src/sched_trx.c index f412400..237daca 100644 --- a/src/host/trxcon/src/sched_trx.c +++ b/src/host/trxcon/src/sched_trx.c @@ -153,7 +153,8 @@ .priv = priv, }; - memcpy(&sched->sacch_cache[0], &meas_rep_dummy[0], sizeof(meas_rep_dummy)); + /* Populate UL SACCH cache */ + l1sched_sacch_cache_update(sched, meas_rep_dummy); if (cfg->log_prefix == NULL) sched->log_prefix = talloc_asprintf(sched, "l1sched[0x%p]: ", sched); @@ -193,7 +194,18 @@ for (tn = 0; tn < ARRAY_SIZE(sched->ts); tn++) l1sched_del_ts(sched, tn); - memcpy(&sched->sacch_cache[0], &meas_rep_dummy[0], sizeof(meas_rep_dummy)); + /* Reset UL SACCH cache */ + l1sched_sacch_cache_update(sched, meas_rep_dummy); +} + +void l1sched_sacch_cache_read(struct l1sched_state *sched, uint8_t *out) +{ + memcpy(out, sched->sacch_cache, sizeof(sched->sacch_cache)); +} + +void l1sched_sacch_cache_update(struct l1sched_state *sched, const uint8_t *in) +{ + memcpy(sched->sacch_cache, in, sizeof(sched->sacch_cache)); } struct l1sched_ts *l1sched_add_ts(struct l1sched_state *sched, int tn) diff --git a/src/host/trxcon/src/trxcon_fsm.c b/src/host/trxcon/src/trxcon_fsm.c index 9545883..ce3c0dd 100644 --- a/src/host/trxcon/src/trxcon_fsm.c +++ b/src/host/trxcon/src/trxcon_fsm.c @@ -108,7 +108,7 @@ break; } - memcpy(&trxcon->sched->sacch_cache[0], req->data, req->data_len); + l1sched_sacch_cache_update(trxcon->sched, req->data); break; } default: -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41901?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ica42dbc28cfdd7af2e1becdcc5d45337b70da8a7 Gerrit-Change-Number: 41901 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log January 2026