January 2026 - gerrit-log - lists.osmocom.org

[L] Change in libosmocore[master]: osmo_io: Support rx of segments up to ~UINT16_MAX
by pespin 23 Jan '26

23 Jan '26

Attention is currently required from: daniel, fixeria, laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41911?usp=email ) Change subject: osmo_io: Support rx of segments up to ~UINT16_MAX ...................................................................... Patch Set 6: (2 comments) File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/41911/comment/e03823ce_2168d2ac?… : PS6, Line 394: memcpy > formatting: same here Done https://gerrit.osmocom.org/c/libosmocore/+/41911/comment/75d3516d_c4af1c84?… : PS6, Line 401: memcpy > formatting: same here Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41911?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8c11a7edbed2335ada40a1f93d081041974c3586 Gerrit-Change-Number: 41911 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Jan 2026 10:42:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[L] Change in libosmocore[master]: osmo_io: Support rx of segments up to ~UINT16_MAX
by fixeria 23 Jan '26

23 Jan '26

Attention is currently required from: daniel, laforge, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41911?usp=email ) Change subject: osmo_io: Support rx of segments up to ~UINT16_MAX ...................................................................... Patch Set 6: Code-Review+1 (2 comments) File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/41911/comment/e4f3b460_796868d9?… : PS6, Line 394: memcpy formatting: same here https://gerrit.osmocom.org/c/libosmocore/+/41911/comment/b999255f_f685b8d7?… : PS6, Line 401: memcpy formatting: same here -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41911?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8c11a7edbed2335ada40a1f93d081041974c3586 Gerrit-Change-Number: 41911 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Jan 2026 10:19:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmocore[master]: Remove unused private API log_target_create_file_stream()
by pespin 23 Jan '26

23 Jan '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/41893?usp=email ) Change subject: Remove unused private API log_target_create_file_stream() ...................................................................... Remove unused private API log_target_create_file_stream() This function was never added to the logging.h (despite it was not static and it was inside libosmocore.map). It is actually used nowhere, and changing it to static made the compiler warn about it. Remove it. Change-Id: Ia30c6b47cfcbb54e7c2c43b877cd9554dc596abf --- M src/core/libosmocore.map M src/core/logging.c 2 files changed, 0 insertions(+), 24 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/core/libosmocore.map b/src/core/libosmocore.map index 3ec322c..cb79843 100644 --- a/src/core/libosmocore.map +++ b/src/core/libosmocore.map @@ -96,7 +96,6 @@ log_set_use_color; log_target_create; log_target_create_file; -log_target_create_file_stream; log_target_create_gsmtap; log_target_create_rb; log_target_create_stderr; diff --git a/src/core/logging.c b/src/core/logging.c index ac10d00..479513a 100644 --- a/src/core/logging.c +++ b/src/core/logging.c @@ -1278,29 +1278,6 @@ } #if (!EMBEDDED) -/*! Create a new file-based log target using buffered, blocking stream output - * \param[in] fname File name of the new log file - * \returns Log target in case of success, NULL otherwise - */ -struct log_target *log_target_create_file_stream(const char *fname) -{ - struct log_target *target; - - target = log_target_create(); - if (!target) - return NULL; - - target->type = LOG_TGT_TYPE_FILE; - target->tgt_file.out = fopen(fname, "a"); - if (!target->tgt_file.out) { - log_target_destroy(target); - return NULL; - } - target->output = _file_output_stream; - target->tgt_file.fname = talloc_strdup(target, fname); - - return target; -} /*! switch from non-blocking/write-queue to blocking + buffered stream output * \param[in] target log target which we should switch -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41893?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia30c6b47cfcbb54e7c2c43b877cd9554dc596abf Gerrit-Change-Number: 41893 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmocore[master]: gb: Avoid accessing struct log_target members directly
by pespin 23 Jan '26

23 Jan '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/41883?usp=email ) Change subject: gb: Avoid accessing struct log_target members directly ...................................................................... gb: Avoid accessing struct log_target members directly Change-Id: Idb2f7f3736f0a22a091a702e23ef7cf58e56cfa9 --- M src/gb/common_vty.c M src/gb/gprs_bssgp_vty.c M src/gb/gprs_ns2_vty.c M src/gb/gprs_ns_vty.c 4 files changed, 29 insertions(+), 29 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/gb/common_vty.c b/src/gb/common_vty.c index ad3dea2..da88475 100644 --- a/src/gb/common_vty.c +++ b/src/gb/common_vty.c @@ -40,23 +40,23 @@ int gprs_log_filter_fn(const struct log_context *ctx, struct log_target *tar) { - const void *nse = ctx->ctx[LOG_CTX_GB_NSE]; - const void *nsvc = ctx->ctx[LOG_CTX_GB_NSVC]; - const void *bvc = ctx->ctx[LOG_CTX_GB_BVC]; + const void *nse = log_get_context(ctx, LOG_CTX_GB_NSE); + const void *nsvc = log_get_context(ctx, LOG_CTX_GB_NSVC); + const void *bvc = log_get_context(ctx, LOG_CTX_GB_BVC); /* Filter on the NS Entity */ - if ((tar->filter_map & (1 << LOG_FLT_GB_NSE)) != 0 - && nse && (nse == tar->filter_data[LOG_FLT_GB_NSE])) + if (log_get_filter(tar, LOG_FLT_GB_NSE) && + nse && (nse == log_get_filter_data(tar, LOG_FLT_GB_NSE))) return 1; /* Filter on the NS Virtual Connection */ - if ((tar->filter_map & (1 << LOG_FLT_GB_NSVC)) != 0 - && nsvc && (nsvc == tar->filter_data[LOG_FLT_GB_NSVC])) + if (log_get_filter(tar, LOG_FLT_GB_NSVC) && + nsvc && (nsvc == log_get_filter_data(tar, LOG_FLT_GB_NSVC))) return 1; /* Filter on the BSSGP Virtual Connection */ - if ((tar->filter_map & (1 << LOG_FLT_GB_BVC)) != 0 - && bvc && (bvc == tar->filter_data[LOG_FLT_GB_BVC])) + if (log_get_filter(tar, LOG_FLT_GB_BVC) && + bvc && (bvc == log_get_filter_data(tar, LOG_FLT_GB_BVC))) return 1; return 0; diff --git a/src/gb/gprs_bssgp_vty.c b/src/gb/gprs_bssgp_vty.c index d04641d..ed4cdb9 100644 --- a/src/gb/gprs_bssgp_vty.c +++ b/src/gb/gprs_bssgp_vty.c @@ -48,11 +48,11 @@ struct bssgp_bvc_ctx *bctx) { if (bctx) { - target->filter_map |= (1 << LOG_FLT_GB_BVC); - target->filter_data[LOG_FLT_GB_BVC] = bctx; - } else if (target->filter_data[LOG_FLT_GB_BVC]) { - target->filter_map = ~(1 << LOG_FLT_GB_BVC); - target->filter_data[LOG_FLT_GB_BVC] = NULL; + log_set_filter(target, LOG_FLT_GB_BVC, true); + log_set_filter_data(target, LOG_FLT_GB_BVC, bctx); + } else if (log_get_filter(target, LOG_FLT_GB_BVC)) { + log_set_filter(target, LOG_FLT_GB_BVC, false); + log_set_filter_data(target, LOG_FLT_GB_BVC, NULL); } } diff --git a/src/gb/gprs_ns2_vty.c b/src/gb/gprs_ns2_vty.c index 32de49d..c85180e 100644 --- a/src/gb/gprs_ns2_vty.c +++ b/src/gb/gprs_ns2_vty.c @@ -2180,11 +2180,11 @@ struct gprs_ns2_nse *nse) { if (nse) { - target->filter_map |= (1 << LOG_FLT_GB_NSE); - target->filter_data[LOG_FLT_GB_NSE] = nse; - } else if (target->filter_data[LOG_FLT_GB_NSE]) { - target->filter_map = ~(1 << LOG_FLT_GB_NSE); - target->filter_data[LOG_FLT_GB_NSE] = NULL; + log_set_filter(target, LOG_FLT_GB_NSE, true); + log_set_filter_data(target, LOG_FLT_GB_NSE, nse); + } else if (log_get_filter(target, LOG_FLT_GB_NSE)) { + log_set_filter(target, LOG_FLT_GB_NSE, false); + log_set_filter_data(target, LOG_FLT_GB_NSE, NULL); } } @@ -2192,11 +2192,11 @@ struct gprs_ns2_vc *nsvc) { if (nsvc) { - target->filter_map |= (1 << LOG_FLT_GB_NSVC); - target->filter_data[LOG_FLT_GB_NSVC] = nsvc; - } else if (target->filter_data[LOG_FLT_GB_NSVC]) { - target->filter_map = ~(1 << LOG_FLT_GB_NSVC); - target->filter_data[LOG_FLT_GB_NSVC] = NULL; + log_set_filter(target, LOG_FLT_GB_NSVC, true); + log_set_filter_data(target, LOG_FLT_GB_NSVC, nsvc); + } else if (log_get_filter(target, LOG_FLT_GB_NSVC)) { + log_set_filter(target, LOG_FLT_GB_NSVC, false); + log_set_filter_data(target, LOG_FLT_GB_NSVC, NULL); } } diff --git a/src/gb/gprs_ns_vty.c b/src/gb/gprs_ns_vty.c index f27bf6a..6bfdc3a 100644 --- a/src/gb/gprs_ns_vty.c +++ b/src/gb/gprs_ns_vty.c @@ -68,11 +68,11 @@ struct gprs_nsvc *nsvc) { if (nsvc) { - target->filter_map |= (1 << LOG_FLT_GB_NSVC); - target->filter_data[LOG_FLT_GB_NSVC] = nsvc; - } else if (target->filter_data[LOG_FLT_GB_NSVC]) { - target->filter_map = ~(1 << LOG_FLT_GB_NSVC); - target->filter_data[LOG_FLT_GB_NSVC] = NULL; + log_set_filter(target, LOG_FLT_GB_NSVC, true); + log_set_filter_data(target, LOG_FLT_GB_NSVC, nsvc); + } else if (log_get_filter(target, LOG_FLT_GB_NSVC)) { + log_set_filter(target, LOG_FLT_GB_NSVC, false); + log_set_filter_data(target, LOG_FLT_GB_NSVC, NULL); } } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41883?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Idb2f7f3736f0a22a091a702e23ef7cf58e56cfa9 Gerrit-Change-Number: 41883 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmocore[master]: logging: Add APIs to set/get log_{target,context} fields
by pespin 23 Jan '26

23 Jan '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/41879?usp=email ) Change subject: logging: Add APIs to set/get log_{target,context} fields ...................................................................... logging: Add APIs to set/get log_{target,context} fields Change-Id: Ie48e7e635feb91509b9c034394df4fb16cb931a3 --- M TODO-RELEASE M include/osmocom/core/logging.h M src/core/libosmocore.map M src/core/logging.c 4 files changed, 115 insertions(+), 5 deletions(-) Approvals: fixeria: Looks good to me, approved osmith: Looks good to me, but someone else must approve pespin: Verified diff --git a/TODO-RELEASE b/TODO-RELEASE index 3c98f06..b7d1585 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -10,3 +10,4 @@ core added osmo_sock_set_nonblock(), osmo_sock_get_nonblock() core added gsmtap_source_set_nonblock(), gsmtap_source_using_wq() core added osmo_iofd_set_name_f() +core added log_{get,set}_filter(_data)(), log_get_context() diff --git a/include/osmocom/core/logging.h b/include/osmocom/core/logging.h index 44263fb..286f646 100644 --- a/include/osmocom/core/logging.h +++ b/include/osmocom/core/logging.h @@ -225,7 +225,7 @@ /*! Log context information, passed to filter */ struct log_context { - void *ctx[LOG_MAX_CTX+1]; + void *ctx[LOG_MAX_CTX+1] OSMO_DEPRECATED_OUTSIDE("Accessing struct log_context members directly is deprecated"); }; /*! Compatibility with older libosmocore versions */ @@ -298,13 +298,15 @@ }; /*! structure representing a logging target */ +#define OSMO_DEPRECATED_OUTSIDE_LIBOSMOCORE_LOG_TARGET \ + OSMO_DEPRECATED_OUTSIDE("Accessing struct log_target members directly is deprecated") struct log_target { struct llist_head entry; /*!< linked list */ /*! Internal data for filtering */ - int filter_map; + int filter_map OSMO_DEPRECATED_OUTSIDE_LIBOSMOCORE_LOG_TARGET; /*! Internal data for filtering */ - void *filter_data[LOG_MAX_FILTERS+1]; + void *filter_data[LOG_MAX_FILTERS+1] OSMO_DEPRECATED_OUTSIDE_LIBOSMOCORE_LOG_TARGET; /*! logging categories */ struct log_category *categories; @@ -406,10 +408,16 @@ /* context management */ void log_reset_context(void); -int log_set_context(uint8_t ctx, void *value); +int log_set_context(uint8_t ctx_nr, void *value); +void *log_get_context(const struct log_context *ctx, uint8_t ctx_nr); /* filter on the targets */ void log_set_all_filter(struct log_target *target, int); +bool log_get_filter(const struct log_target *target, int log_filter_index); +int log_set_filter(struct log_target *target, int log_filter_index, bool enable); +void *log_get_filter_data(const struct log_target *target, int log_filter_index); +int log_set_filter_data(struct log_target *target, int log_filter_index, void *data); + int log_cache_enable(void); void log_cache_update(int mapped_subsys, uint8_t enabled, uint8_t level); void log_set_use_color(struct log_target *target, int); diff --git a/src/core/libosmocore.map b/src/core/libosmocore.map index 2818f8a..3ec322c 100644 --- a/src/core/libosmocore.map +++ b/src/core/libosmocore.map @@ -75,8 +75,13 @@ log_parse_level; logp_stub; log_reset_context; +log_get_context; +log_get_filter; +log_get_filter_data; log_set_all_filter; log_set_category_filter; +log_set_filter; +log_set_filter_data; log_set_context; log_set_log_level; log_set_print_category; diff --git a/src/core/logging.c b/src/core/logging.c index 9e5ae9f..ac10d00 100644 --- a/src/core/logging.c +++ b/src/core/logging.c @@ -886,7 +886,42 @@ return 0; } -/*! Enable the \ref LOG_FLT_ALL log filter +/*! Get the logging context + * \param[in] ctx logging context + * \param[in] ctx_nr logging context number + * \returns value set for the context + * + * A logging context is something like the subscriber identity to which + * the currently processed message relates, or the BTS through which it + * was received. The main use of this API is during + * (struct log_info)->filter_fn(ctx, log_tgt). + */ +void *log_get_context(const struct log_context *ctx, uint8_t ctx_nr) +{ + if (ctx_nr > LOG_MAX_CTX) + return NULL; + return ctx->ctx[ctx_nr]; +} + +/*! Query whether a log filter is enabled or disabled + * \param[in] target Log target to be queried + * \param[in] log_filter_index the index of the log filter to query + * \returns whether the filtering is enabled (true) or disabled (false) + */ +bool log_get_filter(const struct log_target *target, int log_filter_index) +{ + /* TODO: in the future we can support app-specified log filters here, + * similar to how we do dynamic cateogries defined by apps. */ + if (log_filter_index < 0) + return false; + + if (log_filter_index >= LOG_MAX_FILTERS) + return false; + + return target->filter_map & (1 << log_filter_index); +} + +/*! Enable/disable the \ref LOG_FLT_ALL log filter * \param[in] target Log target to be affected * \param[in] all enable (1) or disable (0) the ALL filter * @@ -902,6 +937,67 @@ target->filter_map &= ~(1 << LOG_FLT_ALL); } +/*! Enable/disable a log filter + * \param[in] target Log target to be affected + * \param[in] log_filter_index the index of the log filter to set + * \param[in] enable enable (true) or disable (false) the ALL filter + * \returns 0 on success, negative on error. + */ +int log_set_filter(struct log_target *target, int log_filter_index, bool enable) +{ + /* TODO: in the future we can support app-specified log filters here, + * similar to how we do dynamic cateogries defined by apps. */ + if (log_filter_index < 0) + return -EINVAL; + + if (log_filter_index >= LOG_MAX_FILTERS) + return -EINVAL; + + if (enable) + target->filter_map |= (1 << log_filter_index); + else + target->filter_map &= ~(1 << log_filter_index); + return 0; +} + +/*! Obtain data associated to a log filter + * \param[in] target Log target to be queried + * \param[in] log_filter_index the index of the log filter to query + * \returns data associated to the log filter + */ +void *log_get_filter_data(const struct log_target *target, int log_filter_index) +{ + /* TODO: in the future we can support app-specified log filters here, + * similar to how we do dynamic cateogries defined by apps. */ + if (log_filter_index < 0) + return NULL; + + if (log_filter_index >= LOG_MAX_FILTERS) + return NULL; + + return target->filter_data[log_filter_index]; +} + +/*! Set data associated to a log filter + * \param[in] target Log target to be affected + * \param[in] log_filter_index the index of the log filter to set associate data for + * \param[in] data The user provided data pointer to associate to the log filter + * \returns 0 on success, negative on error. + */ +int log_set_filter_data(struct log_target *target, int log_filter_index, void *data) +{ + /* TODO: in the future we can support app-specified log filters here, + * similar to how we do dynamic cateogries defined by apps. */ + if (log_filter_index < 0) + return -EINVAL; + + if (log_filter_index >= LOG_MAX_FILTERS) + return -EINVAL; + + target->filter_data[log_filter_index] = data; + return 0; +} + /*! Enable or disable the use of colored output * \param[in] target Log target to be affected * \param[in] use_color Use color (1) or don't use color (0) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41879?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie48e7e635feb91509b9c034394df4fb16cb931a3 Gerrit-Change-Number: 41879 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[L] Change in libosmocore[master]: osmo_io: Support rx of segments up to ~UINT16_MAX
by pespin 23 Jan '26

23 Jan '26

Attention is currently required from: daniel, fixeria, laforge. Hello Jenkins Builder, daniel, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/41911?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: osmo_io: Support rx of segments up to ~UINT16_MAX ...................................................................... osmo_io: Support rx of segments up to ~UINT16_MAX Previously if we recevied a big chunk (near UINT16_MAX), we would hit the following assert in iofd_msgb_alloc2(), because our msgb implementation can only handle sizes up to 16 bit length, counting headroom + data length: "OSMO_ASSERT(size + headroom <= 0xffff);". This new improved logic allows handling segments of up to ~UINT16_MAX which may come in in multiple read calls. It also adds logic to catch received segments greater than UINT16_MAX (or buggy segment_cb or buggy peer transmitting to us) and notifies the user of a broken stream through read_cb() in that case. test_segmentation_uint16_max() is added to osmo_io_test, which would abort without this patch applied. Related: SYS#7842 Change-Id: I8c11a7edbed2335ada40a1f93d081041974c3586 --- M src/core/osmo_io.c M tests/osmo_io/osmo_io_test.c M tests/osmo_io/osmo_io_test.err M tests/osmo_io/osmo_io_test.ok 4 files changed, 602 insertions(+), 34 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/11/41911/6 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41911?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8c11a7edbed2335ada40a1f93d081041974c3586 Gerrit-Change-Number: 41911 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>

1 0

[L] Change in libosmocore[master]: osmo_io: Support rx of segments up to ~UINT16_MAX
by pespin 23 Jan '26

23 Jan '26

Attention is currently required from: daniel, fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41911?usp=email ) Change subject: osmo_io: Support rx of segments up to ~UINT16_MAX ...................................................................... Patch Set 5: (4 comments) File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/41911/comment/f5378fed_b96ddf75?… : PS5, Line 367: struct osmo_io_fd *iofd > `const` Done https://gerrit.osmocom.org/c/libosmocore/+/41911/comment/451ee954_ddfbf781?… : PS5, Line 379: memcpy(msgb_put(iofd->pending, msgb_length(in_msg)), : msgb_data(in_msg), : > cosmetic: formatting looks weird here, I find it confusing Done File tests/osmo_io/osmo_io_test.c: https://gerrit.osmocom.org/c/libosmocore/+/41911/comment/1b2f9913_baccf1d2?… : PS5, Line 413: 3 > ```suggestion […] Done https://gerrit.osmocom.org/c/libosmocore/+/41911/comment/21354517_a2a0f71c?… : PS5, Line 513: ; > ```suggestion […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41911?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8c11a7edbed2335ada40a1f93d081041974c3586 Gerrit-Change-Number: 41911 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Jan 2026 10:05:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: vty: guard definition of _XOPEN_SOURCE
by fixeria 23 Jan '26

23 Jan '26

Attention is currently required from: Timur Davydov, laforge, osmith. fixeria has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41924?usp=email ) Change subject: vty: guard definition of _XOPEN_SOURCE ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41924?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4f53aff1afef02abce7cb70d1b29080ba900ff41 Gerrit-Change-Number: 41924 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Fri, 23 Jan 2026 09:26:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmocore[master]: build: keep netns API public and gate features with HAVE_*
by fixeria 23 Jan '26

23 Jan '26

Attention is currently required from: Timur Davydov, laforge. fixeria has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41878?usp=email ) Change subject: build: keep netns API public and gate features with HAVE_* ...................................................................... Patch Set 9: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41878?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2322eb2936bea35596f1fd6b6a713ea5f997b1ea Gerrit-Change-Number: 41878 Gerrit-PatchSet: 9 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Fri, 23 Jan 2026 09:24:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: core: fix printf format casts for struct timeval fields
by fixeria 23 Jan '26

23 Jan '26

Attention is currently required from: Timur Davydov, laforge, osmith. fixeria has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41923?usp=email ) Change subject: core: fix printf format casts for struct timeval fields ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41923?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icac9e392c728948a7976970658e37f5e0da41709 Gerrit-Change-Number: 41923 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Fri, 23 Jan 2026 09:20:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log January 2026