January 2026 - gerrit-log - lists.osmocom.org

[S] Change in libosmocore[master]: remove references to define EMBEDDED in public headers
by pespin 24 Jan '26

24 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/41932?usp=email ) Change subject: remove references to define EMBEDDED in public headers ...................................................................... remove references to define EMBEDDED in public headers It's not a good idea to base opt-in/out of code in public headers based on some specific non-standard define being set at compile time when calling the compiler. Get rid of those references; Now that osmocom/core/socket.h can be included thanks to improved osmocom/core/socket_compat.h, it shouldn't be a problem. Change-Id: I7a657d67077dfbe861959c6123eb9163bc791694 --- M include/osmocom/core/netdev.h M include/osmocom/core/netns.h M include/osmocom/core/tun.h M include/osmocom/gsm/gsup.h 4 files changed, 0 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/32/41932/1 diff --git a/include/osmocom/core/netdev.h b/include/osmocom/core/netdev.h index fb0f124..4d505fe 100644 --- a/include/osmocom/core/netdev.h +++ b/include/osmocom/core/netdev.h @@ -2,7 +2,6 @@ * network device (interface) convenience functions. */ #pragma once -#if (!EMBEDDED) #include <stddef.h> #include <stdint.h> @@ -47,5 +46,4 @@ uint8_t dst_prefixlen, const struct osmo_sockaddr *gw_addr); int osmo_netdev_ifupdown(struct osmo_netdev *netdev, bool ifupdown); -#endif /* (!EMBEDDED) */ /*! @} */ diff --git a/include/osmocom/core/netns.h b/include/osmocom/core/netns.h index 5bbf224..a6ed9e3 100644 --- a/include/osmocom/core/netns.h +++ b/include/osmocom/core/netns.h @@ -2,7 +2,6 @@ * Network namespace convenience functions. */ #pragma once -#if (!EMBEDDED) #if defined(__linux__) @@ -19,6 +18,4 @@ #endif /* defined(__linux__) */ - -#endif /* (!EMBEDDED) */ /*! @} */ diff --git a/include/osmocom/core/tun.h b/include/osmocom/core/tun.h index 21e7703..1351d04 100644 --- a/include/osmocom/core/tun.h +++ b/include/osmocom/core/tun.h @@ -2,7 +2,6 @@ * tunnel network device convenience functions. */ #pragma once -#if (!EMBEDDED) #include <stddef.h> #include <stdint.h> @@ -40,6 +39,4 @@ struct osmo_netdev *osmo_tundev_get_netdev(struct osmo_tundev *tundev); int osmo_tundev_send(struct osmo_tundev *tundev, struct msgb *msg); - -#endif /* (!EMBEDDED) */ /*! @} */ diff --git a/include/osmocom/gsm/gsup.h b/include/osmocom/gsm/gsup.h index 6ad72d2..3ef03a9 100644 --- a/include/osmocom/gsm/gsup.h +++ b/include/osmocom/gsm/gsup.h @@ -37,7 +37,6 @@ * */ #pragma once -#if (!EMBEDDED) #include <stdint.h> #include <osmocom/core/msgb.h> @@ -421,6 +420,4 @@ int osmo_gsup_encode(struct msgb *msg, const struct osmo_gsup_message *gsup_msg); int osmo_gsup_get_err_msg_type(enum osmo_gsup_message_type type_in) OSMO_DEPRECATED("Use OSMO_GSUP_TO_MSGT_ERROR() instead"); - -#endif /* (!EMBEDDED) */ /*! @} */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41932?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7a657d67077dfbe861959c6123eb9163bc791694 Gerrit-Change-Number: 41932 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: osmo_io.h: add forward declaration of struct osmo_sockaddr
by pespin 24 Jan '26

24 Jan '26

pespin has abandoned this change. ( https://gerrit.osmocom.org/c/libosmocore/+/41928?usp=email ) Change subject: osmo_io.h: add forward declaration of struct osmo_sockaddr ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41928?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id7db4b081752a1034b95a92b4850484a26ec11c6 Gerrit-Change-Number: 41928 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

[M] Change in libosmocore[master]: socket_compat.h improvements to always have struct osmo_sockaddr avai...
by pespin 24 Jan '26

24 Jan '26

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/41931?usp=email to look at the new patch set (#3). Change subject: socket_compat.h improvements to always have struct osmo_sockaddr available ...................................................................... socket_compat.h improvements to always have struct osmo_sockaddr available Having a #if (!EMBEDDED) based on compiler defined variable is not a good idea. Instead, add minimal sys/socket.h and netient/in.h to always have the definition of struct osmo_sockaddr available. Change-Id: I5b10e09770727c72812af15360ab3385b957509b --- M configure.ac M include/osmocom/core/Makefile.am M include/osmocom/core/socket.h M include/osmocom/core/socket_compat.h.tpl 4 files changed, 73 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/31/41931/3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41931?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5b10e09770727c72812af15360ab3385b957509b Gerrit-Change-Number: 41931 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmocore[master]: socket_compat.h improvements to always have struct osmo_sockaddr avai...
by pespin 24 Jan '26

24 Jan '26

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/41931?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: socket_compat.h improvements to always have struct osmo_sockaddr available ...................................................................... socket_compat.h improvements to always have struct osmo_sockaddr available Having a #if (!EMBEDDED) based on compiler defined variable is not a good idea. Instead, add minimal sys/socket.h and netient/in.h to always have the definition of struct osmo_sockaddr available. Change-Id: I5b10e09770727c72812af15360ab3385b957509b --- M configure.ac M include/osmocom/core/Makefile.am M include/osmocom/core/socket.h M include/osmocom/core/socket_compat.h.tpl 4 files changed, 73 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/31/41931/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41931?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5b10e09770727c72812af15360ab3385b957509b Gerrit-Change-Number: 41931 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmocore[master]: socket_compat.h improvements to always have struct osmo_sockaddr avai...
by pespin 24 Jan '26

24 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/41931?usp=email ) Change subject: socket_compat.h improvements to always have struct osmo_sockaddr available ...................................................................... socket_compat.h improvements to always have struct osmo_sockaddr available Having a #if (!EMBEDDED) based on compiler defined variable is not a good idea. Instead, add minimal sys/socket.h and netient/in.h to always have the definition of struct osmo_sockaddr available. Change-Id: I5b10e09770727c72812af15360ab3385b957509b --- M configure.ac M include/osmocom/core/Makefile.am M include/osmocom/core/socket.h M include/osmocom/core/socket_compat.h.tpl 4 files changed, 69 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/31/41931/1 diff --git a/configure.ac b/configure.ac index c30876c..966751f 100644 --- a/configure.ac +++ b/configure.ac @@ -75,6 +75,7 @@ dnl checks for header files AC_HEADER_STDC AC_CHECK_HEADERS(arpa/inet.h execinfo.h poll.h sys/select.h sys/socket.h sys/signalfd.h sys/eventfd.h sys/timerfd.h ctype.h netinet/tcp.h netinet/in.h) +AC_CHECK_DECL(HAVE_NETINET_IN_H, AC_SUBST(HAVE_NETINET_IN_H, 1), AC_SUBST(HAVE_NETINET_IN_H, 0)) AC_CHECK_DECL(HAVE_SYS_SOCKET_H, AC_SUBST(HAVE_SYS_SOCKET_H, 1), AC_SUBST(HAVE_SYS_SOCKET_H, 0)) # for src/conv.c AC_FUNC_ALLOCA diff --git a/include/osmocom/core/Makefile.am b/include/osmocom/core/Makefile.am index 9a949ae..18ee283 100644 --- a/include/osmocom/core/Makefile.am +++ b/include/osmocom/core/Makefile.am @@ -100,7 +100,9 @@ socket_compat.h: socket_compat.h.tpl $(AM_V_GEN)$(MKDIR_P) $(dir $@) - $(AM_V_GEN)sed -e's/XX/$(HAVE_SYS_SOCKET_H)/g' $< > $@ + $(AM_V_GEN)sed -e's/__LIBOSMOCORE_HAVE_SYS_SOCKET_H XX/__LIBOSMOCORE_HAVE_SYS_SOCKET_H $(HAVE_SYS_SOCKET_H)/g' \ + -e's/__LIBOSMOCORE_HAVE_NETINET_IN_H XX/__LIBOSMOCORE_HAVE_NETINET_IN_H $(HAVE_NETINET_IN_H)/g' \ + $< > $@ version.h: version.h.tpl $(AM_V_GEN)$(MKDIR_P) $(dir $@) diff --git a/include/osmocom/core/socket.h b/include/osmocom/core/socket.h index 845efd7..7498e35 100644 --- a/include/osmocom/core/socket.h +++ b/include/osmocom/core/socket.h @@ -2,7 +2,6 @@ * Osmocom socket convenience functions. */ #pragma once -#if (!EMBEDDED) /*! \defgroup socket Socket convenience functions * @{ @@ -12,9 +11,8 @@ #include <stdbool.h> #include <stddef.h> -#include <netinet/in.h> - #include <osmocom/core/defs.h> +#include <osmocom/core/socket_compat.h> /*! maximum number of local or remote addresses supported by an osmo_sock instance */ #define OSMO_SOCK_MAX_ADDRS 32 @@ -29,9 +27,6 @@ /*! maximum length of a multia-address socket name ("r=(::2|1.2.3.4):123<->l=(5.6.7.8|::9):987") */ #define OSMO_SOCK_MULTIADDR_NAME_MAXLEN (OSMO_SOCK_MULTIADDR_PEER_STR_MAXLEN + 7) - -struct sockaddr_in; -struct sockaddr; struct osmo_fd; struct sctp_paddrinfo; @@ -224,5 +219,4 @@ int osmo_sock_sctp_get_peer_addr_info(int fd, struct sctp_paddrinfo *pinfo, size_t *pinfo_cnt); -#endif /* (!EMBEDDED) */ /*! @} */ diff --git a/include/osmocom/core/socket_compat.h.tpl b/include/osmocom/core/socket_compat.h.tpl index 43bee9e..4254d68 100644 --- a/include/osmocom/core/socket_compat.h.tpl +++ b/include/osmocom/core/socket_compat.h.tpl @@ -1,10 +1,68 @@ -#define HAVE_STRUCT_SOCKADDR_STORAGE XX +#define __LIBOSMOCORE_HAVE_SYS_SOCKET_H XX +#define __LIBOSMOCORE_HAVE_NETINET_IN_H XX -#if HAVE_STRUCT_SOCKADDR_STORAGE +#if __LIBOSMOCORE_HAVE_SYS_SOCKET_H #include <sys/socket.h> #else -struct sockaddr_storage { - unsigned short ss_family; - char __data[128 - sizeof(unsigned short)]; +/* Minimal netinet/in.h as per POSIX https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/sys_socket.h.html */ +#include <stdint.h> +typedef uint32_t socklen_t; +typedef unsigned short sa_family_t; + +struct sockaddr { + sa_family_t sa_family; + char sa_data[14]; }; -#endif + +struct sockaddr_storage { + sa_family_t ss_family; + char __data[128 - sizeof(sa_family_t)]; +}; +#endif /* if __LIBOSMOCORE_HAVE_SYS_SOCKET_H */ + +#if __LIBOSMOCORE_HAVE_NETINET_IN_H + #include <netinet/in.h> +#else +/* Minimal netinet/in.h as per POSIX https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/netinet_in.h.html */ +#include <stdint.h> + +typedef uint32_t in_addr_t; +struct in_addr { + in_addr_t s_addr; +}; + +typedef uint16_t in_port_t; + +struct in6_addr { + union { + uint8_t __u6_addr8[16]; + uint16_t __u6_addr16[8]; + uint32_t __u6_addr32[4]; + } __in6_u; + #define s6_addr __in6_u.__u6_addr8 + #define s6_addr16 __in6_u.__u6_addr16 + #define s6_addr32 __in6_u.__u6_addr32 +}; + +#define INET_ADDRSTRLEN 16 +#define INET6_ADDRSTRLEN 46 + +struct sockaddr_in { + sa_family_t sin_family; + in_port_t sin_port; + struct in_addr sin_addr; + unsigned char sin_zero[sizeof (struct sockaddr) + - sizeof (sa_family_t) + - sizeof (in_port_t) + - sizeof (struct in_addr)]; +}; + +struct sockaddr_in6 { + sa_family_t sin6_family; + in_port_t sin6_port; + uint32_t sin6_flowinfo; + struct in6_addr sin6_addr; + uint32_t sin6_scope_id; +}; + +#endif /* if __LIBOSMOCORE_HAVE_NETINET_IN_H */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41931?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5b10e09770727c72812af15360ab3385b957509b Gerrit-Change-Number: 41931 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: configure.ac: Add arpa/inet.h to AC_CHECK_HEADERS
by pespin 24 Jan '26

24 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/41930?usp=email ) Change subject: configure.ac: Add arpa/inet.h to AC_CHECK_HEADERS ...................................................................... configure.ac: Add arpa/inet.h to AC_CHECK_HEADERS We use arpa/inet.h in several places in the code, so it's good to look up for presence even if it's only to debug toolchain compatibility. Change-Id: Ib2d1fb3efb1dcb429b511698691249c257e00720 --- M configure.ac 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/30/41930/1 diff --git a/configure.ac b/configure.ac index 4a6a474..c30876c 100644 --- a/configure.ac +++ b/configure.ac @@ -74,7 +74,7 @@ dnl checks for header files AC_HEADER_STDC -AC_CHECK_HEADERS(execinfo.h poll.h sys/select.h sys/socket.h sys/signalfd.h sys/eventfd.h sys/timerfd.h ctype.h netinet/tcp.h netinet/in.h) +AC_CHECK_HEADERS(arpa/inet.h execinfo.h poll.h sys/select.h sys/socket.h sys/signalfd.h sys/eventfd.h sys/timerfd.h ctype.h netinet/tcp.h netinet/in.h) AC_CHECK_DECL(HAVE_SYS_SOCKET_H, AC_SUBST(HAVE_SYS_SOCKET_H, 1), AC_SUBST(HAVE_SYS_SOCKET_H, 0)) # for src/conv.c AC_FUNC_ALLOCA -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41930?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib2d1fb3efb1dcb429b511698691249c257e00720 Gerrit-Change-Number: 41930 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: socket.h: Include netinet/in.h instead of arpa/inet.h
by pespin 24 Jan '26

24 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/41929?usp=email ) Change subject: socket.h: Include netinet/in.h instead of arpa/inet.h ...................................................................... socket.h: Include netinet/in.h instead of arpa/inet.h In socket.h we are mainly interested in netinet/int.h, since that's the one defining INET_ADDRSTRLEN, struct sockaddr_in, struct in_addr, ec. Header arpa/inet.h usually defines several functions which use those, like htonl(), inet_ntop(), etc. See POSIX: https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/arpa_inet.h.html#… https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/netinet_in.h.html Change-Id: I03919c4adc962bbcfabc9030c6f12c0e10ff060c --- M include/osmocom/core/socket.h 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/29/41929/1 diff --git a/include/osmocom/core/socket.h b/include/osmocom/core/socket.h index e9979f5..845efd7 100644 --- a/include/osmocom/core/socket.h +++ b/include/osmocom/core/socket.h @@ -12,7 +12,7 @@ #include <stdbool.h> #include <stddef.h> -#include <arpa/inet.h> +#include <netinet/in.h> #include <osmocom/core/defs.h> -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41929?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I03919c4adc962bbcfabc9030c6f12c0e10ff060c Gerrit-Change-Number: 41929 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: osmo_io.h: add forward declaration of struct osmo_sockaddr
by pespin 24 Jan '26

24 Jan '26

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/41928?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: osmo_io.h: add forward declaration of struct osmo_sockaddr ...................................................................... osmo_io.h: add forward declaration of struct osmo_sockaddr During amr-none-eabi build (EMBEDDED defined), including <osmocom/core/socket.h> includes a mostly empty file, since that file is guarded by "#if (!EMBEDDED)" because sys/socket.h is not available there. As a result, if somebody includes osmo_io.h when EMBEDDED is set, there will be no declaration of struct osmo_sockaddr used in declared APIs. Add a forward declaration to fix it. Furthermore, the EMBEDDED check in osmocom/core/socket.h is actually broken because it's in a header file which cannot include "config.h", so also avoid including osocom/core/socket.h altogether in order to avoid it in turn including arpa/inet.h which is not available in the arm-none-eabi toolchain. Change-Id: Id7db4b081752a1034b95a92b4850484a26ec11c6 --- M include/osmocom/core/osmo_io.h 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/28/41928/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41928?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id7db4b081752a1034b95a92b4850484a26ec11c6 Gerrit-Change-Number: 41928 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

[XS] Change in libosmocore[master]: osmo_io.h: add forward declaration of struct osmo_sockaddr
by pespin 24 Jan '26

24 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/41928?usp=email ) Change subject: osmo_io.h: add forward declaration of struct osmo_sockaddr ...................................................................... osmo_io.h: add forward declaration of struct osmo_sockaddr During amr-none-eabi build (EMBEDDED defined), including <osmocom/core/socket.h> includes a mostly empty file, since that file is guarded by "#if (!EMBEDDED)" because sys/socket.h is not available there. As a result, if somebody includes osmo_io.h when EMBEDDED is set, there will be no declaration of struct osmo_sockaddr used in declared APIs. Add a forward declaration to fix it. Change-Id: Id7db4b081752a1034b95a92b4850484a26ec11c6 --- M include/osmocom/core/osmo_io.h 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/28/41928/1 diff --git a/include/osmocom/core/osmo_io.h b/include/osmocom/core/osmo_io.h index 525c23c..b5e7ea8 100644 --- a/include/osmocom/core/osmo_io.h +++ b/include/osmocom/core/osmo_io.h @@ -14,6 +14,10 @@ * We only really need a forward declaration here: */ struct msghdr; +/* struct osmo_sockaddr is defined in osmocom/core/socket.h, which in turn relies on sys/socket.h to define it, + * which may not be available. We only really need a forward declaration here: */ +struct osmo_sockaddr; + /*! \defgroup osmo_io Osmocom I/O interface * @{ * -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41928?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id7db4b081752a1034b95a92b4850484a26ec11c6 Gerrit-Change-Number: 41928 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[L] Change in libosmocore[master]: logging: Move log target file to its own file
by pespin 24 Jan '26

24 Jan '26

Attention is currently required from: fixeria, laforge, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41894?usp=email ) Change subject: logging: Move log target file to its own file ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: I moved this patch before the one making struct log_target private, since it's actually not dependent on it and this way it can already be merged. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41894?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8e32e31c75b66ff0649d92c2f469f8895689fbad Gerrit-Change-Number: 41894 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 23 Jan 2026 15:23:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

2026

2025

2024

2023

2022

gerrit-log January 2026