fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41936?usp=email )
Change subject: bts: f_est_dchan(): populate UL SACCH cache
......................................................................
bts: f_est_dchan(): populate UL SACCH cache
This ensures that UL SACCH blocks always contain the expected content
and a proper L1 SACCH header, rather than the dummy measurement report
hard-coded in trxcon/firmware. As a result, the BTS receives
consistent and realistic UL SACCH from the very beginning.
Change-Id: I4781fe7539e64e77d594e84f905646c127f46b64
Related: OS#6933
---
M bts/BTS_Tests.ttcn
1 file changed, 3 insertions(+), 9 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/36/41936/1
diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index 3a24d48..27dd83f 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -2525,6 +2525,9 @@
ch_desc := valueof(ts_ChanDescH0(g_pars.chan_nr, trx_pars.arfcn, g_pars.tsc));
}
+ /* Populate UL SACCH cache with a Measurement Report */
+ f_send_meas_rep(ts_MeasurementResults);
+
/* enable dedicated mode */
f_l1ctl_est_dchan(L1CTL, g_pars);
@@ -3891,9 +3894,6 @@
g_pars.l1_pars.ms_actual_ta := ta_to_test;
f_L1CTL_PARAM(L1CTL, g_pars.l1_pars.ms_actual_ta,
g_pars.l1_pars.ms_power_level);
- /* tell trxcon to use a given TA in UL SACCH blocks
- * this is achieved by populating UL SACCH cache before doing f_l1ctl_est_dchan() */
- f_send_meas_rep(ts_MeasurementResults);
f_est_dchan(more_ies :={valueof(t_RSL_IE(RSL_IE_TIMING_ADVANCE, RSL_IE_Body:{timing_adv := ta_to_test}))} );
@@ -8189,9 +8189,6 @@
/* Ensure that 'rx-current' equals 'rx-target' */
f_trxc_fake_rssi(mp_uplink_power_target);
- /* Populate SACCH cache with a Measurement Report */
- f_send_meas_rep(ts_MeasurementResults);
-
/* Establish a dedicated channel */
f_est_dchan(more_ies := valueof(ies));
@@ -8253,9 +8250,6 @@
/* Ensure that 'rx-current' equals 'rx-target' */
f_trxc_fake_rssi(mp_uplink_power_target);
- /* Populate SACCH cache with a Measurement Report */
- f_send_meas_rep(ts_MeasurementResults);
-
/* Establish a dedicated channel */
f_est_dchan(more_ies := valueof(ies));
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41936?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I4781fe7539e64e77d594e84f905646c127f46b64
Gerrit-Change-Number: 41936
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: fixeria, laforge, osmith.
Hello Jenkins Builder, fixeria, laforge, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmocore/+/41894?usp=email
to look at the new patch set (#8).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: logging: Move log target file to its own file
......................................................................
logging: Move log target file to its own file
We already have all other log_target implementations each on its own
file. Move the file (and stderr, a specific case of file) into its own
file too, properly separating most file-specific logic from general
logging logic.
Change-Id: I8e32e31c75b66ff0649d92c2f469f8895689fbad
---
M include/osmocom/core/logging_internal.h
M src/core/Makefile.am
M src/core/logging.c
A src/core/logging_file.c
4 files changed, 382 insertions(+), 328 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/94/41894/8
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41894?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I8e32e31c75b66ff0649d92c2f469f8895689fbad
Gerrit-Change-Number: 41894
Gerrit-PatchSet: 8
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: laforge, osmith, pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41894?usp=email )
Change subject: logging: Move log target file to its own file
......................................................................
Patch Set 7:
(2 comments)
File src/core/logging.c:
https://gerrit.osmocom.org/c/libosmocore/+/41894/comment/a3a19a49_7768587c?… :
PS7, Line 762: _output
This function no longer exists.
File src/core/logging_file.c:
https://gerrit.osmocom.org/c/libosmocore/+/41894/comment/aad51479_4ec903ad?… :
PS7, Line 2: Syslog
This is not really syslog?
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41894?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I8e32e31c75b66ff0649d92c2f469f8895689fbad
Gerrit-Change-Number: 41894
Gerrit-PatchSet: 7
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 23 Jan 2026 21:27:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41930?usp=email )
Change subject: configure.ac: Add arpa/inet.h to AC_CHECK_HEADERS
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41930?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib2d1fb3efb1dcb429b511698691249c257e00720
Gerrit-Change-Number: 41930
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 23 Jan 2026 21:11:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41929?usp=email )
Change subject: socket.h: Include netinet/in.h instead of arpa/inet.h
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41929?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I03919c4adc962bbcfabc9030c6f12c0e10ff060c
Gerrit-Change-Number: 41929
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 23 Jan 2026 21:10:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes