fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41946?usp=email )
Change subject: fake_trx: reset settings on CMD POWEROFF
......................................................................
Patch Set 1: Verified+1
(1 comment)
Patchset:
PS1:
I have tested this patch by running ttcn3-bts-test.
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41946?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmocom-bb
Gerrit-Branch: ttcn3-bts-test
Gerrit-Change-Id: I5c58bc684acc7a58d7aa940bb2ae7597d4a282f2
Gerrit-Change-Number: 41946
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 26 Jan 2026 13:05:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41946?usp=email )
Change subject: fake_trx: reset settings on CMD POWEROFF
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Build verification failure is expected here because this branch predates Oliver's firmware fixes.
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41946?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmocom-bb
Gerrit-Branch: ttcn3-bts-test
Gerrit-Change-Id: I5c58bc684acc7a58d7aa940bb2ae7597d4a282f2
Gerrit-Change-Number: 41946
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 26 Jan 2026 13:05:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41899?usp=email )
Change subject: bts: TC_rsl_chan_initial_ta: fix sporadic failures
......................................................................
Patch Set 2:
(1 comment)
File bts/BTS_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41899/comment/056b3af8_8449… :
PS1, Line 3894: /* tell trxcon to use a given TA for UL bursts */
> > a lot of trxcon blackmagic which is need to "set TA on trxcon" […]
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41936
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41899?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iebb043ccc710750dff937e2281c23d343b85bda1
Gerrit-Change-Number: 41899
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 26 Jan 2026 13:03:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41946?usp=email )
Change subject: fake_trx: reset settings on CMD POWEROFF
......................................................................
fake_trx: reset settings on CMD POWEROFF
When running ttcn3-bts-test, parameters such as SETTA, FAKE_RSSI,
FAKE_TOA, and others may persist across testcases if not explicitly
reset, leading to unintended cross-test interference.
Reset all transceiver settings on CMD POWEROFF to ensure proper
test isolation and predictable behavior between testcases.
Change-Id: I5c58bc684acc7a58d7aa940bb2ae7597d4a282f2
(cherry picked from commit 754d5ebb1e120e661fd3b1e025abfc5b5216ac80)
---
M src/target/trx_toolkit/fake_trx.py
M src/target/trx_toolkit/transceiver.py
2 files changed, 14 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/46/41946/1
diff --git a/src/target/trx_toolkit/fake_trx.py b/src/target/trx_toolkit/fake_trx.py
index 7dc80d1..1aba866 100755
--- a/src/target/trx_toolkit/fake_trx.py
+++ b/src/target/trx_toolkit/fake_trx.py
@@ -116,7 +116,12 @@
CI_NOISE_DEFAULT = -30
def __init__(self, *trx_args, **trx_kwargs):
- Transceiver.__init__(self, *trx_args, **trx_kwargs)
+ super().__init__(*trx_args, **trx_kwargs)
+ self.reset_params()
+
+ def reset_params(self):
+ """ Reset/initialize all parameters """
+ super().reset_params()
# fake RSSI is disabled by default, only enabled through TRXC FAKE_RSSI.
# When disabled, RSSI is calculated based on Tx power and Rx path loss
diff --git a/src/target/trx_toolkit/transceiver.py b/src/target/trx_toolkit/transceiver.py
index ffd18ab..d0ff955 100644
--- a/src/target/trx_toolkit/transceiver.py
+++ b/src/target/trx_toolkit/transceiver.py
@@ -205,6 +205,13 @@
log.info("(%s) Frequency hopping disabled" % self)
self.fh = None
+ def reset_params(self):
+ """ Reset/initialize all parameters """
+ self.running = False
+ self._rx_freq = None
+ self._tx_freq = None
+ self.disable_fh()
+
# To be overwritten if required,
# no custom command handlers by default
def ctrl_cmd_handler(self, request):
@@ -220,7 +227,7 @@
for trx in trx_list:
trx.running = poweron
if not poweron:
- trx.disable_fh()
+ trx.reset_params()
# Trigger clock generator if required
if self.clck_gen is not None:
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41946?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmocom-bb
Gerrit-Branch: ttcn3-bts-test
Gerrit-Change-Id: I5c58bc684acc7a58d7aa940bb2ae7597d4a282f2
Gerrit-Change-Number: 41946
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41945?usp=email )
Change subject: fake_trx: reset settings on CMD POWEROFF
......................................................................
fake_trx: reset settings on CMD POWEROFF
When running ttcn3-bts-test, parameters such as SETTA, FAKE_RSSI,
FAKE_TOA, and others may persist across testcases if not explicitly
reset, leading to unintended cross-test interference.
Reset all transceiver settings on CMD POWEROFF to ensure proper
test isolation and predictable behavior between testcases.
Change-Id: I5c58bc684acc7a58d7aa940bb2ae7597d4a282f2
---
M src/target/trx_toolkit/fake_trx.py
M src/target/trx_toolkit/transceiver.py
2 files changed, 14 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/45/41945/1
diff --git a/src/target/trx_toolkit/fake_trx.py b/src/target/trx_toolkit/fake_trx.py
index 8f187ac..f8ddd23 100755
--- a/src/target/trx_toolkit/fake_trx.py
+++ b/src/target/trx_toolkit/fake_trx.py
@@ -116,7 +116,12 @@
CI_NOISE_DEFAULT = -30
def __init__(self, *trx_args, **trx_kwargs):
- Transceiver.__init__(self, *trx_args, **trx_kwargs)
+ super().__init__(*trx_args, **trx_kwargs)
+ self.reset_params()
+
+ def reset_params(self):
+ """ Reset/initialize all parameters """
+ super().reset_params()
# fake RSSI is disabled by default, only enabled through TRXC FAKE_RSSI.
# When disabled, RSSI is calculated based on Tx power and Rx path loss
diff --git a/src/target/trx_toolkit/transceiver.py b/src/target/trx_toolkit/transceiver.py
index ce71bb1..20d9cde 100644
--- a/src/target/trx_toolkit/transceiver.py
+++ b/src/target/trx_toolkit/transceiver.py
@@ -241,6 +241,13 @@
log.info("(%s) Frequency hopping disabled" % self)
self.fh = None
+ def reset_params(self):
+ """ Reset/initialize all parameters """
+ self.running = False
+ self._rx_freq = None
+ self._tx_freq = None
+ self.disable_fh()
+
# To be overwritten if required,
# no custom command handlers by default
def ctrl_cmd_handler(self, request):
@@ -257,7 +264,7 @@
trx.running = poweron
if not poweron:
trx.tx_queue_clear()
- trx.disable_fh()
+ trx.reset_params()
# Trigger clock generator if required
if self.clck_gen is not None:
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41945?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I5c58bc684acc7a58d7aa940bb2ae7597d4a282f2
Gerrit-Change-Number: 41945
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>