January 2026 - gerrit-log - lists.osmocom.org

[XS] Change in pysim[master]: pySim.esim.saip: Don't try to generate file contents for MF/DF/ADF
by dexter 27 Jan '26

27 Jan '26

Attention is currently required from: laforge, neels. dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/38015?usp=email ) Change subject: pySim.esim.saip: Don't try to generate file contents for MF/DF/ADF ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38015?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I02a54a3b2f73a0e9118db87f8b514d1dbf53971f Gerrit-Change-Number: 38015 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 26 Jan 2026 13:42:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmocom-bb[master]: trx_toolkit/burst_fwd: Use 'is' instead of '==' when checking if trx ...
by fixeria 27 Jan '26

27 Jan '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/40044?usp=email ) Change subject: trx_toolkit/burst_fwd: Use 'is' instead of '==' when checking if trx is src_trx ...................................................................... trx_toolkit/burst_fwd: Use 'is' instead of '==' when checking if trx is src_trx In python `a is b` is just a pointer comparison of locations of objects a and b, while `a == b` can involve doing arbitrary code invoking __eq__ and is generally slower even without __eq__ defined: In [1]: class A: ...: pass ...: In [2]: a = A() In [4]: b = A() In [5]: a == a Out[5]: True In [6]: a == b Out[6]: False In [7]: a is a Out[7]: True In [8]: a is b Out[8]: False In [9]: %timeit a is a 84.2 ns ± 0.133 ns per loop (mean ± std. dev. of 7 runs, 10,000,000 loops each) In [10]: %timeit a is b 87.5 ns ± 0.0736 ns per loop (mean ± std. dev. of 7 runs, 10,000,000 loops each) In [11]: %timeit a == a 100 ns ± 0.659 ns per loop (mean ± std. dev. of 7 runs, 10,000,000 loops each) In [12]: %timeit a == b 116 ns ± 0.399 ns per loop (mean ± std. dev. of 7 runs, 10,000,000 loops each) BurstForwarder.forward_msg is one of the hottest places, as e.g. for every received packet from BTS it forwards it to multiple Ms receivers. It makes sense to be careful and save cycles here. Change-Id: Ic9e16720daeb348b5f9c535c24a682db53a93529 --- M src/target/trx_toolkit/burst_fwd.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/target/trx_toolkit/burst_fwd.py b/src/target/trx_toolkit/burst_fwd.py index 6924531..e3da9c2 100644 --- a/src/target/trx_toolkit/burst_fwd.py +++ b/src/target/trx_toolkit/burst_fwd.py @@ -52,7 +52,7 @@ # Iterate over all known transceivers for trx in self.trx_list: - if trx == src_trx: + if trx is src_trx: continue # Check transceiver state -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/40044?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ic9e16720daeb348b5f9c535c24a682db53a93529 Gerrit-Change-Number: 40044 Gerrit-PatchSet: 2 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmocom-bb[master]: trx_toolkit/*: Don't use `del x; x = None` idiom
by fixeria 27 Jan '26

27 Jan '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/40045?usp=email ) Change subject: trx_toolkit/*: Don't use `del x; x = None` idiom ...................................................................... trx_toolkit/*: Don't use `del x; x = None` idiom In Python it is enough to do `x = None` to release the object that was pointed to by x previously. So at Python level doing this extra del only spends more CPU time, but when we will switch to Cython, and e.g. Msg.burst will be a C-level attribute, the following will not work at all del msg.burst msg.burst = None because at runtime it will complain that del msg.burst AttributeError: 'Msg' object has no attribute 'burst' and no __dict__ for setting new attributes -> Remove unneeded del to save some time and avoid problems with upcoming switch to Cython. Change-Id: I7a83bdd52fb9318bd8b975f85ce37c7144873f61 --- M src/target/trx_toolkit/burst_fwd.py M src/target/trx_toolkit/clck_gen.py M src/target/trx_toolkit/fake_trx.py 3 files changed, 2 insertions(+), 5 deletions(-) Approvals: fixeria: Looks good to me, approved; Verified laforge: Looks good to me, but someone else must approve diff --git a/src/target/trx_toolkit/burst_fwd.py b/src/target/trx_toolkit/burst_fwd.py index e3da9c2..2824e0a 100644 --- a/src/target/trx_toolkit/burst_fwd.py +++ b/src/target/trx_toolkit/burst_fwd.py @@ -47,8 +47,7 @@ tx_freq = src_trx.get_tx_freq(rx_msg.fn) if src_trx.rf_muted: - del rx_msg.burst # burst bits are omited - rx_msg.burst = None + rx_msg.burst = None # burst bits are omited # Iterate over all known transceivers for trx in self.trx_list: diff --git a/src/target/trx_toolkit/clck_gen.py b/src/target/trx_toolkit/clck_gen.py index ae7a899..f769c3e 100755 --- a/src/target/trx_toolkit/clck_gen.py +++ b/src/target/trx_toolkit/clck_gen.py @@ -82,7 +82,6 @@ self._thread.join() # Free memory, reset breaker - del self._thread self._thread = None self._breaker.clear() diff --git a/src/target/trx_toolkit/fake_trx.py b/src/target/trx_toolkit/fake_trx.py index 8f187ac..711ad21 100755 --- a/src/target/trx_toolkit/fake_trx.py +++ b/src/target/trx_toolkit/fake_trx.py @@ -226,8 +226,7 @@ return # Since TRXDv1, we should send a NOPE.ind - del msg.burst # burst bits are omited - msg.burst = None + msg.burst = None # burst bits are omited # TODO: shoud we make these values configurable? msg.toa256 = self.TOA256_NOISE_DEFAULT -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/40045?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I7a83bdd52fb9318bd8b975f85ce37c7144873f61 Gerrit-Change-Number: 40045 Gerrit-PatchSet: 2 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmocom-bb[master]: trx_toolkit/udp_link: Factor code to describe remote into .desc_remot...
by fixeria 27 Jan '26

27 Jan '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/40046?usp=email ) Change subject: trx_toolkit/udp_link: Factor code to describe remote into .desc_remote() function ...................................................................... trx_toolkit/udp_link: Factor code to describe remote into .desc_remote() function And use that utility everywhere where remote of UDPLink is logged. The reason we are doing this is that with upcoming switch to Cython the way remote address is stored will change to `struct sockaddr_in` and instead of updating all users, we will need to only change UDPLink.desc_remote() in one place. Add .desc_local() for symmetry. Change-Id: I1e2fa560ada7a8de4c9b9150058c2a1c73874fbe --- M src/target/trx_toolkit/data_if.py M src/target/trx_toolkit/udp_link.py 2 files changed, 9 insertions(+), 5 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve diff --git a/src/target/trx_toolkit/data_if.py b/src/target/trx_toolkit/data_if.py index 5bc243f..f59ca17 100644 --- a/src/target/trx_toolkit/data_if.py +++ b/src/target/trx_toolkit/data_if.py @@ -70,7 +70,7 @@ msg.parse_msg(data) except: log.error("Failed to parse a TRXD Tx message " - "from R:%s:%u" % (self.remote_addr, self.remote_port)) + "from R:%s" % self.desc_remote()) return None # Make sure the header version matches @@ -90,7 +90,7 @@ msg.parse_msg(bytearray(data)) except: log.error("Failed to parse a TRXD Rx message " - "from R:%s:%u" % (self.remote_addr, self.remote_port)) + "from R:%s" % self.desc_remote()) return None # Make sure the header version matches diff --git a/src/target/trx_toolkit/udp_link.py b/src/target/trx_toolkit/udp_link.py index f0a8224..8690109 100644 --- a/src/target/trx_toolkit/udp_link.py +++ b/src/target/trx_toolkit/udp_link.py @@ -34,11 +34,15 @@ def __del__(self): self.sock.close() - def desc_link(self): + def desc_local(self): (bind_addr, bind_port) = self.sock.getsockname() + return "%s:%u" % (bind_addr, bind_port) - return "L:%s:%u <-> R:%s:%u" \ - % (bind_addr, bind_port, self.remote_addr, self.remote_port) + def desc_remote(self): + return "%s:%u" % (self.remote_addr, self.remote_port) + + def desc_link(self): + return "L:%s <-> R:%s" % (self.desc_local(), self.desc_remote()) def send(self, data): self.sendto(data, (self.remote_addr, self.remote_port)) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/40046?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I1e2fa560ada7a8de4c9b9150058c2a1c73874fbe Gerrit-Change-Number: 40046 Gerrit-PatchSet: 2 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmocom-bb[master]: trx_toolkit/udp_link: Factor code to describe remote into .desc_remot...
by fixeria 27 Jan '26

27 Jan '26

Attention is currently required from: kirr, laforge. fixeria has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/40046?usp=email ) Change subject: trx_toolkit/udp_link: Factor code to describe remote into .desc_remote() function ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/40046?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I1e2fa560ada7a8de4c9b9150058c2a1c73874fbe Gerrit-Change-Number: 40046 Gerrit-PatchSet: 1 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: kirr <kirr(a)nexedi.com> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 26 Jan 2026 13:29:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-remsim[master]: rspro_server.c: Fix missing include for inet_ntoa()
by osmith 27 Jan '26

27 Jan '26

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-remsim/+/41947?usp=email ) Change subject: rspro_server.c: Fix missing include for inet_ntoa() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/41947?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I49352bcc2b8e418e17453809354382bd37eb838e Gerrit-Change-Number: 41947 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jan 2026 13:23:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-remsim[master]: rspro_server.c: Fix missing include for inet_ntoa()
by pespin 27 Jan '26

27 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/41947?usp=email ) Change subject: rspro_server.c: Fix missing include for inet_ntoa() ...................................................................... rspro_server.c: Fix missing include for inet_ntoa() This file was calling inet_ntoa() without including arpa/inet.h, which is the header defining the function according to man and posix documentation. Change-Id: I49352bcc2b8e418e17453809354382bd37eb838e --- M src/server/rspro_server.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/47/41947/1 diff --git a/src/server/rspro_server.c b/src/server/rspro_server.c index 1cc1af1..4e3666c 100644 --- a/src/server/rspro_server.c +++ b/src/server/rspro_server.c @@ -3,6 +3,7 @@ #include <unistd.h> #include <pthread.h> #include <errno.h> +#include <arpa/inet.h> #include <osmocom/core/linuxlist.h> #include <osmocom/core/select.h> -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/41947?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I49352bcc2b8e418e17453809354382bd37eb838e Gerrit-Change-Number: 41947 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmocom-bb[ttcn3-bts-test]: fake_trx: reset settings on CMD POWEROFF
by pespin 27 Jan '26

27 Jan '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41946?usp=email ) Change subject: fake_trx: reset settings on CMD POWEROFF ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41946?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: ttcn3-bts-test Gerrit-Change-Id: I5c58bc684acc7a58d7aa940bb2ae7597d4a282f2 Gerrit-Change-Number: 41946 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jan 2026 13:17:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmocom-bb[master]: fake_trx: reset settings on CMD POWEROFF
by pespin 27 Jan '26

27 Jan '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41945?usp=email ) Change subject: fake_trx: reset settings on CMD POWEROFF ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41945?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I5c58bc684acc7a58d7aa940bb2ae7597d4a282f2 Gerrit-Change-Number: 41945 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jan 2026 13:17:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: jobs/dahdi: fix git clones not getting updated
by osmith 27 Jan '26

27 Jan '26

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/41943?usp=email ) Change subject: jobs/dahdi: fix git clones not getting updated ...................................................................... jobs/dahdi: fix git clones not getting updated The refspec line has caused the git clones of the linux kernel to not get updated. Fixes: OS#6932 Change-Id: Id3b35ac10cf4fcb244c572a319433379e2e59c22 --- M jobs/gerrit-verifications-dahdi.yml M jobs/master-builds-dahdi.yml 2 files changed, 0 insertions(+), 2 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified tnt: Looks good to me, but someone else must approve diff --git a/jobs/gerrit-verifications-dahdi.yml b/jobs/gerrit-verifications-dahdi.yml index 78909c8..8213287 100644 --- a/jobs/gerrit-verifications-dahdi.yml +++ b/jobs/gerrit-verifications-dahdi.yml @@ -52,7 +52,6 @@ url: '{repo}' branches: - '{linux-ver}' - refspec: '{linux-ver}' shallow-clone: true wipe-workspace: false clean: diff --git a/jobs/master-builds-dahdi.yml b/jobs/master-builds-dahdi.yml index 7ba5985..60a703b 100644 --- a/jobs/master-builds-dahdi.yml +++ b/jobs/master-builds-dahdi.yml @@ -56,7 +56,6 @@ url: '{repo}' branches: - '{linux-ver}' - refspec: '{linux-ver}' shallow-clone: true wipe-workspace: false clean: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41943?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id3b35ac10cf4fcb244c572a319433379e2e59c22 Gerrit-Change-Number: 41943 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com>

1 0

2026

2025

2024

2023

2022

gerrit-log January 2026