January 2026 - gerrit-log - lists.osmocom.org

[XS] Change in docker-playground[master]: jenkins-common: support debian13 suffix
by osmith 14 Jan '26

14 Jan '26

osmith has abandoned this change. ( https://gerrit.osmocom.org/c/docker-playground/+/41838?usp=email ) Change subject: jenkins-common: support debian13 suffix ...................................................................... Abandoned As discussed with Pau, changing the default to debian13 now in https://gerrit.osmocom.org/c/docker-playground/+/41839. A similar patch to this one might be useful if we have to switch some back to 12 in case there are regressions. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/41838?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I442545160dad264d2c3d8f77a3d9fd8ccc706832 Gerrit-Change-Number: 41838 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: osmo_io: Validate msghdr!=NULL after allocation
by pespin 14 Jan '26

14 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/41840?usp=email ) Change subject: osmo_io: Validate msghdr!=NULL after allocation ...................................................................... osmo_io: Validate msghdr!=NULL after allocation Related: Coverity CID#556925 Change-Id: Ib90e6b5bc6c03cbbf40041463f3d05d85f55a68a --- M src/core/osmo_io_poll.c 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/40/41840/1 diff --git a/src/core/osmo_io_poll.c b/src/core/osmo_io_poll.c index c37d436..b861675 100644 --- a/src/core/osmo_io_poll.c +++ b/src/core/osmo_io_poll.c @@ -106,6 +106,11 @@ } msghdr = iofd_msghdr_alloc(iofd, action, NULL, iofd->cmsg_size); + if (!msghdr) { + LOGPIO(iofd, LOGL_ERROR, "Could not allocate msghdr for reading\n"); + OSMO_ASSERT(0); + } + for (idx = 0; idx < msghdr->io_len; idx++) { msghdr->iov[idx].iov_base = msghdr->msg[idx]->tail; msghdr->iov[idx].iov_len = msgb_tailroom(msghdr->msg[idx]); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41840?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib90e6b5bc6c03cbbf40041463f3d05d85f55a68a Gerrit-Change-Number: 41840 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in docker-playground[master]: ttcn3-bts-test: use osmo-bts with debian 13
by pespin 14 Jan '26

14 Jan '26

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/docker-playground/+/41839?usp=email ) Change subject: ttcn3-bts-test: use osmo-bts with debian 13 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/41839?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I231e1e93724faf6d659132be9b9d0e164502bf95 Gerrit-Change-Number: 41839 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Jan 2026 10:09:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in docker-playground[master]: jenkins-common: support debian13 suffix
by pespin 14 Jan '26

14 Jan '26

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/docker-playground/+/41838?usp=email ) Change subject: jenkins-common: support debian13 suffix ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/41838?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I442545160dad264d2c3d8f77a3d9fd8ccc706832 Gerrit-Change-Number: 41838 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Jan 2026 10:09:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in docker-playground[master]: jenkins-common: support debian13 suffix
by osmith 14 Jan '26

14 Jan '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/41838?usp=email ) Change subject: jenkins-common: support debian13 suffix ...................................................................... jenkins-common: support debian13 suffix Make it possible to switch some containers over from debian 12 to debian 13 without touching the rest (which may have unintended side effects). Change-Id: I442545160dad264d2c3d8f77a3d9fd8ccc706832 --- M jenkins-common.sh 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/38/41838/1 diff --git a/jenkins-common.sh b/jenkins-common.sh index 57d2190..8016a5e 100644 --- a/jenkins-common.sh +++ b/jenkins-common.sh @@ -24,7 +24,9 @@ osmo-*-centos7) echo "centos7-build" ;; osmo-*-centos8) echo "centos8-build" ;; osmo-*-latest-debian10) echo "debian-buster-obs-latest" ;; + osmo-*-latest-debian13) echo "debian-trixie-obs-latest" ;; osmo-*-debian10) echo "debian-buster-build" ;; + osmo-*-debian13) echo "debian-trixie-build" ;; osmo-*-latest) echo "debian-$DEBIAN_DEFAULT-obs-latest" ;; osmo-*-asan) echo "debian-$DEBIAN_DEFAULT-obs-asan" ;; osmo_dia2gsup-*) echo "debian-$DEBIAN_DEFAULT-erlang" ;; @@ -43,6 +45,7 @@ centos7-*) echo "centos7" ;; centos8-*) echo "centos8" ;; osmo-*-debian10) echo "debian-buster" ;; + osmo-*-debian13) echo "debian-trixie" ;; debian-buster-*) echo "debian-buster" ;; debian-bullseye-*) echo "debian-bullseye" ;; debian-bookworm-*) echo "debian-bookworm" ;; @@ -58,6 +61,7 @@ centos7-*) echo "centos:centos7" ;; centos8-*) echo "almalinux:8" ;; osmo-*-debian10) echo "debian/eol:buster" ;; + osmo-*-debian13) echo "debian:trixie" ;; debian9-*) echo "debian/eol:stretch" ;; debian10-*) echo "debian/eol:buster" ;; debian11-*) echo "debian:bullseye" ;; @@ -90,6 +94,10 @@ # e.g. osmo-gbproxy-master-debian10 -> osmo-gbproxy-master echo "$1" | sed 's/\-debian10$//' ;; + osmo-*-debian13) + # e.g. osmo-bts-master-debian13 -> osmo-bts-master + echo "$1" | sed 's/\-debian13$//' + ;; centos8-obs-20*q*) # e.g. centos8-obs-2021q1 -> centos8-obs-latest echo "$1" | sed 's/20[0-9][0-9]q.*$/latest/' -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/41838?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I442545160dad264d2c3d8f77a3d9fd8ccc706832 Gerrit-Change-Number: 41838 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in docker-playground[master]: ttcn3-bts-test: use osmo-bts with debian 13
by osmith 14 Jan '26

14 Jan '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/41839?usp=email ) Change subject: ttcn3-bts-test: use osmo-bts with debian 13 ...................................................................... ttcn3-bts-test: use osmo-bts with debian 13 Run osmo-bts in a debian 13 container, so we get a much newer bpftrace version. Debian 12: 0.17.0-1 Debian 13: 0.23.2-1 Change-Id: I231e1e93724faf6d659132be9b9d0e164502bf95 --- M ttcn3-bts-test/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/39/41839/1 diff --git a/ttcn3-bts-test/jenkins.sh b/ttcn3-bts-test/jenkins.sh index 6e5cc67..b11d2d7 100755 --- a/ttcn3-bts-test/jenkins.sh +++ b/ttcn3-bts-test/jenkins.sh @@ -11,7 +11,7 @@ # NOTE: there is no osmocom-bb-host-latest, hence always use master! docker_images_require \ "osmo-bsc-$IMAGE_SUFFIX" \ - "osmo-bts-$IMAGE_SUFFIX" \ + "osmo-bts-$IMAGE_SUFFIX-debian13" \ "osmocom-bb-host-master" \ "ttcn3-bts-test" -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/41839?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I231e1e93724faf6d659132be9b9d0e164502bf95 Gerrit-Change-Number: 41839 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: saip: ProfileElementSD: call _post_decode() when instantiating with d...
by lynxis lazus 14 Jan '26

14 Jan '26

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/41837?usp=email ) Change subject: saip: ProfileElementSD: call _post_decode() when instantiating with decoded argument ...................................................................... saip: ProfileElementSD: call _post_decode() when instantiating with decoded argument Otherwise self.keys is not generated from the given data and encoding will fail. Change-Id: I3020f581a908fecc01d5d255ab5991ce1652e3ec --- M pySim/esim/saip/__init__.py 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/37/41837/1 diff --git a/pySim/esim/saip/__init__.py b/pySim/esim/saip/__init__.py index 7c6a557..de951dc 100644 --- a/pySim/esim/saip/__init__.py +++ b/pySim/esim/saip/__init__.py @@ -1027,6 +1027,7 @@ def __init__(self, decoded: Optional[dict] = None, **kwargs): super().__init__(decoded, **kwargs) if decoded: + self._post_decode() return # provide some reasonable defaults for a MNO-SD self.decoded['instance'] = { -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41837?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3020f581a908fecc01d5d255ab5991ce1652e3ec Gerrit-Change-Number: 41837 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in pysim[master]: saip: calculate the number of records for LF and CY
by laforge 14 Jan '26

14 Jan '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/41687?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: saip: calculate the number of records for LF and CY ...................................................................... saip: calculate the number of records for LF and CY Some templates (e.g. for 5GS) define files which aren't completely defined. 5GS OPL5G: doesn't have a file size defined in the template, but a record size. Change-Id: I5ec1757d6852eb24d3662ec1c3fc88365e90a616 --- M pySim/esim/saip/__init__.py 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified neels: Looks good to me, approved diff --git a/pySim/esim/saip/__init__.py b/pySim/esim/saip/__init__.py index f4ac305..f8a854d 100644 --- a/pySim/esim/saip/__init__.py +++ b/pySim/esim/saip/__init__.py @@ -144,6 +144,9 @@ def file_size(self) -> Optional[int]: """Return the size of the file in bytes.""" if self.file_type in ['LF', 'CY']: + if self._file_size and self.nb_rec is None and self.rec_len: + self.nb_rec = self._file_size // self.rec_len + return self.nb_rec * self.rec_len elif self.file_type in ['TR', 'BT']: return self._file_size -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41687?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5ec1757d6852eb24d3662ec1c3fc88365e90a616 Gerrit-Change-Number: 41687 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: saip: rework file sizes for "half-defined" template files
by laforge 14 Jan '26

14 Jan '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/41686?usp=email ) Change subject: saip: rework file sizes for "half-defined" template files ...................................................................... saip: rework file sizes for "half-defined" template files Define the file size early if possible. Some templates (e.g. for 5GS) define files which aren't completely defined. Fixes the parsing for 5GS SUCI_Calc_Info which doesn't have a file size defined. The saip-tool will other crash when reading a 5G enabled profile: ``` Traceback (most recent call last): File "./contrib/saip-tool.py", line 458, in <module> pes = ProfileElementSequence.from_der(f.read()) File "pySim/esim/saip/__init__.py", line 1679, in from_der inst.parse_der(der) ~~~~~~~~~~~~~~^^^^^ File "pySim/esim/saip/__init__.py", line 1552, in parse_der self.pe_list.append(ProfileElement.from_der(first_tlv, pe_sequence=self)) ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "pySim/esim/saip/__init__.py", line 557, in from_der inst._post_decode() ~~~~~~~~~~~~~~~~~^^ File "pySim/esim/saip/__init__.py", line 668, in _post_decode self.pe2files() ~~~~~~~~~~~~~^^ File "pySim/esim/saip/__init__.py", line 655, in pe2files file = File(k, v, template.files_by_pename.get(k, None)) File "pySim/esim/saip/__init__.py", line 133, in __init__ self.from_tuples(l) ~~~~~~~~~~~~~~~~^^^ File "pySim/esim/saip/__init__.py", line 358, in from_tuples self._body = self.file_content_from_tuples(l) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^ File "pySim/esim/saip/__init__.py", line 393, in file_content_from_tuples stream.write(self.template.expand_default_value_pattern(self.file_size)) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^ File "pySim/esim/saip/templates.py", line 123, in expand_default_value_pattern raise ValueError("%s does not have a default length" % self) ValueError: FileTemplate(EF.SUCI_Calc_Info) does not have a default length ``` Change-Id: I7c4a0914aef1049a416e6b091f23daab39a1dd9c --- M pySim/esim/saip/__init__.py 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified neels: Looks good to me, approved diff --git a/pySim/esim/saip/__init__.py b/pySim/esim/saip/__init__.py index 7c6a557..f4ac305 100644 --- a/pySim/esim/saip/__init__.py +++ b/pySim/esim/saip/__init__.py @@ -291,6 +291,10 @@ dfName = fileDescriptor.get('dfName', None) if dfName: self.df_name = dfName + efFileSize = fileDescriptor.get('efFileSize', None) + if efFileSize: + self._file_size = self._decode_file_size(efFileSize) + pefi = fileDescriptor.get('proprietaryEFInfo', {}) securityAttributesReferenced = fileDescriptor.get('securityAttributesReferenced', None) if securityAttributesReferenced: @@ -300,13 +304,11 @@ fdb_dec = fd_dec['file_descriptor_byte'] self.shareable = fdb_dec['shareable'] if fdb_dec['file_type'] == 'working_ef': - efFileSize = fileDescriptor.get('efFileSize', None) if fd_dec['num_of_rec']: self.nb_rec = fd_dec['num_of_rec'] if fd_dec['record_len']: self.rec_len = fd_dec['record_len'] if efFileSize: - self._file_size = self._decode_file_size(efFileSize) if self.rec_len and self.nb_rec == None: # compute the number of records from file size and record length self.nb_rec = self._file_size // self.rec_len -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41686?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7c4a0914aef1049a416e6b091f23daab39a1dd9c Gerrit-Change-Number: 41686 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: Fix esim.saip.ProfileElementSequence.remove_naas_of_type
by laforge 13 Jan '26

13 Jan '26

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/41836?usp=email ) Change subject: Fix esim.saip.ProfileElementSequence.remove_naas_of_type ...................................................................... Fix esim.saip.ProfileElementSequence.remove_naas_of_type This method did not work at all at the moment, likely due to API churn over time. This change makes the following exception go away: Traceback (most recent call last): File "projects/git/pysim/contrib/saip-tool.py", line 473, in <module> do_remove_naa(pes, opts) ~~~~~~~~~~~~~^^^^^^^^^^^ File "projects/git/pysim/contrib/saip-tool.py", line 203, in do_remove_naa pes.remove_naas_of_type(naa) ~~~~~~~~~~~~~~~~~~~~~~~^^^^^ File "projects/git/pysim/contrib/pySim/esim/saip/__init__.py", line 1748, in remove_naas_of_type if template in hdr.decoded['eUICC-Mandatory-GFSTEList']: ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "projects/git/pysim/contrib/pySim/esim/saip/oid.py", line 48, in __eq__ return (self.intlist == other.intlist) ^^^^^^^^^^^^^ AttributeError: 'str' object has no attribute 'intlist' A subsequent patch should introduce unit tests to avoid such breakage in the future. Change-Id: I88d862d751198c3d1648ab7f11d6e6a8fdbc41c9 --- M pySim/esim/saip/__init__.py 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/36/41836/1 diff --git a/pySim/esim/saip/__init__.py b/pySim/esim/saip/__init__.py index 7c6a557..d3ad2ab 100644 --- a/pySim/esim/saip/__init__.py +++ b/pySim/esim/saip/__init__.py @@ -1745,8 +1745,7 @@ del hdr.decoded['eUICC-Mandatory-services'][service] # remove any associated mandatory filesystem templates for template in naa.templates: - if template in hdr.decoded['eUICC-Mandatory-GFSTEList']: - hdr.decoded['eUICC-Mandatory-GFSTEList'] = [x for x in hdr.decoded['eUICC-Mandatory-GFSTEList'] if not template.prefix_match(x)] + hdr.decoded['eUICC-Mandatory-GFSTEList'] = [x for x in hdr.decoded['eUICC-Mandatory-GFSTEList'] if not template.prefix_match(x)] # determine the ADF names (AIDs) of all NAA ADFs naa_adf_names = [] if naa.pe_types[0] in self.pe_by_type: -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41836?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I88d862d751198c3d1648ab7f11d6e6a8fdbc41c9 Gerrit-Change-Number: 41836 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>

1 0

2026

2025

2024

2023

2022

gerrit-log January 2026