January 2026 - gerrit-log - lists.osmocom.org

[XS] Change in docker-playground[master]: jenkins-common: use debian 13 by default
by osmith 14 Jan '26

14 Jan '26

Attention is currently required from: fixeria. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/docker-playground/+/41839?usp=email ) Change subject: jenkins-common: use debian 13 by default ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: I'll merge this now, as we see processes not stopping with the old bpftrace version: https://osmocom.org/issues/6925 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/41839?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I231e1e93724faf6d659132be9b9d0e164502bf95 Gerrit-Change-Number: 41839 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Jan 2026 15:07:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: osmo_io: Validate msghdr!=NULL after allocation
by pespin 14 Jan '26

14 Jan '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/41840?usp=email ) Change subject: osmo_io: Validate msghdr!=NULL after allocation ...................................................................... osmo_io: Validate msghdr!=NULL after allocation Related: Coverity CID#556925 Change-Id: Ib90e6b5bc6c03cbbf40041463f3d05d85f55a68a --- M src/core/osmo_io_poll.c 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/core/osmo_io_poll.c b/src/core/osmo_io_poll.c index c37d436..b861675 100644 --- a/src/core/osmo_io_poll.c +++ b/src/core/osmo_io_poll.c @@ -106,6 +106,11 @@ } msghdr = iofd_msghdr_alloc(iofd, action, NULL, iofd->cmsg_size); + if (!msghdr) { + LOGPIO(iofd, LOGL_ERROR, "Could not allocate msghdr for reading\n"); + OSMO_ASSERT(0); + } + for (idx = 0; idx < msghdr->io_len; idx++) { msghdr->iov[idx].iov_base = msghdr->msg[idx]->tail; msghdr->iov[idx].iov_len = msgb_tailroom(msghdr->msg[idx]); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41840?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib90e6b5bc6c03cbbf40041463f3d05d85f55a68a Gerrit-Change-Number: 41840 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: osmo_io: io_uring: Fix batch mode in multithread process
by pespin 14 Jan '26

14 Jan '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/41841?usp=email ) Change subject: osmo_io: io_uring: Fix batch mode in multithread process ...................................................................... osmo_io: io_uring: Fix batch mode in multithread process Change-Id: Ie7f3a3684a4b550c4e23fe82426ec2d384cc606f --- M src/core/osmo_io_uring.c 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/core/osmo_io_uring.c b/src/core/osmo_io_uring.c index 0304375..3925f94 100644 --- a/src/core/osmo_io_uring.c +++ b/src/core/osmo_io_uring.c @@ -65,7 +65,6 @@ #define OSMO_IO_URING_READ_SQE "LIBOSMO_IO_URING_READ_SQE" bool g_io_uring_batch = false; -bool g_io_uring_submit_needed = false; static int g_io_uring_size = IOFD_URING_INITIAL_SIZE; @@ -76,6 +75,7 @@ struct io_uring ring; struct llist_head cancel_queue; unsigned int num_pending_submissions; + bool submit_needed; }; static __thread struct osmo_io_uring *g_ring = NULL; @@ -234,7 +234,7 @@ if (OSMO_LIKELY(!g_io_uring_batch)) io_uring_submit(&g_ring->ring); else - g_io_uring_submit_needed = true; + g_ring->submit_needed = true; } static inline int iofd_uring_submit_recv_sqe(struct osmo_io_fd *iofd, enum iofd_msg_action action) @@ -806,9 +806,9 @@ void osmo_io_uring_submit(void) { - if (OSMO_LIKELY(g_io_uring_submit_needed)) { + if (OSMO_LIKELY(g_ring->submit_needed)) { io_uring_submit(&g_ring->ring); - g_io_uring_submit_needed = false; + g_ring->submit_needed = false; } } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41841?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie7f3a3684a4b550c4e23fe82426ec2d384cc606f Gerrit-Change-Number: 41841 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: osmo_io: Validate msghdr!=NULL after allocation
by laforge 14 Jan '26

14 Jan '26

Attention is currently required from: fixeria, jolly, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41840?usp=email ) Change subject: osmo_io: Validate msghdr!=NULL after allocation ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41840?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib90e6b5bc6c03cbbf40041463f3d05d85f55a68a Gerrit-Change-Number: 41840 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Jan 2026 13:53:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: osmo_io: io_uring: Fix batch mode in multithread process
by laforge 14 Jan '26

14 Jan '26

Attention is currently required from: daniel, fixeria, jolly, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41841?usp=email ) Change subject: osmo_io: io_uring: Fix batch mode in multithread process ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41841?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie7f3a3684a4b550c4e23fe82426ec2d384cc606f Gerrit-Change-Number: 41841 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Jan 2026 13:53:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: osmo_io: io_uring: Fix batch mode in multithread process
by osmith 14 Jan '26

14 Jan '26

Attention is currently required from: daniel, fixeria, jolly, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41841?usp=email ) Change subject: osmo_io: io_uring: Fix batch mode in multithread process ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41841?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie7f3a3684a4b550c4e23fe82426ec2d384cc606f Gerrit-Change-Number: 41841 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Jan 2026 12:43:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: osmo_io: io_uring: Fix batch mode in multithread process
by pespin 14 Jan '26

14 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/41841?usp=email ) Change subject: osmo_io: io_uring: Fix batch mode in multithread process ...................................................................... osmo_io: io_uring: Fix batch mode in multithread process Change-Id: Ie7f3a3684a4b550c4e23fe82426ec2d384cc606f --- M src/core/osmo_io_uring.c 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/41/41841/1 diff --git a/src/core/osmo_io_uring.c b/src/core/osmo_io_uring.c index 0304375..3925f94 100644 --- a/src/core/osmo_io_uring.c +++ b/src/core/osmo_io_uring.c @@ -65,7 +65,6 @@ #define OSMO_IO_URING_READ_SQE "LIBOSMO_IO_URING_READ_SQE" bool g_io_uring_batch = false; -bool g_io_uring_submit_needed = false; static int g_io_uring_size = IOFD_URING_INITIAL_SIZE; @@ -76,6 +75,7 @@ struct io_uring ring; struct llist_head cancel_queue; unsigned int num_pending_submissions; + bool submit_needed; }; static __thread struct osmo_io_uring *g_ring = NULL; @@ -234,7 +234,7 @@ if (OSMO_LIKELY(!g_io_uring_batch)) io_uring_submit(&g_ring->ring); else - g_io_uring_submit_needed = true; + g_ring->submit_needed = true; } static inline int iofd_uring_submit_recv_sqe(struct osmo_io_fd *iofd, enum iofd_msg_action action) @@ -806,9 +806,9 @@ void osmo_io_uring_submit(void) { - if (OSMO_LIKELY(g_io_uring_submit_needed)) { + if (OSMO_LIKELY(g_ring->submit_needed)) { io_uring_submit(&g_ring->ring); - g_io_uring_submit_needed = false; + g_ring->submit_needed = false; } } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41841?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie7f3a3684a4b550c4e23fe82426ec2d384cc606f Gerrit-Change-Number: 41841 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: osmo_io: Validate msghdr!=NULL after allocation
by osmith 14 Jan '26

14 Jan '26

Attention is currently required from: fixeria, jolly, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41840?usp=email ) Change subject: osmo_io: Validate msghdr!=NULL after allocation ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41840?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib90e6b5bc6c03cbbf40041463f3d05d85f55a68a Gerrit-Change-Number: 41840 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Jan 2026 10:49:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in docker-playground[master]: jenkins-common: use debian 13 by default
by pespin 14 Jan '26

14 Jan '26

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/docker-playground/+/41839?usp=email ) Change subject: jenkins-common: use debian 13 by default ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/41839?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I231e1e93724faf6d659132be9b9d0e164502bf95 Gerrit-Change-Number: 41839 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Jan 2026 10:24:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in docker-playground[master]: jenkins-common: use debian 13 by default
by osmith 14 Jan '26

14 Jan '26

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/docker-playground/+/41839?usp=email ) Change subject: jenkins-common: use debian 13 by default ...................................................................... Patch Set 2: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/41839?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I231e1e93724faf6d659132be9b9d0e164502bf95 Gerrit-Change-Number: 41839 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Jan 2026 10:23:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

2026

2025

2024

2023

2022

gerrit-log January 2026