September 2025 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-iuh[master]: ranap: Fix wrong PTMSI vs TMSI field passed during ranap_new_msg_pagi...

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/41002?usp=email ) Change subject: ranap: Fix wrong PTMSI vs TMSI field passed during ranap_new_msg_paging_cmd() ...................................................................... ranap: Fix wrong PTMSI vs TMSI field passed during ranap_new_msg_paging_cmd() Change-Id: I3c47cf7d80864bbdd141a9da546c7ad545da1adc --- M src/ranap_msg_factory.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified lynxis lazus: Looks good to me, approved osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/ranap_msg_factory.c b/src/ranap_msg_factory.c index 794d82d..1005594 100644 --- a/src/ranap_msg_factory.c +++ b/src/ranap_msg_factory.c @@ -544,10 +544,10 @@ ies.presenceMask |= PAGINGIES_RANAP_TEMPORARYUE_ID_PRESENT; if (is_ps) { ies.temporaryUE_ID.present = RANAP_TemporaryUE_ID_PR_p_TMSI; - asn1_u32_to_str(&ies.temporaryUE_ID.choice.tMSI, tmsi_buf, *tmsi); + asn1_u32_to_str(&ies.temporaryUE_ID.choice.p_TMSI, tmsi_buf, *tmsi); } else { ies.temporaryUE_ID.present = RANAP_TemporaryUE_ID_PR_tMSI; - asn1_u32_to_str(&ies.temporaryUE_ID.choice.p_TMSI, tmsi_buf, *tmsi); + asn1_u32_to_str(&ies.temporaryUE_ID.choice.tMSI, tmsi_buf, *tmsi); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/41002?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I3c47cf7d80864bbdd141a9da546c7ad545da1adc Gerrit-Change-Number: 41002 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

2 weeks, 4 days

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: S1GW tests: Add test cases for S1 handover procedure

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009?usp=email ) Change subject: S1GW tests: Add test cases for S1 handover procedure ...................................................................... Patch Set 1: (4 comments) File s1gw/S1GW_ConnHdlr.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/c3fc6ee7_62dc… : PS1, Line 71: template TargetID const c_TargetID https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/a79021dc_0e3c… : PS1, Line 76: /* PLMNidentity */ '62F210'O, you know you can assign by field name instead of commenting all of them? eg. pLMNidentity := '62F210'O https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/8a29cf9e_c032… : PS1, Line 1072: function f_ConnHdlr_tx_handover_req(in ERabList erabs, either add in to all params or to none. (I vote for the later :P) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009/comment/89eb3014_6402… : PS1, Line 1090: items[i] := ts_E_RABToBeSetupListHOReq(item)[0]; see the problem I mentioned in the previous commit? You end up doing weird stuff with [0] because you don't have a template for 1 item imho. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id349c84749f7e897defa8cfd2ecd2c1f2fb52fc7 Gerrit-Change-Number: 41009 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Wed, 03 Sep 2025 12:48:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

2 weeks, 4 days

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: Add templates for S1AP Handover procedure

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008?usp=email ) Change subject: Add templates for S1AP Handover procedure ...................................................................... Patch Set 1: (9 comments) File library/s1ap/S1AP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008/comment/935097f3_ab1f… : PS1, Line 2293: procedureCode := S1AP_Constants.id_HandoverPreparation, Are you sure this ID is correct? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008/comment/3b756f6b_6df5… : PS1, Line 2337: procedureCode := S1AP_Constants.id_HandoverPreparation, Are you sure this ID is correct? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008/comment/d32ecbda_eb4b… : PS1, Line 2370: } (FYI, see in https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40985/2/library/ranap/RANAP… an example on how to add optional IEs to the list here). https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008/comment/409a6437_eabd… : PS1, Line 2374: ts_E_RABSubjecttoDataForwardingList(template (value) E_RABDataForwardingItem it) := { IMHO it's better to have a template for E_RABSubjecttoDataForwardingItem, and then simply do "{ ts_E_RABSubjecttoDataForwardingList(...) }" wherever needed. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008/comment/dead07bc_5f81… : PS1, Line 2391: template (omit) TransportLayerAddress dl_tla, we usually set default value to ":= omit" for "template (omit)". https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008/comment/ac6ac93b_c4a3… : PS1, Line 2423: successfulOutcome := { Are you sure the HandoverCmd is a succesfulOutcome and not an InitialMessage? I'd suggest you revisit the specs and asn1 files. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008/comment/b76727f0_f801… : PS1, Line 2424: procedureCode := S1AP_Constants.id_HandoverPreparation, Are you sure this ID is correct? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008/comment/261ca2fc_dc6c… : PS1, Line 2462: procedureCode := S1AP_Constants.id_HandoverPreparation, same comments as per ts_S1AP_HandoverCmd apply here too. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008/comment/bd527db8_babe… : PS1, Line 2560: procedureCode := S1AP_Constants.id_HandoverResourceAllocation, are you sure this ID is correct? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib8b8aee0665a4f6644287b802f5e941bd82128f6 Gerrit-Change-Number: 41008 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Wed, 03 Sep 2025 12:43:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

2 weeks, 4 days

1
0
0 0

[S] Change in ...osmo-s1gw[master]: s1ap_proxy: erab_fsm_start_reg/2: check if already registered

by pespin

Attention is currently required from: fixeria, jolly. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40993?usp=email ) Change subject: s1ap_proxy: erab_fsm_start_reg/2: check if already registered ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40993?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I8e93492219100496fd8dc69e031310858ba9c7fb Gerrit-Change-Number: 40993 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 03 Sep 2025 12:32:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks, 4 days

1
0
0 0

[XS] Change in ...osmo-s1gw[master]: s1ap_proxy: add type hints for #proxy_state.erabs

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41003?usp=email ) Change subject: s1ap_proxy: add type hints for #proxy_state.erabs ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41003?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I08e0339bf401067eaf8ace32da619d5016fe98d7 Gerrit-Change-Number: 41003 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 03 Sep 2025 12:31:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks, 4 days

1
0
0 0

[M] Change in ...osmo-s1gw[master]: s1ap_proxy: remove eNB-ID from erab_uid()

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40994?usp=email ) Change subject: s1ap_proxy: remove eNB-ID from erab_uid() ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: Did you think about making eNB-UE-S1AP-ID optional when doing the lookup? This way you get a more robust operation when it is available. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40994?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I7277d19080795600252306dbfa0c733f996e026e Gerrit-Change-Number: 40994 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 03 Sep 2025 12:31:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

2 weeks, 4 days

1
0
0 0

[XS] Change in osmo-iuh[master]: ranap: Fix wrong PTMSI vs TMSI field passed during ranap_new_msg_pagi...

by lynxis lazus

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-iuh/+/41002?usp=email ) Change subject: ranap: Fix wrong PTMSI vs TMSI field passed during ranap_new_msg_paging_cmd() ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: autsch. How could have been this never a problem for us? -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/41002?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I3c47cf7d80864bbdd141a9da546c7ad545da1adc Gerrit-Change-Number: 41002 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 03 Sep 2025 11:30:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

2 weeks, 4 days

1
0
0 0

[XS] Change in osmo-iuh[master]: ranap: Fix wrong PTMSI vs TMSI field passed during ranap_new_msg_pagi...

by fixeria

Attention is currently required from: lynxis lazus, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-iuh/+/41002?usp=email ) Change subject: ranap: Fix wrong PTMSI vs TMSI field passed during ranap_new_msg_paging_cmd() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/41002?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I3c47cf7d80864bbdd141a9da546c7ad545da1adc Gerrit-Change-Number: 41002 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 03 Sep 2025 10:58:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks, 4 days

1
0
0 0

[M] Change in ...osmo-s1gw[master]: s1ap_proxy: Add support for S1 HANDOVER procedure

by fixeria

Attention is currently required from: jolly. fixeria has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006?usp=email ) Change subject: s1ap_proxy: Add support for S1 HANDOVER procedure ...................................................................... Patch Set 1: (5 comments) File include/s1gw_metrics.hrl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006/comment/659ff3c5_e460… : PS1, Line 36: handover_rsp Let's use `handover_req_ack` here. File src/s1ap_proxy.erl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006/comment/9843dec1_aa19… : PS1, Line 640: PATH SWITCH These PDUs are not implemented yet, so let's keep the TODO comments for them. https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006/comment/5065b38c_b7bd… : PS1, Line 642: fetch {MME,eNB}-UE-S1AP-ID values (mandatory IEs) this comment is not relevant here? https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006/comment/e1a8feda_a6b1… : PS1, Line 1092: 'transportLayerAddress' = TLA_In, : cosmetic: formatting issues https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006/comment/aa41c854_b766… : PS1, Line 1113: 'transportLayerAddress' = TLA_In, : cosmetic: formatting issues -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ib2c8b1787c60d35a512c3c78d35e1f72a9d7bb08 Gerrit-Change-Number: 41006 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Wed, 03 Sep 2025 10:31:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

2 weeks, 4 days

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: S1GW tests: Add test cases for S1 handover procedure

by jolly

jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009?usp=email ) Change subject: S1GW tests: Add test cases for S1 handover procedure ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41009?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id349c84749f7e897defa8cfd2ecd2c1f2fb52fc7 Gerrit-Change-Number: 41009 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Wed, 03 Sep 2025 10:25:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

2 weeks, 4 days

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2025