Attention is currently required from: pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40994?usp=email )
Change subject: s1ap_proxy: remove eNB-ID from erab_uid()
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
> Did you think about making eNB-UE-S1AP-ID optional when doing the lookup? This way you get a more ro […]
This will make the E-RAB lookup more complicated for... what kind of robustness? When doing the lookup with partial knowledge of the key (`erab_uid()`), you can no longer use `dict:find` or `dict:get`, you'll have to convert the dictionary to a list and recursively check each item. This is significantly slower.
The only scenario I could think of is the `PATCH SWITCH` procedure, when it's the eNB establishing E-RAB (not the MME as usual). In that case the `PATH SWITCH REQUEST` contains only the `eNB-UE-S1AP-ID` alone. We do not implement this procedure yet, and implementing it would require quite a lot of additional changes.
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40994?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I7277d19080795600252306dbfa0c733f996e026e
Gerrit-Change-Number: 40994
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 03 Sep 2025 13:43:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: fixeria, pespin.
lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/41001?usp=email )
The change is no longer submittable: Code-Review is unsatisfied now.
Change subject: ranap: Take into account RNC availability during paging
......................................................................
Patch Set 1: -Code-Review
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/41001?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I24e5446bcf4c958028577230b231960acea9e5b9
Gerrit-Change-Number: 41001
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 03 Sep 2025 13:36:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-iuh/+/41002?usp=email )
Change subject: ranap: Fix wrong PTMSI vs TMSI field passed during ranap_new_msg_paging_cmd()
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> autsch. […]
Because they probably are in a union and hence map to the same memory address.
--
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/41002?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: I3c47cf7d80864bbdd141a9da546c7ad545da1adc
Gerrit-Change-Number: 41002
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 03 Sep 2025 13:33:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>