Attention is currently required from: osmith, pespin.
daniel has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41021?usp=email )
Change subject: Fix decoding of TCAP messages
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Patchset:
PS2:
> I fail to see why are we modifying the asn file if we are switching to a newer asn1 file in next com […]
The new part
```DialoguePortion ::= [APPLICATION 11] EXPLICIT EXTERNAL```
is needed for the TCAP to be properly decoded, the WS workaround didn't work for the old or the new asn1c (that we were using). EXTERNAL is supported in the newer asn1c that is used in subsequent patches.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41021?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-asn1-tcap
Gerrit-Branch: master
Gerrit-Change-Id: I4a27a52b2be70b1fc50e0a3d5441ded4c151fe65
Gerrit-Change-Number: 41021
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 04 Sep 2025 09:59:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41019?usp=email )
Change subject: rebuild-from-asn.sh: Update to work with present-day osmocom asn1c
......................................................................
Patch Set 2: -Verified Code-Review-1
(1 comment)
Patchset:
PS2:
This file actually gets deleted in a later patch, so I'll abondon this patch in the next series
--
To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41019?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-asn1-tcap
Gerrit-Branch: master
Gerrit-Change-Id: I1e9b64112805a39bd4bc9d94b64d3d99516bd6c6
Gerrit-Change-Number: 41019
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 04 Sep 2025 09:46:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes