September 2025 - gerrit-log - lists.osmocom.org

[S] Change in ...osmo-epdg[master]: Remove duplicate 3GPP-AAA-Server-Name definition and break 3-way circ...

by lynxis lazus

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41016?usp=email ) Change subject: Remove duplicate 3GPP-AAA-Server-Name definition and break 3-way circular dependency ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I would have proposed to use ts29_273_common.dia or so for all 29.273 related avps/enums. unresolved this comment. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41016?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Idb1a7f7588b751c59788e4d99cd1d86f1fd2b573 Gerrit-Change-Number: 41016 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Sep 2025 10:05:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

2 weeks, 4 days

1
0
0 0

[XL] Change in libosmo-asn1-tcap[master]: Regenerate code with newer asn1c

by daniel

Attention is currently required from: osmith, pespin. daniel has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022?usp=email ) Change subject: Regenerate code with newer asn1c ...................................................................... Patch Set 3: (2 comments) File include/AARE-apdu.h: https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022/comment/3932d954_cb6… : PS3, Line 1: /* > These header files are all in the wrong directory. […] This library instead sets ```osmo_asn1_tcapdir = $(includedir)/osmocom/tcap``` But I can see that our other libraries keep the directory structure in the source. I'll change it File src/constr_CHOICE_print.c: https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022/comment/3972b78a_430… : PS3, Line 1: /* > I would really like/suggest to keep the generated C files in a separate directory, like done in osmo […] So far there is only the generated files. -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: If43a5d518f94fa558a3dff563a1c7aa31c925fec Gerrit-Change-Number: 41022 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Sep 2025 10:05:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

2 weeks, 4 days

1
0
0 0

[S] Change in ...osmo-epdg[master]: Remove duplicate 3GPP-AAA-Server-Name definition and break 3-way circ...

by lynxis lazus

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41016?usp=email ) Change subject: Remove duplicate 3GPP-AAA-Server-Name definition and break 3-way circular dependency ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: I would have proposed to use ts29_273_common.dia or so for all 29.273 related avps/enums. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41016?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Idb1a7f7588b751c59788e4d99cd1d86f1fd2b573 Gerrit-Change-Number: 41016 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Sep 2025 10:05:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

2 weeks, 4 days

1
0
0 0

[XS] Change in ...osmo-epdg[master]: dia: restrict AVPs inherited from RFC4005

by lynxis lazus

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41015?usp=email ) Change subject: dia: restrict AVPs inherited from RFC4005 ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41015/comment/67d17b9d_64f3… : PS1, Line 15: fiiiix nasreq fixxx it? -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41015?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Ibc11180489db6d86819ab17a5e7e92636dfed95e Gerrit-Change-Number: 41015 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Sep 2025 10:03:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

2 weeks, 4 days

1
0
0 0

[L] Change in ...osmo-epdg[master]: dia/diameter_3ggp_ts32_299.dia: Inherit RFC4005 instead of RFC7155

by lynxis lazus

Attention is currently required from: fixeria, laforge, lynxis lazus, pespin. lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41014?usp=email ) Change subject: dia/diameter_3ggp_ts32_299.dia: Inherit RFC4005 instead of RFC7155 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: @laforge@osmocom.org what do you think about the incompatibility between RFC4005 and RFC7155? 7155 obsolete the old one and isn't 100% compatible. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41014?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I7742d1523026e260b8501550977a41ebd3ad1b09 Gerrit-Change-Number: 41014 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 04 Sep 2025 10:02:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

2 weeks, 4 days

1
0
0 0

[XS] Change in ...osmo-epdg[master]: dia/diameter_3gpp_ts29_229.dia: inherit only Line-Identifier

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41013?usp=email ) Change subject: dia/diameter_3gpp_ts29_229.dia: inherit only Line-Identifier ...................................................................... dia/diameter_3gpp_ts29_229.dia: inherit only Line-Identifier That's the only type being used, and skip inheriting other types avoids inherit problem below: ETSI ES 283 035 has an AVP (vendor=ETSI) with same name "Event-Type" but different content (enumerated) and vendor (ETSI) than the one in 3GPP TS 32.299 (grouped, vendor 3GPP). When trying to inherit one from the other (through indirect TS 29.229), diameter compiler fails with: diameter_3gpp_ts32_299.dia failed: AVP Event-Type imported by @inherits diameter_etsi_es283_035 at line 0 defined at line 143 Change-Id: Iece0c768eb2dbb429726796a73274fd476cd1d0b --- M dia/diameter_3gpp_ts29_229.dia 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: lynxis lazus: Looks good to me, approved Jenkins Builder: Verified diff --git a/dia/diameter_3gpp_ts29_229.dia b/dia/diameter_3gpp_ts29_229.dia index ff1d8f7..62ac31f 100644 --- a/dia/diameter_3gpp_ts29_229.dia +++ b/dia/diameter_3gpp_ts29_229.dia @@ -24,7 +24,7 @@ @vendor 10415 3GPP @inherits diameter_gen_base_rfc6733 -@inherits diameter_etsi_es283_035 +@inherits diameter_etsi_es283_035 Line-Identifier @inherits diameter_rfc4005_nasreq ;; only attributes required by other applications are defined -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41013?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Iece0c768eb2dbb429726796a73274fd476cd1d0b Gerrit-Change-Number: 41013 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

2 weeks, 4 days

1
0
0 0

[XS] Change in ...osmo-epdg[master]: rebar.config: Update rebar3_diameter_compiler from 0.8.0 to v0.8.1

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41010?usp=email ) Change subject: rebar.config: Update rebar3_diameter_compiler from 0.8.0 to v0.8.1 ...................................................................... rebar.config: Update rebar3_diameter_compiler from 0.8.0 to v0.8.1 There's a new patch release of rebar3_diameter_compiler with multiple fixes and improvements, use it. Change-Id: Ic67581435a06052b0e3159172a2324dd1c1e58fc --- M rebar.config 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified lynxis lazus: Looks good to me, approved diff --git a/rebar.config b/rebar.config index 7b85d5b..68092a7 100644 --- a/rebar.config +++ b/rebar.config @@ -13,7 +13,7 @@ {minimum_otp_vsn, "25.2.3"}. {plugins, [ {rebar3_diameter_compiler, - {git, "https://github.com/carlosedp/rebar3_diameter_compiler.git", {tag, "0.8.0"}}} + {git, "https://github.com/carlosedp/rebar3_diameter_compiler.git", {tag, "v0.8.1"}}} ]}. {xref_checks, [undefined_function_calls, undefined_functions, -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41010?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Ic67581435a06052b0e3159172a2324dd1c1e58fc Gerrit-Change-Number: 41010 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

2 weeks, 4 days

1
0
0 0

[XS] Change in ...osmo-epdg[master]: dia/diameter_3gpp_ts29_273.dia: Fix trailing whitespace

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41012?usp=email ) Change subject: dia/diameter_3gpp_ts29_273.dia: Fix trailing whitespace ...................................................................... dia/diameter_3gpp_ts29_273.dia: Fix trailing whitespace Change-Id: I94b6bab39936002479e2841ef6c88731b38570b9 --- M dia/diameter_3gpp_ts29_273.dia 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: lynxis lazus: Looks good to me, approved Jenkins Builder: Verified diff --git a/dia/diameter_3gpp_ts29_273.dia b/dia/diameter_3gpp_ts29_273.dia index b4a5ce3..0e0b51c 100644 --- a/dia/diameter_3gpp_ts29_273.dia +++ b/dia/diameter_3gpp_ts29_273.dia @@ -69,7 +69,7 @@ Transport-Access-Type 1519 Enumerated V ;; 5.2.3.19 DER-Flags 1520 Unsigned32 V ;; 5.2.3.20 DEA-Flags 1521 Unsigned32 V ;; 5.2.3.21 - RAR-Flags 1522 Unsigned32 V ;; 9.2.3.1.5 + RAR-Flags 1522 Unsigned32 V ;; 9.2.3.1.5 DER-S6b-Flags 1523 Unsigned32 V ;; 9.2.3.7 SSID 1524 UTF8String V ;; 5.2.3.22 HESSID 1525 UTF8String V ;; 5.2.3.23 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41012?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I94b6bab39936002479e2841ef6c88731b38570b9 Gerrit-Change-Number: 41012 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

2 weeks, 4 days

1
0
0 0

[S] Change in ...osmo-epdg[master]: dia/diameter_3gpp_ts29_173.dia: Fix trailing whitespace

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41011?usp=email ) Change subject: dia/diameter_3gpp_ts29_173.dia: Fix trailing whitespace ...................................................................... dia/diameter_3gpp_ts29_173.dia: Fix trailing whitespace Change-Id: I0d0573176e2a9d25c19e98d2565cfa0b2bedc851 --- M dia/diameter_3gpp_ts29_173.dia 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified lynxis lazus: Looks good to me, approved diff --git a/dia/diameter_3gpp_ts29_173.dia b/dia/diameter_3gpp_ts29_173.dia index 25fe69c..6d8dc1c 100644 --- a/dia/diameter_3gpp_ts29_173.dia +++ b/dia/diameter_3gpp_ts29_173.dia @@ -70,7 +70,7 @@ *[ Supported-Features ] *[ Proxy-Info ] *[ Route-Record ] - *[ AVP ] + *[ AVP ] ;; 6.2.4 LCS-Routing-Info-Answer RIA ::= < Diameter Header: 8388622, PXY > @@ -83,7 +83,7 @@ [ Experimental-Result ] *[ Supported-Features ] [ User-Name ] - [ MSISDN ] + [ MSISDN ] [ LMSI ] [ Serving-Node ] *[ Additional-Serving-Node ] @@ -93,7 +93,7 @@ *[ AVP ] [ Failed-AVP ] *[ Proxy-Info ] - *[ Route-Record ] + *[ Route-Record ] @grouped @@ -108,11 +108,11 @@ [ 3GPP-AAA-Server-Name ] [ LCS-Capabilities-Sets ] [ GMLC-Address ] - *[AVP] + *[AVP] ;; 6.4.8 Additional-Serving-Node ::= <AVP Header: 2406 10415> - [ SGSN-Number ] + [ SGSN-Number ] [ MME-Name ] [ SGSN-Name ] [ SGSN-Realm ] @@ -121,4 +121,4 @@ [ 3GPP-AAA-Server-Name ] [ LCS-Capabilities-Sets ] [ GMLC-Address ] - *[AVP] + *[AVP] -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41011?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I0d0573176e2a9d25c19e98d2565cfa0b2bedc851 Gerrit-Change-Number: 41011 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

2 weeks, 4 days

1
0
0 0

[XS] Change in ...osmo-epdg[master]: dia/diameter_3gpp_ts29_229.dia: inherit only Line-Identifier

by lynxis lazus

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41013?usp=email ) Change subject: dia/diameter_3gpp_ts29_229.dia: inherit only Line-Identifier ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41013?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Iece0c768eb2dbb429726796a73274fd476cd1d0b Gerrit-Change-Number: 41013 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Sep 2025 10:00:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks, 4 days

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2025