Attention is currently required from: jolly, pespin.
fixeria has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008?usp=email )
Change subject: Add templates for S1AP Handover procedure
......................................................................
Patch Set 1:
(11 comments)
File library/s1ap/S1AP_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008/comment/9dd59a67_f798… :
PS1, Line 2293: procedureCode := S1AP_Constants.id_HandoverPreparation,
> Are you sure this ID is correct?
It may look confusing, but yes, it's correct.
See 3GPP TS 36.413, section 8.4.1 "Handover Preparation".
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008/comment/1d9ab67d_fd76… :
PS1, Line 2337: procedureCode := S1AP_Constants.id_HandoverPreparation,
> Are you sure this ID is correct?
It may look confusing, but yes, it's correct.
See 3GPP TS 36.413, section 8.4.1 "Handover Preparation".
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008/comment/e3709bce_b93e… :
PS1, Line 2370: }
> (FYI, see in https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40985/2/library/ranap/RANAP…. […]
Optional IEs can be added later whenever they're needed.
For testing the S1 HANDOVER procedures, it's enough to have mandatory IEs only.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008/comment/8ac1fa85_cdbf… :
PS1, Line 2374: ts_E_RABSubjecttoDataForwardingList(template (value) E_RABDataForwardingItem it) := {
> IMHO it's better to have a template for E_RABSubjecttoDataForwardingItem, and then simply do "{ ts_E […]
`E-RABSubjecttoDataForwardingItem` does not exist in the ASN.1 definition, so it's not possible to define templates for a single list item. This is how it's defined:
```
E-RABSubjecttoDataForwardingList ::= E-RAB-IE-ContainerList { {E-RABDataForwardingItemIEs} }
```
Same applies to the `E_RABModifyListBearerModConf` templates above.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008/comment/e1e49616_bddf… :
PS1, Line 2423: successfulOutcome := {
> Are you sure the HandoverCmd is a succesfulOutcome and not an InitialMessage? […]
Yes, because this PDU is sent in response to the `HANDOVER REQUIRED`.
* `HANDOVER REQUIRED` - `initiatingMessage`,
* `HANDOVER COMMAND` - `successfulOutcome`.
See 3GPP TS 36.413, section 8.4.1 "Handover Preparation".
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008/comment/19585d4b_fe0a… :
PS1, Line 2424: procedureCode := S1AP_Constants.id_HandoverPreparation,
> Are you sure this ID is correct?
See above (yes).
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008/comment/20931929_6431… :
PS1, Line 2450: }
We definitely want `E-RABs to Release List` IE (optional) here.
Not a merge blocker, can be added later in a separate patch.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008/comment/5d45d5b8_b6e6… :
PS1, Line 2462: procedureCode := S1AP_Constants.id_HandoverPreparation,
> same comments as per ts_S1AP_HandoverCmd apply here too.
See above.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008/comment/40b75a58_5b55… :
PS1, Line 2560: procedureCode := S1AP_Constants.id_HandoverResourceAllocation,
> are you sure this ID is correct?
Yes. See 3GPP TS 36.413, section 8.4.2 "Handover Resource Allocation".
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008/comment/a0577d5d_8cc9… :
PS1, Line 2638: *,
I see no optional IEs between the `E-RABs To Be Setup List` and `Source to Target
Transparent Container`, so a wildcard is not needed here.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008/comment/e3051405_106d… :
PS1, Line 2732: }, {
Likewise, would be nice to have optional `E-RABs Failed to Setup List` IE here.
Not a merge blocker, can be added later in a separate patch.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41008?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib8b8aee0665a4f6644287b802f5e941bd82128f6
Gerrit-Change-Number: 41008
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 07 Sep 2025 10:23:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: jolly, pespin.
fixeria has uploaded a new patch set (#5) to the change originally created by jolly. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006?usp=email )
Change subject: s1ap_proxy: Add support for S1 HANDOVER procedure
......................................................................
s1ap_proxy: Add support for S1 HANDOVER procedure
The HANDOVER procedure consists of two parts:
* Preparation of handover on the source eNB
A list of E-RABs to be released are processed by the proxy.
* Resource allocation on the target eNB
A list of E-RABs to be established are processed by the proxy. GTP-TEIDs
and transport layer addresses will be modified.
Change-Id: Ib2c8b1787c60d35a512c3c78d35e1f72a9d7bb08
Related: osmo-ttcn3-hacks.git Id349c84749f7e897defa8cfd2ecd2c1f2fb52fc7
Related: SYS#7309
---
M include/s1gw_metrics.hrl
M src/s1ap_proxy.erl
M src/s1gw_metrics.erl
3 files changed, 127 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/06/41006/5
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: Ib2c8b1787c60d35a512c3c78d35e1f72a9d7bb08
Gerrit-Change-Number: 41006
Gerrit-PatchSet: 5
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: fixeria, pespin.
fixeria has uploaded a new patch set (#4) to the change originally created by jolly. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41029?usp=email )
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: s1ap_proxy_test: Add unit tests for S1 HANDOVER procedure
......................................................................
s1ap_proxy_test: Add unit tests for S1 HANDOVER procedure
Change-Id: I400ac73343f2a795c8206aeee75a31f1455adbd0
Related: SYS#7309
---
M test/s1ap_proxy_test.erl
1 file changed, 108 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/29/41029/4
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41029?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I400ac73343f2a795c8206aeee75a31f1455adbd0
Gerrit-Change-Number: 41029
Gerrit-PatchSet: 4
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41065?usp=email )
Change subject: mme: Split ConnHdlr to its own file
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File mme/ConnHdlr.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41065/comment/04f4fdaa_6838… :
PS1, Line 927: }
"No newline at end of right file." (fix your editor)
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41065?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I322e679fa252388649b897a13d2d4a325212a71a
Gerrit-Change-Number: 41065
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 07 Sep 2025 06:07:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41063?usp=email )
Change subject: mme: Move g_Tguard to MTC_CT
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File mme/MME_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41063/comment/47330f62_d1d6… :
PS3, Line 102: 45.0;
The commit message says "move", but you're also increasing (30 -> 45) it?
Is this because you're arming it earlier and the `f_init()` can take ~15s?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41063?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I8b766ad83030ac5c92fe64b7ea2df35468b23fc0
Gerrit-Change-Number: 41063
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 07 Sep 2025 06:02:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes