September 2025 - gerrit-log - lists.osmocom.org

[S] Change in ...osmo-s1gw[master]: s1ap_proxy: add fetch_enb_info/1

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41030?usp=email ) Change subject: s1ap_proxy: add fetch_enb_info/1 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41030?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I79fcb599274c78d8f58e6c774a4f8c64c2fb08b5 Gerrit-Change-Number: 41030 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Sep 2025 13:53:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks, 4 days

1
0
0 0

[XS] Change in ...osmo-s1gw[master]: sctp_proxy: return handler Pid in fetch_info/0

by pespin

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40904?usp=email ) Change subject: sctp_proxy: return handler Pid in fetch_info/0 ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40904?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I3911bfc107fea3ca572cf44f1d93b768b3c82b4f Gerrit-Change-Number: 40904 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Sep 2025 13:52:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks, 4 days

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: msc: CC SETUP MT speech: verify bearer capabilities

by osmith

osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41044?usp=email ) Change subject: msc: CC SETUP MT speech: verify bearer capabilities ...................................................................... Patch Set 4: (1 comment) This change is ready for review. Patchset: PS3: > TC_lu_and_mt_csd currently fails with this, looking into it Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41044?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8fd33cf2f7fb8a1c34851ecf54fccddd2efd0536 Gerrit-Change-Number: 41044 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Thu, 04 Sep 2025 13:33:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

2 weeks, 4 days

1
0
0 0

[M] Change in osmo-msc[master]: gsm48_cc_tx_setup: fix speech bearer capabilities

by osmith

osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-msc/+/41043?usp=email ) Change subject: gsm48_cc_tx_setup: fix speech bearer capabilities ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41043?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I7046e9244fd9d4301ee2c4df1147a619f753739c Gerrit-Change-Number: 41043 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Thu, 04 Sep 2025 13:10:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

2 weeks, 4 days

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: msc: CC SETUP MT speech: verify bearer capabilities

by osmith

osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41044?usp=email ) Change subject: msc: CC SETUP MT speech: verify bearer capabilities ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: TC_lu_and_mt_csd currently fails with this, looking into it -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41044?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8fd33cf2f7fb8a1c34851ecf54fccddd2efd0536 Gerrit-Change-Number: 41044 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Thu, 04 Sep 2025 12:49:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

2 weeks, 4 days

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: msc: CC SETUP MT speech: verify bearer capabilities

by osmith

osmith has uploaded a new patch set (#3). ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41044?usp=email ) Change subject: msc: CC SETUP MT speech: verify bearer capabilities ...................................................................... msc: CC SETUP MT speech: verify bearer capabilities Verify that the MSC sends the bearer capability IE from 3GPP TS 24.008 § D.1.2 for speech in the network to MS direction, instead of allowing e.g. what osmo-msc master and latest release currently do: - Filling out radio channel requirement the same way as the MS to Network direction, which is wrong for the Network to MS direction: "Bits 6 and 7 are spare bits. The sending side (i.e. the network) shall set bit 7 to value 0 and bit 6 to value 1." (3GPP TS 24.008 Table 10.5.102) - Sending a speech list in the Network to MS direction, which seems to be allowed in theory and MS are supposed to ignore it (end of Table 10.5.103) but causes bugs in some MS in practice. Therefore it is better to ensure that osmo-msc does not send it (OS#6656). Implement this in f_mt_call_complete(), which gets used e.g. by TC_lu_and_mt_call. Depends: osmo-msc I7046e9244fd9d4301ee2c4df1147a619f753739c Related: OS#6657, OS#6655, OS#6656 Change-Id: I8fd33cf2f7fb8a1c34851ecf54fccddd2efd0536 --- M library/L3_Templates.ttcn M msc/BSC_ConnectionHandler.ttcn 2 files changed, 26 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/44/41044/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41044?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8fd33cf2f7fb8a1c34851ecf54fccddd2efd0536 Gerrit-Change-Number: 41044 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

2 weeks, 4 days

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: msc: CC SETUP MT speech: verify bearer capabilities

by osmith

osmith has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41044?usp=email ) Change subject: msc: CC SETUP MT speech: verify bearer capabilities ...................................................................... msc: CC SETUP MT speech: verify bearer capabilities Verify that the MSC sends the bearer capability IE from 3GPP TS 24.008 § D.1.2 for speech in the network to MS direction, instead of allowing e.g. what osmo-msc master and latest release currently do: - Filling out radio channel requirement the same way as the MS to Network direction, which is wrong for the Network to MS direction: "Bits 6 and 7 are spare bits. The sending side (i.e. the network) shall set bit 7 to value 0 and bit 6 to value 1." (3GPP TS 24.008 Table 10.5.102) - Sending a speech list in the Network to MS direction, which seems to be allowed in theory and MS are supposed to ignore it (end of Table 10.5.103) but causes bugs in some MS in practice. Therefore it is better to ensure that osmo-msc does not send it (OS#6656). Implement this in f_mt_call_complete(), which gets used e.g. by TC_lu_and_mt_call. Depends: osmo-msc I7046e9244fd9d4301ee2c4df1147a619f753739c Related: OS#6657, OS#6655, OS#6656 Change-Id: I8fd33cf2f7fb8a1c34851ecf54fccddd2efd0536 --- M library/L3_Templates.ttcn M msc/BSC_ConnectionHandler.ttcn 2 files changed, 26 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/44/41044/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41044?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8fd33cf2f7fb8a1c34851ecf54fccddd2efd0536 Gerrit-Change-Number: 41044 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

2 weeks, 4 days

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: msc: CC SETUP MT speech: verify bearer capabilities

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41044?usp=email ) Change subject: msc: CC SETUP MT speech: verify bearer capabilities ...................................................................... msc: CC SETUP MT speech: verify bearer capabilities Verify that the MSC sends the bearer capability IE from 3GPP TS 24.008 § D.1.2 for speech in the network to MS direction, instead of allowing e.g. what osmo-msc master and latest release currently do: - Filling out radio channel requirement the same way as the MS to Network direction, which is wrong for the Network to MS direction: "Bits 6 and 7 are spare bits. The sending side (i.e. the network) shall set bit 7 to value 0 and bit 6 to value 1." (3GPP TS 24.008 Table 10.5.102) - Sending a speech list in the Network to MS direction, which seems to be allowed in theory and MS are supposed to ignore it (end of Table 10.5.103) but causes bugs in some MS in practice. Therefore it is better to ensure that osmo-msc does not send it (OS#6656). Implement this in f_mt_call_complete(), which gets used e.g. by TC_lu_and_mt_call. Related: osmo-msc I7046e9244fd9d4301ee2c4df1147a619f753739c Related: OS#6657, OS#6655, OS#6656 Change-Id: I8fd33cf2f7fb8a1c34851ecf54fccddd2efd0536 --- M library/L3_Templates.ttcn M msc/BSC_ConnectionHandler.ttcn 2 files changed, 26 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/44/41044/1 diff --git a/library/L3_Templates.ttcn b/library/L3_Templates.ttcn index 9551845..49aa2c0 100644 --- a/library/L3_Templates.ttcn +++ b/library/L3_Templates.ttcn @@ -1382,6 +1382,24 @@ octet7 := omit } +/* TS 3GPP 24.008 § D.1.2 */ +template (value) BearerCapability_TLV ts_Bcap_voice_mt := { + elementIdentifier := '04'O, + lengthIndicator := 1, + octet3 := { + informationTransferCapability := '000'B, + transferMode := '0'B, + codingStandard := '0'B, + radioChannelRequirement := '01'B, /* spare */ + extension_octet_3 := '1'B, /* not ext */ + speech_aux_3a_3b := omit + }, + octet4 := omit, + octet5 := omit, + octet6 := omit, + octet7 := omit +} + /* TS 3GPP 24.008 § 10.5.4.5 */ template (value) BearerCapability_TLV ts_Bcap_csd := { elementIdentifier := '04'O, @@ -1960,7 +1978,6 @@ } } - template PDU_ML3_NW_MS tr_ML3_MT_CC_SETUP(integer tid, template hexstring called := *, template hexstring calling := *, template BearerCapability_TLV bcap := *) := { diff --git a/msc/BSC_ConnectionHandler.ttcn b/msc/BSC_ConnectionHandler.ttcn index 6acaa20..cfe2d53 100644 --- a/msc/BSC_ConnectionHandler.ttcn +++ b/msc/BSC_ConnectionHandler.ttcn @@ -1130,8 +1130,14 @@ cpars.got_osmux_count := 0; - /* MS <- MSC: Expect CC SETUP */ - BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_CC_SETUP(cpars.transaction_id, *, cpars.called_party))); + /* MS <- MSC: Expect CC SETUP with ts_Bcap_voice_mt (OS#6657) */ + if (Misc_Helpers.f_osmo_repo_is("nightly")) { + BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_CC_SETUP(cpars.transaction_id, *, cpars.called_party, valueof(ts_Bcap_voice_mt)))); + } else { + /* Remove this latest path after osmo-msc >= 1.14.x is released + * with I7046e9244fd9d4301ee2c4df1147a619f753739c */ + BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_CC_SETUP(cpars.transaction_id, *, cpars.called_party))); + } /* MS -> MSC: ALERTING */ BSSAP.send(ts_PDU_DTAP_MO(ts_ML3_MO_CC_ALERTING(cpars.transaction_id))); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41044?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8fd33cf2f7fb8a1c34851ecf54fccddd2efd0536 Gerrit-Change-Number: 41044 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

2 weeks, 4 days

1
0
0 0

[S] Change in osmo-msc[master]: gsm48_cc_tx_setup: add goto error

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/41036?usp=email ) Change subject: gsm48_cc_tx_setup: add goto error ...................................................................... gsm48_cc_tx_setup: add goto error Move common clean up code to a new error label. Change-Id: Ic8268d32df968d2e7c80f62b4a4fe370052f999f --- M src/libmsc/gsm_04_08_cc.c 1 file changed, 10 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/36/41036/1 diff --git a/src/libmsc/gsm_04_08_cc.c b/src/libmsc/gsm_04_08_cc.c index 467305d..59f42c8 100644 --- a/src/libmsc/gsm_04_08_cc.c +++ b/src/libmsc/gsm_04_08_cc.c @@ -855,9 +855,7 @@ GSM48_CAUSE_LOC_PRN_S_LU, GSM48_CC_CAUSE_RESOURCE_UNAVAIL); trans->callref = 0; - trans_free(trans); - msgb_free(msg); - return rc; + goto error; } /* Get free transaction_id */ @@ -868,9 +866,7 @@ GSM48_CAUSE_LOC_PRN_S_LU, GSM48_CC_CAUSE_RESOURCE_UNAVAIL); trans->callref = 0; - trans_free(trans); - msgb_free(msg); - return rc; + goto error; } trans->transaction_id = trans_id; @@ -929,9 +925,7 @@ rc = bearer_cap_set_radio(&bearer_cap); if (rc) { LOG_TRANS(trans, LOGL_ERROR, "Error composing Bearer Capability for CC Setup\n"); - trans_free(trans); - msgb_free(msg); - return rc; + goto error; } /* If no resulting codecs remain, error out. We cannot find a codec that matches both call legs. If the MGW were * able to transcode, we could use non-identical codecs on each conn of the MGW endpoint, but we are aiming for @@ -946,16 +940,12 @@ GSM48_CAUSE_LOC_PRN_S_LU, GSM48_CC_CAUSE_INCOMPAT_DEST /* TODO: correct cause code? */); trans->callref = 0; - trans_free(trans); - msgb_free(msg); - return rc; + goto error; } rc = bearer_cap_filter_rev_lev(&bearer_cap, trans->vsub->classmark.classmark1.rev_lev); if (rc) { LOG_TRANS(trans, LOGL_ERROR, "No codec offered is supported by phase 1 mobile.\n"); - trans_free(trans); - msgb_free(msg); - return rc; + goto error; } break; case GSM48_BCAP_ITCAP_3k1_AUDIO: @@ -976,9 +966,7 @@ GSM48_CAUSE_LOC_PRN_S_LU, GSM48_CC_CAUSE_INCOMPAT_DEST /* TODO: correct cause code? */); trans->callref = 0; - trans_free(trans); - msgb_free(msg); - return rc; + goto error; } break; } @@ -1021,6 +1009,10 @@ rate_ctr_inc(rate_ctr_group_get_ctr(trans->net->msc_ctrs, MSC_CTR_CALL_MT_SETUP)); return trans_tx_gsm48(trans, msg); +error: + trans_free(trans); + msgb_free(msg); + return rc; } static int gsm48_cc_rx_call_conf(struct gsm_trans *trans, struct msgb *msg) -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41036?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ic8268d32df968d2e7c80f62b4a4fe370052f999f Gerrit-Change-Number: 41036 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

2 weeks, 4 days

1
0
0 0

[S] Change in osmo-msc[master]: gsm48_cc_tx_setup: move msgb_alloc down

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/41037?usp=email ) Change subject: gsm48_cc_tx_setup: move msgb_alloc down ...................................................................... gsm48_cc_tx_setup: move msgb_alloc down Don't alloc msgb before it gets used. Change-Id: I99edbdc915552a4ab28ef6f7a1e55818092a2e20 --- M src/libmsc/gsm_04_08_cc.c 1 file changed, 5 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/37/41037/1 diff --git a/src/libmsc/gsm_04_08_cc.c b/src/libmsc/gsm_04_08_cc.c index 59f42c8..b82c018 100644 --- a/src/libmsc/gsm_04_08_cc.c +++ b/src/libmsc/gsm_04_08_cc.c @@ -838,14 +838,12 @@ static int gsm48_cc_tx_setup(struct gsm_trans *trans, void *arg) { - struct msgb *msg = gsm48_msgb_alloc_name("GSM 04.08 CC SETUP"); + struct msgb *msg; struct gsm48_hdr *gh; struct gsm_mncc *setup = arg; int rc, trans_id; struct gsm_mncc_bearer_cap bearer_cap; - gh = (struct gsm48_hdr *) msgb_put(msg, sizeof(*gh)); - /* transaction id must not be assigned */ if (trans->transaction_id != TRANS_ID_UNASSIGNED) { LOG_TRANS(trans, LOGL_DEBUG, "TX Setup with assigned transaction. " @@ -870,8 +868,6 @@ } trans->transaction_id = trans_id; - gh->msg_type = GSM48_MT_CC_SETUP; - gsm48_start_cc_timer(trans, 0x303, GSM48_T303); /* MT call leg is starting. Gather all codecs information so far known. @@ -974,6 +970,10 @@ /* Create a copy of the bearer capability in the transaction struct, so we can use this information later */ trans->bearer_cap = bearer_cap; + msg = gsm48_msgb_alloc_name("GSM 04.08 CC SETUP"); + gh = (struct gsm48_hdr *) msgb_put(msg, sizeof(*gh)); + gh->msg_type = GSM48_MT_CC_SETUP; + gsm48_encode_bearer_cap(msg, 0, &bearer_cap); /* facility */ @@ -1011,7 +1011,6 @@ return trans_tx_gsm48(trans, msg); error: trans_free(trans); - msgb_free(msg); return rc; } -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41037?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I99edbdc915552a4ab28ef6f7a1e55818092a2e20 Gerrit-Change-Number: 41037 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

2 weeks, 4 days

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2025