September 2025 - gerrit-log - lists.osmocom.org

[M] Change in libosmo-asn1-tcap[master]: debian: initial

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41023?usp=email ) Change subject: debian: initial ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41023?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: I8ab1b2d69b5617c91ac694bf4a754d6c28b080dd Gerrit-Change-Number: 41023 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Sep 2025 15:07:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks, 4 days

1
0
0 0

[S] Change in libosmo-asn1-tcap[master]: (cosmetic) asn: Remove trailing whitespace

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41020?usp=email ) Change subject: (cosmetic) asn: Remove trailing whitespace ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41020?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: Ib0aaa0f37f813851e8cfe28aaa22b105b5dcac17 Gerrit-Change-Number: 41020 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Sep 2025 15:06:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks, 4 days

1
0
0 0

[S] Change in ...osmo-epdg[master]: Remove duplicate 3GPP-AAA-Server-Name definition and break 3-way circ...

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41016?usp=email ) Change subject: Remove duplicate 3GPP-AAA-Server-Name definition and break 3-way circular dependency ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41016?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Idb1a7f7588b751c59788e4d99cd1d86f1fd2b573 Gerrit-Change-Number: 41016 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Sep 2025 15:04:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks, 4 days

1
0
0 0

[XS] Change in ...osmo-epdg[master]: dia: restrict AVPs inherited from RFC4005

by laforge

Attention is currently required from: lynxis lazus, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41015?usp=email ) Change subject: dia: restrict AVPs inherited from RFC4005 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41015?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Ibc11180489db6d86819ab17a5e7e92636dfed95e Gerrit-Change-Number: 41015 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 04 Sep 2025 15:04:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks, 4 days

1
0
0 0

[L] Change in ...osmo-epdg[master]: dia/diameter_3ggp_ts32_299.dia: Inherit RFC4005 instead of RFC7155

by laforge

Attention is currently required from: lynxis lazus, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41014?usp=email ) Change subject: dia/diameter_3ggp_ts32_299.dia: Inherit RFC4005 instead of RFC7155 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > @laforge@osmocom. […] We must use whatever the 3GPP specs say. It's not relevant what the internet community is doing elsewhere. So RFC4005 it is! -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41014?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I7742d1523026e260b8501550977a41ebd3ad1b09 Gerrit-Change-Number: 41014 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 04 Sep 2025 15:04:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

2 weeks, 4 days

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: msc: CC SETUP MT speech: verify bearer capabilities

by pespin

Attention is currently required from: neels, osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41044?usp=email ) Change subject: msc: CC SETUP MT speech: verify bearer capabilities ...................................................................... Patch Set 4: Code-Review+1 (1 comment) File msc/BSC_ConnectionHandler.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41044/comment/615aa60a_81cf… : PS4, Line 1137: BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_CC_SETUP(cpars.transaction_id, *, cpars.called_party))); you may want to add explicit "*" param here to easily spot the differences. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41044?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8fd33cf2f7fb8a1c34851ecf54fccddd2efd0536 Gerrit-Change-Number: 41044 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Sep 2025 14:16:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

2 weeks, 4 days

1
0
0 0

[M] Change in osmo-msc[master]: gsm48_cc_tx_setup: fix speech bearer capabilities

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-msc/+/41043?usp=email ) Change subject: gsm48_cc_tx_setup: fix speech bearer capabilities ...................................................................... Patch Set 2: (3 comments) File src/libmsc/gsm_04_08_cc.c: https://gerrit.osmocom.org/c/osmo-msc/+/41043/comment/573371e9_1a77126f?usp… : PS2, Line 994: * - We shall send spares for radio (which happens to be the same as what's "spares"? "spare bits"? What do you mean with "radio" here? https://gerrit.osmocom.org/c/osmo-msc/+/41043/comment/aa88333e_82a752a7?usp… : PS2, Line 997: * - We could send a speech version list in theory that MS are then "We could in theory send a speech version list that" https://gerrit.osmocom.org/c/osmo-msc/+/41043/comment/79cbe407_bfbf01d0?usp… : PS2, Line 1003: .radio = GSM48_BCAP_RRQ_FR_ONLY, /* spare */ If it's a spare, imho it'd be better to add a hardcoded value, or add an explicit enum field (eg. a define inside the enum). -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41043?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I7046e9244fd9d4301ee2c4df1147a619f753739c Gerrit-Change-Number: 41043 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Sep 2025 14:14:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

2 weeks, 4 days

1
0
0 0

[S] Change in osmo-msc[master]: gsm48_cc_tx_setup: remove extra bearer_cap var

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-msc/+/41042?usp=email ) Change subject: gsm48_cc_tx_setup: remove extra bearer_cap var ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41042?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I247ef10923c2875ca75e73046f4b8ed14190d4d2 Gerrit-Change-Number: 41042 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Sep 2025 14:08:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks, 4 days

1
0
0 0

[M] Change in osmo-msc[master]: gsm48_cc_tx_setup_encode_msg: split out

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-msc/+/41041?usp=email ) Change subject: gsm48_cc_tx_setup_encode_msg: split out ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/libmsc/gsm_04_08_cc.c: https://gerrit.osmocom.org/c/osmo-msc/+/41041/comment/bb562798_d49605ab?usp… : PS1, Line 1052: msg = gsm48_cc_tx_setup_encode_msg(setup, &bearer_cap); Probably want to also swap the param order to have it inline with the ones above. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41041?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I443b4b54c6ad40d852e4c21c896c2d0da5fac239 Gerrit-Change-Number: 41041 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Sep 2025 14:07:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

2 weeks, 4 days

1
0
0 0

[M] Change in osmo-msc[master]: gsm48_cc_tx_setup_set_bearer_cap: split out

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-msc/+/41040?usp=email ) Change subject: gsm48_cc_tx_setup_set_bearer_cap: split out ...................................................................... Patch Set 1: (2 comments) File src/libmsc/gsm_04_08_cc.c: https://gerrit.osmocom.org/c/osmo-msc/+/41040/comment/8233395f_659f9564?usp… : PS1, Line 918: static int gsm48_cc_tx_setup_set_bearer_cap(struct gsm_trans *trans, const struct gsm_mncc *setup, Since we have 2 inout pars and 1 in par, please move the in par to the end instead of having it in the middle. https://gerrit.osmocom.org/c/osmo-msc/+/41040/comment/01263951_0f79eb8c?usp… : PS1, Line 1008: rc = gsm48_cc_tx_setup_set_bearer_cap(trans, setup, &bearer_cap); (trans, &bearer_cap, setup) -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41040?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3fe6bb2af90d729bb32cae8f5a1a38dcf8f87eb9 Gerrit-Change-Number: 41040 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 Sep 2025 14:05:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

2 weeks, 4 days

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2025