August 2025 - gerrit-log - lists.osmocom.org

[XS] Change in ...osmo_dia2gsup[master]: rebar.config: fix invalid branch for rebar3_diameter_compiler.git

by pespin

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40910?usp=email ) Change subject: rebar.config: fix invalid branch for rebar3_diameter_compiler.git ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40910?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I21490a837ee039e02dfde3e19ded338cf428d291 Gerrit-Change-Number: 40910 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Aug 2025 12:15:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 weeks, 1 day

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: Makefile: DIR_clean_template: clean depends on Makefile

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40909?usp=email ) Change subject: Makefile: DIR_clean_template: clean depends on Makefile ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40909?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4934f345f4a1d54fa939143d46033c1ef6751aba Gerrit-Change-Number: 40909 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Aug 2025 12:14:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 weeks, 1 day

1
0
0 0

[XS] Change in ...osmo_dia2gsup[master]: rebar.config: fix invalid branch for rebar3_diameter_compiler.git

by fixeria

Attention is currently required from: fixeria, laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40910?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: rebar.config: fix invalid branch for rebar3_diameter_compiler.git ...................................................................... rebar.config: fix invalid branch for rebar3_diameter_compiler.git The upstream has ranamed 'master' branch to 'main', so the old name is no longer valid. This resulted in osmo_dia2gsup build failures. Let's use the latest stable release (0.8.0) instead. It's quite dated (2022), yet does the job. I could not find any significant changes since 0.8.0 (mostly CI and doc improvements). Change-Id: I21490a837ee039e02dfde3e19ded338cf428d291 Related: https://github.com/carlosedp/rebar3_diameter_compiler/commit/077e7b23d9ad2c… --- M rebar.config 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/10/40910/2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40910?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I21490a837ee039e02dfde3e19ded338cf428d291 Gerrit-Change-Number: 40910 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

4 weeks, 1 day

1
0
0 0

[XS] Change in ...osmo_dia2gsup[master]: rebar.config: fix invalid branch for rebar3_diameter_compiler.git

by osmith

Attention is currently required from: fixeria, laforge. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40910?usp=email ) Change subject: rebar.config: fix invalid branch for rebar3_diameter_compiler.git ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > > * Use the latest tag (`{tag, "0.8.0"}`) -- it's quite old though, from 2022. […] Acknowledged -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40910?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I21490a837ee039e02dfde3e19ded338cf428d291 Gerrit-Change-Number: 40910 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Aug 2025 11:53:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

4 weeks, 1 day

1
0
0 0

[XS] Change in ...osmo_dia2gsup[master]: rebar.config: fix invalid branch for rebar3_diameter_compiler.git

by fixeria

Attention is currently required from: laforge, osmith. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40910?usp=email ) Change subject: rebar.config: fix invalid branch for rebar3_diameter_compiler.git ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > * Use the latest tag (`{tag, "0.8.0"}`) -- it's quite old though, from 2022. Actually, I think it's fine to use this tag instead: * There have been no significant changes since that tag (mostly CI and doc improvements). * I tested `0.8.0` and confirmed that it does the job. So I am going to update this patch to use the tag. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40910?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I21490a837ee039e02dfde3e19ded338cf428d291 Gerrit-Change-Number: 40910 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 25 Aug 2025 11:52:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

4 weeks, 1 day

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: 5gc: Test UE requested PDU Session Modification procedure

by pespin

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40895?usp=email ) Change subject: 5gc: Test UE requested PDU Session Modification procedure ...................................................................... Patch Set 2: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40895?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id9ac0f0e431c4a82dfab8675c93bf3c3f05442a7 Gerrit-Change-Number: 40895 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Mon, 25 Aug 2025 11:45:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

4 weeks, 1 day

1
0
0 0

[XS] Change in ...osmo-s1gw[master]: sctp_proxy: return handler Pid in fetch_info/0

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40904?usp=email ) Change subject: sctp_proxy: return handler Pid in fetch_info/0 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Not sure what kind of completeness you mean here and why would we want to squash patches? I dislike […] Fine, I'm just mentioning because afaics there are several patches adding functions, etc. which are not used in the patch nor explained where they will be used, etc. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40904?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I3911bfc107fea3ca572cf44f1d93b768b3c82b4f Gerrit-Change-Number: 40904 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Aug 2025 11:43:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

4 weeks, 1 day

1
0
0 0

[XS] Change in osmo-ci[master]: jobs/gerrit-verifications: osmo-ttcn3-hacks: do make clean

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/40908?usp=email ) Change subject: jobs/gerrit-verifications: osmo-ttcn3-hacks: do make clean ...................................................................... jobs/gerrit-verifications: osmo-ttcn3-hacks: do make clean It's easy to break the build verification [for everybody] by submitting a patch that creates a symlink to a non-existent file. The workspace is not wiped, so the stale symlink remains and results in failures like this: (cd sgsn && ./gen_links.sh && ./regen_makefile.sh) ttcn3_makefilegen: error: Cannot find any source file for argument `NAS_Templates.ttcn'. make: *** [Makefile:131: _build/sgsn/Makefile] Error 1 Let's invoke the 'clean' recipe before 'compile' to avoid this. Change-Id: I886a99e7b1e8c42ccc7441685ecd7b2c54d5a7af --- M jobs/gerrit-verifications.yml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: osmith: Looks good to me, but someone else must approve lynxis lazus: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml index 48ba632..f91cbb8 100644 --- a/jobs/gerrit-verifications.yml +++ b/jobs/gerrit-verifications.yml @@ -524,7 +524,7 @@ ln -s "$i" /build/deps/ fi done - su build -c "make -C /build compile" + su build -c "make -C /build clean compile" ' pipeline_binpkgs: "" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40908?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I886a99e7b1e8c42ccc7441685ecd7b2c54d5a7af Gerrit-Change-Number: 40908 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 weeks, 1 day

1
0
0 0

[XS] Change in osmo-ci[master]: jobs/gerrit-verifications: osmo-ttcn3-hacks: do make clean

by fixeria

Attention is currently required from: fixeria, lynxis lazus, osmith, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ci/+/40908?usp=email ) Change subject: jobs/gerrit-verifications: osmo-ttcn3-hacks: do make clean ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40908?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I886a99e7b1e8c42ccc7441685ecd7b2c54d5a7af Gerrit-Change-Number: 40908 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 25 Aug 2025 11:12:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

4 weeks, 1 day

1
0
0 0

[XS] Change in pysim[master]: Make sure to select MF before probing for files/Addons

by bjoern

bjoern has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/40913?usp=email ) Change subject: Make sure to select MF before probing for files/Addons ...................................................................... Make sure to select MF before probing for files/Addons Change-Id: I685367c282f57a8856668a3172a9391a5bbcf2e2 --- M pySim/cards.py M pySim/runtime.py 2 files changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/13/40913/1 diff --git a/pySim/cards.py b/pySim/cards.py index dedb2d6..58e8503 100644 --- a/pySim/cards.py +++ b/pySim/cards.py @@ -112,6 +112,8 @@ def probe(self) -> bool: # EF.DIR is a mandatory EF on all ICCIDs; however it *may* also exist on a TS 51.011 SIM ef_dir = EF_DIR() + # select MF first + self.file_exists("3f00") return self.file_exists(ef_dir.fid) def read_aids(self) -> List[Hexstr]: diff --git a/pySim/runtime.py b/pySim/runtime.py index ec19cb4..2205957 100644 --- a/pySim/runtime.py +++ b/pySim/runtime.py @@ -60,6 +60,9 @@ self.card.set_apdu_parameter( cla=self.profile.cla, sel_ctrl=self.profile.sel_ctrl) + # make sure MF is selected before probing for Addons + self.lchan[0].select('MF') + for addon_cls in self.profile.addons: addon = addon_cls() if addon.probe(self.card): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40913?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I685367c282f57a8856668a3172a9391a5bbcf2e2 Gerrit-Change-Number: 40913 Gerrit-PatchSet: 1 Gerrit-Owner: bjoern <bjoern.c3(a)nixda.biz>

4 weeks, 1 day

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2025