August 2025 - gerrit-log - lists.osmocom.org

[XS] Change in ...osmo-s1gw[master]: sctp_proxy: return handler Pid in fetch_info/0

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40904?usp=email ) Change subject: sctp_proxy: return handler Pid in fetch_info/0 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I'm not really following you with all these apparently non-complete patches? I guess squashing them […] Not sure what kind of completeness you mean here and why would we want to squash patches? I dislike the idea of squashing patches because I prefer small atomic changes and do not see benefits of submitting a single huge patch for review. To give you some context, these patches are preparing for the upcoming REST interface. I decided to submit them first while I am still working on the main logic, so that I have less things to maintain in a WIP branch. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40904?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I3911bfc107fea3ca572cf44f1d93b768b3c82b4f Gerrit-Change-Number: 40904 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Aug 2025 10:40:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

4 weeks, 1 day

1
0
0 0

[XS] Change in ...osmo-s1gw[master]: enb_uptime: handle 'stop' when Global-eNB-ID is unknown

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40899?usp=email ) Change subject: enb_uptime: handle 'stop' when Global-eNB-ID is unknown ...................................................................... enb_uptime: handle 'stop' when Global-eNB-ID is unknown Change-Id: I706d78ee6cc39ff836ad8cd6b998041db5e09d19 Fixes: a4cec554 ("enb_uptime: track eNB uptime") --- M src/enb_uptime.erl 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve diff --git a/src/enb_uptime.erl b/src/enb_uptime.erl index 4c6f76a..6283fd0 100644 --- a/src/enb_uptime.erl +++ b/src/enb_uptime.erl @@ -91,6 +91,8 @@ {genb_id_ind, GlobalENBId} -> catch exometer:new(?S1GW_CTR_ENB_UPTIME(GlobalENBId), counter), loop(S#{genb_id => GlobalENBId}); + stop -> + ok; Event -> ?LOG_ERROR("Rx unexpected event: ~p", [Event]) end. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40899?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I706d78ee6cc39ff836ad8cd6b998041db5e09d19 Gerrit-Change-Number: 40899 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 weeks, 1 day

1
0
0 0

[XS] Change in ...osmo-s1gw[master]: enb_uptime: remove debugging leftover

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40900?usp=email ) Change subject: enb_uptime: remove debugging leftover ...................................................................... enb_uptime: remove debugging leftover Change-Id: I7fc9c4a1ec4952c9ec58f6c82bf5ae1bb743ef7b Fixes: a4cec554 ("enb_uptime: track eNB uptime") --- M src/enb_uptime.erl 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/enb_uptime.erl b/src/enb_uptime.erl index 6283fd0..ac71ebd 100644 --- a/src/enb_uptime.erl +++ b/src/enb_uptime.erl @@ -82,7 +82,6 @@ T1 = erlang:monotonic_time(), Diff = erlang:convert_time_unit(T1 - T0, native, second), s1gw_metrics:ctr_inc(?S1GW_CTR_ENB_UPTIME(GlobalENBId), Diff), - ?LOG_INFO("Td ~p second(s)", [Diff]), loop(S#{time => T1}) end; -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40900?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I7fc9c4a1ec4952c9ec58f6c82bf5ae1bb743ef7b Gerrit-Change-Number: 40900 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 weeks, 1 day

1
0
0 0

[XS] Change in ...osmo-s1gw[master]: sctp_server: remove unused include of s1ap.hrl

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40901?usp=email ) Change subject: sctp_server: remove unused include of s1ap.hrl ...................................................................... sctp_server: remove unused include of s1ap.hrl Change-Id: I3faf5714e7abc3ab261bd4ae841f214c3c9f117c --- M src/sctp_server.erl 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/sctp_server.erl b/src/sctp_server.erl index 1eeb075..5530677 100644 --- a/src/sctp_server.erl +++ b/src/sctp_server.erl @@ -50,7 +50,6 @@ -include_lib("kernel/include/inet_sctp.hrl"). -include("s1gw_metrics.hrl"). --include("s1ap.hrl"). -type addr_port() :: {inet:ip_address(), inet:port_number()}. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40901?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I3faf5714e7abc3ab261bd4ae841f214c3c9f117c Gerrit-Change-Number: 40901 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 weeks, 1 day

1
0
0 0

[XS] Change in osmo-ci[master]: jenkins-gerrit: print the URLs this script reads

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/40911?usp=email ) Change subject: jenkins-gerrit: print the URLs this script reads ...................................................................... jenkins-gerrit: print the URLs this script reads Make errors easier to understand by printing all URLs that the script is reading from. Change-Id: Ic0e7fc0e5a82927fc9ef6ec02c374b1ec7dd73e5 --- M scripts/jenkins-gerrit/comment_generate.py 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/scripts/jenkins-gerrit/comment_generate.py b/scripts/jenkins-gerrit/comment_generate.py index a2aec0e..c81011f 100755 --- a/scripts/jenkins-gerrit/comment_generate.py +++ b/scripts/jenkins-gerrit/comment_generate.py @@ -41,6 +41,7 @@ global re_distro url = f"{job_url}/consoleText" + print(f"Reading {url}") with urllib.request.urlopen(url) as response: content = response.read().decode("utf-8") match = re_distro.search(content) @@ -77,6 +78,7 @@ ret = {} url = f"{build_url}/consoleText" + print(f"Reading {url}") with urllib.request.urlopen(url) as response: for line in io.TextIOWrapper(response, encoding='utf-8'): # Parse start build lines @@ -123,6 +125,7 @@ ret = [] url = f"{job['url']}/consoleFull" + print(f"Reading {url}") with urllib.request.urlopen(url) as response: for line in io.TextIOWrapper(response, encoding='utf-8'): if " completed with result " in line: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40911?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic0e7fc0e5a82927fc9ef6ec02c374b1ec7dd73e5 Gerrit-Change-Number: 40911 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 weeks, 1 day

1
0
0 0

[XS] Change in osmo-ci[master]: jenkins-gerrit: binpkgs: ignore decode errors

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/40912?usp=email ) Change subject: jenkins-gerrit: binpkgs: ignore decode errors ...................................................................... jenkins-gerrit: binpkgs: ignore decode errors The output of recent osmo-s1gw jobs for building binary packages contains invalid utf-8 characters, even though it should be utf-8 according to the HTTP header: content-type: text/plain;charset=utf-8 We only need to get the distro name from the output here, so simply ignore any decode errors. Fix for: $ ./comment_generate.py https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-s1gw/417/ -o gerrit_report.json -t result Reading https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-s1gw/417//consoleText Reading https://jenkins.osmocom.org/jenkins/job/gerrit-binpkgs/17255/consoleText Reading https://jenkins.osmocom.org/jenkins/job/gerrit-binpkgs/17260/consoleText Traceback (most recent call last): File "/home/user/code/osmo-dev/src/osmo-ci/scripts/jenkins-gerrit/./comment_generate.py", line 270, in <module> main() File "/home/user/code/osmo-dev/src/osmo-ci/scripts/jenkins-gerrit/./comment_generate.py", line 257, in main comment = get_comment_result(args.build_url, args.notify_on_success) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/user/code/osmo-dev/src/osmo-ci/scripts/jenkins-gerrit/./comment_generate.py", line 198, in get_comment_result pipeline = parse_pipeline(build_url) ^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/user/code/osmo-dev/src/osmo-ci/scripts/jenkins-gerrit/./comment_generate.py", line 89, in parse_pipeline stage = stage_from_job_name(job_name, job_url) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/user/code/osmo-dev/src/osmo-ci/scripts/jenkins-gerrit/./comment_generate.py", line 59, in stage_from_job_name return stage_binpkgs_from_url(job_url) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/user/code/osmo-dev/src/osmo-ci/scripts/jenkins-gerrit/./comment_generate.py", line 46, in stage_binpkgs_from_url content = response.read().decode("utf-8") ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ UnicodeDecodeError: 'utf-8' codec can't decode byte 0xef in position 237446: invalid continuation byte Change-Id: If398037272c2de54c359ea8d907b35f6fb1e2b8b --- M scripts/jenkins-gerrit/comment_generate.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/scripts/jenkins-gerrit/comment_generate.py b/scripts/jenkins-gerrit/comment_generate.py index c81011f..ff5a92a 100755 --- a/scripts/jenkins-gerrit/comment_generate.py +++ b/scripts/jenkins-gerrit/comment_generate.py @@ -43,7 +43,7 @@ url = f"{job_url}/consoleText" print(f"Reading {url}") with urllib.request.urlopen(url) as response: - content = response.read().decode("utf-8") + content = response.read().decode("utf-8", errors="ignore") match = re_distro.search(content) assert match, f"couldn't find distro name in log: {url}" return match.group(1) -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40912?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: If398037272c2de54c359ea8d907b35f6fb1e2b8b Gerrit-Change-Number: 40912 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 weeks, 1 day

1
0
0 0

[XS] Change in osmo-ci[master]: jenkins-gerrit: binpkgs: ignore decode errors

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40912?usp=email ) Change subject: jenkins-gerrit: binpkgs: ignore decode errors ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40912?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: If398037272c2de54c359ea8d907b35f6fb1e2b8b Gerrit-Change-Number: 40912 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Aug 2025 10:18:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 weeks, 1 day

1
0
0 0

[XS] Change in osmo-ci[master]: jenkins-gerrit: binpkgs: ignore decode errors

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40912?usp=email ) Change subject: jenkins-gerrit: binpkgs: ignore decode errors ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40912?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: If398037272c2de54c359ea8d907b35f6fb1e2b8b Gerrit-Change-Number: 40912 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Aug 2025 10:17:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 weeks, 1 day

1
0
0 0

[XS] Change in osmo-ci[master]: jenkins-gerrit: print the URLs this script reads

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40911?usp=email ) Change subject: jenkins-gerrit: print the URLs this script reads ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40911?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic0e7fc0e5a82927fc9ef6ec02c374b1ec7dd73e5 Gerrit-Change-Number: 40911 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Aug 2025 10:16:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 weeks, 1 day

1
0
0 0

[XS] Change in osmo-ci[master]: jenkins-gerrit: print the URLs this script reads

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40911?usp=email ) Change subject: jenkins-gerrit: print the URLs this script reads ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40911?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic0e7fc0e5a82927fc9ef6ec02c374b1ec7dd73e5 Gerrit-Change-Number: 40911 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Aug 2025 10:16:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 weeks, 1 day

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2025