Attention is currently required from: osmith.
laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmocore/+/40920?usp=email )
Change subject: VTY: Initialize fields of struct cmd_element in order of declaration
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40920?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: osmith/1.11.2
Gerrit-Change-Id: Ifaa31980f149f9c1f1a9b28f318a4850f6855472
Gerrit-Change-Number: 40920
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 27 Aug 2025 07:20:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: dexter.
osmith has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/40936?usp=email )
Change subject: contrib: add a tool to parse the SIMA response from an eUICC
......................................................................
Patch Set 1:
(4 comments)
File contrib/sima-response-tool.py:
https://gerrit.osmocom.org/c/pysim/+/40936/comment/ef39092f_02ef0a29?usp=em… :
PS1, Line 57: 8 : 'template-not-supported',
: 9 : 'feature-not-supported',
```suggestion
8 : 'lib-not-supported',
9 : 'template-not-supported',
```
https://gerrit.osmocom.org/c/pysim/+/40936/comment/a8664bda_356868c9?usp=em… :
PS1, Line 74: propritary
```suggestion
return "%d = %04x (proprietary)" % (status, status)
```
(same typo in other places in this file)
https://gerrit.osmocom.org/c/pysim/+/40936/comment/cc8717fb_99af552b?usp=em… :
PS1, Line 77: return "%d (unknown, propritary?)" % (status, status)
contrib/sima-response-tool.py:77:11: E1305: Too many arguments for format string (too-many-format-args)
https://gerrit.osmocom.org/c/pysim/+/40936/comment/7a0dd315_06111ac3?usp=em… :
PS1, Line 93: if euicc_response_decoded.get('profileInstallationAborted', False) is None:
Is comparing against `is None` correct here? I wonder if it should be compared against `is True` as the print then says `True`.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/40936?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ida4c3c5446653b283a3869c0c387f328ae51e55e
Gerrit-Change-Number: 40936
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 27 Aug 2025 06:57:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: daniel, fixeria.
osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-bsc/+/40933?usp=email )
Change subject: Fix building for debian 13 armv7l
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> I agree that `unsigned long int` would be better, but this is a cherry-pick from a patch that has al […]
Thanks for pointing this out. But yes, this is cherry-picked from master so it would not make sense to change the patch here.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/40933?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bsc
Gerrit-Branch: osmith/1.13.1
Gerrit-Change-Id: I416b31dd11a82ad52f6a662d7e099123a5c77fff
Gerrit-Change-Number: 40933
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 27 Aug 2025 06:27:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>
Attention is currently required from: osmith.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-msc/+/40932?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: Bump version: 1.13.0.24-e1389 → 1.14.0
......................................................................
Bump version: 1.13.0.24-e1389 → 1.14.0
Change-Id: I1256e2485a846bc0c2fe53b4b1731956396a84c6
---
M debian/changelog
1 file changed, 40 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/32/40932/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/40932?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I1256e2485a846bc0c2fe53b4b1731956396a84c6
Gerrit-Change-Number: 40932
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>