August 2025 - gerrit-log - lists.osmocom.org

[XS] Change in libosmocore[osmith/1.11.2]: VTY: Initialize fields of struct cmd_element in order of declaration

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmocore/+/40920?usp=email ) Change subject: VTY: Initialize fields of struct cmd_element in order of declaration ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40920?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: osmith/1.11.2 Gerrit-Change-Id: Ifaa31980f149f9c1f1a9b28f318a4850f6855472 Gerrit-Change-Number: 40920 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: jolly <andreas(a)eversberg.eu> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 26 Aug 2025 19:58:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 weeks, 6 days

1
0
0 0

[XS] Change in libosmocore[osmith/1.11.2]: Makefile: fix doc/vty race condition

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmocore/+/40919?usp=email ) Change subject: Makefile: fix doc/vty race condition ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40919?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: osmith/1.11.2 Gerrit-Change-Id: If9029059ac60060bdb14f5629f50836166e3afd7 Gerrit-Change-Number: 40919 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 26 Aug 2025 19:57:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 weeks, 6 days

1
0
0 0

[XL] Change in libosmo-netif[master]: bring twjit into libosmo-netif

by falconia

Attention is currently required from: fixeria, jolly, laforge, pespin. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email ) Change subject: bring twjit into libosmo-netif ...................................................................... Patch Set 6: (1 comment) File include/osmocom/netif/twjit.h: https://gerrit.osmocom.org/c/libosmo-netif/+/39280/comment/3f29a244_3e59f0f… : PS6, Line 50: struct osmo_twjit_config { > @falcon@freecalypso. […] @pespin@sysmocom.de: your proposal would not work for twjit config because it would break vty, or more precisely, network operators' ability to tune twjit settings in their network elements. Right now tw-border-mgw and tw-e1abis-mgw have twjit nodes in their vty config trees, and the same would need to happen in OsmoBTS if it were equipped with ability to use twrtp+twjit instead of ortp. Each block of twjit tunable settings in a network element's vty config tree corresponds to a twjit config struct somewhere in that network element app's data structures. Removing app-visible config structure and having tuning APIs banging directly on twjit/twrtp instances won't work, as there is only one vty-managed twjit config struct per app (or multiple as makes sense for that app, such as GSM vs PSTN in tw-border-mgw), but many more instances of twrtp with twjit. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ia3be5834571ca18b68939abbcf1ce3a879156658 Gerrit-Change-Number: 39280 Gerrit-PatchSet: 6 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 26 Aug 2025 19:53:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

3 weeks, 6 days

1
0
0 0

[XS] Change in libosmo-sigtran[master]: sccp: Allow osmo_sccp_instance_destroy(NULL)

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40937?usp=email ) Change subject: sccp: Allow osmo_sccp_instance_destroy(NULL) ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40937?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ib1c995ed5ad57bc88bd845d10b31fa88488f7849 Gerrit-Change-Number: 40937 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 26 Aug 2025 19:49:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 weeks, 6 days

1
0
0 0

[M] Change in osmo-bsc[master]: Fix missing LAC/CI hashtable update upon CTRL SET

by keith

Attention is currently required from: fixeria, laforge, pespin. keith has posted comments on this change by keith. ( https://gerrit.osmocom.org/c/osmo-bsc/+/40917?usp=email ) Change subject: Fix missing LAC/CI hashtable update upon CTRL SET ...................................................................... Patch Set 8: Verified+1 (1 comment) File src/osmo-bsc/bts.c: https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/1dbf6cb0_e4d54141?usp… : PS6, Line 769: return > Done Yeah, not that it matters, but other similar functions seem to be defined as int and returned 0 unconditionally, so I just followed suit. Actually, in patch set 1, I did check the return value (at least from the vty) - yes, assuming maybe in the future we may not return 0, but due to warnings about control reaching end of non void function, I thought it was better to just remove the check for return value rather than checking it, returning OK and then returning OK anyway.. seemed more ugly, anyway.. They are void now so all good for the time being. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/40917?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If9509534bd4a75f8ed8fb3e0a6bec701c7596861 Gerrit-Change-Number: 40917 Gerrit-PatchSet: 8 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 26 Aug 2025 18:24:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

3 weeks, 6 days

1
0
0 0

[XS] Change in libosmo-sigtran[master]: sccp: Allow osmo_sccp_instance_destroy(NULL)

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40937?usp=email ) Change subject: sccp: Allow osmo_sccp_instance_destroy(NULL) ...................................................................... sccp: Allow osmo_sccp_instance_destroy(NULL) Change-Id: Ib1c995ed5ad57bc88bd845d10b31fa88488f7849 --- M src/sccp_instance.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/37/40937/1 diff --git a/src/sccp_instance.c b/src/sccp_instance.c index 1a9e02c..f5b056f 100644 --- a/src/sccp_instance.c +++ b/src/sccp_instance.c @@ -337,6 +337,9 @@ { struct osmo_sccp_user *scu, *scu2; + if (!inst) + return; + inst->ss7->sccp = NULL; osmo_ss7_user_unregister(inst->ss7, MTP_SI_SCCP, inst->ss7_user); osmo_ss7_user_destroy(inst->ss7_user); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40937?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ib1c995ed5ad57bc88bd845d10b31fa88488f7849 Gerrit-Change-Number: 40937 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

3 weeks, 6 days

1
0
0 0

[XS] Change in osmo-bsc[osmith/1.13.1]: Fix building for debian 13 armv7l

by daniel

Attention is currently required from: osmith. daniel has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-bsc/+/40933?usp=email ) Change subject: Fix building for debian 13 armv7l ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I have always read unsigned and long as modifiers to int so I'd prefer int to be last. unsigned long int instead of unsigned int long -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/40933?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: osmith/1.13.1 Gerrit-Change-Id: I416b31dd11a82ad52f6a662d7e099123a5c77fff Gerrit-Change-Number: 40933 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 26 Aug 2025 16:36:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

3 weeks, 6 days

1
0
0 0

[M] Change in pysim[master]: contrib: add a tool to parse the SIMA response from an eUICC

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/40936?usp=email ) Change subject: contrib: add a tool to parse the SIMA response from an eUICC ...................................................................... contrib: add a tool to parse the SIMA response from an eUICC When an eUICC performs a profile installation it returns a (concatenated) series of ASN.1 encoded strings as "simaResponse". In case the profile installation fails for some reason the simaResponse contains diagnostic information to diagnose why the profile installation failed. Unfortunately there are currently no practical tools available to decode and display the information in the simaResponse. Let's add a tool for that. Related SYS#7617 Change-Id: Ida4c3c5446653b283a3869c0c387f328ae51e55e --- A contrib/sima-response-tool.py 1 file changed, 109 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/36/40936/1 diff --git a/contrib/sima-response-tool.py b/contrib/sima-response-tool.py new file mode 100755 index 0000000..fb54219 --- /dev/null +++ b/contrib/sima-response-tool.py @@ -0,0 +1,109 @@ +#!/usr/bin/env python3 + +# A tool to anylaze the eUICC simaResponse (series of EUICCResponse) +# +# (C) 2025 by Sysmocom s.f.m.c. GmbH +# All Rights Reserved +# +# This program is free software: you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation, either version 2 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see <http://www.gnu.org/licenses/>. +# +import argparse +from osmocom.utils import h2b, b2h +from osmocom.tlv import bertlv_parse_one, bertlv_encode_tag, bertlv_encode_len +from pySim.esim.saip import * + +parser = argparse.ArgumentParser(description="""Utility program to analyze the contents of an eUICC simaResponse.""") +parser.add_argument('SIMA_RESPONSE', help='Hexstring containing the simaResponse as received from the eUICC') + +def split_sima_response(sima_response): + """split an eUICC simaResponse field into a list of EUICCResponse fields""" + + remainder = sima_response + result = [] + while len(remainder): + tdict, l, v, next_remainder = bertlv_parse_one(remainder) + rawtag = bertlv_encode_tag(tdict) + rawlen = bertlv_encode_len(l) + result = result + [remainder[0:len(rawtag) + len(rawlen) + l]] + remainder = next_remainder + return result + +def analyze_status(status): + """ + Convert a status code (integer) into a human readable string + (see eUICC Profile Package: Interoperable Format Technical Specification, section 8.11) + """ + + # SIMA status codes + string_values = {0 : 'ok', + 1 : 'pe-not-supported', + 2 : 'memory-failure', + 3 : 'bad-values', + 4 : 'not-enough-memory', + 5 : 'invalid-request-format', + 6 : 'invalid-parameter', + 7 : 'runtime-not-supported', + 8 : 'template-not-supported', + 9 : 'feature-not-supported', + 10 : 'feature-not-supported', + 11 : 'pin-code-missing', + 31 : 'unsupported-profile-version'} + string_value = string_values.get(status, None) + if string_value is not None: + return "%d = %s (SIMA status code)" % (status, string_value) + + # ISO 7816 status words + if status >= 24576 and status <= 28671: + return "%d = %04x (ISO7816 status word)" % (status, status) + elif status >= 36864 and status <= 40959: + return "%d = %04x (ISO7816 status word)" % (status, status) + + # Propritary status codes + elif status >= 40960 and status <= 65535: + return "%d = %04x (propritary)" % (status, status) + + # Unknown status codes + return "%d (unknown, propritary?)" % (status, status) + +def analyze_euicc_response(euicc_response): + """Analyze and display the contents of an EUICCResponse""" + + print(" EUICCResponse: %s" % b2h(euicc_response)) + euicc_response_decoded = asn1.decode('EUICCResponse', euicc_response) + + pe_status = euicc_response_decoded.get('peStatus') + print(" peStatus:") + for s in pe_status: + print(" status: %s" % analyze_status(s.get('status'))) + print(" identification: %s" % str(s.get('identification', None))) + print(" additional-information: %s" % str(s.get('additional-information', None))) + print(" offset: %s" % str(s.get('offset', None))) + + if euicc_response_decoded.get('profileInstallationAborted', False) is None: + print(" profileInstallationAborted: True") + else: + print(" profileInstallationAborted: False") + + status_message = euicc_response_decoded.get('statusMessage', None) + print(" statusMessage: %s" % str(status_message)) + +if __name__ == '__main__': + opts = parser.parse_args() + sima_response = h2b(opts.SIMA_RESPONSE); + + print("simaResponse: %s" % b2h(sima_response)) + euicc_response_list = split_sima_response(sima_response) + + for euicc_response in euicc_response_list: + analyze_euicc_response(euicc_response) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40936?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ida4c3c5446653b283a3869c0c387f328ae51e55e Gerrit-Change-Number: 40936 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

3 weeks, 6 days

1
0
0 0

[XS] Change in osmo-sgsn[master]: debug.h: Remove unused log category DIUCS

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40935?usp=email ) Change subject: debug.h: Remove unused log category DIUCS ...................................................................... debug.h: Remove unused log category DIUCS It's used nowhere, not even defined in the initialization array of categories, because IuCS has no place in SGSN. Change-Id: I0f7c6bedaf3b7f909c3e27175ca99967492ab7c3 --- M include/osmocom/sgsn/debug.h 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/35/40935/1 diff --git a/include/osmocom/sgsn/debug.h b/include/osmocom/sgsn/debug.h index 04ba3c0..3beb365 100644 --- a/include/osmocom/sgsn/debug.h +++ b/include/osmocom/sgsn/debug.h @@ -22,7 +22,6 @@ DRANAP, DSUA, DV42BIS, - DIUCS, DSIGTRAN, DGTP, DOBJ, -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40935?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I0f7c6bedaf3b7f909c3e27175ca99967492ab7c3 Gerrit-Change-Number: 40935 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

3 weeks, 6 days

1
0
0 0

[XS] Change in osmo-bsc[osmith/1.13.1]: Bump version: 1.13.0.1-6438 → 1.13.1

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/40934?usp=email ) Change subject: Bump version: 1.13.0.1-6438 → 1.13.1 ...................................................................... Bump version: 1.13.0.1-6438 → 1.13.1 Change-Id: I4da7e79ee573b749aece8cf182aaaef44f152e68 --- M debian/changelog 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/34/40934/1 diff --git a/debian/changelog b/debian/changelog index 8b1ad98..9c5dc70 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,9 @@ +osmo-bsc (1.13.1) unstable; urgency=medium + + * Fix building for debian 13 armv7l + + -- Oliver Smith <osmith(a)sysmocom.de> Tue, 26 Aug 2025 16:39:28 +0200 + osmo-bsc (1.13.0) unstable; urgency=medium [ Pau Espin Pedrol ] -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/40934?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: osmith/1.13.1 Gerrit-Change-Id: I4da7e79ee573b749aece8cf182aaaef44f152e68 Gerrit-Change-Number: 40934 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

3 weeks, 6 days

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2025