August 2025 - gerrit-log - lists.osmocom.org

[M] Change in libosmocore[master]: Automatically increase io_uring, if too small.

by jolly

Attention is currently required from: laforge, pespin. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40725?usp=email ) Change subject: Automatically increase io_uring, if too small. ...................................................................... Patch Set 6: (6 comments) File src/core/osmo_io_internal.h: https://gerrit.osmocom.org/c/libosmocore/+/40725/comment/552ae731_981cd2ff?… : PS6, Line 116: /* ! array of rings the submitted read SQEs have been submitted */ > "have been submitted to" Done File src/core/osmo_io_uring.c: https://gerrit.osmocom.org/c/libosmocore/+/40725/comment/26394b77_0fcf72bf?… : PS6, Line 115: g_ring = calloc(1, sizeof(*g_ring)); > use talloc. Done https://gerrit.osmocom.org/c/libosmocore/+/40725/comment/4e4bec31_ca323694?… : PS6, Line 164: LOGP(DLIO, LOGL_NOTICE, "increasing io_uring size to %d.\n", g_io_uring_size); > Please put this into 1 single LOGP. Done https://gerrit.osmocom.org/c/libosmocore/+/40725/comment/916ef134_960c9bdd?… : PS6, Line 172: sqe = io_uring_get_sqe(&g_ring->ring); > so here we end up with 2 read SQEs on 2 different queues. […] I added a check, so subsequent read SQEs are never spread over different rings. https://gerrit.osmocom.org/c/libosmocore/+/40725/comment/66a64478_c9e53bf8?… : PS6, Line 527: while ((sqe = io_uring_get_sqe(iofd->u.uring.read_ring[idx])) == NULL); > that looks like a really nice tight non-blocking loop filling the CPU? Done https://gerrit.osmocom.org/c/libosmocore/+/40725/comment/3f85a947_de8c504b?… : PS6, Line 543: while ((sqe = io_uring_get_sqe(iofd->u.uring.write_ring)) == NULL); > that looks like a really nice tight non-blocking loop filling the CPU? Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40725?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id9230146acc8d54bfd44834e783c31b37bd64bca Gerrit-Change-Number: 40725 Gerrit-PatchSet: 6 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Aug 2025 07:49:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 month

1
0
0 0

[M] Change in libosmocore[master]: Automatically increase io_uring, if too small.

by jolly

Attention is currently required from: jolly, laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/40725?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Code-Review-1 by laforge, Verified+1 by Jenkins Builder Change subject: Automatically increase io_uring, if too small. ...................................................................... Automatically increase io_uring, if too small. The ring may be too small to store all SQEs before the kernel can handle them. If this happens, a new ring is allocated with twice of the size of the old ring. The old ring will not be destroyed, as it still contains uncompleted elements. Some of them may never be completed. A pointer to the current ring will be stored within the msghdr structure. It is used when cancelling an SQE. The cancellation must be performed in the same ring where it was created. It is quite unlikely that the old ring cannot store the cancellation SQE. If this happens, the kernel is given some time to handle the SQEs. The initial size of the ring can be changed via environment variable. Related: OS#6705 Change-Id: Id9230146acc8d54bfd44834e783c31b37bd64bca --- M src/core/osmo_io_internal.h M src/core/osmo_io_uring.c 2 files changed, 148 insertions(+), 40 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/25/40725/7 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40725?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id9230146acc8d54bfd44834e783c31b37bd64bca Gerrit-Change-Number: 40725 Gerrit-PatchSet: 7 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org>

1 month

1
0
0 0

[XS] Change in osmo-ci[master]: jobs/master-builds: add logger_gsmtap and enftables

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/40803?usp=email ) Change subject: jobs/master-builds: add logger_gsmtap and enftables ...................................................................... jobs/master-builds: add logger_gsmtap and enftables Change-Id: I88d8e03770e7effb49e59493d0e9ba59f75e8ddd Related: logger_gsmtap.git e06a0b9b3506e8ab1a7cfeeae72e32b2d6186989 Related: enftables.git 735602e15471eab82c93f9e2e044a4d69031ced8 --- M jobs/master-builds.yml 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml index 4b34eb2..af8432a 100644 --- a/jobs/master-builds.yml +++ b/jobs/master-builds.yml @@ -317,6 +317,14 @@ repos_url: '{gerrit_url}/erlang/{repos}' cmd: '{docker_run} {docker_img_erlang} {timeout_cmd} /build/contrib/jenkins.sh' + - logger_gsmtap: + repos_url: '{gerrit_url}/erlang/{repos}' + cmd: '{docker_run} {docker_img_erlang} {timeout_cmd} /build/contrib/jenkins.sh' + + - enftables: + repos_url: '{gerrit_url}/erlang/{repos}' + cmd: '{docker_run} {docker_img_erlang} {timeout_cmd} /build/contrib/jenkins.sh' + - osmo-e1-hardware: a2_name: JOB_TYPE a2: !!python/tuple ["firmware", "gateware", "manuals", "software"] -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40803?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I88d8e03770e7effb49e59493d0e9ba59f75e8ddd Gerrit-Change-Number: 40803 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 month

1
0
0 0

[XS] Change in osmo-ci[master]: osmo_git_clone_url(): add logger_gsmtap and enftables

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/40802?usp=email ) Change subject: osmo_git_clone_url(): add logger_gsmtap and enftables ...................................................................... osmo_git_clone_url(): add logger_gsmtap and enftables Change-Id: I495f3334a8d61a325fe6540043b07b8dababd8c6 --- M scripts/common.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/scripts/common.sh b/scripts/common.sh index 46bf9c3..fb06d70 100644 --- a/scripts/common.sh +++ b/scripts/common.sh @@ -149,7 +149,7 @@ libosmo-sccp-legacy) echo "$OSMO_GIT_URL_GITEA"/osmocom/"$1" ;; - osmo_dia2gsup|osmo-epdg|osmo-s1gw) + osmo_dia2gsup|osmo-epdg|osmo-s1gw|logger_gsmtap|enftables) echo "$OSMO_GIT_URL_GERRIT"/erlang/"$1" ;; pyosmocom) -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40802?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I495f3334a8d61a325fe6540043b07b8dababd8c6 Gerrit-Change-Number: 40802 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 month

1
0
0 0

[XS] Change in osmo-ci[master]: jobs/master-builds: add logger_gsmtap and enftables

by fixeria

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ci/+/40803?usp=email ) Change subject: jobs/master-builds: add logger_gsmtap and enftables ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ci/+/40803/comment/b729f4a6_7fb6c3d7?usp=… : PS1, Line 10: e06a0b9b3506e8ab1a7cfeeae72e32b2d6186989 > This patch (https://gerrit.osmocom.org/c/erlang/logger_gsmtap/+/40800) needs to be merged. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40803?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I88d8e03770e7effb49e59493d0e9ba59f75e8ddd Gerrit-Change-Number: 40803 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Aug 2025 07:31:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 month

1
0
0 0

[XS] Change in ...logger_gsmtap[master]: contrib/jenkins.sh: add build verification script

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/logger_gsmtap/+/40800?usp=email ) Change subject: contrib/jenkins.sh: add build verification script ...................................................................... contrib/jenkins.sh: add build verification script Change-Id: I3183112c96c92716edb4fb485621d14d531166cc --- A contrib/jenkins.sh 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: osmith: Looks good to me, approved fixeria: Verified diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh new file mode 100755 index 0000000..d58398d --- /dev/null +++ b/contrib/jenkins.sh @@ -0,0 +1,5 @@ +#!/bin/sh -ex + +rebar3 clean +rebar3 compile +rebar3 dialyzer -- To view, visit https://gerrit.osmocom.org/c/erlang/logger_gsmtap/+/40800?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/logger_gsmtap Gerrit-Branch: master Gerrit-Change-Id: I3183112c96c92716edb4fb485621d14d531166cc Gerrit-Change-Number: 40800 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 month

1
0
0 0

[XS] Change in ...logger_gsmtap[master]: contrib/jenkins.sh: add build verification script

by fixeria

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/logger_gsmtap/+/40800?usp=email ) Change subject: contrib/jenkins.sh: add build verification script ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/logger_gsmtap/+/40800?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/logger_gsmtap Gerrit-Branch: master Gerrit-Change-Id: I3183112c96c92716edb4fb485621d14d531166cc Gerrit-Change-Number: 40800 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Aug 2025 07:31:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: 5gc: Introduce test TC_periodic_registration_updating

by osmith

Attention is currently required from: laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40799?usp=email ) Change subject: 5gc: Introduce test TC_periodic_registration_updating ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40799?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I63da25a3927cb459563d4325adc690beb8a67451 Gerrit-Change-Number: 40799 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Aug 2025 07:10:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month

1
0
0 0

[XS] Change in ...logger_gsmtap[master]: logger_gsmtap.app.src: add vim modeline and syntax hint

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/logger_gsmtap/+/40801?usp=email ) Change subject: logger_gsmtap.app.src: add vim modeline and syntax hint ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/logger_gsmtap/+/40801?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/logger_gsmtap Gerrit-Branch: master Gerrit-Change-Id: Id8cd8e1ab19ed2209ff1d867a7026b7663920013 Gerrit-Change-Number: 40801 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Aug 2025 07:07:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month

1
0
0 0

[XS] Change in ...logger_gsmtap[master]: contrib/jenkins.sh: add build verification script

by osmith

Attention is currently required from: fixeria, laforge, pespin. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/logger_gsmtap/+/40800?usp=email ) Change subject: contrib/jenkins.sh: add build verification script ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/logger_gsmtap/+/40800?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/logger_gsmtap Gerrit-Branch: master Gerrit-Change-Id: I3183112c96c92716edb4fb485621d14d531166cc Gerrit-Change-Number: 40800 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Aug 2025 07:07:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2025