Attention is currently required from: fixeria, laforge, osmith, pespin.
Hello Jenkins Builder, fixeria, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-uecups/+/40788?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Code-Review+1 by fixeria, Code-Review+1 by osmith
Change subject: gtp_endpoint: Avoid deadlocks logging while thread is cancelled
......................................................................
gtp_endpoint: Avoid deadlocks logging while thread is cancelled
We cannot guarantee that LOGP will not end up calling a syscall which can
be a cancellation point. Since the syscall will be probably called while
having the logging mutex locked, an eventual cancellation of the thread
would leave the logging mutex locked forever, hence making all other
threads deadlock as soon as they try to write anything to the log.
Similar to what's already done in tun_device_thread().
Change-Id: I1e141175440402a7db34f3d246104c6ea38031fb
---
M daemon/gtp_endpoint.c
1 file changed, 25 insertions(+), 11 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-uecups refs/changes/88/40788/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/40788?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-uecups
Gerrit-Branch: master
Gerrit-Change-Id: I1e141175440402a7db34f3d246104c6ea38031fb
Gerrit-Change-Number: 40788
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: jolly, laforge.
pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40725?usp=email )
Change subject: Automatically increase io_uring, if too small.
......................................................................
Patch Set 9:
(6 comments)
Commit Message:
https://gerrit.osmocom.org/c/libosmocore/+/40725/comment/bf3fa1ff_1903038e?… :
PS9, Line 23: to determine when all submissions are completed.
Sounds like an easy thing to add right? It makes sense to implement this either her eor on a follow-up patch.
File src/core/osmo_io_internal.h:
https://gerrit.osmocom.org/c/libosmocore/+/40725/comment/b34815a0_ee55ba5c?… :
PS9, Line 110: bool read_enabled;
(At some point it may make sense to properly put all these fields into a "read" and "write" substructs in here.)
File src/core/osmo_io_uring.c:
https://gerrit.osmocom.org/c/libosmocore/+/40725/comment/09634797_688ca5a4?… :
PS9, Line 126: g_ring = talloc_zero(OTC_GLOBAL, struct osmo_io_uring);
are you sure OTC_GLOBAL is defined at this point? Or is it actually NULL?
If it's still NULL better pass NULL explicitly to avoid creating confusion.
https://gerrit.osmocom.org/c/libosmocore/+/40725/comment/afc5fac1_bb6d44e8?… :
PS9, Line 175: g_io_uring_size *= 2;
Once you move this to an unsigned, you can do "<< 1" here. BTW, I don't see you are making sure we don't go over the "maximum ring size allowed" in there, the one you are checking in previous commit.
https://gerrit.osmocom.org/c/libosmocore/+/40725/comment/6946c3e3_7a05083e?… :
PS9, Line 208: /* All subsequent read SQEs must be on the same ring. */
This should imho go inside iofd_uring_get_sqe(), based on "current_ring" being passed to it.
https://gerrit.osmocom.org/c/libosmocore/+/40725/comment/a8053e18_abe26da4?… :
PS9, Line 282: while (iofd->u.uring.reads_submitted < ((iofd->u.uring.num_read_sqes) ? : g_io_uring_read_sqes)) {
why is the g_io_uring_read_sqes reference needed here? How can iofd have num_read_sqes = 0, and if it does, why are we overriding it?
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40725?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Id9230146acc8d54bfd44834e783c31b37bd64bca
Gerrit-Change-Number: 40725
Gerrit-PatchSet: 9
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Fri, 01 Aug 2025 11:46:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
