July 2025 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: GSUP Templates: fix empty destination_name in GSUP ISD/UL
by fixeria 15 Jul '25

15 Jul '25

Attention is currently required from: lynxis lazus. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40666?usp=email ) Change subject: GSUP Templates: fix empty destination_name in GSUP ISD/UL ...................................................................... Patch Set 2: Code-Review-1 (4 comments) File library/GSUP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40666/comment/d1f6a494_e440… : PS2, Line 421: omit This change makes no sense to me, since `ts_GSUP_UL_RES` cannot yield `omit`. It's always a value. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40666/comment/54e7c42c_6aba… : PS2, Line 437: omit This change makes no sense to me, since `ts_GSUP_UL_RES` cannot yield `omit`. It's always a value. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40666/comment/3a50ba04_7928… : PS2, Line 447: omit likewise, it should be `(value)` https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40666/comment/4a5928f6_c6ad… : PS2, Line 448: template (omit) octetstring source_name := omit, : please fix alignment here -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40666?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia89b5a82665e407fa578e5209fbcde0676326df0 Gerrit-Change-Number: 40666 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 15 Jul 2025 19:25:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-sgsn[master]: routing area: sgsn_ra_geran_page_ra: make argument rai const
by fixeria 15 Jul '25

15 Jul '25

Attention is currently required from: lynxis lazus. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40693?usp=email ) Change subject: routing area: sgsn_ra_geran_page_ra: make argument rai const ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40693?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I21d7e66e433f2b891c94bae91697aa46198fb20c Gerrit-Change-Number: 40693 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 15 Jul 2025 19:19:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-sgsn[master]: routing area: add LOGRA() logging macro
by fixeria 15 Jul '25

15 Jul '25

Attention is currently required from: lynxis lazus. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40692?usp=email ) Change subject: routing area: add LOGRA() logging macro ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File include/osmocom/sgsn/gprs_routing_area.h: https://gerrit.osmocom.org/c/osmo-sgsn/+/40692/comment/ddde6498_651b707f?us… : PS2, Line 16: osmo_rai_name2_buf Why not using `osmo_rai_name2()` here? I guess to allow the macro user to use it? -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40692?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ib287b70c34b21ce64bc864f69fcf6af5fa0698b9 Gerrit-Change-Number: 40692 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 15 Jul 2025 19:18:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-sgsn[master]: routing area: on alloc, check if RA already exists
by fixeria 15 Jul '25

15 Jul '25

Attention is currently required from: lynxis lazus. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40691?usp=email ) Change subject: routing area: on alloc, check if RA already exists ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/sgsn/gprs_routing_area.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/40691/comment/af9d1177_c12835db?us… : PS2, Line 88: LOGL_ERROR Is this supposed to happen regularly? If so, `LOGL_ERROR` looks too verbose. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40691?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I6955a09d9d8f3ba4dc3a14d7ed5cd9798d929c61 Gerrit-Change-Number: 40691 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 15 Jul 2025 19:15:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-sgsn[master]: routing area: move cell.cell_id behind a geran union
by fixeria 15 Jul '25

15 Jul '25

Attention is currently required from: lynxis lazus. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40690?usp=email ) Change subject: routing area: move cell.cell_id behind a geran union ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40690?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I0c24d98dd699748842dca271b93e58d27cf02285 Gerrit-Change-Number: 40690 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 15 Jul 2025 19:09:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-sgsn[master]: use variable name rai for `struct osmo_routing_area_id`
by fixeria 15 Jul '25

15 Jul '25

Attention is currently required from: lynxis lazus. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40689?usp=email ) Change subject: use variable name rai for `struct osmo_routing_area_id` ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40689?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I946983d4857035e06c68af378654466b35025014 Gerrit-Change-Number: 40689 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 15 Jul 2025 19:07:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-sgsn[master]: routing area: introduce ran_type on the RA
by fixeria 15 Jul '25

15 Jul '25

Attention is currently required from: lynxis lazus. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40688?usp=email ) Change subject: routing area: introduce ran_type on the RA ...................................................................... Patch Set 2: (6 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-sgsn/+/40688/comment/d126487f_2539ae64?us… : PS2, Line 9: unique uniquely File include/osmocom/sgsn/gprs_routing_area.h: https://gerrit.osmocom.org/c/osmo-sgsn/+/40688/comment/1dbf809b_efb97065?us… : PS2, Line 35: 2x PCU serves you mean "more than one PCU" here? https://gerrit.osmocom.org/c/osmo-sgsn/+/40688/comment/0bdd8b3f_9d9e66d0?us… : PS2, Line 38: individual individually https://gerrit.osmocom.org/c/osmo-sgsn/+/40688/comment/5f219d2a_d911cd33?us… : PS2, Line 39: has have https://gerrit.osmocom.org/c/osmo-sgsn/+/40688/comment/9ee676e4_1745282c?us… : PS2, Line 47: which are alive maybe call it `alive_cells` or `cells_alive` then? File src/sgsn/gprs_routing_area.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/40688/comment/ce3b8e2d_c492ea83?us… : PS2, Line 201: valid for GERAN If some API is GERAN specific, maybe function names should reflect that? Otherwise you don't know without looking at the function definition... -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40688?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I59c35f1a4912ff11574bb31e4fe424816993548c Gerrit-Change-Number: 40688 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 15 Jul 2025 19:05:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-sgsn[master]: ranap: split mmctx related iu events into own function
by fixeria 15 Jul '25

15 Jul '25

Attention is currently required from: lynxis lazus. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40699?usp=email ) Change subject: ranap: split mmctx related iu events into own function ...................................................................... Patch Set 1: (1 comment) File src/sgsn/gprs_ranap.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/40699/comment/9bc2b1e8_e1f9d0e5?us… : PS1, Line 205: new_area unused -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40699?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ie6f131d29da299f09e897240ec5c39a395ce6f1b Gerrit-Change-Number: 40699 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 15 Jul 2025 18:57:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-sgsn[master]: mmctx: LOGIUP: allow ue to be NULL
by fixeria 15 Jul '25

15 Jul '25

Attention is currently required from: lynxis lazus. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40698?usp=email ) Change subject: mmctx: LOGIUP: allow ue to be NULL ...................................................................... Patch Set 1: Code-Review+1 (2 comments) File include/osmocom/sgsn/mmctx.h: https://gerrit.osmocom.org/c/osmo-sgsn/+/40698/comment/11e6652f_daa74cd4?us… : PS1, Line 236: ue->conn_id idea for a separate patch: `(ue)->conn_id` https://gerrit.osmocom.org/c/osmo-sgsn/+/40698/comment/ebc8f6b0_c2589a6a?us… : PS1, Line 238: {} I would not print curly braces in the case of `NULL` at all. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40698?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ie569fa100abe518cb63c1b918ad7748a7ea3bb99 Gerrit-Change-Number: 40698 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 15 Jul 2025 18:54:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: xua_default_lm_fsm: Activate all ASPs in tmode broadcast/loadshare/ro...
by fixeria 15 Jul '25

15 Jul '25

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40697?usp=email ) Change subject: xua_default_lm_fsm: Activate all ASPs in tmode broadcast/loadshare/roundrobin ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/xua_default_lm_fsm.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/40697/comment/df13f97d_d7ecc… : PS1, Line 253: alreasy typo: alrea[d]y -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40697?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I548b88fa70b308033cb225623e803b731755651e Gerrit-Change-Number: 40697 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Jul 2025 18:51:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0