July 2025 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: Cosmetic: deps/Makefile: update comments
by osmith 24 Jul '25

24 Jul '25

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40741?usp=email ) Change subject: Cosmetic: deps/Makefile: update comments ...................................................................... Cosmetic: deps/Makefile: update comments Remove the part about caching logic of docker containers, as most testsuites don't use docker-playground anymore. The main reason for using commits here is that we have exact commits when doing regression testing. Replace the verbose license header with the SPDX version while at it. Change-Id: I7eddc64aeab20292922ba013221679dfe952ff45 --- M deps/Makefile 1 file changed, 3 insertions(+), 16 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/41/40741/1 diff --git a/deps/Makefile b/deps/Makefile index 0792c09..8739abc 100644 --- a/deps/Makefile +++ b/deps/Makefile @@ -1,17 +1,6 @@ # Copyright 2017 Harald Welte # Copyright 2018 sysmocom - s.f.m.c. GmbH -# -# Licensed under the Apache License, Version 2.0 (the "License"); -# you may not use this file except in compliance with the License. -# You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. +# SPDX-License-Identifier: Apache-2.0 ECLIPSEGITLAB:=https://gitlab.eclipse.org/eclipse/titan OSMOGITHUB:=https://github.com/osmocom @@ -81,10 +70,8 @@ $(OSMOGITEA_REPOS) \ $(FORKEDGITLAB_REPOS) -# Tag names from 'git-describe --tags'; if not available, a commit hash may be used instead. -# Do not put references to branches here, except for local testing: this breaks the caching -# logic of docker containers, which only invalidate their cached ttcn3 dependencies if this -# file changed. +# Use tag names from 'git describe --tags' or commit hashes. This way we get +# exact commits of deps when doing regression testing. nas_commit= eff069b772a53e16773638f07599e7936ffcdd9a titan.Libraries.TCCUsefulFunctions_commit= R.35.B-6-gb3687da titan.ProtocolEmulations.M3UA_commit= b58f92046e48a7b1ed531e243a2319ebca53bf4c -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40741?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7eddc64aeab20292922ba013221679dfe952ff45 Gerrit-Change-Number: 40741 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[L] Change in osmo-ttcn3-hacks[master]: 5gc: Support PDU Session Establishment procedure
by osmith 24 Jul '25

24 Jul '25

Attention is currently required from: fixeria, jolly, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40445?usp=email ) Change subject: 5gc: Support PDU Session Establishment procedure ...................................................................... Patch Set 4: Code-Review+1 (1 comment) File 5gc/C5G_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40445/comment/d28db1a8_8fa9… : PS2, Line 469: //setup_req_transf := dec_NGAP_PDUSessionResourceSetupRequestTransfer(it.pDUSessionResourceSetupRequestTransfer); > I don't know something specifically, but for sure ffasn1c-generated code can point to exactly the by […] Done (see https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40730/2?usp=related-change) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40445?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If0769afd07a4bae7778d7a7c347cebaa5909b5f8 Gerrit-Change-Number: 40445 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Jul 2025 07:33:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: add config file for ruff linter: ruff.toml
by neels 23 Jul '25

23 Jul '25

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/40740?usp=email ) Change subject: add config file for ruff linter: ruff.toml ...................................................................... add config file for ruff linter: ruff.toml Change-Id: I9ca385eef9e6831a49f61456aa24492d4fa2ec17 --- A ruff.toml 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/40/40740/1 diff --git a/ruff.toml b/ruff.toml new file mode 100644 index 0000000..a2e281b --- /dev/null +++ b/ruff.toml @@ -0,0 +1,8 @@ +[lint] +ignore = [ + "E741", + + "F403", + "F405", + "E713", +] -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40740?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9ca385eef9e6831a49f61456aa24492d4fa2ec17 Gerrit-Change-Number: 40740 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>

1 0

[L] Change in pysim[master]: personalization: add param_source.py, implement batch personalization
by neels 23 Jul '25

23 Jul '25

Attention is currently required from: neels. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/40096?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: personalization: add param_source.py, implement batch personalization ...................................................................... personalization: add param_source.py, implement batch personalization Implement pySim.esim.saip.personalization.BatchPersonalization, generating N eSIM profiles from a preset configuration. Batch parameters can be fed by a constant, incrementing, random or from CSV rows: add pySim.esim.saip.param_source.* classes to feed such input to each of the BatchPersonalization's ConfigurableParameter instances. Related: SYS#6768 Change-Id: I497c60c101ea0eea980e8b1a4b1f36c0eda39002 --- A pySim/esim/saip/param_source.py M pySim/esim/saip/personalization.py 2 files changed, 280 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/96/40096/5 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40096?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I497c60c101ea0eea980e8b1a4b1f36c0eda39002 Gerrit-Change-Number: 40096 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>

1 0

[M] Change in pysim[master]: [2/6] personalization: refactor ConfigurableParameter, Iccid, Imsi
by neels 23 Jul '25

23 Jul '25

Attention is currently required from: dexter, fixeria. Hello Jenkins Builder, dexter, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/39742?usp=email to look at the new patch set (#11). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: [2/6] personalization: refactor ConfigurableParameter, Iccid, Imsi ...................................................................... [2/6] personalization: refactor ConfigurableParameter, Iccid, Imsi Main points/rationales of the refactoring, details below: 1) common validation implementation 2) offer classmethods The new features are optional, and will be heavily used by batch personalization patches coming soon. Implement Iccid and Imsi to use the new way, with a common abstract DecimalParam implementation. So far leave the other parameter classes working as they always did, to follow suit in subsequent commits. Details: 1) common validation implementation: There are very common validation steps in the various parameter implementations. It is more convenient and much more readable to implement those once and set simple validation parameters per subclass. So there now is a validate_val() classmethod, which subclasses can use as-is to apply the validation parameters -- or subclasses can override their cls.validate_val() for specialized validation. (Those subclasses that this patch doesn't touch still override the self.validate() instance method. Hence they still work as before this patch, but don't use the new common features yet.) 2) offer stateless classmethods: It is useful for... - batch processing of multiple profiles (in upcoming patches) and - user input validation to be able to have classmethods that do what self.validate() and self.apply() do, but do not modify any self.* members. So far the paradigm was to create a class instance to keep state about the value. This remains available, but in addition we make available the paradigm of a singleton that is stateless (the classmethods). Using self.validate() and self.apply() still work the same as before this patch, i.e. via self.input_value and self.value -- but in addition, there are now classmethods that don't touch self.* members. Related: SYS#6768 Change-Id: I6522be4c463e34897ca9bff2309b3706a88b3ce8 --- M pySim/esim/saip/personalization.py 1 file changed, 179 insertions(+), 34 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/42/39742/11 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39742?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6522be4c463e34897ca9bff2309b3706a88b3ce8 Gerrit-Change-Number: 39742 Gerrit-PatchSet: 11 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[L] Change in pysim[master]: personalization: make sense of SdKey subclasses
by neels 23 Jul '25

23 Jul '25

Attention is currently required from: neels. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/40205?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: personalization: make sense of SdKey subclasses ...................................................................... personalization: make sense of SdKey subclasses After a call with Harald, I think I finally understand what SdKey subclasses we need. Change-Id: I8c9e6095e200103d2e1779964be06fff63c5cebf --- M pySim/esim/saip/personalization.py M tests/unittests/test_esim_saip.py 2 files changed, 312 insertions(+), 59 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/05/40205/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40205?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8c9e6095e200103d2e1779964be06fff63c5cebf Gerrit-Change-Number: 40205 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: add lint_pylint.sh
by neels 23 Jul '25

23 Jul '25

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/40739?usp=email ) Change subject: add lint_pylint.sh ...................................................................... add lint_pylint.sh Change-Id: I0aeb38604909bbc7d3daaa83cf2088e9e62a23f9 --- A lint_pylint.sh 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/39/40739/1 diff --git a/lint_pylint.sh b/lint_pylint.sh new file mode 100755 index 0000000..1835354 --- /dev/null +++ b/lint_pylint.sh @@ -0,0 +1,2 @@ +#!/bin/sh +python3 -m pylint -j0 --errors-only --disable E1102 --disable E0401 --enable W0301 pySim -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40739?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0aeb38604909bbc7d3daaa83cf2088e9e62a23f9 Gerrit-Change-Number: 40739 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>

1 0

[L] Change in osmo-ttcn3-hacks[master]: 5gc: Support PDU Session Establishment procedure
by pespin 23 Jul '25

23 Jul '25

Attention is currently required from: fixeria, jolly, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40445?usp=email ) Change subject: 5gc: Support PDU Session Establishment procedure ...................................................................... Patch Set 4: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40445?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If0769afd07a4bae7778d7a7c347cebaa5909b5f8 Gerrit-Change-Number: 40445 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 23 Jul 2025 20:35:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[XS] Change in ...osmo-s1gw[master]: gtpu_kpi_cfg/0: fix typo in env param name
by fixeria 23 Jul '25

23 Jul '25

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40738?usp=email ) Change subject: gtpu_kpi_cfg/0: fix typo in env param name ...................................................................... gtpu_kpi_cfg/0: fix typo in env param name Change-Id: I3afa1ebb864f8e3cb81d08a4562bb55181753f0f Fixes: 0abdf91 ("Rename enft_kpi -> gtpu_kpi") --- M src/osmo_s1gw_sup.erl 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo_s1gw_sup.erl b/src/osmo_s1gw_sup.erl index 2077094..50bd682 100644 --- a/src/osmo_s1gw_sup.erl +++ b/src/osmo_s1gw_sup.erl @@ -117,7 +117,7 @@ -spec gtpu_kpi_cfg() -> gtpu_kpi:cfg(). gtpu_kpi_cfg() -> - #{enable => osmo_s1gw:get_env(gput_kpi_enable, ?ENV_DEFAULT_GTPU_KPI_ENABLE), + #{enable => osmo_s1gw:get_env(gtpu_kpi_enable, ?ENV_DEFAULT_GTPU_KPI_ENABLE), table_name => osmo_s1gw:get_env(gtpu_kpi_table_name, ?ENV_DEFAULT_GTPU_KPI_TABLE_NAME), interval => osmo_s1gw:get_env(gtpu_kpi_interval, ?ENV_DEFAULT_GTPU_KPI_INTERVAL)}. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40738?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I3afa1ebb864f8e3cb81d08a4562bb55181753f0f Gerrit-Change-Number: 40738 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in ...osmo-s1gw[master]: gtpu_kpi_cfg/0: fix typo in env param name
by pespin 23 Jul '25

23 Jul '25

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40738?usp=email ) Change subject: gtpu_kpi_cfg/0: fix typo in env param name ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40738?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I3afa1ebb864f8e3cb81d08a4562bb55181753f0f Gerrit-Change-Number: 40738 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 23 Jul 2025 19:25:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0