July 2025 - gerrit-log - lists.osmocom.org

[S] Change in libosmocore[master]: linuxlist.h: add llist_last_entry_or_null macro
by pespin 23 Jul '25

23 Jul '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/40724?usp=email ) Change subject: linuxlist.h: add llist_last_entry_or_null macro ...................................................................... linuxlist.h: add llist_last_entry_or_null macro Related: OS#6705 Change-Id: Iaa5c8900434fe327a9c8b072182624a7fbfb369c --- M include/osmocom/core/linuxlist.h 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/include/osmocom/core/linuxlist.h b/include/osmocom/core/linuxlist.h index 2fc3fa7..8c8b1bc 100644 --- a/include/osmocom/core/linuxlist.h +++ b/include/osmocom/core/linuxlist.h @@ -254,6 +254,16 @@ #define llist_first_entry_or_null(ptr, type, member) \ (!llist_empty(ptr) ? llist_first_entry(ptr, type, member) : NULL) +/*! Get the last element from a list, or NULL. + * \param ptr the list head to take the element from. + * \param type the type of the struct this is embedded in. + * \param member the name of the list_head within the struct. + * + * Note that if the list is empty, it returns NULL. + */ +#define llist_last_entry_or_null(ptr, type, member) \ + (!llist_empty(ptr) ? llist_last_entry(ptr, type, member) : NULL) + /*! Iterate over a linked list. * \param pos the llist_head to use as a loop counter. * \param head the head of the list over which to iterate. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40724?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iaa5c8900434fe327a9c8b072182624a7fbfb369c Gerrit-Change-Number: 40724 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: ngap: Fix deviation in ASN1 from TS 38.413 version 17.5.0
by pespin 23 Jul '25

23 Jul '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40729?usp=email ) Change subject: ngap: Fix deviation in ASN1 from TS 38.413 version 17.5.0 ...................................................................... ngap: Fix deviation in ASN1 from TS 38.413 version 17.5.0 I originally copied the ASN1 files from https://forge.etsi.org/rep/int/5g-core/ngap.git directory ttcn/LibNGAP/lib/asn1, commit fa43d01e202379a969e991a9454d9c6c6930b5b5. Apparently one file contained a deviation from the 3GPP content and it was also fixed in ngap.git in 47e7239dd80f2f12a4cbcdd7977ca0a32356f3be. I found out this problem when trying to use this ASN1 file to generate new libfftranscode, which then failed to properly decode DownlinkNASTransport due to the deviation. Change-Id: I7d127998ea162a392f3381ebb1d198ad3c783a56 --- M library/ngap/NGAP_PDU_Descriptions.asn 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/library/ngap/NGAP_PDU_Descriptions.asn b/library/ngap/NGAP_PDU_Descriptions.asn index d8dbd98..dcf4704 100644 --- a/library/ngap/NGAP_PDU_Descriptions.asn +++ b/library/ngap/NGAP_PDU_Descriptions.asn @@ -266,7 +266,7 @@ InitiatingMessage ::= SEQUENCE { procedureCode NGAP-ELEMENTARY-PROCEDURE.&procedureCode ({NGAP-ELEMENTARY-PROCEDURES}), criticality NGAP-ELEMENTARY-PROCEDURE.&criticality ({NGAP-ELEMENTARY-PROCEDURES}{@procedureCode}), - value NGAP-ELEMENTARY-PROCEDURE.&InitiatingMessage ({NGAP-ELEMENTARY-PROCEDURES}{@procedureCode}) OPTIONAL + value NGAP-ELEMENTARY-PROCEDURE.&InitiatingMessage ({NGAP-ELEMENTARY-PROCEDURES}{@procedureCode}) } SuccessfulOutcome ::= SEQUENCE { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40729?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7d127998ea162a392f3381ebb1d198ad3c783a56 Gerrit-Change-Number: 40729 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: ngap: Fix deviation in ASN1 from TS 38.413 version 17.5.0
by pespin 23 Jul '25

23 Jul '25

Attention is currently required from: laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40729?usp=email ) Change subject: ngap: Fix deviation in ASN1 from TS 38.413 version 17.5.0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40729?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7d127998ea162a392f3381ebb1d198ad3c783a56 Gerrit-Change-Number: 40729 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 23 Jul 2025 13:30:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in docker-playground[master]: titan: upgrade to libfftranscode 0.6 (updated NGAP ASN.1 to V17.5.0)
by pespin 23 Jul '25

23 Jul '25

Attention is currently required from: laforge. pespin has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/docker-playground/+/40734?usp=email ) Change subject: titan: upgrade to libfftranscode 0.6 (updated NGAP ASN.1 to V17.5.0) ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > @pespin@sysmocom. […] I manually tested it still worked fine with successful tests, but it was still failing with the specific error I found, but now after looking at libfftranscode I know it's most probably due to the fact that the struct that had to be decoded/encoded was not a PDU struct but a IEs one. Hence a new API would be needed to decode/encode that. I decided to use the native ttcn3 APER dec/enc instead in order to avoid havign to add more APIs, which worked fine. Still, a lot of stuff has changed since NGAP revision 16 to 17, so I think it makes sense to have an updated one in case we want to test something with it. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/40734?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I56034ef75cd6cca88fc9d353e097086bce6d639c Gerrit-Change-Number: 40734 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 23 Jul 2025 13:29:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: Dockerfile: upgrade to libfftranscode 0.6 (updated NGAP ASN.1 to V17....
by pespin 23 Jul '25

23 Jul '25

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40737?usp=email ) Change subject: Dockerfile: upgrade to libfftranscode 0.6 (updated NGAP ASN.1 to V17.5.0) ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > FYI: after this is merged, https://jenkins.osmocom. […] Triggered here: https://jenkins.osmocom.org/jenkins/job/registry-rebuild-upload-testenv/20/ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40737?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I57c2f9adbb2f691f28ab936f09db3c24bdfeef5f Gerrit-Change-Number: 40737 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 23 Jul 2025 13:28:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: Dockerfile: upgrade to libfftranscode 0.6 (updated NGAP ASN.1 to V17....
by pespin 23 Jul '25

23 Jul '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40737?usp=email ) Change subject: Dockerfile: upgrade to libfftranscode 0.6 (updated NGAP ASN.1 to V17.5.0) ...................................................................... Dockerfile: upgrade to libfftranscode 0.6 (updated NGAP ASN.1 to V17.5.0) Change-Id: I57c2f9adbb2f691f28ab936f09db3c24bdfeef5f --- M _testenv/data/podman/Dockerfile 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/_testenv/data/podman/Dockerfile b/_testenv/data/podman/Dockerfile index 3c241dc..e94812a 100644 --- a/_testenv/data/podman/Dockerfile +++ b/_testenv/data/podman/Dockerfile @@ -126,11 +126,12 @@ ENV USE_CCACHE=0 # Binary-only transcoding library for RANAP/RUA/HNBAP to work around TITAN only implementing BER +ENV LIBFFTRANSCODE_VERSION="0.6" RUN set -x && \ export DPKG_ARCH="$(dpkg --print-architecture)" && \ - wget https://ftp.osmocom.org/binaries/libfftranscode/libfftranscode0_0.5_${DPKG_… && \ - wget https://ftp.osmocom.org/binaries/libfftranscode/libfftranscode-dev_0.5_${DP… && \ - dpkg -i ./libfftranscode0_0.5_${DPKG_ARCH}.deb ./libfftranscode-dev_0.5_${DPKG_ARCH}.deb && \ + wget https://ftp.osmocom.org/binaries/libfftranscode/libfftranscode0_${LIBFFTRAN… && \ + wget https://ftp.osmocom.org/binaries/libfftranscode/libfftranscode-dev_${LIBFFT… && \ + dpkg -i ./libfftranscode0_${LIBFFTRANSCODE_VERSION}_${DPKG_ARCH}.deb ./libfftranscode-dev_${LIBFFTRANSCODE_VERSION}_${DPKG_ARCH}.deb && \ apt-get install --fix-broken && \ rm libfftranscode*.deb -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40737?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I57c2f9adbb2f691f28ab936f09db3c24bdfeef5f Gerrit-Change-Number: 40737 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: Dockerfile: upgrade to libfftranscode 0.6 (updated NGAP ASN.1 to V17....
by pespin 23 Jul '25

23 Jul '25

Attention is currently required from: laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40737?usp=email ) Change subject: Dockerfile: upgrade to libfftranscode 0.6 (updated NGAP ASN.1 to V17.5.0) ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > has the new libfftranscode version been manually tested to fix the issue it was created for? I just […] I manually tested it still worked fine with successful tests, but it was still failing with the specific error I found, but now after looking at libfftranscode I know it's most probably due to the fact that the struct that had to be decoded/encoded was not a PDU struct but a IEs one. Hence a new API would be needed to decode/encode that. I decided to use the native ttcn3 APER dec/enc instead in order to avoid havign to add more APIs, which worked fine. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40737?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I57c2f9adbb2f691f28ab936f09db3c24bdfeef5f Gerrit-Change-Number: 40737 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 23 Jul 2025 13:26:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmo-cbc[master]: vty: cbc_vty_go_parent(): fix formatting
by osmith 23 Jul '25

23 Jul '25

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-cbc/+/40733?usp=email ) Change subject: vty: cbc_vty_go_parent(): fix formatting ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/40733?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: Ic6a6dcef7691358a75d9f848d4c7370526ce8f37 Gerrit-Change-Number: 40733 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 23 Jul 2025 11:59:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-cbc[master]: vty: register talloc / stats introspection commands
by osmith 23 Jul '25

23 Jul '25

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-cbc/+/40732?usp=email ) Change subject: vty: register talloc / stats introspection commands ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/40732?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I05ecc74426f68e19a18b7111ebc39ef504735d15 Gerrit-Change-Number: 40732 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 23 Jul 2025 11:59:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-cbc[master]: vty: clarify deprecation messages
by osmith 23 Jul '25

23 Jul '25

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-cbc/+/40731?usp=email ) Change subject: vty: clarify deprecation messages ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/40731?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I7d45292065950846e5e28eb2b21abcdb0707a9b3 Gerrit-Change-Number: 40731 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 23 Jul 2025 11:59:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0