Attention is currently required from: daniel, fixeria, laforge, osmith, pespin.
Hello Jenkins Builder, daniel, fixeria, laforge, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-uecups/+/40763?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: Introduce GTPv1U QFI support
......................................................................
Introduce GTPv1U QFI support
* Allow user configuring over the json interface the Tx of PDU Session
Container with UL/DL direction and a given QFI per flow.
* Support decoding incoming GTPv1U packets containing extended headers.
* Update ttcn3/UECUPTS_Types.ttcn accordingly to be able to use the new
features.
With this patch it is now possible to use osmo-uecups against a 5GC.
Related: SYS#7073
Change-Id: I6262c3dfbf774b361aadf0aa53ce09b5fdc38da4
---
M daemon/cups_client.c
M daemon/gtp.h
M daemon/gtp_endpoint.c
M daemon/gtp_tunnel.c
M daemon/internal.h
M daemon/tun_device.c
M ttcn3/UECUPS_Types.ttcn
7 files changed, 339 insertions(+), 76 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-uecups refs/changes/63/40763/5
--
To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/40763?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-uecups
Gerrit-Branch: master
Gerrit-Change-Id: I6262c3dfbf774b361aadf0aa53ce09b5fdc38da4
Gerrit-Change-Number: 40763
Gerrit-PatchSet: 5
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Attention is currently required from: daniel, fixeria, laforge, osmith, pespin.
Hello Jenkins Builder, daniel, fixeria, laforge, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-uecups/+/40763?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: Introduce GTPv1U QFI support
......................................................................
Introduce GTPv1U QFI support
* Allow user configuring over the json interface the Tx of PDU Session
Container with UL/DL direction and a given QFI per flow.
* Support decoding incoming GTPv1U packets containing extended headers.
* Update ttcn3/UECUPTS_Types.ttcn accordingly to be able to use the new
features.
With this patch it is now possible to use osmo-uecups against a 5GC.
Related: SYS#7073
Change-Id: I6262c3dfbf774b361aadf0aa53ce09b5fdc38da4
---
M daemon/cups_client.c
M daemon/gtp.h
M daemon/gtp_endpoint.c
M daemon/gtp_tunnel.c
M daemon/internal.h
M daemon/tun_device.c
M ttcn3/UECUPS_Types.ttcn
7 files changed, 296 insertions(+), 38 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-uecups refs/changes/63/40763/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/40763?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-uecups
Gerrit-Branch: master
Gerrit-Change-Id: I6262c3dfbf774b361aadf0aa53ce09b5fdc38da4
Gerrit-Change-Number: 40763
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Attention is currently required from: daniel, fixeria, laforge, osmith.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-uecups/+/40763?usp=email )
Change subject: Introduce GTPv1U QFI support
......................................................................
Patch Set 3:
This change is ready for review.
--
To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/40763?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-uecups
Gerrit-Branch: master
Gerrit-Change-Id: I6262c3dfbf774b361aadf0aa53ce09b5fdc38da4
Gerrit-Change-Number: 40763
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 28 Jul 2025 16:37:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Attention is currently required from: fixeria, laforge.
osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39415?usp=email )
Change subject: Add GSMTAP logging handler
......................................................................
Patch Set 9: Code-Review+1
(1 comment)
File config/sys.config:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39415/comment/26a3bc70_d756… :
PS9, Line 39: app_name => "OsmoS1GW"}}},
AFAIK we don't enable gsmtap logging by default in other Osmocom default configs. So maybe comment it out here too, so users can easily enable it on demand?
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39415?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: Iea884e2ca146b852c64bd9f135d8c71f4c925f09
Gerrit-Change-Number: 39415
Gerrit-PatchSet: 9
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 28 Jul 2025 12:51:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria.
osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40757?usp=email )
Change subject: Makefile: 'run' becomes an alias of 'shell'
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40757?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I8b34c11cc9361d8b65316401f67a5038544b27ac
Gerrit-Change-Number: 40757
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 28 Jul 2025 12:47:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40757?usp=email )
Change subject: Makefile: 'run' becomes an alias of 'shell'
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> I am not adding new `make run`, this target existed before this patch.
indeed I understood it wrong.
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40757?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I8b34c11cc9361d8b65316401f67a5038544b27ac
Gerrit-Change-Number: 40757
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 28 Jul 2025 12:36:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40757?usp=email )
Change subject: Makefile: 'run' becomes an alias of 'shell'
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> That has nothing to do with now adding a new "make run" pointing an existing "make shell"?
I am not adding new `make run`, this target existed before this patch.
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40757?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I8b34c11cc9361d8b65316401f67a5038544b27ac
Gerrit-Change-Number: 40757
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 28 Jul 2025 12:34:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40757?usp=email )
Change subject: Makefile: 'run' becomes an alias of 'shell'
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> Because: […]
That has nothing to do with now adding a new "make run" pointing an existing "make shell"?
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40757?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I8b34c11cc9361d8b65316401f67a5038544b27ac
Gerrit-Change-Number: 40757
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 28 Jul 2025 12:32:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>