July 2025 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: pgw: Use templates to generate UECUPS commands
by pespin 28 Jul '25

28 Jul '25

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40762?usp=email ) Change subject: pgw: Use templates to generate UECUPS commands ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Depends on https://gerrit.osmocom.org/c/osmo-uecups/+/40761 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40762?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4de6623318fe2abf9807702251fe420eb14de2cc Gerrit-Change-Number: 40762 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Jul 2025 10:40:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-ttcn3-hacks[master]: pgw: Use templates to generate UECUPS commands
by pespin 28 Jul '25

28 Jul '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40762?usp=email ) Change subject: pgw: Use templates to generate UECUPS commands ...................................................................... pgw: Use templates to generate UECUPS commands This way if commands are extended with optional fields, we don't need to update these since default params in templates will take care of it. Related: SYS#7073 Depends: osmo-uecups.git Change-Id If524b0a122d1217fcd39e4633835a1a7d0620c7a Change-Id: I4de6623318fe2abf9807702251fe420eb14de2cc --- M deps/Makefile M pgw/PGW_Tests.ttcn 2 files changed, 9 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/62/40762/1 diff --git a/deps/Makefile b/deps/Makefile index 0f710e8..b0b18b3 100644 --- a/deps/Makefile +++ b/deps/Makefile @@ -124,7 +124,7 @@ titan.TestPorts.UDPasp_commit= 54176e95850654e5e8b0ffa2f1b5f35c412b949c titan.TestPorts.UNIX_DOMAIN_SOCKETasp_commit= R.2.A-13-gd34ab71 titan.TestPorts.USB_commit= a9470fdc99c82fbf988f4508c3161118c9106e28 -osmo-uecups_commit= 8362efef7c6fa341eb947a75786878e0685767b7 +osmo-uecups_commit= 0eb4f08a31fd1d7aac6ffe9c6a60503f17c01787 all: $(foreach dir,$(ALL_REPOS),$(dir)/update) clean: $(foreach dir,$(ALL_REPOS),$(dir)/clean) diff --git a/pgw/PGW_Tests.ttcn b/pgw/PGW_Tests.ttcn index c63568e..1ba58f4 100644 --- a/pgw/PGW_Tests.ttcn +++ b/pgw/PGW_Tests.ttcn @@ -702,7 +702,7 @@ g_gtpu6_remote := rx_fteid.iPv6_Address; } - var UECUPS_CreateTun uecups_create := { + var template (value) UECUPS_CreateTun uecups_create := ts_UECUPS_CreateTun( tx_teid := oct2int(g_pars.bearer.teid_remote), rx_teid := oct2int(g_pars.bearer.teid_local), user_addr_type := IPV4, @@ -711,7 +711,7 @@ remote_gtp_ep := valueof(ts_UECUPS_SockAddr(g_gtpu4_remote)), tun_dev_name := g_pars.tun_dev_name, tun_netns_name := g_pars.tun_netns_name - }; + ); /* create tunnel in daemon */ if (isbound(g_ip4_addr)) { @@ -889,10 +889,11 @@ /* destroy tunnel in daemon */ if (isbound(g_pars.bearer.teid_local)) { - var UECUPS_DestroyTun uecups_destroy := { + var template (value) UECUPS_DestroyTun uecups_destroy; + uecups_destroy := ts_UECUPS_DestroyTun( local_gtp_ep := valueof(ts_UECUPS_SockAddr(f_inet_addr(mp_local_hostname_u))), rx_teid := oct2int(g_pars.bearer.teid_local) - }; + ); /* FIXME: what about IPv4/IPv6 differentiation? */ f_gtp1u_destroy_tunnel(uecups_destroy); } @@ -901,13 +902,13 @@ private function f_run_prog_init(charstring command) runs on PGW_Session_CT return UECUPS_StartProgram { - var UECUPS_StartProgram sprog := { + var template (value) UECUPS_StartProgram sprog := ts_UECUPS_StartProgram( command := command, environment := {}, run_as_user := mp_run_prog_as_user, tun_netns_name := g_pars.tun_netns_name - }; - return sprog; + ); + return valueof(sprog); } private function f_run_prog_unique_log_path() runs on PGW_Session_CT return charstring -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40762?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4de6623318fe2abf9807702251fe420eb14de2cc Gerrit-Change-Number: 40762 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-uecups[master]: ttcn3: UECUPS_Types: Add templates for existing json commands
by pespin 28 Jul '25

28 Jul '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-uecups/+/40761?usp=email ) Change subject: ttcn3: UECUPS_Types: Add templates for existing json commands ...................................................................... ttcn3: UECUPS_Types: Add templates for existing json commands Related: SYS#7073 Change-Id: If524b0a122d1217fcd39e4633835a1a7d0620c7a --- M ttcn3/UECUPS_Types.ttcn 1 file changed, 39 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-uecups refs/changes/61/40761/1 diff --git a/ttcn3/UECUPS_Types.ttcn b/ttcn3/UECUPS_Types.ttcn index bbd849f..2e6686b 100644 --- a/ttcn3/UECUPS_Types.ttcn +++ b/ttcn3/UECUPS_Types.ttcn @@ -128,5 +128,44 @@ Port := Port } +template (value) UECUPS_CreateTun +ts_UECUPS_CreateTun(template (value) uint32_t tx_teid, + template (value) uint32_t rx_teid, + template (value) UECUPS_AddrType user_addr_type, + template (value) OCT4_16n user_addr, + template (value) UECUPS_SockAddr local_gtp_ep, + template (value) UECUPS_SockAddr remote_gtp_ep, + template (value) charstring tun_dev_name := "tun", + template (omit) charstring tun_netns_name := omit) +:= { + tx_teid := tx_teid, + rx_teid := rx_teid, + user_addr_type := user_addr_type, + user_addr := user_addr, + local_gtp_ep := local_gtp_ep, + remote_gtp_ep := remote_gtp_ep, + tun_dev_name := tun_dev_name, + tun_netns_name := tun_netns_name +}; + +template (value) UECUPS_DestroyTun +ts_UECUPS_DestroyTun(template (value) UECUPS_SockAddr local_gtp_ep, + template (value) uint32_t rx_teid) +:= { + local_gtp_ep := local_gtp_ep, + rx_teid := rx_teid +}; + +template (value) UECUPS_StartProgram +ts_UECUPS_StartProgram(template (value) charstring command, + template (omit) charstring_list environment := omit, + template (value) charstring run_as_user := "root", + template (omit) charstring tun_netns_name := omit) +:= { + command := command, + environment := environment, + run_as_user := run_as_user, + tun_netns_name := tun_netns_name +}; } with { encode "JSON" }; -- To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/40761?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-uecups Gerrit-Branch: master Gerrit-Change-Id: If524b0a122d1217fcd39e4633835a1a7d0620c7a Gerrit-Change-Number: 40761 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmocore[master]: Send multiple read/recvfrom/recvmsg SQEs in advance
by Jenkins Builder 28 Jul '25

28 Jul '25

Attention is currently required from: pespin. Jenkins Builder has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40494?usp=email ) Change subject: Send multiple read/recvfrom/recvmsg SQEs in advance ...................................................................... Patch Set 8: (1 comment) File src/core/osmo_io.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmocore/+/40494/comment/85847f79_0de80a8c?… : PS8, Line 860: /*! Set the number of SQEs that are submitted to an io_unring before completion is recevied. 'recevied' may be misspelled - perhaps 'received'? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40494?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id50a8900fa2fe6de553e5025feae7e1e8d501e30 Gerrit-Change-Number: 40494 Gerrit-PatchSet: 8 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Jul 2025 10:25:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in libosmocore[master]: Add multiple messages buffers to struct iofd_msghdr
by Jenkins Builder 28 Jul '25

28 Jul '25

Attention is currently required from: laforge, pespin. Jenkins Builder has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40491?usp=email ) Change subject: Add multiple messages buffers to struct iofd_msghdr ...................................................................... Patch Set 7: (1 comment) File src/core/osmo_io.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmocore/+/40491/comment/fb9ed244_57caa6bc?… : PS7, Line 768: switch (op) { switch and case should be at the same indent -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40491?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4fb1067de4615cc22cc6caf99b481491e7f2ef92 Gerrit-Change-Number: 40491 Gerrit-PatchSet: 7 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Jul 2025 10:25:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in libosmocore[master]: Automatically increase io_uring, if too small.
by jolly 28 Jul '25

28 Jul '25

Attention is currently required from: laforge, pespin. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40725?usp=email ) Change subject: Automatically increase io_uring, if too small. ...................................................................... Patch Set 4: (6 comments) File src/core/osmo_io_internal.h: https://gerrit.osmocom.org/c/libosmocore/+/40725/comment/88d1e846_2dae4314?… : PS2, Line 110: void *read_ring[IOFD_MSGHDR_READ_SQES]; > some comments here would be useful to explan what those fields are and how hey are used (not just th […] Done File src/core/osmo_io_uring.c: https://gerrit.osmocom.org/c/libosmocore/+/40725/comment/71b86426_f122d2f5?… : PS2, Line 67: g_io_uring_queue > pleaes use a more descriptive name. The variable is not a qeuue, but it is the size of the ring. […] Done https://gerrit.osmocom.org/c/libosmocore/+/40725/comment/e38bd57a_d54e1f06?… : PS2, Line 113: OSMO_IO_URING_QUEUE > like the variable name in the code, the environment variable name shold be self-descriptive. […] Done https://gerrit.osmocom.org/c/libosmocore/+/40725/comment/720762d0_8db9c7c1?… : PS2, Line 163: osmo_iofd_uring_get_sqe > the 'osmo_' prefix is reserverd for exported functions. […] Done https://gerrit.osmocom.org/c/libosmocore/+/40725/comment/86884b81_0162c7d1?… : PS2, Line 172: LOGP(DLIO, LOGL_NOTICE, "io_uring too small to handle all SQEs, increasing size to %d.\n", g_io_uring_queue); > minor: while the current implementation alsways doubles the size, it might still be useful to print […] Done https://gerrit.osmocom.org/c/libosmocore/+/40725/comment/13d47890_d1b52789?… : PS2, Line 175: > is there code to clean up the old ring after completion of the last cqe of the old ring? No, it doesn't, because I don't track the number of submissions and the number of completions. I could do that. This would make it more complex, especially during cancellation process. I can add this if you want and test with the ttcn3 tests. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40725?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id9230146acc8d54bfd44834e783c31b37bd64bca Gerrit-Change-Number: 40725 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Jul 2025 10:19:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[M] Change in libosmocore[master]: Send multiple read/recvfrom/recvmsg SQEs in advance
by jolly 28 Jul '25

28 Jul '25

Attention is currently required from: pespin. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40494?usp=email ) Change subject: Send multiple read/recvfrom/recvmsg SQEs in advance ...................................................................... Patch Set 8: (10 comments) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/40494/comment/b0f7bd16_7fd684d5?… : PS7, Line 7: Send multiple read/recvfrom SQEs in advance > /recvmsg too from what I can see in the commit implementation. Done File src/core/osmo_io_internal.h: https://gerrit.osmocom.org/c/libosmocore/+/40494/comment/18563c78_6ed83ec8?… : PS7, Line 52: #define IOFD_MSGHDR_READ_SQES 32 > IOFD_MSGHDR_MAX_READ_SQES Done https://gerrit.osmocom.org/c/libosmocore/+/40494/comment/d682967f_fa5c7564?… : PS7, Line 110: int read_len; > Documenting these fields here would be awesome. Done File src/core/osmo_io_uring.c: https://gerrit.osmocom.org/c/libosmocore/+/40494/comment/61911071_8e099969?… : PS4, Line 122: if ((env = getenv(OSMO_IO_URING_READ_SQE))) { > Feel free to add an extra internal commit to force-enable it during benchmarking. […] Now it has both, one env for benchmarking and one API call for the application. File src/core/osmo_io_uring.c: https://gerrit.osmocom.org/c/libosmocore/+/40494/comment/333cb073_916574e2?… : PS7, Line 240: iofd->u.uring.read_msghdr = NULL; > This one probably needs to be moved above around line 238? Done https://gerrit.osmocom.org/c/libosmocore/+/40494/comment/ebeefd79_9f1da12d?… : PS7, Line 216: goto submit_again; > this goto can be implemented by simple recursive call: […] Done https://gerrit.osmocom.org/c/libosmocore/+/40494/comment/e5f6c023_9f7ce15d?… : PS7, Line 231: LOGP(DLIO, LOGL_DEBUG, "Read SQE completion, but msghdr not found, please fix!\n"); > sounds like LOGL_FATAL instead ;) Done https://gerrit.osmocom.org/c/libosmocore/+/40494/comment/87f450f1_9e5eba40?… : PS7, Line 238: > missing =NULL for last read_msghdr? Done https://gerrit.osmocom.org/c/libosmocore/+/40494/comment/08a8a2cb_f67ca9a5?… : PS7, Line 470: int idx; > unsigned int Done https://gerrit.osmocom.org/c/libosmocore/+/40494/comment/54f4a98b_c12a24af?… : PS7, Line 473: msghdr = iofd->u.uring.read_msghdr[idx]; > iofd->u.uring. […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40494?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id50a8900fa2fe6de553e5025feae7e1e8d501e30 Gerrit-Change-Number: 40494 Gerrit-PatchSet: 8 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Jul 2025 10:19:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmocore[master]: Add multiple messages buffers to io_uring write operations
by jolly 28 Jul '25

28 Jul '25

Attention is currently required from: pespin. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40493?usp=email ) Change subject: Add multiple messages buffers to io_uring write operations ...................................................................... Patch Set 8: (2 comments) File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/40493/comment/747f89ec_2678ed2c?… : PS4, Line 444: /* Re-enqueue remaining buffers. */ > No, what I mean is that in here a function should be called to re-arrange msgs inside msghdrs in the […] There will be a follow-up commit. File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/40493/comment/dc039d0b_33123e35?… : PS7, Line 442: /* Re-enqueue the complete msgb. */ > This can be moved to the top of the function before the for loop, to simplify function now that you […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40493?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8c4e0a785cf66becd7fb5b2caf718c9724b56686 Gerrit-Change-Number: 40493 Gerrit-PatchSet: 8 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Jul 2025 10:19:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmocore[master]: Add multiple messages buffers to io_uring read operations
by jolly 28 Jul '25

28 Jul '25

Attention is currently required from: pespin. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40492?usp=email ) Change subject: Add multiple messages buffers to io_uring read operations ...................................................................... Patch Set 7: (2 comments) File src/core/osmo_io_uring.c: https://gerrit.osmocom.org/c/libosmocore/+/40492/comment/ba5f15dc_d48d8b9a?… : PS3, Line 179: if (idx) > Because it is already allocated above at: iofd_msgb_alloc(iodfd); and then added to the msghdr durin […] Done https://gerrit.osmocom.org/c/libosmocore/+/40492/comment/31c00280_a1b8f037?… : PS3, Line 185: > the cases below have all "/* fall-through */". I still need to check if action == IOFD_ACT_READ. Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40492?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic4544b8fcbad5a266db748d6864d3ae93ee06bce Gerrit-Change-Number: 40492 Gerrit-PatchSet: 7 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Jul 2025 10:19:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmocore[master]: Add multiple messages buffers to struct iofd_msghdr
by jolly 28 Jul '25

28 Jul '25

Attention is currently required from: laforge, pespin. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40491?usp=email ) Change subject: Add multiple messages buffers to struct iofd_msghdr ...................................................................... Patch Set 7: (8 comments) File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/40491/comment/ef361154_bc712529?… : PS3, Line 165: hdr->msg_max = (g_io_backend == OSMO_IO_BACKEND_IO_URING) ? g_io_uring_iov : 1; > this info should be obtained from osmo_io_fd struct. Done https://gerrit.osmocom.org/c/libosmocore/+/40491/comment/c1736551_2110a685?… : PS3, Line 406: struct msgb *msg = msghdr->msg[0]; > I see now, because this commit is actually not yet adding support for >1 msgb per msghdr, it's only […] Done File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/40491/comment/97886b07_25aada17?… : PS5, Line 727: iofd->io_buffers = (g_io_backend == OSMO_IO_BACKEND_IO_URING) ? g_io_uring_iov : 1; > sounds like we want to have this per-backend logic as part of the per-backend ops, and not here. It is set by an API function now. File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/40491/comment/ecc7525f_6e3dcb0d?… : PS6, Line 747: * If your osmo_io_fd is in OSMO_IO_FD_MODE_READ_WRITE mode, this API function can be used to tell the > Please add proper doxygen documentation of params here. Done https://gerrit.osmocom.org/c/libosmocore/+/40491/comment/12c1d822_38847e71?… : PS6, Line 748: * osmo_io code how many buffers should be read or written with a single read or write operation. > "read or write". Extra space. Done https://gerrit.osmocom.org/c/libosmocore/+/40491/comment/5a0c93ff_615b47a6?… : PS6, Line 751: int osmo_iofd_set_io_buffers(struct osmo_io_fd *iofd, int buffers) > unsigned int buffers? […] Done File src/core/osmo_io_internal.h: https://gerrit.osmocom.org/c/libosmocore/+/40491/comment/c79bae45_5b9c7630?… : PS6, Line 143: int io_len; > this can also be a unsigned int. And even actually a uint8_t. Done File src/core/osmo_io_uring.c: https://gerrit.osmocom.org/c/libosmocore/+/40491/comment/84b14b5c_5b18e99a?… : PS3, Line 110: g_io_uring_iov = atoi(env); > afaict this is not some information which is needed really early in the startup of the program, befo […] It is configured in an API function now. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40491?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4fb1067de4615cc22cc6caf99b481491e7f2ef92 Gerrit-Change-Number: 40491 Gerrit-PatchSet: 7 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Jul 2025 10:19:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0