July 2025 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: msc: Add suport to obtain statsd output
by fixeria 10 Jul '25

10 Jul '25

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40635?usp=email ) Change subject: msc: Add suport to obtain statsd output ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40635?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I66ffb278a7ddff975e43f72d9ec6b323705f720c Gerrit-Change-Number: 40635 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Jul 2025 19:29:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: RAN_Emulation: Fix handling of IMSI in RANAP Paging
by fixeria 10 Jul '25

10 Jul '25

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40634?usp=email ) Change subject: RAN_Emulation: Fix handling of IMSI in RANAP Paging ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40634?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia892a52bad41a4e331703bbab438d8c811b2025e Gerrit-Change-Number: 40634 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Jul 2025 19:24:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-msc[master]: ran_peer: Introuce stats msc.ran_peers.{total,active}
by laforge 10 Jul '25

10 Jul '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-msc/+/40633?usp=email ) Change subject: ran_peer: Introuce stats msc.ran_peers.{total,active} ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/40633?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I36e40510c9a95f0c9cf5f32d2a7baab840aa8660 Gerrit-Change-Number: 40633 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Jul 2025 19:07:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-msc[master]: ran_peer: Add specific API to free object
by laforge 10 Jul '25

10 Jul '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-msc/+/40632?usp=email ) Change subject: ran_peer: Add specific API to free object ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/40632?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I721de21a68a4e336ae508a995e3cfcca05d57efe Gerrit-Change-Number: 40632 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Jul 2025 19:07:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-msc[master]: ran_peer: Avoid paging attempt if not ready
by laforge 10 Jul '25

10 Jul '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-msc/+/40631?usp=email ) Change subject: ran_peer: Avoid paging attempt if not ready ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/40631?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ia858291f4454e4caf293e1aaf60ea04d2d4a64e9 Gerrit-Change-Number: 40631 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Jul 2025 19:06:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-msc[master]: msc: Initial implementation of N-PCSTATE.ind
by laforge 10 Jul '25

10 Jul '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-msc/+/40630?usp=email ) Change subject: msc: Initial implementation of N-PCSTATE.ind ...................................................................... Patch Set 1: (3 comments) File src/libmsc/sccp_ran.c: https://gerrit.osmocom.org/c/osmo-msc/+/40630/comment/697a42d7_aae5c31d?usp… : PS1, Line 84: LOGP(DMSC, LOGL_DEBUG, "N-PCSTATE ind: affected_pc=%u sp_status=%s remote_sccp_status=%s\n", as usual, please print pointcodes in the user-configured point-code format, not [just?] as integer. https://gerrit.osmocom.org/c/osmo-msc/+/40630/comment/792e5b53_8b8bbb33?usp… : PS1, Line 148: "now unreachable: N-PCSTATE ind: pc=%u sp_status=%s remote_sccp_status=%s\n", as usual, please print pointcodes in the user-configured point-code format, not [just?] as integer. https://gerrit.osmocom.org/c/osmo-msc/+/40630/comment/57cf2b6f_c7f19529?usp… : PS1, Line 156: "now available: N-PCSTATE ind: pc=%u sp_status=%s remote_sccp_status=%s\n", as usual, please print pointcodes in the user-configured point-code format, not [just?] as integer. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/40630?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ice1b2c163b1b0d134fcaa1c8bf543038a35fabdf Gerrit-Change-Number: 40630 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Jul 2025 19:05:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmo-ttcn3-hacks[master]: msc: Introduce test TC_stat_bsc_sctp_disconnected
by laforge 10 Jul '25

10 Jul '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40636?usp=email ) Change subject: msc: Introduce test TC_stat_bsc_sctp_disconnected ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40636?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4cf30ea09cb1d1286bd5ab6975f3f27e39b9c183 Gerrit-Change-Number: 40636 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Jul 2025 19:03:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: msc: Add suport to obtain statsd output
by laforge 10 Jul '25

10 Jul '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40635?usp=email ) Change subject: msc: Add suport to obtain statsd output ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40635?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I66ffb278a7ddff975e43f72d9ec6b323705f720c Gerrit-Change-Number: 40635 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Jul 2025 19:03:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: RAN_Emulation: Fix handling of IMSI in RANAP Paging
by laforge 10 Jul '25

10 Jul '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40634?usp=email ) Change subject: RAN_Emulation: Fix handling of IMSI in RANAP Paging ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40634?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia892a52bad41a4e331703bbab438d8c811b2025e Gerrit-Change-Number: 40634 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Jul 2025 19:03:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: msc: Add suport to obtain statsd output
by pespin 10 Jul '25

10 Jul '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40635?usp=email ) Change subject: msc: Add suport to obtain statsd output ...................................................................... msc: Add suport to obtain statsd output It will be used in a follow-up commit introducing a new test. Change-Id: I66ffb278a7ddff975e43f72d9ec6b323705f720c --- M msc/MSC_Tests.default M msc/MSC_Tests.ttcn M msc/README.md M msc/gen_links.sh M msc/osmo-msc.cfg M msc/regen_makefile.sh 6 files changed, 42 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/35/40635/1 diff --git a/msc/MSC_Tests.default b/msc/MSC_Tests.default index 98bf299..34954bd 100644 --- a/msc/MSC_Tests.default +++ b/msc/MSC_Tests.default @@ -22,6 +22,15 @@ *.MSCVTY.CTRL_CLIENT_CLEANUP_LINEFEED := "yes" *.MSCVTY.CTRL_DETECT_CONNECTION_ESTABLISHMENT_RESULT := "yes" *.MSCVTY.PROMPT1 := "OsmoMSC> " +*.STATSVTY.CTRL_MODE := "client" +*.STATSVTY.CTRL_HOSTNAME := "127.0.0.1" +*.STATSVTY.CTRL_PORTNUM := "4254" +*.STATSVTY.CTRL_LOGIN_SKIPPED := "yes" +*.STATSVTY.CTRL_DETECT_SERVER_DISCONNECTED := "yes" +*.STATSVTY.CTRL_READMODE := "buffered" +*.STATSVTY.CTRL_CLIENT_CLEANUP_LINEFEED := "yes" +*.STATSVTY.CTRL_DETECT_CONNECTION_ESTABLISHMENT_RESULT := "yes" +*.STATSVTY.PROMPT1 := "OsmoMSC> " [MODULE_PARAMETERS] diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index 22b6608..1ba52d9 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -78,6 +78,11 @@ import from SCCP_Templates all; +import from StatsD_Types all; +import from StatsD_CodecPort all; +import from StatsD_CodecPort_CtrlFunct all; +import from StatsD_Checker all; + import from SS_Types all; import from SS_Templates all; import from USSD_Helpers all; @@ -90,7 +95,7 @@ /* Needed for SGsAP SMS */ import from MobileL3_SMS_Types all; -type component MTC_CT extends CTRL_Adapter_CT { +type component MTC_CT extends CTRL_Adapter_CT, StatsD_ConnHdlr { var boolean g_initialized := false; var RAN_Adapter g_bssap[NUM_BSC]; @@ -108,6 +113,10 @@ /* VTY to MSC */ port TELNETasp_PT MSCVTY; + /* StatsD */ + var StatsD_Checker_CT vc_STATSD; + var float g_statd_timeout := 5.0; + /* A port to directly send BSSAP messages. This port is used for * tests that require low level access to sen arbitrary BSSAP * messages. Run f_init_bssap_direct() to connect and initialize */ @@ -129,6 +138,8 @@ charstring mp_msc_ip := "127.0.0.1"; integer mp_msc_ctrl_port := 4255; integer mp_msc_vty_port := 4254; + /* port number to which to listen for STATSD metrics */ + integer mp_msc_statsd_port := 8125; /* local parameters of emulated HLR */ boolean mp_mm_info := false; @@ -137,6 +148,11 @@ charstring mp_mgw_ip := "127.0.0.1"; integer mp_mgw_port := 2427; + /* Address where we listen for STATSD metrics */ + charstring mp_local_statsd_ip := "127.0.0.1"; + charstring mp_statsd_prefix := "TTCN3."; + + charstring mp_msc_mncc := "/tmp/mncc"; integer mp_msc_smpp_port := 2775; @@ -357,6 +373,8 @@ f_init_sgsap("MSC_Test"); } + f_init_statsd("MSC_Test", vc_STATSD, mp_local_statsd_ip, mp_msc_statsd_port, g_statd_timeout); + } /* Initialize for a direct connection to BSSAP. This function is an alternative diff --git a/msc/README.md b/msc/README.md index d79303b..d411b0c 100644 --- a/msc/README.md +++ b/msc/README.md @@ -9,6 +9,7 @@ * SMPP (emulates ESME side) * VTY * CTRL + * StatsD {% dot msc_tests.svg digraph G { @@ -21,6 +22,7 @@ ATS -> MSC [label="SMPP",style="dashed"]; ATS -> MSC [label="CTRL"]; ATS -> MSC [label="VTY"]; + MSC -> ATS [label="StatsD"]; MSC -> ATS [label="GSUP"]; MSC -> ATS [label="MGCP"]; ATS -> STP [label="A BSSAP\nSCCP/M3UA"]; diff --git a/msc/gen_links.sh b/msc/gen_links.sh index 63d90fc..f18c2f8 100755 --- a/msc/gen_links.sh +++ b/msc/gen_links.sh @@ -103,6 +103,7 @@ FILES+="SS_Templates.ttcn SCCP_Templates.ttcn USSD_Helpers.ttcn " FILES+="SGsAP_Templates.ttcn SGsAP_CodecPort.ttcn SGsAP_CodecPort_CtrlFunct.ttcn SGsAP_CodecPort_CtrlFunctDef.cc SGsAP_Emulation.ttcn DNS_Helpers.ttcn " FILES+="SCTP_Templates.ttcn " +FILES+="StatsD_Types.ttcn StatsD_CodecPort.ttcn StatsD_CodecPort_CtrlFunct.ttcn StatsD_CodecPort_CtrlFunctdef.cc StatsD_Checker.ttcnpp " gen_links $DIR $FILES gen_links_finish diff --git a/msc/osmo-msc.cfg b/msc/osmo-msc.cfg index 61b03cf..9b52896 100644 --- a/msc/osmo-msc.cfg +++ b/msc/osmo-msc.cfg @@ -34,7 +34,15 @@ logging level vlr debug logging level iucs debug ! -stats interval 5 +stats interval 0 +stats reporter statsd + prefix TTCN3 + level subscriber + remote-ip 127.0.0.1 + remote-port 8125 + flush-period 1 + mtu 1024 + enable ! line vty no login diff --git a/msc/regen_makefile.sh b/msc/regen_makefile.sh index b254f9d..7f897a5 100755 --- a/msc/regen_makefile.sh +++ b/msc/regen_makefile.sh @@ -23,6 +23,7 @@ SGsAP_CodecPort_CtrlFunctDef.cc SMPP_CodecPort_CtrlFunctDef.cc SMPP_EncDec.cc + StatsD_CodecPort_CtrlFunctdef.cc SS_EncDec.cc TCCConversion.cc TCCEncoding.cc @@ -41,6 +42,7 @@ -DRAN_EMULATION_CTRL -DRAN_EMULATION_MGCP -DRAN_EMULATION_RANAP + -DSTATSD_HAVE_VTY -DUSE_MTP3_DISTRIBUTOR " -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40635?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I66ffb278a7ddff975e43f72d9ec6b323705f720c Gerrit-Change-Number: 40635 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0