July 2025 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-ttcn3-hacks[master]: GSUP Fix missing IMSI template present restriction in tr_GSUP_SAI_REQ
by lynxis lazus 11 Jul '25

11 Jul '25

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40639?usp=email ) Change subject: GSUP Fix missing IMSI template present restriction in tr_GSUP_SAI_REQ ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40639?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iea712df2f922fe5eb16e116f7a4609a0e20233b4 Gerrit-Change-Number: 40639 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 11 Jul 2025 13:35:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: msc: Introduce test TC_stat_bsc_sctp_disconnected
by osmith 11 Jul '25

11 Jul '25

Attention is currently required from: fixeria, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40636?usp=email ) Change subject: msc: Introduce test TC_stat_bsc_sctp_disconnected ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40636?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4cf30ea09cb1d1286bd5ab6975f3f27e39b9c183 Gerrit-Change-Number: 40636 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 11 Jul 2025 12:43:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ggsn[master]: gtp: SGSN Ctx: prevent a stack reference to be in **ie
by lynxis lazus 11 Jul '25

11 Jul '25

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/40641?usp=email ) Change subject: gtp: SGSN Ctx: prevent a stack reference to be in **ie ...................................................................... gtp: SGSN Ctx: prevent a stack reference to be in **ie Even the caller shouldn't re-use **ie after using it with sgsn_context_response, ensure there is no stack reference in **ie when returning. Related: Coverity CID#530774 Related: Coverity CID#530775 Fixes: d46d0cc36845 ("gtp: add support for SGSN Context Req/Resp/Ack") Change-Id: Ideca8beb21c6cce7104721b4d80854448baf6c4e --- M gtp/gtp.c 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/41/40641/1 diff --git a/gtp/gtp.c b/gtp/gtp.c index fa65575..13b7de7 100644 --- a/gtp/gtp.c +++ b/gtp/gtp.c @@ -912,6 +912,11 @@ pack = &packet; pack += packet_len; rc = gtpie_encaps3(ie, GTPIE_SIZE, pack, GTP_MAX - packet_len, &encoded_len); + + /* Prevent a stack reference within **ie */ + ie[GTPIE_TEI_C] = NULL; + ie[GTPIE_GSN_ADDR] = NULL; + if (rc) return -EINVAL; @@ -954,6 +959,11 @@ pack = &packet; pack += packet_len; rc = gtpie_encaps3(ie, GTPIE_SIZE, pack, GTP_MAX - packet_len, &encoded_len); + + /* Prevent a stack reference within **ie */ + ie[GTPIE_TEI_C] = NULL; + ie[GTPIE_GSN_ADDR] = NULL; + if (rc) return -EINVAL; @@ -999,6 +1009,11 @@ pack += packet_len; rc = gtpie_encaps3(ie, GTPIE_SIZE, pack, GTP_MAX - packet_len, &encoded_len); + + /* Prevent a stack reference within **ie */ + ie[GTPIE_TEI_C] = NULL; + ie[GTPIE_GSN_ADDR] = NULL; + if (rc) return -EINVAL; -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/40641?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Ideca8beb21c6cce7104721b4d80854448baf6c4e Gerrit-Change-Number: 40641 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in osmo-ttcn3-hacks[master]: sgsn: Use static sigtran config between osmo-sgsn and osmo-stp
by osmith 11 Jul '25

11 Jul '25

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40640?usp=email ) Change subject: sgsn: Use static sigtran config between osmo-sgsn and osmo-stp ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40640?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie52f4c1877587067af66add56ad8674b82b51718 Gerrit-Change-Number: 40640 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 11 Jul 2025 12:33:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: GSUP Fix missing IMSI template present restriction in tr_GSUP_SAI_REQ
by osmith 11 Jul '25

11 Jul '25

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40639?usp=email ) Change subject: GSUP Fix missing IMSI template present restriction in tr_GSUP_SAI_REQ ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40639?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iea712df2f922fe5eb16e116f7a4609a0e20233b4 Gerrit-Change-Number: 40639 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 11 Jul 2025 12:32:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: GSUP Fix missing IMSI template present restriction in tr_GSUP_SAI_REQ
by pespin 11 Jul '25

11 Jul '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40639?usp=email ) Change subject: GSUP Fix missing IMSI template present restriction in tr_GSUP_SAI_REQ ...................................................................... GSUP Fix missing IMSI template present restriction in tr_GSUP_SAI_REQ I got this DTE while running SGSN_Tests_Iu.TC_attach_pdp_act_user: """ GSUP_Templates.ttcn:381 Dynamic test case error: Restriction `present' on template of type hexstring violated. """ According to GSUP documentation, the IMSI param is mandatory. Upon fixing it, the compiler found the user causing the problem: """ BSSGP_ConnHdlr.ttcn:797.49: error: Restriction on template formal parameter does not allow usage of any or omit """ That error is also fixed in this same commit. Change-Id: Iea712df2f922fe5eb16e116f7a4609a0e20233b4 --- M library/GSUP_Templates.ttcn M sgsn/BSSGP_ConnHdlr.ttcn 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/39/40639/1 diff --git a/library/GSUP_Templates.ttcn b/library/GSUP_Templates.ttcn index 327f7f6..227a7d2 100644 --- a/library/GSUP_Templates.ttcn +++ b/library/GSUP_Templates.ttcn @@ -378,7 +378,7 @@ valueof(ts_GSUP_IE_RAND(rand)) }); -template GSUP_PDU tr_GSUP_SAI_REQ(template hexstring imsi) := +template GSUP_PDU tr_GSUP_SAI_REQ(template (present) hexstring imsi) := tr_GSUP_IMSI(OSMO_GSUP_MSGT_SEND_AUTH_INFO_REQUEST, imsi); template GSUP_PDU tr_GSUP_SAI_REQ_UMTS_AKA_RESYNC( diff --git a/sgsn/BSSGP_ConnHdlr.ttcn b/sgsn/BSSGP_ConnHdlr.ttcn index 1b2e5a0..2b95ec0 100644 --- a/sgsn/BSSGP_ConnHdlr.ttcn +++ b/sgsn/BSSGP_ConnHdlr.ttcn @@ -794,7 +794,7 @@ Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Service Request: Unexpected GMM Auth Req"); } - [not expect_auth] GSUP.receive(tr_GSUP_SAI_REQ(*)) { + [not expect_auth] GSUP.receive(tr_GSUP_SAI_REQ(?)) { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Service Request: Unexpected GSUP SAI Req"); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40639?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iea712df2f922fe5eb16e116f7a4609a0e20233b4 Gerrit-Change-Number: 40639 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: sgsn: Use static sigtran config between osmo-sgsn and osmo-stp
by pespin 11 Jul '25

11 Jul '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40640?usp=email ) Change subject: sgsn: Use static sigtran config between osmo-sgsn and osmo-stp ...................................................................... sgsn: Use static sigtran config between osmo-sgsn and osmo-stp This allows referencing/accessing the specific ASP in osmo-stp, which will be needed in a follow-up commit to test IUT behavior when the SCTP conn is dropped. Related: OS#5917 Change-Id: Ie52f4c1877587067af66add56ad8674b82b51718 --- M sgsn/osmo-sgsn.cfg M sgsn/osmo-stp.cfg 2 files changed, 12 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/40/40640/1 diff --git a/sgsn/osmo-sgsn.cfg b/sgsn/osmo-sgsn.cfg index 4a5f236..ae01923 100644 --- a/sgsn/osmo-sgsn.cfg +++ b/sgsn/osmo-sgsn.cfg @@ -56,7 +56,8 @@ ! cs7 instance 0 point-code 0.23.4 - asp asp-clnt-OsmoSGSN-A 2905 0 m3ua + asp asp-clnt-OsmoSGSN-A 2905 1905 m3ua + local-ip 127.0.0.10 remote-ip 127.0.0.200 role asp sctp-role client diff --git a/sgsn/osmo-stp.cfg b/sgsn/osmo-stp.cfg index e79c298..7b1e965 100644 --- a/sgsn/osmo-stp.cfg +++ b/sgsn/osmo-stp.cfg @@ -37,6 +37,14 @@ ! cs7 instance 0 xua rkm routing-key-allocation dynamic-permitted + asp sgsn0-0 1905 2905 m3ua + local-ip 127.0.0.200 + remote-ip 127.0.0.10 + role sg + sctp-role server + as sgsn0 m3ua + asp sgsn0-0 + routing-key 3 0.23.4 asp virt-rnc0-0 23908 2905 m3ua local-ip 127.0.0.200 remote-ip 127.0.0.104 @@ -46,10 +54,8 @@ asp virt-rnc0-0 routing-key 2 0.24.3 route-table system + update route 0.23.4 7.255.7 linkset sgsn0 update route 0.24.3 7.255.7 linkset virt-rnc0 listen m3ua 2905 local-ip 127.0.0.200 - accept-asp-connections dynamic-permitted - listen ipa 5000 - local-ip 127.0.0.200 - accept-asp-connections dynamic-permitted + accept-asp-connections pre-configured -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40640?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie52f4c1877587067af66add56ad8674b82b51718 Gerrit-Change-Number: 40640 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-msc[master]: msc: Initial implementation of N-PCSTATE.ind
by pespin 11 Jul '25

11 Jul '25

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-msc/+/40630?usp=email ) Change subject: msc: Initial implementation of N-PCSTATE.ind ...................................................................... Patch Set 2: (1 comment) File src/libmsc/sccp_ran.c: https://gerrit.osmocom.org/c/osmo-msc/+/40630/comment/7e00647e_48b5c2ca?usp… : PS1, Line 156: "now available: N-PCSTATE ind: pc=%u sp_status=%s remote_sccp_status=%s\n", > as usual, please print pointcodes in the user-configured point-code format, not [just?] as integer. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/40630?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ice1b2c163b1b0d134fcaa1c8bf543038a35fabdf Gerrit-Change-Number: 40630 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 11 Jul 2025 12:09:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[M] Change in osmo-msc[master]: msc: Initial implementation of N-PCSTATE.ind
by pespin 11 Jul '25

11 Jul '25

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-msc/+/40630?usp=email ) Change subject: msc: Initial implementation of N-PCSTATE.ind ...................................................................... Patch Set 2: (1 comment) File src/libmsc/sccp_ran.c: https://gerrit.osmocom.org/c/osmo-msc/+/40630/comment/8a81dff7_5f4df6de?usp… : PS1, Line 148: "now unreachable: N-PCSTATE ind: pc=%u sp_status=%s remote_sccp_status=%s\n", > as usual, please print pointcodes in the user-configured point-code format, not [just?] as integer. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/40630?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ice1b2c163b1b0d134fcaa1c8bf543038a35fabdf Gerrit-Change-Number: 40630 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 11 Jul 2025 12:09:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[M] Change in osmo-msc[master]: msc: Initial implementation of N-PCSTATE.ind
by pespin 11 Jul '25

11 Jul '25

Attention is currently required from: fixeria, laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/40630?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: msc: Initial implementation of N-PCSTATE.ind ...................................................................... msc: Initial implementation of N-PCSTATE.ind Change-Id: Ice1b2c163b1b0d134fcaa1c8bf543038a35fabdf --- M include/osmocom/msc/ran_peer.h M src/libmsc/ran_peer.c M src/libmsc/sccp_ran.c 3 files changed, 129 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/30/40630/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/40630?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ice1b2c163b1b0d134fcaa1c8bf543038a35fabdf Gerrit-Change-Number: 40630 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0