June 2025 - gerrit-log - lists.osmocom.org

[M] Change in libosmo-sigtran[master]: asp,xua_srv: Apply SCTP sockopts only on SCTP osckets

by osmith

Attention is currently required from: daniel, fixeria, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40480?usp=email ) Change subject: asp,xua_srv: Apply SCTP sockopts only on SCTP osckets ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/ss7_xua_srv.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/40480/comment/c0725210_43e25… : PS1, Line 328: applyng > ```suggestion […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40480?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I013c51efd03a3f5561bf9849c8841b1c7e66c172 Gerrit-Change-Number: 40480 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 18 Jun 2025 11:21:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

2 months, 3 weeks

1
0
0 0

[M] Change in libosmo-netif[master]: stream: Support configuring TCP keep-alive pars

by osmith

Attention is currently required from: daniel, fixeria, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/40478?usp=email ) Change subject: stream: Support configuring TCP keep-alive pars ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/40478?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ie748ad581c1c42f4c24f9409ce7d34d419cbca8b Gerrit-Change-Number: 40478 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 18 Jun 2025 11:21:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 months, 3 weeks

1
0
0 0

[M] Change in libosmo-sigtran[master]: asp: Introduce support to configure and enable TCP keep-alive

by pespin

Attention is currently required from: osmith, pespin. Hello Jenkins Builder, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40481?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by osmith, Verified-1 by Jenkins Builder Change subject: asp: Introduce support to configure and enable TCP keep-alive ...................................................................... asp: Introduce support to configure and enable TCP keep-alive Depends: libosmo-netif.git Change-Id Ie748ad581c1c42f4c24f9409ce7d34d419cbca8b Change-Id: I2a9338053e741fb6dab94492c6bdc2badaf7afb1 --- M TODO-RELEASE M src/ss7_asp.c M src/ss7_asp.h M src/ss7_asp_vty.c M src/ss7_xua_srv.c M tests/vty/osmo_stp_test.vty 6 files changed, 200 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/81/40481/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40481?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I2a9338053e741fb6dab94492c6bdc2badaf7afb1 Gerrit-Change-Number: 40481 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

2 months, 3 weeks

1
0
0 0

[M] Change in libosmo-sigtran[master]: asp,xua_srv: Apply SCTP sockopts only on SCTP osckets

by pespin

Attention is currently required from: daniel, fixeria, laforge, osmith, pespin. Hello Jenkins Builder, daniel, fixeria, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40480?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by osmith, Verified+1 by Jenkins Builder Change subject: asp,xua_srv: Apply SCTP sockopts only on SCTP osckets ...................................................................... asp,xua_srv: Apply SCTP sockopts only on SCTP osckets Otherwise if user somehow configured those paremeters over VTY, they would end up trying to be applied and most probably fail. Take the chance to split that really specific code to helper functions to sanitize a bit some lifecycle code paths. Change-Id: I013c51efd03a3f5561bf9849c8841b1c7e66c172 --- M src/ss7_asp.c M src/ss7_xua_srv.c 2 files changed, 58 insertions(+), 34 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/80/40480/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40480?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I013c51efd03a3f5561bf9849c8841b1c7e66c172 Gerrit-Change-Number: 40480 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>

2 months, 3 weeks

1
0
0 0

[M] Change in libosmo-netif[master]: stream: Support configuring TCP keep-alive pars

by pespin

Attention is currently required from: daniel, fixeria, laforge, osmith. Hello Jenkins Builder, daniel, fixeria, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/40478?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by osmith, Verified+1 by Jenkins Builder Change subject: stream: Support configuring TCP keep-alive pars ...................................................................... stream: Support configuring TCP keep-alive pars for servers, the param can either be set on the link (which will be automatically inherited/applied for all accepted conn sockets), or can be set specifically on a srv conn socket. The second is useful when user can supply different parameters for different clients connected to the listening socket, eg. ASP configuration in libosmo-sigtran. Change-Id: Ie748ad581c1c42f4c24f9409ce7d34d419cbca8b --- M TODO-RELEASE M include/osmocom/netif/stream.h M include/osmocom/netif/stream_private.h M src/stream.c M src/stream_cli.c M src/stream_srv.c 6 files changed, 237 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/78/40478/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/40478?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ie748ad581c1c42f4c24f9409ce7d34d419cbca8b Gerrit-Change-Number: 40478 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>

2 months, 3 weeks

1
0
0 0

[M] Change in libosmo-netif[master]: stream: Support configuring TCP keep-alive pars

by pespin

Attention is currently required from: daniel, fixeria, laforge, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/40478?usp=email ) Change subject: stream: Support configuring TCP keep-alive pars ...................................................................... Patch Set 1: (3 comments) File src/stream_cli.c: https://gerrit.osmocom.org/c/libosmo-netif/+/40478/comment/a2cdf7fa_9f23cd2… : PS1, Line 1542: keelapive > ```suggestion […] Done File src/stream_srv.c: https://gerrit.osmocom.org/c/libosmo-netif/+/40478/comment/c7e539a4_830f39c… : PS1, Line 685: keelapive > ```suggestion […] Done https://gerrit.osmocom.org/c/libosmo-netif/+/40478/comment/eacc2c0b_8b9566f… : PS1, Line 1454: keelapive > ```suggestion […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/40478?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ie748ad581c1c42f4c24f9409ce7d34d419cbca8b Gerrit-Change-Number: 40478 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 18 Jun 2025 11:16:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

2 months, 3 weeks

1
0
0 0

[XS] Change in osmo-ci[master]: jobs/ttcn3-testsuites: add email parameter

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40483?usp=email ) Change subject: jobs/ttcn3-testsuites: add email parameter ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40483?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I9385f553196ac8d1ac1bfb05735ed937da67b7b4 Gerrit-Change-Number: 40483 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 18 Jun 2025 11:12:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 months, 3 weeks

1
0
0 0

[S] Change in osmo-ci[master]: jobs/ttcn3-…-testenv: add TESTENV ARGS parameter

by pespin

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40482?usp=email ) Change subject: jobs/ttcn3-…-testenv: add TESTENV_ARGS parameter ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40482?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I2a07319ee26ac497eff2853329a002cdb09f75b4 Gerrit-Change-Number: 40482 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 18 Jun 2025 11:12:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 months, 3 weeks

1
0
0 0

[S] Change in osmo-ci[master]: jobs/ttcn3-…-testenv: add TESTENV ARGS parameter

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/40482?usp=email ) Change subject: jobs/ttcn3-…-testenv: add TESTENV_ARGS parameter ...................................................................... jobs/ttcn3-…-testenv: add TESTENV_ARGS parameter Change-Id: I2a07319ee26ac497eff2853329a002cdb09f75b4 --- M jobs/ttcn3-testsuites-testenv.yml 1 file changed, 15 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/82/40482/1 diff --git a/jobs/ttcn3-testsuites-testenv.yml b/jobs/ttcn3-testsuites-testenv.yml index a79ded0..609a215 100644 --- a/jobs/ttcn3-testsuites-testenv.yml +++ b/jobs/ttcn3-testsuites-testenv.yml @@ -142,23 +142,23 @@ - ttcn3-ggsn-test: # ~15 min testsuite: ggsn - args: -b osmocom:nightly -c 'osmo_ggsn_*' + args: -b osmocom:nightly -c osmo_ggsn_* timer: H 10 * * * - ttcn3-ggsn-test-kernel: # ~10 min testsuite: ggsn - args: -b osmocom:nightly -c 'osmo_ggsn_v*_only' --debian-kernel + args: -b osmocom:nightly -c osmo_ggsn_v*_only --debian-kernel timer: H 10 * * * - ttcn3-ggsn-test-kernel-net-next: # ~10 min testsuite: ggsn - args: -b osmocom:nightly -c 'osmo_ggsn_v*_only' --custom-kernel + args: -b osmocom:nightly -c osmo_ggsn_v*_only --custom-kernel kernel: net-next timer: H 10 * * * - ttcn3-ggsn-test-kernel-torvalds: # ~10 min testsuite: ggsn - args: -b osmocom:nightly -c 'osmo_ggsn_v*_only' --custom-kernel + args: -b osmocom:nightly -c osmo_ggsn_v*_only --custom-kernel kernel: torvalds timer: H 10 * * * @@ -309,23 +309,23 @@ - ttcn3-ggsn-test-latest: # ~15 min testsuite: ggsn - args: -b osmocom:latest -c 'osmo_ggsn_*' + args: -b osmocom:latest -c osmo_ggsn_* timer: H 12 * * * - ttcn3-ggsn-test-kernel-latest: # ~10 min testsuite: ggsn - args: -b osmocom:latest -c 'osmo_ggsn_v*_only' --debian-kernel + args: -b osmocom:latest -c osmo_ggsn_v*_only --debian-kernel timer: H 12 * * * - ttcn3-ggsn-test-kernel-latest-net-next: # ~10 min testsuite: ggsn - args: -b osmocom:latest -c 'osmo_ggsn_v*_only' --custom-kernel + args: -b osmocom:latest -c osmo_ggsn_v*_only --custom-kernel kernel: net-next timer: H 12 * * * - ttcn3-ggsn-test-kernel-latest-torvalds: # ~10 min testsuite: ggsn - args: -b osmocom:latest -c 'osmo_ggsn_v*_only' --custom-kernel + args: -b osmocom:latest -c osmo_ggsn_v*_only --custom-kernel kernel: torvalds timer: H 12 * * * @@ -479,7 +479,7 @@ - ttcn3-ggsn-test-asan: # ~15 min testsuite: ggsn - args: -b osmocom:nightly:asan -c 'osmo_ggsn_*' + args: -b osmocom:nightly:asan -c osmo_ggsn_* timer: H 16 * * * - ttcn3-stp-test-asan: # ~10 min @@ -566,6 +566,11 @@ Branch of <code>osmo-ttcn3-hacks.git</code> default: 'master' - string: + name: TESTENV_ARGS + description: | + Additional arguments to <code>./testenv.py --podman</code> + default: '{obj:args}' + - string: name: EMAIL_NOTIFICATIONS description: For failed build notifications, set to empty to disable default: '{obj:email}' @@ -610,7 +615,7 @@ --cache "$PWD"/_cache \ --ccache ~/ccache/testenv \ --log-dir "$PWD"/logs \ - {args}; then + $TESTENV_ARGS; then RC=1 fi -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40482?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I2a07319ee26ac497eff2853329a002cdb09f75b4 Gerrit-Change-Number: 40482 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

2 months, 3 weeks

1
0
0 0

[XS] Change in osmo-ci[master]: jobs/ttcn3-testsuites: add email parameter

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/40483?usp=email ) Change subject: jobs/ttcn3-testsuites: add email parameter ...................................................................... jobs/ttcn3-testsuites: add email parameter Change-Id: I9385f553196ac8d1ac1bfb05735ed937da67b7b4 --- M jobs/ttcn3-testsuites.yml 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/83/40483/1 diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml index 9e0d026..3202212 100644 --- a/jobs/ttcn3-testsuites.yml +++ b/jobs/ttcn3-testsuites.yml @@ -88,6 +88,10 @@ Branch of <code>docker-playground.git</code>. Only modify if you are hacking on the docker-playground scripts. default: 'master' + - string: + name: EMAIL_NOTIFICATIONS + description: For failed build notifications, set to empty to disable + default: '{obj:email}' builders: - shell: |- export REGISTRY_HOST="registry.osmocom.org" @@ -166,7 +170,7 @@ allow-empty-results: false - email: notify-every-unstable-build: false - recipients: '{obj:email}' + recipients: '$EMAIL_NOTIFICATIONS' send-to-individuals: false - archive: allow-empty: false -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40483?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I9385f553196ac8d1ac1bfb05735ed937da67b7b4 Gerrit-Change-Number: 40483 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

2 months, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log June 2025