June 2025 - gerrit-log - lists.osmocom.org

[M] Change in pysim[master]: smdpp: less verbose by default

by laforge

Attention is currently required from: Hoernchen. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/40468?usp=email ) Change subject: smdpp: less verbose by default ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40468?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I04a72b8f52417862d4dcba1f0743700dd942ef49 Gerrit-Change-Number: 40468 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Jun 2025 09:49:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 months, 3 weeks

1
0
0 0

[XS] Change in pysim[master]: smdpp: optional deps

by laforge

Attention is currently required from: Hoernchen, fixeria. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/40463?usp=email ) Change subject: smdpp: optional deps ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40463?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If69b2bd5f8bc604443108c942c17eba9c22f4053 Gerrit-Change-Number: 40463 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Jun 2025 09:49:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 months, 3 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: Bump titan_min to 11.1.0 where possible

by laforge

Attention is currently required from: fixeria, osmith, pespin. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40484?usp=email ) Change subject: Bump titan_min to 11.1.0 where possible ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40484?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iba562ace07e6f38a8cde15b17478a0a1680df2fc Gerrit-Change-Number: 40484 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Jun 2025 09:48:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 months, 3 weeks

1
0
0 0

[M] Change in libosmo-sigtran[master]: asp: Introduce support to configure and enable TCP keep-alive

by laforge

Attention is currently required from: fixeria, osmith, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40481?usp=email ) Change subject: asp: Introduce support to configure and enable TCP keep-alive ...................................................................... Patch Set 3: (1 comment) File src/ss7_asp.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/40481/comment/33f4f3c8_a337c… : PS3, Line 801: what kind of syntax is that "(void) rc;" without assigning any value to rc? I don't know what it is supposed to achieve. If rc of keepalive is to be ignored, why not simply set it to zero? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40481?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I2a9338053e741fb6dab94492c6bdc2badaf7afb1 Gerrit-Change-Number: 40481 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Jun 2025 07:26:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

2 months, 3 weeks

1
0
0 0

[M] Change in libosmo-sigtran[master]: WIP: m3ua: Make sure MTP-PAUSE.ind is sent to SCCP when AS goes down

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40488?usp=email ) Change subject: WIP: m3ua: Make sure MTP-PAUSE.ind is sent to SCCP when AS goes down ...................................................................... WIP: m3ua: Make sure MTP-PAUSE.ind is sent to SCCP when AS goes down Whenever an SCTP link goes down, it may affect current set of accessible DPCs if any of the routes (AS) using that ASP become inactive. The approach presented in this patch is to, based on existing route table, figure out which DPCs may have been accessible before the AS went down, and then figure out which of those are not reachable anymore, then send MTP-PAUSE.ind for those. In turn, SCCP will trigger N-PCSTATE.ind towards its users. Change-Id: I0f28b049045fbea93fe91c99251e7aaa40c014e5 --- M src/xua_as_fsm.c M src/xua_snm.c 2 files changed, 173 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/88/40488/1 diff --git a/src/xua_as_fsm.c b/src/xua_as_fsm.c index 3e117ee..1247db9 100644 --- a/src/xua_as_fsm.c +++ b/src/xua_as_fsm.c @@ -22,6 +22,7 @@ #include "xua_msg.h" #include <osmocom/sigtran/protocol/sua.h> #include <osmocom/sigtran/protocol/m3ua.h> +#include <sys/types.h> #include "ss7_as.h" #include "ss7_asp.h" @@ -413,12 +414,147 @@ } } + +#include "ss7_combined_linkset.h" +enum pc_map_item_state { + DPC_UNSET = 0, + DPC_ACTIVE, + DPC_LOST +}; +struct pc_map { + uint8_t v[16384]; /* 2^14, 14-bit PCs */ +}; + + +static void pcmap_fill_pc_mask(struct osmo_ss7_instance *ss7, struct pc_map *pcmap, uint32_t pc, uint32_t mask, enum pc_map_item_state val) +{ + unsigned int width = osmo_ss7_pc_width(&ss7->cfg.pc_fmt); + uint32_t maskbits = ~mask & ((1 << width)-1); + uint32_t fullpc; + + LOGP(DLSS7, LOGL_NOTICE, "PESPIN: FILL PCMAP PC=%u mask=0x%08x width=%u, maskbits=0x%08x\n", pc, mask, width, maskbits); + + for (fullpc = (pc & maskbits); fullpc <= (pc | maskbits); fullpc++) { + const enum pc_map_item_state prev_val = pcmap->v[fullpc]; + /* if an ACTIVE route is found for the DPC with a lower prio, it will be used, so it's not lost */ + if (prev_val == DPC_UNSET || val == DPC_ACTIVE) + pcmap->v[fullpc] = val; + } +} + + +static int pcmap_find_chunk_start(const struct pc_map *pcmap, unsigned int start, enum pc_map_item_state val) +{ + unsigned int i = start; + while (i < ARRAY_SIZE(pcmap->v)) { + if (pcmap->v[i] == val) + return i; + i++; + } + return -1; +} +static int pcmap_find_chunk_end(const struct pc_map *pcmap, unsigned int start, enum pc_map_item_state val) +{ + unsigned int i = start; + while (i < ARRAY_SIZE(pcmap->v)) { + if (pcmap->v[i] != val) + return i; + i++; + } + return i; +} + +static void as_gen_dpc_lost_bv(const struct osmo_ss7_as *as, struct pc_map *pcmap) +{ + struct osmo_ss7_instance *ss7 = as->inst; + struct osmo_ss7_route_table *rtbl = ss7->rtable_system; + struct osmo_ss7_combined_linkset *clset; + + llist_for_each_entry(clset, &rtbl->combined_linksets, list) { + struct osmo_ss7_route *rt; + bool as_match = false; + bool active = false; + /* If AS is involved and none of the combined linkset routes is working, add it: */ + llist_for_each_entry(rt, &clset->routes, list) { + if (rt->dest.as == as) + as_match = true; + else if (ss7_route_is_available(rt)) { + active = true; + break; + } + } + if (active) + pcmap_fill_pc_mask(ss7, pcmap, clset->cfg.pc, clset->cfg.mask, DPC_ACTIVE); + else if (as_match) + pcmap_fill_pc_mask(ss7, pcmap, clset->cfg.pc, clset->cfg.mask, DPC_LOST); + } +} + +static unsigned int fill_chunk(uint32_t *aff_pc, uint32_t start_pc, unsigned int num_pc, unsigned int width) +{ + if (num_pc == 1) { /* base case */ + aff_pc[0] = htonl(start_pc & 0xffffff); /* mask 0 */ + return 1; + } + + /* See if we have a whole contiguous block: */ + for (unsigned int lvl = width; lvl > 0; lvl--) { + LOGP(DLSS7, LOGL_NOTICE, "PESPIN: fill_chunk() lvl=%u %u %u\n", lvl, (start_pc & ((1 << lvl) - 1)), num_pc == (0x01 << (lvl + 1))); + + if ((start_pc & ((1 << lvl)-1)) == 0 && + num_pc == (0x01 << lvl)) { + aff_pc[0] = htonl(lvl << 24 | (start_pc & 0xffffff)); + return 1; + } + } + + LOGP(DLSS7, LOGL_NOTICE, "PESPIN: fill_chunk(START_PC=%u num_pc=%u width=%u) NOT CONTIGUOUS!\n", start_pc, num_pc, width); + + aff_pc[0] = htonl(start_pc & 0xffffff); /* mask 0 */ + return 1 + fill_chunk(aff_pc, start_pc + 1, num_pc - 1, width); +} + +static unsigned int as_became_unavailable_calc_affected_pc(const struct osmo_ss7_as *as, + uint32_t *aff_pc, unsigned int num_aff_pc) +{ + struct osmo_ss7_instance *ss7 = as->inst; + const uint32_t max_num_aff_pc = num_aff_pc; + + struct pc_map *pcmap = talloc_zero(NULL, struct pc_map); + as_gen_dpc_lost_bv(as, pcmap); + + num_aff_pc = 0; + unsigned int last_pos = 0; + int pos = 0; + + while ((pos = pcmap_find_chunk_start(pcmap, last_pos, DPC_LOST)) >= 0) { + unsigned int until = pcmap_find_chunk_end(pcmap, pos, DPC_LOST); + if (until - pos > max_num_aff_pc) { + LOGPAS(as, DLSS7, LOGL_ERROR, "Not enough space in aff_pc!\n"); + num_aff_pc += fill_chunk(&aff_pc[num_aff_pc], pos, max_num_aff_pc - num_aff_pc, osmo_ss7_pc_width(&ss7->cfg.pc_fmt)); + return num_aff_pc; + } + LOGPAS(as, DLSS7, LOGL_NOTICE, "PESPIN: FILL CHUNK PC=%u num_pcs=%u\n", pos, until - pos); + num_aff_pc += fill_chunk(&aff_pc[num_aff_pc], pos, until - pos, osmo_ss7_pc_width(&ss7->cfg.pc_fmt)); + LOGPAS(as, DLSS7, LOGL_NOTICE, "PESPIN: FILL CHUNK total num_aff_pc=%u\n", num_aff_pc); + last_pos = until + 1; + } + + return num_aff_pc; +} + +/* TODO: move to header file: */ +void xua_snm_pc_available_to_sccp(struct osmo_sccp_instance *sccp, + const uint32_t *aff_pc, unsigned int num_aff_pc, + bool available); + /* onenter call-back responsible of transmitting NTFY to all ASPs in * case of AS state changes */ static void xua_as_fsm_onenter(struct osmo_fsm_inst *fi, uint32_t old_state) { struct xua_as_fsm_priv *xafp = (struct xua_as_fsm_priv *) fi->priv; struct osmo_ss7_as *as = xafp->as; + struct osmo_ss7_instance *s7i = as->inst; struct osmo_xlm_prim_notify npar; switch (fi->state) { @@ -456,15 +592,38 @@ as_notify_all_asp(xafp->as, &npar); - /* only if we are the SG, we must start broadcasting availability information - * to everyone else */ - if (get_local_role(xafp->as) == OSMO_SS7_ASP_ROLE_SG) { + bool became_available = (old_state != XUA_AS_S_ACTIVE && fi->state == XUA_AS_S_ACTIVE); + bool became_unavailable = (old_state == XUA_AS_S_ACTIVE && fi->state != XUA_AS_S_ACTIVE); + int role = get_local_role(xafp->as); + + switch (role) { + case OSMO_SS7_ASP_ROLE_ASP: + if (s7i->sccp) { + if (became_available) { + LOGPAS(as, DLSS7, LOGL_NOTICE, "PESPIN: AS BECAME AVAILABLE!\n"); + /* TODO */ + } else if (became_unavailable) { + LOGPAS(as, DLSS7, LOGL_NOTICE, "PESPIN: AS BECAME UNAVAILABLE!\n"); + uint32_t *aff_pc = talloc_size(NULL, 16384); /* 2^14, 14-bit PCs */ + uint32_t num_aff_pc = 16384; + num_aff_pc = as_became_unavailable_calc_affected_pc(as, aff_pc, num_aff_pc); + xua_snm_pc_available_to_sccp(s7i->sccp, aff_pc, num_aff_pc, became_available); + talloc_free(aff_pc); + } + } + break; + case OSMO_SS7_ASP_ROLE_SG: + /* only if we are the SG, we must start broadcasting availability information + * to everyone else */ /* advertise availability of the routing key to others */ - uint32_t aff_pc = htonl(as->cfg.routing_key.pc); - if (old_state != XUA_AS_S_ACTIVE && fi->state == XUA_AS_S_ACTIVE) - xua_snm_pc_available(as, &aff_pc, 1, NULL, true); - else if (old_state == XUA_AS_S_ACTIVE && fi->state != XUA_AS_S_ACTIVE) - xua_snm_pc_available(as, &aff_pc, 1, NULL, false); + if (became_available || became_unavailable) { + uint32_t aff_pc = htonl(as->cfg.routing_key.pc); + xua_snm_pc_available(as, &aff_pc, 1, NULL, became_available); + } + break; + case OSMO_SS7_ASP_ROLE_IPSP: + /* TODO */ + break; } }; diff --git a/src/xua_snm.c b/src/xua_snm.c index 079cd96..2693306 100644 --- a/src/xua_snm.c +++ b/src/xua_snm.c @@ -117,9 +117,9 @@ } /* generate MTP-PAUSE / MTP-RESUME towards local SCCP users */ -static void xua_snm_pc_available_to_sccp(struct osmo_sccp_instance *sccp, - const uint32_t *aff_pc, unsigned int num_aff_pc, - bool available) +void xua_snm_pc_available_to_sccp(struct osmo_sccp_instance *sccp, + const uint32_t *aff_pc, unsigned int num_aff_pc, + bool available) { int i; for (i = 0; i < num_aff_pc; i++) { @@ -129,6 +129,8 @@ uint32_t pc = _aff_pc & 0xffffff; uint8_t mask = _aff_pc >> 24; + LOGPSCI(sccp, LOGL_ERROR, "PESPIN: mtp_pause pc=%u mask=%u available=%u\n", pc, mask, available); + if (!mask) { if (available) sccp_scmg_rx_mtp_resume(sccp, pc); @@ -140,6 +142,7 @@ uint32_t maskbits = (1 << mask) - 1; uint32_t fullpc; for (fullpc = (pc & ~maskbits); fullpc <= (pc | maskbits); fullpc++) { + LOGPSCI(sccp, LOGL_ERROR, "PESPIN: mtp_pause fullpc=%u available=%u\n", fullpc, available); if (available) sccp_scmg_rx_mtp_resume(sccp, fullpc); else -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40488?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I0f28b049045fbea93fe91c99251e7aaa40c014e5 Gerrit-Change-Number: 40488 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

2 months, 3 weeks

1
0
0 0

[XS] Change in libosmo-sigtran[master]: xua_snm.c: Fix wrong PC value passed in MTP-{PAUSE,RESUME} towards SCCP

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40487?usp=email ) Change subject: xua_snm.c: Fix wrong PC value passed in MTP-{PAUSE,RESUME} towards SCCP ...................................................................... xua_snm.c: Fix wrong PC value passed in MTP-{PAUSE,RESUME} towards SCCP Change-Id: I28bfb13744f2feb4adb610b341330725e2691a77 --- M src/xua_snm.c 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/87/40487/1 diff --git a/src/xua_snm.c b/src/xua_snm.c index 3dd988f..079cd96 100644 --- a/src/xua_snm.c +++ b/src/xua_snm.c @@ -123,6 +123,8 @@ { int i; for (i = 0; i < num_aff_pc; i++) { + /* 32bit "Affected Point Code" consists of a 7-bit mask followed by 14/16/24-bit SS7 PC, + * see RFC 4666 3.4.1 */ uint32_t _aff_pc = ntohl(aff_pc[i]); uint32_t pc = _aff_pc & 0xffffff; uint8_t mask = _aff_pc >> 24; @@ -139,9 +141,9 @@ uint32_t fullpc; for (fullpc = (pc & ~maskbits); fullpc <= (pc | maskbits); fullpc++) { if (available) - sccp_scmg_rx_mtp_resume(sccp, pc); + sccp_scmg_rx_mtp_resume(sccp, fullpc); else - sccp_scmg_rx_mtp_pause(sccp, pc); + sccp_scmg_rx_mtp_pause(sccp, fullpc); } } } -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40487?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I28bfb13744f2feb4adb610b341330725e2691a77 Gerrit-Change-Number: 40487 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

2 months, 3 weeks

1
0
0 0

[M] Change in libosmo-sigtran[master]: asp: Introduce support to configure and enable TCP keep-alive

by pespin

Attention is currently required from: fixeria, osmith. Hello Jenkins Builder, fixeria, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40481?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by osmith, Code-Review-1 by fixeria, Verified-1 by Jenkins Builder Change subject: asp: Introduce support to configure and enable TCP keep-alive ...................................................................... asp: Introduce support to configure and enable TCP keep-alive Depends: libosmo-netif.git Change-Id Ie748ad581c1c42f4c24f9409ce7d34d419cbca8b Change-Id: I2a9338053e741fb6dab94492c6bdc2badaf7afb1 --- M TODO-RELEASE M src/ss7_asp.c M src/ss7_asp.h M src/ss7_asp_vty.c M src/ss7_xua_srv.c M tests/vty/osmo_stp_test.vty 6 files changed, 202 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/81/40481/3 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40481?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I2a9338053e741fb6dab94492c6bdc2badaf7afb1 Gerrit-Change-Number: 40481 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

2 months, 3 weeks

1
0
0 0

[M] Change in libosmo-sigtran[master]: asp: Introduce support to configure and enable TCP keep-alive

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40481?usp=email ) Change subject: asp: Introduce support to configure and enable TCP keep-alive ...................................................................... Patch Set 2: (2 comments) File src/ss7_asp.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/40481/comment/6b071c95_fb2cb… : PS2, Line 800: rc = > You're assigning a value to `rc`, but then after the `switch` it gets overwritten. I did that on purpose, I don't want failure to set this make all fail, specially regarding SCTP INIT params applied on kernels which may have bad support for it, etc. There's already error logging happening in the lower layers btw. I'll add some explicit lines stating so. File src/ss7_asp_vty.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/40481/comment/d8c0eb22_f9144… : PS2, Line 512: "num-ostreams" > Acknowledged Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40481?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I2a9338053e741fb6dab94492c6bdc2badaf7afb1 Gerrit-Change-Number: 40481 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 18 Jun 2025 14:50:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

2 months, 3 weeks

1
0
0 0

[M] Change in libosmo-netif[master]: stream: Support configuring TCP_USER_TIMEOUT parameter

by pespin

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/40479?usp=email ) Change subject: stream: Support configuring TCP_USER_TIMEOUT parameter ...................................................................... Patch Set 3: (1 comment) File include/osmocom/netif/stream_private.h: https://gerrit.osmocom.org/c/libosmo-netif/+/40479/comment/9a500e46_cd1985d… : PS2, Line 52: stream_setsockopt_tcp_user_timeout > No, imho it belongs here below the tcp_pars struct. Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/40479?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I22c7df92b463cf4ca82854a12ec24337d53e8b20 Gerrit-Change-Number: 40479 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 18 Jun 2025 14:15:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

2 months, 3 weeks

1
0
0 0

[S] Change in libosmo-netif[master]: stream_srv: Improve API documentation

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/40485?usp=email ) Change subject: stream_srv: Improve API documentation ...................................................................... stream_srv: Improve API documentation Change-Id: Ib41eeef3a21ec55a175b6bbb818d05c091b46df5 --- M src/stream_srv.c 1 file changed, 9 insertions(+), 3 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/stream_srv.c b/src/stream_srv.c index be950ce..5ffb28b 100644 --- a/src/stream_srv.c +++ b/src/stream_srv.c @@ -628,7 +628,7 @@ } /*! Set given parameter of stream_srv_link to given value. - * \param[in] cli stream client on which to set parameter. + * \param[in] link stream server link on which to set parameter. * \param[in] par identifier of the parameter to be set. * \param[in] val value of the parameter to be set. * \param[in] val_len length of the parameter value. @@ -916,7 +916,10 @@ * \param[in] read_cb Call-back to call when the socket is readable * \param[in] closed_cb Call-back to call when the connection is closed * \param[in] data User data to save in the new Stream Server struct - * \returns Stream Server in case of success; NULL on error */ + * \returns Stream Server in case of success; NULL on error + * + * Note: In case of error, the caller is responsible for closing the fd. + */ struct osmo_stream_srv * osmo_stream_srv_create(void *ctx, struct osmo_stream_srv_link *link, int fd, osmo_stream_srv_read_cb_t read_cb, @@ -959,7 +962,10 @@ * \param[in] link Stream Server Link to which we belong * \param[in] fd system file descriptor of the new connection * \param[in] data User data to save in the new Stream Server struct - * \returns Stream Server in case of success; NULL on error */ + * \returns Stream Server in case of success; NULL on error + * + * Note: In case of error, the caller is responsible for closing the fd. + */ struct osmo_stream_srv * osmo_stream_srv_create2(void *ctx, struct osmo_stream_srv_link *link, int fd, void *data) { -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/40485?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ib41eeef3a21ec55a175b6bbb818d05c091b46df5 Gerrit-Change-Number: 40485 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

2 months, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log June 2025