May 2025 - gerrit-log - lists.osmocom.org

[S] Change in osmo-hnbgw[master]: cnlink: Cleanup talloc tree

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40267?usp=email ) Change subject: cnlink: Cleanup talloc tree ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Patchset: PS3: commit message could benefit from describing old and new talloc tree. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40267?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I90c22f2a2932ede7103c66f2263e72ac2fdae497 Gerrit-Change-Number: 40267 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 May 2025 11:26:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 month, 2 weeks

1
0
0 0

[L] Change in osmo-hnbgw[master]: Move cnlink funcs from hnbgw_cn.c to cnlink.c

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40266?usp=email ) Change subject: Move cnlink funcs from hnbgw_cn.c to cnlink.c ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40266?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ic9a962877ea000aa1bca6c2c282baac6e53f6489 Gerrit-Change-Number: 40266 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 May 2025 11:25:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month, 2 weeks

1
0
0 0

[L] Change in osmo-hnbgw[master]: Get rid of cnpool->cnlink_ctrg_desc

by laforge

Attention is currently required from: daniel, fixeria, neels, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40265?usp=email ) Change subject: Get rid of cnpool->cnlink_ctrg_desc ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40265?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Iaa36bb52f8135ef2421931f1ea6a40885b588e1d Gerrit-Change-Number: 40265 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 May 2025 11:25:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month, 2 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: hnbgw: Introduce tests TC_ps_rab_release(_abnormal)

by laforge

Attention is currently required from: fixeria, neels, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40272?usp=email ) Change subject: hnbgw: Introduce tests TC_ps_rab_release(_abnormal) ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40272?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia25efc2d6bf01d4a13e7fd1ce0563d20dd2e321e Gerrit-Change-Number: 40272 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 May 2025 11:25:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Introduce altstep as_pfcp_handle_del_req()

by laforge

Attention is currently required from: fixeria, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40271?usp=email ) Change subject: hnbgw: Introduce altstep as_pfcp_handle_del_req() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40271?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I94101b5f0ad8634db68f0a9d5230c00926b02061 Gerrit-Change-Number: 40271 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 May 2025 11:24:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month, 2 weeks

1
0
0 0

[S] Change in libosmo-sigtran[master]: sccp: Implement dpc_accessible()

by laforge

Attention is currently required from: daniel, fixeria, neels, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40250?usp=email ) Change subject: sccp: Implement dpc_accessible() ...................................................................... Patch Set 2: (1 comment) File src/sccp_scrc.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/40250/comment/11d58332_34f10… : PS2, Line 87: LOGL_INFO > I think INFO for something which most probably denotes some operation problem or wrong config it goo […] I think the point code should not be printed as integer but in the correct user-configured point code format. We should have formatting functions for that around... -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40250?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I16b0aa71db5be2daf7a8c52da829a38ad564eb7b Gerrit-Change-Number: 40250 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 May 2025 11:24:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 month, 2 weeks

1
0
0 0

[M] Change in ...osmo-epdg[master]: Enable the use of an UE requested IP type and address to be used for ...

by laforge

Attention is currently required from: clufn, fixeria. laforge has posted comments on this change by clufn. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40277?usp=email ) Change subject: Enable the use of an UE requested IP type and address to be used for gtpv2 PDN Address Allocation ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40277?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: If0c77b1e366df36439d3a1b72030d831dd1b3a05 Gerrit-Change-Number: 40277 Gerrit-PatchSet: 4 Gerrit-Owner: clufn <callumfarrbennett(a)yahoo.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: clufn <callumfarrbennett(a)yahoo.com> Gerrit-Comment-Date: Mon, 12 May 2025 11:23:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month, 2 weeks

1
0
0 0

[S] Change in osmo-hnbgw[master]: kpi: Use HNB_CTR_RANAP_CS_RAB_REL_REQ(_ABNORMAL) explicitly

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40278?usp=email to look at the new patch set (#3). Change subject: kpi: Use HNB_CTR_RANAP_CS_RAB_REL_REQ(_ABNORMAL) explicitly ...................................................................... kpi: Use HNB_CTR_RANAP_CS_RAB_REL_REQ(_ABNORMAL) explicitly I was first tricked by the increment of ctr_num. This is wrong for several reasons: * Assumes one counter will always be immediatelly after the other, and there's no static assert about that. * Makes it difficult to grep for users of the counter in the code. Change-Id: I126973b93e86784adaccbcba49c6322c261f4746 --- M src/osmo-hnbgw/kpi_ranap.c 1 file changed, 4 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/78/40278/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40278?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I126973b93e86784adaccbcba49c6322c261f4746 Gerrit-Change-Number: 40278 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 month, 2 weeks

1
0
0 0

[XS] Change in osmo-hnbgw[master]: kpi: Use HNB_CTR_RANAP_CS_RAB_REL_REQ(_ABNORMAL) explicitly

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40278?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: kpi: Use HNB_CTR_RANAP_CS_RAB_REL_REQ(_ABNORMAL) explicitly ...................................................................... kpi: Use HNB_CTR_RANAP_CS_RAB_REL_REQ(_ABNORMAL) explicitly I was first tricked by the increment of ctr_num. This is wrong for several reasons: * Assumes one counter will always be immediatelly after the other, and there's no static assert about that. * Makes it difficult to grep for users of the counter in the code. Change-Id: I126973b93e86784adaccbcba49c6322c261f4746 --- M src/osmo-hnbgw/kpi_ranap.c 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/78/40278/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40278?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I126973b93e86784adaccbcba49c6322c261f4746 Gerrit-Change-Number: 40278 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 month, 2 weeks

1
0
0 0

[XS] Change in osmo-hnbgw[master]: kpi: Fix HNB_CTR_RANAP_CS_RAB_REL_REQ(_ABNORMAL) never incremented

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40278?usp=email ) Change subject: kpi: Fix HNB_CTR_RANAP_CS_RAB_REL_REQ(_ABNORMAL) never incremented ...................................................................... kpi: Fix HNB_CTR_RANAP_CS_RAB_REL_REQ(_ABNORMAL) never incremented Change-Id: I126973b93e86784adaccbcba49c6322c261f4746 --- M src/osmo-hnbgw/kpi_ranap.c 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/78/40278/1 diff --git a/src/osmo-hnbgw/kpi_ranap.c b/src/osmo-hnbgw/kpi_ranap.c index c1c77bf..97f3a76 100644 --- a/src/osmo-hnbgw/kpi_ranap.c +++ b/src/osmo-hnbgw/kpi_ranap.c @@ -153,9 +153,11 @@ case RAB_STATE_ACTIVE: if (rab_rel_item->cause.present == RANAP_Cause_PR_nAS && rab_rel_item->cause.choice.nAS == RANAP_CauseNAS_normal_release) { - ctr_num = HNB_CTR_RANAP_PS_RAB_REL_REQ; + ctr_num = map->is_ps ? HNB_CTR_RANAP_PS_RAB_REL_REQ : + HNB_CTR_RANAP_CS_RAB_REL_REQ; } else { - ctr_num = HNB_CTR_RANAP_PS_RAB_REL_REQ_ABNORMAL; + ctr_num = map->is_ps ? HNB_CTR_RANAP_PS_RAB_REL_REQ_ABNORMAL : + HNB_CTR_RANAP_CS_RAB_REL_REQ_ABNORMAL; } if (!map->is_ps) ctr_num++; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40278?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I126973b93e86784adaccbcba49c6322c261f4746 Gerrit-Change-Number: 40278 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 month, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2025