May 2025 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: NGAP_Templates: Fix criticality of PLMNSupportList IE in NGSetupResponse

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40364?usp=email ) Change subject: NGAP_Templates: Fix criticality of PLMNSupportList IE in NGSetupResponse ...................................................................... NGAP_Templates: Fix criticality of PLMNSupportList IE in NGSetupResponse The criticality rejected is specified in 3GPP TS 38.413 version 18.5.0 Release 18, both in the ASN.1 definition of "NGSetupResponseIEs NGAP-PROTOCOL-IES", as well as section 9.2.6.2. open5gs-amfd is correctly sending reject there. Change-Id: I0e73a97201e61a41ce5b056a149e185582ed187c --- M library/ngap/NGAP_Templates.ttcn 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved osmith: Looks good to me, but someone else must approve diff --git a/library/ngap/NGAP_Templates.ttcn b/library/ngap/NGAP_Templates.ttcn index 9d77cec..592f2ae 100644 --- a/library/ngap/NGAP_Templates.ttcn +++ b/library/ngap/NGAP_Templates.ttcn @@ -5794,7 +5794,7 @@ }, { id := id_PLMNSupportList, - criticality := ignore, + criticality := reject, value_ := { PLMNSupportList := p_plmnSuppList } } } @@ -5836,8 +5836,8 @@ value_ := { RelativeAMFCapacity := p_relativeAmfCap } }, { - id := id_PLMNSupportList, - criticality := ignore, + id := id_PLMNSupportList, + criticality := reject, value_ := { PLMNSupportList := p_plmnSuppList } } } @@ -5874,7 +5874,7 @@ }, { id := id_PLMNSupportList, - criticality := ignore, + criticality := reject, value_ := { PLMNSupportList := p_plmnSuppList } }, { @@ -5916,7 +5916,7 @@ }, { id := id_PLMNSupportList, - criticality := ignore, + criticality := reject, value_ := { PLMNSupportList := p_plmnSuppList } }, { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40364?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0e73a97201e61a41ce5b056a149e185582ed187c Gerrit-Change-Number: 40364 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 weeks, 1 day

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: NGAP_Templates: Add missing rx template for NGSetupFailure with TimeT...

by pespin

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40365?usp=email ) Change subject: NGAP_Templates: Add missing rx template for NGSetupFailure with TimeToWait optional IE ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40365?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I241b83119e1fcf849895393ac1a1231368a85cbb Gerrit-Change-Number: 40365 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 May 2025 08:50:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 weeks, 1 day

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: ngap: NGAP_Pixits: fix modulepar without default value assigned to te...

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40363?usp=email ) Change subject: ngap: NGAP_Pixits: fix modulepar without default value assigned to template ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40363?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib2410457d2b25f09134509b618b079b010e6ace0 Gerrit-Change-Number: 40363 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 May 2025 08:50:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 weeks, 1 day

1
0
0 0

[XL] Change in osmo-ttcn3-hacks[master]: library: Add NGAP_Templates.ttcn

by pespin

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40362?usp=email ) Change subject: library: Add NGAP_Templates.ttcn ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40362?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I52aed2961329ee904de82b4fdb91e3eaca2059c9 Gerrit-Change-Number: 40362 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 May 2025 08:50:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 weeks, 1 day

1
0
0 0

[XL] Change in osmo-ttcn3-hacks[master]: library: NGAP encoding/decoding using libfftranscode

by pespin

Attention is currently required from: jolly, laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40361?usp=email ) Change subject: library: NGAP encoding/decoding using libfftranscode ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40361?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia8e29c77e09a4388c774e3d7286f96052d67fe3f Gerrit-Change-Number: 40361 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 26 May 2025 08:50:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 weeks, 1 day

1
0
0 0

[M] Change in ...osmo-s1gw[master]: s1ap_proxy: parse and store Global-ENB-ID IE

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40368?usp=email ) Change subject: s1ap_proxy: parse and store Global-ENB-ID IE ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40368?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Icc24d4daf06d161d7b5b386456e8e92ac07d5eba Gerrit-Change-Number: 40368 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 May 2025 08:48:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 weeks, 1 day

1
0
0 0

[XS] Change in ...osmo-s1gw[master]: debian: drop unneeded libpcap-dev

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40348?usp=email ) Change subject: debian: drop unneeded libpcap-dev ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40348?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I4c152b6f5f517acccfe4aa856447c59eb1212707 Gerrit-Change-Number: 40348 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 May 2025 08:47:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 weeks, 1 day

1
0
0 0

[XS] Change in docker-playground[master]: debian-bookworm-build: add deps for osmo-dev test

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/40358?usp=email ) Change subject: debian-bookworm-build: add deps for osmo-dev test ...................................................................... debian-bookworm-build: add deps for osmo-dev test Prepare to run new tests for gen_makefile.py in osmo-dev in CI. This requires pytest and open5gs dependencies to pass "meson setup". Related: osmo-dev I8bb2af7ffb902fd690e83e36739c2b4415b9ab80 Change-Id: I528565fe21b5989fff1d1b005e53136af5be429e --- M debian-bookworm-build/Dockerfile 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/debian-bookworm-build/Dockerfile b/debian-bookworm-build/Dockerfile index 170d363..5b98bef 100644 --- a/debian-bookworm-build/Dockerfile +++ b/debian-bookworm-build/Dockerfile @@ -104,13 +104,16 @@ libgnutls28-dev \ libgps-dev \ libgsm1-dev \ + libidn-dev \ libjansson-dev \ liblua5.3-dev \ libmnl-dev \ + libmongoc-dev \ libncurses5-dev \ libnewlib-arm-none-eabi \ libnftables-dev \ libnftnl-dev \ + libnghttp2-dev \ libnl-3-dev \ libnl-route-3-dev \ liboping-dev \ @@ -124,6 +127,7 @@ libsnmp-dev \ libsofia-sip-ua-glib-dev \ libsqlite3-dev \ + libssh-gcrypt-dev \ libssl-dev \ libtalloc-dev \ libtinfo5 \ @@ -132,10 +136,12 @@ libusb-1.0-0-dev \ libusb-dev \ libxml2-utils \ + libyaml-dev \ libzmq3-dev \ locales \ lua-socket \ make \ + meson \ mscgen \ ofono \ openssh-client \ @@ -149,6 +155,7 @@ python3-nwdiag \ python3-pip \ python3-pyflakes \ + python3-pytest \ python3-setuptools \ python3-usb \ python3-yaml \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/40358?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I528565fe21b5989fff1d1b005e53136af5be429e Gerrit-Change-Number: 40358 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 weeks, 1 day

1
0
0 0

[XS] Change in docker-playground[master]: debian-bookworm-build: add deps for osmo-dev test

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/docker-playground/+/40358?usp=email ) Change subject: debian-bookworm-build: add deps for osmo-dev test ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/40358?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I528565fe21b5989fff1d1b005e53136af5be429e Gerrit-Change-Number: 40358 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 May 2025 08:42:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 weeks, 1 day

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: NGAP_Templates: Add missing rx template for NGSetupFailure with TimeT...

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40365?usp=email ) Change subject: NGAP_Templates: Add missing rx template for NGSetupFailure with TimeToWait optional IE ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40365?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I241b83119e1fcf849895393ac1a1231368a85cbb Gerrit-Change-Number: 40365 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 May 2025 07:25:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 weeks, 1 day

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2025