Attention is currently required from: fixeria.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40363?usp=email )
Change subject: ngap: NGAP_Pixits: fix modulepar without default value assigned to template
......................................................................
Patch Set 1:
(1 comment)
File library/ngap/NGAP_Pixits.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40363/comment/7bc96c57_673f… :
PS1, Line 356: PX_NEXT_HOP_NH
> Maybe do `oct2bin()` to make it shorter? Not critical.
This file will most probably end up going completely away as we adapt more and more the templates to our needs. But I belive it makes sense to do that step by step in the git repo.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40363?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib2410457d2b25f09134509b618b079b010e6ace0
Gerrit-Change-Number: 40363
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 24 May 2025 21:57:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: daniel, laforge, pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40327?usp=email )
Change subject: asp: Avoid double-free of received msg if conn is teared down
......................................................................
Patch Set 2:
(3 comments)
Patchset:
PS2:
This looks very similar to https://osmocom.org/issues/6728 (use-after-free/double-free in osmo-bts). If this is it, in how may other places do we have to do `talloc_steal()` before we finally agree on fixing the root problem?
File src/ss7_asp.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/40327/comment/d7ce0d58_ef639… :
PS2, Line 884: msg being is by
What do you mean here? Is owned by iofd?
https://gerrit.osmocom.org/c/libosmo-sigtran/+/40327/comment/6ed4298c_d4a50… :
PS2, Line 885: which may be automatically
may be what? free()d?
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40327?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I69f80f611c14db2b328dafd4a90247c6f2dac6fd
Gerrit-Change-Number: 40327
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 24 May 2025 09:03:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40367?usp=email )
Change subject: 5gc: initial
......................................................................
Patch Set 1:
(2 comments)
File 5gc/C5G_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40367/comment/da7ff9f7_126f… :
PS1, Line 265: var charstring id := testcasename();
Do we really want doing this in each and every testcase?
Why not just calling `testcasename()` where it's needed, i.e. in `f_init_one_ngran()`?
File Makefile:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40367/comment/19d0e10c_ea42… :
PS1, Line 63: PARALLEL_MAKE ?= -j4
unrelated change
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40367?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I867433c87c6da2f0d1f299245aedf4830acbf539
Gerrit-Change-Number: 40367
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 24 May 2025 08:53:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40366?usp=email )
Change subject: library: Introduce NGAP Emulation
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
File library/NGAP_Functions.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40366/comment/f9968865_7415… :
PS1, Line 3: 2019 by Harald Welte
Did Harald really write this code?
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40366/comment/714edbc8_743e… :
PS1, Line 20: f_NGAP_get_AMF_UE_NGAP_ID
Looks like WIP code? Returning `omit` in all cases does not look useful?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40366?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5aea8be12c54cf907e71bffe6456efb5e60eb203
Gerrit-Change-Number: 40366
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 24 May 2025 08:47:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40364?usp=email )
Change subject: NGAP_Templates: Fix criticality of PLMNSupportList IE in NGSetupResponse
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40364?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I0e73a97201e61a41ce5b056a149e185582ed187c
Gerrit-Change-Number: 40364
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 24 May 2025 08:39:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40363?usp=email )
Change subject: ngap: NGAP_Pixits: fix modulepar without default value assigned to template
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File library/ngap/NGAP_Pixits.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40363/comment/294db324_eb84… :
PS1, Line 356: PX_NEXT_HOP_NH
Maybe do `oct2bin()` to make it shorter? Not critical.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40363?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib2410457d2b25f09134509b618b079b010e6ace0
Gerrit-Change-Number: 40363
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 24 May 2025 08:39:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
