lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

April 2025

  • 1 participants
  • 1186 discussions
[M] Change in osmocom-bb[master]: trx_toolkit/data_msg: Optimize RxMsg/TxMsg parsing
by kirr 17 Apr '25

17 Apr '25
kirr has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/40078?usp=email ) Change subject: trx_toolkit/data_msg: Optimize RxMsg/TxMsg parsing ...................................................................... Patch Set 1: (2 comments) File src/target/trx_toolkit/data_msg.pyx: https://gerrit.osmocom.org/c/osmocom-bb/+/40078/comment/cc6fb76d_90adae90?u… : PS1, Line 397: # NOTE header lenght is already pre-checked by _parse_msg > 'lenght' may be misspelled - perhaps 'length'? Please fix. https://gerrit.osmocom.org/c/osmocom-bb/+/40078/comment/f685c27d_8b5f2926?u… : PS1, Line 710: # NOTE header lenght is already pre-checked by _parse_msg > 'lenght' may be misspelled - perhaps 'length'? Please fix. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/40078?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I661a414bf5091fa6b872831ba911465a8d073397 Gerrit-Change-Number: 40078 Gerrit-PatchSet: 1 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Apr 2025 15:33:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
1 0
0 0
[S] Change in osmocom-bb[master]: trx_toolkit/udp_link: Factor code to describe remote into .desc_remot...
by kirr 17 Apr '25

17 Apr '25
Attention is currently required from: fixeria, laforge. kirr has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/40046?usp=email ) Change subject: trx_toolkit/udp_link: Factor code to describe remote into .desc_remote() function ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Acknowledged, but can be merged as-is and further improved later. Here we do not need it for performance. We only need to move the logic into one place because in https://gerrit.osmocom.org/c/osmocom-bb/+/40055 str remote_addr + remote_port will be changed to sole `struct sockaddr_in remote_addr` and without keeping the logic in one place we will need to update all users. I used a function, because `.desc_link()` is already a function, not a property. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/40046?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I1e2fa560ada7a8de4c9b9150058c2a1c73874fbe Gerrit-Change-Number: 40046 Gerrit-PatchSet: 1 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Apr 2025 13:22:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
1 0
0 0
[XS] Change in osmocom-bb[master]: trx_toolkit/burst_fwd: Do not inherit BurstForwarder from TRXList
by fixeria 17 Apr '25

17 Apr '25
Attention is currently required from: kirr. fixeria has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/40053?usp=email ) Change subject: trx_toolkit/burst_fwd: Do not inherit BurstForwarder from TRXList ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/40053?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I9ce8ca1531eea5d59358fb41cc99d8c349757abb Gerrit-Change-Number: 40053 Gerrit-PatchSet: 1 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: kirr <kirr(a)nexedi.com> Gerrit-Comment-Date: Thu, 17 Apr 2025 12:41:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[L] Change in osmocom-bb[master]: trx_toolkit/fake_trx: Split it into fake_trx and _fake_trx modules
by fixeria 17 Apr '25

17 Apr '25
Attention is currently required from: kirr. fixeria has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/40051?usp=email ) Change subject: trx_toolkit/fake_trx: Split it into fake_trx and _fake_trx modules ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/40051?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iadffd49de8197564e57bfd9cb660b1d11136ffd4 Gerrit-Change-Number: 40051 Gerrit-PatchSet: 1 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: kirr <kirr(a)nexedi.com> Gerrit-Comment-Date: Thu, 17 Apr 2025 12:37:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[M] Change in osmocom-bb[master]: trx_toolkit/fake_trx: Factor functionality to run IO loop out of Appl...
by fixeria 17 Apr '25

17 Apr '25
Attention is currently required from: kirr. fixeria has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/40050?usp=email ) Change subject: trx_toolkit/fake_trx: Factor functionality to run IO loop out of Application ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/40050?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I28613087f48c327763537b53b97cad1e67d91f1a Gerrit-Change-Number: 40050 Gerrit-PatchSet: 1 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: kirr <kirr(a)nexedi.com> Gerrit-Comment-Date: Thu, 17 Apr 2025 12:34:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[M] Change in osmocom-bb[master]: trx_toolkit/clck_gen: Don't use threads because Python GIL is latency...
by kirr 17 Apr '25

17 Apr '25
Attention is currently required from: fixeria. kirr has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/40047?usp=email ) Change subject: trx_toolkit/clck_gen: Don't use threads because Python GIL is latency killer ...................................................................... Patch Set 1: (1 comment) File src/target/trx_toolkit/clck_gen.py: https://gerrit.osmocom.org/c/osmocom-bb/+/40047/comment/bd393094_cf60d47f?u… : PS1, Line 54: RR Scheduler priority of thread. None = don't set it. > IMO, it would be cleaner to revert pespin's patches (https://gerrit.osmocom. […] Maybe. For me it is a bit of overkill and I'm already over the time budget for this task. The patch does: "remove clock thread" step. So I think it is ok to remove in this task everything that is related to clock thread, including setting priority of that thread. In fact it is even more logical to remove this RR sched priority in _this_ patch, because we move clock handling to IO loop with priority over data and ctrl, thus transferring handling setting this clock thread priority to priority of handling clock IO. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/40047?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iaa675c95059ec8ccfad667f69984d5a7f608c249 Gerrit-Change-Number: 40047 Gerrit-PatchSet: 1 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Apr 2025 12:33:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
1 0
0 0
[M] Change in osmocom-bb[master]: trx_toolkit/clck_gen: Don't use threads because Python GIL is latency...
by kirr 17 Apr '25

17 Apr '25
Attention is currently required from: fixeria. kirr has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/40047?usp=email ) Change subject: trx_toolkit/clck_gen: Don't use threads because Python GIL is latency killer ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: From the patch description: > Unfortunately os.timerfd_create() & friends are only available starting > from Python 3.13 . If this poses a problem it can be easily solved by > doing those timerfd related system calls in Cython, after we switch most > of the codebase to Cython later. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/40047?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iaa675c95059ec8ccfad667f69984d5a7f608c249 Gerrit-Change-Number: 40047 Gerrit-PatchSet: 1 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Apr 2025 12:27:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
1 0
0 0
[M] Change in osmocom-bb[master]: trx_toolkit/clck_gen: Split it into clck_gen and _clck_gen modules
by fixeria 17 Apr '25

17 Apr '25
Attention is currently required from: kirr. fixeria has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/40049?usp=email ) Change subject: trx_toolkit/clck_gen: Split it into clck_gen and _clck_gen modules ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/40049?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: If90f5b6718d6a24eda6221e52dc4626197f57356 Gerrit-Change-Number: 40049 Gerrit-PatchSet: 1 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: kirr <kirr(a)nexedi.com> Gerrit-Comment-Date: Thu, 17 Apr 2025 12:23:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[M] Change in osmocom-bb[master]: trx_toolkit/clck_gen: Don't use threads because Python GIL is latency...
by fixeria 17 Apr '25

17 Apr '25
Attention is currently required from: kirr. fixeria has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/40047?usp=email ) Change subject: trx_toolkit/clck_gen: Don't use threads because Python GIL is latency killer ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > The build verification fails because of this error: […] https://docs.python.org/3/library/os.html#timer-file-descriptors tells that this API is added in 3.13, so this change requires a more recent Python version. In general, I am fine bumping the Python version requirement. On the other hand, this would make life harder for those running Debian bookworm, for instance... -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/40047?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iaa675c95059ec8ccfad667f69984d5a7f608c249 Gerrit-Change-Number: 40047 Gerrit-PatchSet: 1 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: kirr <kirr(a)nexedi.com> Gerrit-Comment-Date: Thu, 17 Apr 2025 10:50:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
1 0
0 0
[S] Change in osmocom-bb[master]: trx_toolkit/transceiver: Remove _tx_queue_lock
by fixeria 17 Apr '25

17 Apr '25
Attention is currently required from: kirr. fixeria has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/40048?usp=email ) Change subject: trx_toolkit/transceiver: Remove _tx_queue_lock ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/40048?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I77762564326b370479845a347fc512cb5f643bda Gerrit-Change-Number: 40048 Gerrit-PatchSet: 1 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: kirr <kirr(a)nexedi.com> Gerrit-Comment-Date: Thu, 17 Apr 2025 10:35:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 41
  • 42
  • 43
  • 44
  • 45
  • 46
  • 47
  • ...
  • 119
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.