April 2025 - gerrit-log - lists.osmocom.org

[S] Change in pysim[master]: [6/7] personalization: refactor K, Opc

by laforge

laforge has abandoned this change. ( https://gerrit.osmocom.org/c/pysim/+/39746?usp=email ) Change subject: [6/7] personalization: refactor K, Opc ...................................................................... Abandoned looks like this was merged into https://gerrit.osmocom.org/c/pysim/+/39745 and it was forgotten to abandon this one? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39746?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I966817db38333b6c82f8e316552dfc987e23ab70 Gerrit-Change-Number: 39746 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

4 months

1
0
0 0

[M] Change in ...osmo-s1gw[master]: Bump version: 0.2.0-61-g09ac383 → 0.3.0

by laforge

Attention is currently required from: fixeria, osmith. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40091?usp=email ) Change subject: Bump version: 0.2.0-61-g09ac383 → 0.3.0 ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40091?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ibd805fb754ed210e07f2a7fea1a14f610e35e520 Gerrit-Change-Number: 40091 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sat, 19 Apr 2025 16:17:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months

1
0
0 0

[S] Change in pysim[master]: [6/6] personalization: refactor SdKey

by laforge

Attention is currently required from: dexter, neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39747?usp=email ) Change subject: [6/6] personalization: refactor SdKey ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39747?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I427ea851bfa28b2b045e70a19a9e35d361f0d393 Gerrit-Change-Number: 39747 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sat, 19 Apr 2025 16:17:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months

1
0
0 0

[M] Change in pysim[master]: [4/6] personalization: refactor Pin, Adm

by laforge

Attention is currently required from: neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39744?usp=email ) Change subject: [4/6] personalization: refactor Pin, Adm ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39744?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I54aef10b6d4309398d4b779a3740a7d706d68603 Gerrit-Change-Number: 39744 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Sat, 19 Apr 2025 16:15:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months

1
0
0 0

[M] Change in pysim[master]: [3/6] personalization: refactor Puk

by laforge

Attention is currently required from: neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39743?usp=email ) Change subject: [3/6] personalization: refactor Puk ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39743?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I271e6c030c890778ab7af9ab3bc7997e22018f6a Gerrit-Change-Number: 39743 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Sat, 19 Apr 2025 16:14:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months

1
0
0 0

[M] Change in pysim[master]: [2/6] personalization: refactor ConfigurableParameter, Iccid, Imsi

by laforge

Attention is currently required from: dexter, fixeria, neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39742?usp=email ) Change subject: [2/6] personalization: refactor ConfigurableParameter, Iccid, Imsi ...................................................................... Patch Set 7: Code-Review+1 (2 comments) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/39742/comment/77dfcdc5_a3eee2d7?usp=em… : PS7, Line 67: = shouldn't that be a double-equals (also below)? to me it looks like an assignment rather than a comparison? https://gerrit.osmocom.org/c/pysim/+/39742/comment/a0f0005a_ad7564bd?usp=em… : PS7, Line 100: allow_types = (str, int, ) Does the comma with empty element imply that None is a vaid input value? In that case, I'd prefer an explicit None. Not critical. Just saying I don't understand the way that code is written. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39742?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6522be4c463e34897ca9bff2309b3706a88b3ce8 Gerrit-Change-Number: 39742 Gerrit-PatchSet: 7 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sat, 19 Apr 2025 16:11:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

4 months

1
0
0 0

[M] Change in pysim[master]: [1/6] personalization: refactor: drop ClassVarMeta use

by laforge

Attention is currently required from: fixeria, neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39741?usp=email ) Change subject: [1/6] personalization: refactor: drop ClassVarMeta use ...................................................................... Patch Set 7: (1 comment) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/39741/comment/f3b91bd8_214049bb?usp=em… : PS7, Line 155: class SdKeyScp80_01(SdKey): I'm still somewhat doubtful that this is an improvement. You're turning something that was a very nice single-line syntax into something that now needs three lines to declare something. The original syntax was almost like a table, with columns listing each key_id and key_usage_qual at the same positinin of each line... What I really fail to see is some kind of argument in the commit log how the new approach is better than the old one. I really don't want to spend weeks or months arguing about this. I just want to understand what is the improvement here. "Not using a metaclass" doesn't seem like a qualitative improvement of the code. What was the problem caused by the metaclass? Why is it desirable to not use one? The questions are not rhethorical. I tend to use metaclasses quite a bit in pySim and elsewhere, and so far nobody has argued in code review that anything is wrong about this. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39741?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I60ea8fd11fb438ec90ddb08b17b658cbb789c051 Gerrit-Change-Number: 39741 Gerrit-PatchSet: 7 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sat, 19 Apr 2025 16:07:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

4 months

1
0
0 0

[M] Change in osmocom-bb[master]: trx_toolkit/clck_gen: Don't use threads because Python GIL is latency...

by kirr

Attention is currently required from: fixeria. kirr has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/40047?usp=email ) Change subject: trx_toolkit/clck_gen: Don't use threads because Python GIL is latency killer ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > P.S. However one thing that could be maybe possible to maybe do is to merge the patch > of pyx timerfd right after switch to cython. Then the time where fake_trx becomes py3.13-only will be limited. I moved `trx_toolkit/_clck_gen: Unroll our own timerfd_* functions` to come right after `trx_toolkit: Move FakeTRX-related performance-sensitive modules to Cython` in the patch series as explained above. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/40047?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iaa675c95059ec8ccfad667f69984d5a7f608c249 Gerrit-Change-Number: 40047 Gerrit-PatchSet: 1 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 18 Apr 2025 08:19:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: kirr <kirr(a)nexedi.com> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

4 months

1
0
0 0

[M] Change in osmocom-bb[master]: trx_toolkit/clck_gen: Don't use threads because Python GIL is latency...

by kirr

Attention is currently required from: fixeria. kirr has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/40047?usp=email ) Change subject: trx_toolkit/clck_gen: Don't use threads because Python GIL is latency killer ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Looks good to me, thank you! […] Vadim, thanks for feedback. There are drawbacks of both approaches: if we do it earlier in the patchset, then faketrx cannot work without cython at all. However this fix does not require cython and can be done in pure python. It brings significant benefit just by itself, but unfortunately that speedup is not enough. Overall the problem here is similar to bootstrapping: you cannot really do via single-step without braking something: do single step in plain py - we break compatibility with py < 3.13. Do single step with upgrading to cython: we break compatibility with current tests because they all do currently fail as it is not programmed there to build fake_trx before running it. I choosed to do this step in plain py without bringing cython yet, because it looks more logical to me to fix this while being at plain py level. Reworking the patches to bring cython earlier would be alot of internal inter-patch churn without, in my view, strong benefit. I would appreciate if we can leave the order of steps as they are currently. Kirill P.S. However one thing that could be maybe possible to maybe do is to merge the patch of pyx timerfd right after switch to cython. Then the time where fake_trx becomes py3.13-only will be limited. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/40047?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iaa675c95059ec8ccfad667f69984d5a7f608c249 Gerrit-Change-Number: 40047 Gerrit-PatchSet: 1 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 18 Apr 2025 08:12:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: kirr <kirr(a)nexedi.com> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

4 months

1
0
0 0

[M] Change in osmocom-bb[master]: trx_toolkit/clck_gen: Don't use threads because Python GIL is latency...

by fixeria

Attention is currently required from: kirr. fixeria has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/40047?usp=email ) Change subject: trx_toolkit/clck_gen: Don't use threads because Python GIL is latency killer ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > > Unfortunately os.timerfd_create() & friends are only available starting […] Looks good to me, thank you! Just one moment: can we somehow do this earlier in the patchset? Otherwise one would have to bypass the build verification for most of the patches in this set. Not only this is annoying (it needs to be done manually for each patch), but also imposes a risk of not noticing a regression somewhere in the middle. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/40047?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iaa675c95059ec8ccfad667f69984d5a7f608c249 Gerrit-Change-Number: 40047 Gerrit-PatchSet: 1 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: kirr <kirr(a)nexedi.com> Gerrit-Comment-Date: Fri, 18 Apr 2025 07:24:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: kirr <kirr(a)nexedi.com> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2025