March 2025 - gerrit-log - lists.osmocom.org

[S] Change in osmocom-bb[master]: fake_trx: Allow setting sched RR priority for clckgen thread

by kirr

Attention is currently required from: daniel, laforge, pespin. kirr has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmocom-bb/+/39815?usp=email ) Change subject: fake_trx: Allow setting sched RR priority for clckgen thread ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: Maybe I'm missing something but was it considered to simply run fake_trx.py via `chrt` instead? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/39815?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I3c7f36c17fc7b9cae1023b4a0ed37f983dc286dc Gerrit-Change-Number: 39815 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Mar 2025 18:43:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

3 months, 3 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: bts: Run osmo-bts-trx with sched_rr priority

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39821?usp=email ) Change subject: bts: Run osmo-bts-trx with sched_rr priority ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39821?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0251ed3ec0645617cf4e9bcc03e75c805bf1634c Gerrit-Change-Number: 39821 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Mar 2025 18:24:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 3 weeks

1
0
0 0

[XS] Change in docker-playground[master]: ttcn3-bts-test: Run fake_trx with sched-prio-rr

by fixeria

Attention is currently required from: daniel, laforge, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/docker-playground/+/39816?usp=email ) Change subject: ttcn3-bts-test: Run fake_trx with sched-prio-rr ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/39816?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I8f9df66e0819881587b55c93043fed9a294ab5e8 Gerrit-Change-Number: 39816 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Mar 2025 18:23:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 3 weeks

1
0
0 0

[XS] Change in docker-playground[master]: ttcn3-bts: Allow running osmo-bts-trx with rt prio

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/docker-playground/+/39822?usp=email ) Change subject: ttcn3-bts: Allow running osmo-bts-trx with rt prio ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/39822?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ie85d62a865db9ee0ec26a476bb42e4a6ca0ef70b Gerrit-Change-Number: 39822 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Mar 2025 18:23:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 3 weeks

1
0
0 0

[XS] Change in docker-playground[master]: ttcn3-bts-test: Run fake_trx with sched-prio-rr

by fixeria

Attention is currently required from: daniel, laforge, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/docker-playground/+/39816?usp=email ) Change subject: ttcn3-bts-test: Run fake_trx with sched-prio-rr ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/39816?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I8f9df66e0819881587b55c93043fed9a294ab5e8 Gerrit-Change-Number: 39816 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Mar 2025 18:23:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 3 weeks

1
0
0 0

[S] Change in osmocom-bb[master]: Set sched RR Priority on main thread

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmocom-bb/+/39817?usp=email ) Change subject: Set sched RR Priority on main thread ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/39817?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I6aa22125e7de4f472d691b271639d5bee25762cb Gerrit-Change-Number: 39817 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Mar 2025 18:22:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 3 weeks

1
0
0 0

[S] Change in osmocom-bb[master]: fake_trx: Allow setting sched RR priority for clckgen thread

by fixeria

Attention is currently required from: daniel, kirr, laforge, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmocom-bb/+/39815?usp=email ) Change subject: fake_trx: Allow setting sched RR priority for clckgen thread ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File src/target/trx_toolkit/clck_gen.py: https://gerrit.osmocom.org/c/osmocom-bb/+/39815/comment/8eecb95c_9d6b6c63?u… : PS3, Line 73: self._thread.sched_rr_prio = self.sched_rr_prio Why is this needed? You're already setting `self.sched_rr_prio` above and the `_worker()` will have access to it via `self`. I think you can safely drop this line. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/39815?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I3c7f36c17fc7b9cae1023b4a0ed37f983dc286dc Gerrit-Change-Number: 39815 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: kirr <kirr(a)nexedi.com> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Mar 2025 18:19:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

3 months, 3 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: asterisk: Rework test TC_ims_call_mo_after_tcp_conn_closed with new e...

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39824?usp=email ) Change subject: asterisk: Rework test TC_ims_call_mo_after_tcp_conn_closed with new expectancies ...................................................................... asterisk: Rework test TC_ims_call_mo_after_tcp_conn_closed with new expectancies Previous expected behavior (and Asterisk-UE implementation) was wrong. Since recently, Asterisk behaves better, that is, whenever the TCP conn is dropped by the peer, it will attempt re-connecting and re-registering. Related: SYS#7398 Change-Id: I7ec1e8e30c4d72be96c8e300e0d038e63ba0e600 --- M asterisk/Asterisk_Tests.ttcn M asterisk/IMS_ConnectionHandler.ttcn 2 files changed, 65 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/24/39824/1 diff --git a/asterisk/Asterisk_Tests.ttcn b/asterisk/Asterisk_Tests.ttcn index dccf9fa..84ccb76 100644 --- a/asterisk/Asterisk_Tests.ttcn +++ b/asterisk/Asterisk_Tests.ttcn @@ -870,8 +870,7 @@ IMS_COORD.receive(IMS_COORD_CMD_CALL_REJECTED); } -private function f_TC_ims_call_mo(boolean close_tcp_after_registration := false, - boolean use_precondition_ext := true, +private function f_TC_ims_call_mo(boolean use_precondition_ext := true, boolean use_session_timer := false, call_established_fn call_established_cb := refers(call_established_fn_sleep1), void_fn sip_fn := refers(f_TC_internal_call_mo), @@ -885,7 +884,6 @@ sip_pars := f_init_ConnHdlrPars(idx := 1); ims_pars := f_init_IMS_ConnHdlrPars(); - ims_pars.subscr.close_tcp_after_registration := close_tcp_after_registration; f_ims_call_mo_configure(sip_pars, ims_pars); ims_pars.subscr.cp.support_precondition_ext := use_precondition_ext; @@ -947,13 +945,6 @@ f_TC_ims_call_mo(sip_fn := refers(f_TC_internal_call_mo_with_holdresume), ims_fn := refers(f_TC_ims_call_mo_IMS_ConnHdlr_with_holdresume)); } -/* TC_ims_call_mo, but IMS server closes the TCP conn used during 2nd register after ACKing it. - * Asterisk should consider it is still registered even if that TCP conn was closed, - * and MO call should work the same. - */ -testcase TC_ims_call_mo_after_tcp_conn_closed() runs on test_CT { - f_TC_ims_call_mo(close_tcp_after_registration := true); -} /* Test a 2nd call initiated from a local SIP UA towards IMS after having HOLD the 1st one. */ private function call_established_fn_holdswitchresume(SIPConnHdlrPars sip_pars, IMS_ConnHdlrPars ims_pars) runs on test_CT { @@ -1019,6 +1010,70 @@ ims_fn := refers(f_TC_ims_call_mo_IMS_ConnHdlr_2nd_mt_rejected)); } +/* TC_ims_call_mo, but IMS server closes the TCP conn used during 2nd register after ACKing it. + * Asterisk should then re-connect and re-register before placing a call towards IMS. */ +private function f_TC_ims_call_mo_after_tcp_conn_closed_IMS_ConnHdlr(charstring id) runs on IMS_ConnHdlr { + f_create_sip_expect(valueof(ts_SipUrl_from_Addr_Union(g_pars.subscr.registrar_sip_record.addr))); + /* First full register at the IMS: */ + as_IMS_register(); + f_sleep(1.0); + /* IMS closes TCP conn (TCP FIN/ACK): */ + f_IMS_tcp_close(); + /* Proceed similar to TC_ims_call_mo: expect new full register + MO call: */ + f_TC_ims_call_mo_IMS_ConnHdlr(id); +} +testcase TC_ims_call_mo_after_tcp_conn_closed() runs on test_CT { + var SIPConnHdlrPars sip_pars; + var IMS_ConnHdlrPars ims_pars; + var SIPConnHdlr vc_conn_sip; + var IMS_ConnHdlr vc_conn_ims; + + f_init(); + + sip_pars := f_init_ConnHdlrPars(idx := 1); + ims_pars := f_init_IMS_ConnHdlrPars(); + + f_ims_call_mo_configure(sip_pars, ims_pars); + ims_pars.subscr.cp.support_precondition_ext := true; + ims_pars.subscr.cp.require_precondition_ext := true; + ims_pars.subscr.cp.mo.tx_coord_cmd_invite_trying := true; + ims_pars.subscr.cp.mo.support_timer_enable := false; + + vc_conn_ims := f_start_handler_IMS(refers(f_TC_ims_call_mo_after_tcp_conn_closed_IMS_ConnHdlr), ims_pars); + vc_conn_sip := f_start_handler(refers(f_TC_internal_call_mo), sip_pars); + + COORD.receive(COORD_CMD_REGISTERED) from vc_conn_sip; + + f_AMI_IMS_register(ims_pars); + /* Here IMS_ConnHdlr will have dropped the TCP conn from IMS. */ + as_AMI_IMS_register_Auth(ims_pars); + + f_ims_call_mo_establish(vc_conn_sip, vc_conn_ims); + + /* Call on-going */ + var call_established_fn call_established_cb := refers(call_established_fn_sleep1); + call_established_cb.apply(sip_pars, ims_pars); + + COORD.send(COORD_CMD_HANGUP) to vc_conn_sip; + IMS_COORD.receive(IMS_COORD_CMD_CALL_FINISHED) from vc_conn_ims; + + /* Notify network released dedicated bearer: */ + AMI_CLIENT.clear; + f_ami_action_DedicatedBearerStatus(AMI_CLIENT, + g_asterisk_chan_name, + "Down", fail_others := false); + + /* Trigger unregistration: */ + f_sleep(1.0); + COORD.send(COORD_CMD_UNREGISTER) to vc_conn_sip; + AMI_CLIENT.clear; + f_AMI_IMS_unregister(ims_pars); + + vc_conn_sip.done; + vc_conn_ims.done; + f_shutdown(); +} + /* Test MT call initiated by IMS */ private function f_TC_ims_call_mt_IMS_ConnHdlr(charstring id) runs on IMS_ConnHdlr { f_create_sip_expect(valueof(ts_SipUrl_from_Addr_Union(g_pars.subscr.registrar_sip_record.addr))); diff --git a/asterisk/IMS_ConnectionHandler.ttcn b/asterisk/IMS_ConnectionHandler.ttcn index 39abc59..2f4168a 100644 --- a/asterisk/IMS_ConnectionHandler.ttcn +++ b/asterisk/IMS_ConnectionHandler.ttcn @@ -84,7 +84,6 @@ charstring msisdn, boolean support_video, boolean support_smsip, - boolean close_tcp_after_registration, /* Expected User-Location-Info in P-Access-Network-Info */ charstring uli_str, IMS_AuthVector auth, @@ -211,7 +210,6 @@ msisdn := msisdn, support_video := false, support_smsip := false, - close_tcp_after_registration := false, uli_str := "2380100010000101", auth := { /* The Nonce field is the Base64 encoded version of the RAND value and concatenated with the AUTN: */ @@ -1022,9 +1020,6 @@ supported := supported, userAgent := omit); SIP.send(tx_resp); - if (g_pars.subscr.close_tcp_after_registration) { - f_IMS_tcp_close(); - } } [fail_others] as_SIP_fail_resp(sip_expect_str); [fail_others] as_SIP_fail_req(sip_expect_str); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39824?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7ec1e8e30c4d72be96c8e300e0d038e63ba0e600 Gerrit-Change-Number: 39824 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

3 months, 3 weeks

1
0
0 0

[XS] Change in osmo-pcap[master]: Bump version: 0.6.0.4-d0fa716 → 0.7.0

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39823?usp=email ) Change subject: Bump version: 0.6.0.4-d0fa716 → 0.7.0 ...................................................................... Bump version: 0.6.0.4-d0fa716 → 0.7.0 Change-Id: I46849147e586d6b410b7d3863e05b79b71eafd78 --- M debian/changelog 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/debian/changelog b/debian/changelog index c2e1781..63b73d0 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,12 @@ +osmo-pcap (0.7.0) unstable; urgency=medium + + * Drop use of deprecated vty is_config_node() cb + * pcap-server: Avoid closing cli conn if writing to disk fails + * pcap-server: Validate rolling over file was successful before writing to it + * pcap-server: Introduce VTY cmd file-write-queue-max-length + + -- Pau Espin Pedrol <pespin(a)sysmocom.de> Tue, 18 Mar 2025 16:24:50 +0100 + osmo-pcap (0.6.0) unstable; urgency=medium [ Pau Espin Pedrol ] -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39823?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I46849147e586d6b410b7d3863e05b79b71eafd78 Gerrit-Change-Number: 39823 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

3 months, 3 weeks

1
0
0 0

[XS] Change in osmo-pcap[master]: Bump version: 0.6.0.4-d0fa716 → 0.7.0

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39823?usp=email ) Change subject: Bump version: 0.6.0.4-d0fa716 → 0.7.0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39823?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I46849147e586d6b410b7d3863e05b79b71eafd78 Gerrit-Change-Number: 39823 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Mar 2025 15:29:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2025