March 2025 - gerrit-log - lists.osmocom.org

[S] Change in osmo-trx[master]: Drop use of deprecated vty is_config_node() cb
by laforge 05 Mar '25

05 Mar '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/39678?usp=email ) Change subject: Drop use of deprecated vty is_config_node() cb ...................................................................... Drop use of deprecated vty is_config_node() cb This callback was drepecated and is not ever called since libosmocore.git 70ce871532ab21955e0955d7e230eae65438f047 (release 1.3.0). See also libosmocore.git d31de237582f6fe3315d61bb9a488d4cda92654e. Change-Id: I1bbaa455c018ba9c0943ac3cf1ae5511ebb4b723 --- M CommonLibs/trx_vty.c 1 file changed, 0 insertions(+), 12 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/CommonLibs/trx_vty.c b/CommonLibs/trx_vty.c index bd1b0ce..9647722 100644 --- a/CommonLibs/trx_vty.c +++ b/CommonLibs/trx_vty.c @@ -781,17 +781,6 @@ return CMD_SUCCESS; } -static int trx_vty_is_config_node(struct vty *vty, int node) -{ - switch (node) { - case TRX_NODE: - case CHAN_NODE: - return 1; - default: - return 0; - } -} - static int trx_vty_go_parent(struct vty *vty) { switch (vty->node) { @@ -829,7 +818,6 @@ .version = PACKAGE_VERSION, .copyright = trx_copyright, .go_parent_cb = trx_vty_go_parent, - .is_config_node = trx_vty_is_config_node, }; struct trx_ctx *vty_trx_ctx_alloc(void *talloc_ctx) -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/39678?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I1bbaa455c018ba9c0943ac3cf1ae5511ebb4b723 Gerrit-Change-Number: 39678 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[S] Change in osmo-trx[master]: Drop use of deprecated vty is_config_node() cb
by laforge 05 Mar '25

05 Mar '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-trx/+/39678?usp=email ) Change subject: Drop use of deprecated vty is_config_node() cb ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/39678?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I1bbaa455c018ba9c0943ac3cf1ae5511ebb4b723 Gerrit-Change-Number: 39678 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Mar 2025 14:54:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-pcap[master]: Drop use of deprecated vty is_config_node() cb
by laforge 05 Mar '25

05 Mar '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39682?usp=email ) Change subject: Drop use of deprecated vty is_config_node() cb ...................................................................... Drop use of deprecated vty is_config_node() cb This callback was drepecated and is not ever called since libosmocore.git 70ce871532ab21955e0955d7e230eae65438f047 (release 1.3.0). See also libosmocore.git d31de237582f6fe3315d61bb9a488d4cda92654e. Fixes: 4e934bb546e173ea525d778983cccce8f7c563c0 Change-Id: Idaad5148c7ca486b84bd67ad2ad90b96c3126316 --- M include/osmo-pcap/common.h 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/include/osmo-pcap/common.h b/include/osmo-pcap/common.h index 7ac5bb0..5916c48 100644 --- a/include/osmo-pcap/common.h +++ b/include/osmo-pcap/common.h @@ -56,7 +56,6 @@ extern const struct log_info log_info; extern const char *osmopcap_copyright; extern int osmopcap_go_parent(struct vty *vty); -extern int osmopcap_is_config_node(struct vty *vty, int node); /* defined in libpcap's pcap-int.h, which is not public */ #ifndef MAXIMUM_SNAPLEN -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39682?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Idaad5148c7ca486b84bd67ad2ad90b96c3126316 Gerrit-Change-Number: 39682 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmo-pcap[master]: Drop use of deprecated vty is_config_node() cb
by laforge 05 Mar '25

05 Mar '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39682?usp=email ) Change subject: Drop use of deprecated vty is_config_node() cb ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39682?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Idaad5148c7ca486b84bd67ad2ad90b96c3126316 Gerrit-Change-Number: 39682 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Mar 2025 14:54:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-sysmon[master]: Drop use of deprecated vty is_config_node() cb
by laforge 05 Mar '25

05 Mar '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sysmon/+/39681?usp=email ) Change subject: Drop use of deprecated vty is_config_node() cb ...................................................................... Drop use of deprecated vty is_config_node() cb This callback was drepecated and is not ever called since libosmocore.git 70ce871532ab21955e0955d7e230eae65438f047 (release 1.3.0). See also libosmocore.git d31de237582f6fe3315d61bb9a488d4cda92654e. Change-Id: Ib10b939fbec2620b22c739c57aecbf9d45c27898 --- M src/osysmon_main.c 1 file changed, 0 insertions(+), 11 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osysmon_main.c b/src/osysmon_main.c index 2d5ebfa..0794630 100644 --- a/src/osysmon_main.c +++ b/src/osysmon_main.c @@ -44,16 +44,6 @@ return vty->node; } -static int osysmon_is_config_node(struct vty *vty, int node) -{ - switch (node) { - /* no non-config-nodes */ - default: - return 1; - } -} - - static struct vty_app_info vty_info = { .name = "osysmon", .copyright = @@ -63,7 +53,6 @@ "There is NO WARRANTY, to the extent permitted by law.\r\n", .version = PACKAGE_VERSION, .go_parent_cb = osysmon_go_parent, - .is_config_node = osysmon_is_config_node, }; struct osysmon_state *g_oss; -- To view, visit https://gerrit.osmocom.org/c/osmo-sysmon/+/39681?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-Change-Id: Ib10b939fbec2620b22c739c57aecbf9d45c27898 Gerrit-Change-Number: 39681 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[S] Change in osmo-sysmon[master]: Drop use of deprecated vty is_config_node() cb
by laforge 05 Mar '25

05 Mar '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-sysmon/+/39681?usp=email ) Change subject: Drop use of deprecated vty is_config_node() cb ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sysmon/+/39681?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-Change-Id: Ib10b939fbec2620b22c739c57aecbf9d45c27898 Gerrit-Change-Number: 39681 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Mar 2025 14:54:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-cbc[master]: Drop unnecessary static initialization to NULL
by laforge 05 Mar '25

05 Mar '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/39680?usp=email ) Change subject: Drop unnecessary static initialization to NULL ...................................................................... Drop unnecessary static initialization to NULL Moreover, this callback was drepecated and is not ever called since libosmocore.git 70ce871532ab21955e0955d7e230eae65438f047 (release 1.3.0). See also libosmocore.git d31de237582f6fe3315d61bb9a488d4cda92654e. Change-Id: I68ed65537eb6f33ef666a79ddef70b46c995e0e7 --- M src/cbc_main.c 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/cbc_main.c b/src/cbc_main.c index c777ef6..2de8c72 100644 --- a/src/cbc_main.c +++ b/src/cbc_main.c @@ -147,7 +147,6 @@ .copyright = cbc_copyright, .go_parent_cb = cbc_vty_go_parent, .version = PACKAGE_VERSION, - .is_config_node = NULL, }; static struct { -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/39680?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I68ed65537eb6f33ef666a79ddef70b46c995e0e7 Gerrit-Change-Number: 39680 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmo-cbc[master]: Drop unnecessary static initialization to NULL
by laforge 05 Mar '25

05 Mar '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-cbc/+/39680?usp=email ) Change subject: Drop unnecessary static initialization to NULL ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/39680?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I68ed65537eb6f33ef666a79ddef70b46c995e0e7 Gerrit-Change-Number: 39680 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Mar 2025 14:54:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: Drop use of deprecated vty is_config_node() cb
by laforge 05 Mar '25

05 Mar '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39679?usp=email ) Change subject: Drop use of deprecated vty is_config_node() cb ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39679?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ib0d0079c76a18b09cde6ef3f22dda618ff5fbc98 Gerrit-Change-Number: 39679 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Mar 2025 14:54:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-bsc[master]: Drop use of deprecated vty is_config_node() cb
by laforge 05 Mar '25

05 Mar '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39677?usp=email ) Change subject: Drop use of deprecated vty is_config_node() cb ...................................................................... Drop use of deprecated vty is_config_node() cb This callback was drepecated and is not ever called since libosmocore.git 70ce871532ab21955e0955d7e230eae65438f047 (release 1.3.0). See also libosmocore.git d31de237582f6fe3315d61bb9a488d4cda92654e. Change-Id: I391a6fc9f7325c1770ce410d31ed2d820726225a --- M src/osmo-bsc/osmo_bsc_main.c 1 file changed, 0 insertions(+), 20 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bsc/osmo_bsc_main.c b/src/osmo-bsc/osmo_bsc_main.c index 8da3199..77506c8 100644 --- a/src/osmo-bsc/osmo_bsc_main.c +++ b/src/osmo-bsc/osmo_bsc_main.c @@ -631,25 +631,6 @@ return vty->node; } -static int bsc_vty_is_config_node(struct vty *vty, int node) -{ - /* Check if libosmo-sccp declares the node in - * question as config node */ - if (osmo_ss7_is_config_node(vty, node)) - return 1; - - switch (node) { - /* add items that are not config */ - case OML_NODE: - case OM2K_NODE: - case CONFIG_NODE: - return 0; - - default: - return 1; - } -} - static struct vty_app_info vty_info = { .name = "OsmoBSC", .copyright = @@ -663,7 +644,6 @@ "There is NO WARRANTY, to the extent permitted by law.\r\n", .version = PACKAGE_VERSION, .go_parent_cb = bsc_vty_go_parent, - .is_config_node = bsc_vty_is_config_node, .usr_attr_desc = { [BSC_VTY_ATTR_RESTART_ABIS_OML_LINK] = \ "This command applies on A-bis OML link (re)establishment", -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39677?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I391a6fc9f7325c1770ce410d31ed2d820726225a Gerrit-Change-Number: 39677 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0