March 2025 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-ggsn[master]: Fix Typos
by daniel 05 Mar '25

05 Mar '25

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/39699?usp=email ) Change subject: Fix Typos ...................................................................... Fix Typos Change-Id: Id39fdec016115b34453698b73aacf7be7461504b --- M gtp/gsn.c M gtp/gtp.c 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/99/39699/1 diff --git a/gtp/gsn.c b/gtp/gsn.c index 2fee812..7022212 100644 --- a/gtp/gsn.c +++ b/gtp/gsn.c @@ -112,7 +112,7 @@ .desc = "Counter N3-REQUESTS holds the maximum number of attempts made by GTP to send a request message" }, { .T = GTP_GSN_TIMER_T3_HOLD_RESPONSE, .default_val = 5 * 3 /* (GTP_GSN_TIMER_T3_RESPONSE * GTP_GSN_TIMER_N3_REQUESTS) */, .unit = OSMO_TDEF_S, - .desc = "Time a GTP respoonse message is kept cached to re-transmit it when a duplicate request is received. Value is generally equal to (T3-RESPONSE * N3-REQUESTS) set at the peer" + .desc = "Time a GTP response message is kept cached to re-transmit it when a duplicate request is received. Value is generally equal to (T3-RESPONSE * N3-REQUESTS) set at the peer" }, {} }; diff --git a/gtp/gtp.c b/gtp/gtp.c index 3209a64..9f2d484 100644 --- a/gtp/gtp.c +++ b/gtp/gtp.c @@ -515,7 +515,7 @@ } else { unsigned int t3_hold_resp; LOGP(DLGTP, LOGL_DEBUG, "Registering seq=%" PRIu16 - " in restransmit resp queue\n", seq); + " in retransmit resp queue\n", seq); t3_hold_resp = osmo_tdef_get(gsn->tdef, GTP_GSN_TIMER_T3_HOLD_RESPONSE, OSMO_TDEF_S, -1); memcpy(&qmsg->p, packet, sizeof(union gtp_packet)); qmsg->l = len; -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/39699?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Id39fdec016115b34453698b73aacf7be7461504b Gerrit-Change-Number: 39699 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>

1 0

[S] Change in aram-applet[master]: AccessRuleMaster: allow locking of STORE DATA commands
by laforge 05 Mar '25

05 Mar '25

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/aram-applet/+/39615?usp=email ) Change subject: AccessRuleMaster: allow locking of STORE DATA commands ...................................................................... Patch Set 2: Code-Review+1 (2 comments) File aram/src/main/java/fr/bmartel/aram/AccessRuleMaster.java: https://gerrit.osmocom.org/c/aram-applet/+/39615/comment/d9b377fc_2e443dff?… : PS2, Line 106: ISOException.throwIt(ISO7816.SW_SECURITY_STATUS_NOT_SATISFIED); > This is part of the scheme. […] Done https://gerrit.osmocom.org/c/aram-applet/+/39615/comment/86404513_27c7898e?… : PS2, Line 307: this.aram_lock_status = false; > This method is called from processData() and process(). […] Ok, I was not aware that processData is ony invoked by the SD if INSTALL (for PERSONALIZATION) is requested. The spec reference seems to be Section 5 of GPC_Spec_2_2Amendmend_A_1.0.1.pdf (GPC_SPE_007). Might make sense to add a comment above the method to remind everyone reading this code. -- To view, visit https://gerrit.osmocom.org/c/aram-applet/+/39615?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: aram-applet Gerrit-Branch: master Gerrit-Change-Id: I86437844585c22fc4280cc48b99edbb56e3159db Gerrit-Change-Number: 39615 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Mar 2025 14:33:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in osmo-pcu[master]: tests/alloc: alloc_tbfs(): fix always true condition
by pespin 05 Mar '25

05 Mar '25

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-pcu/+/39698?usp=email ) Change subject: tests/alloc: alloc_tbfs(): fix always true condition ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Looks like something needs fixing in this patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/39698?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ia345938512a2f4f92523596beb19d7c127a8a601 Gerrit-Change-Number: 39698 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Mar 2025 14:31:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmo-iuh[master]: iu_client: add ranap_iu_page_cs2/ranap_iu_page_ps2
by pespin 05 Mar '25

05 Mar '25

Attention is currently required from: daniel, laforge, lynxis lazus, neels. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-iuh/+/38946?usp=email ) Change subject: iu_client: add ranap_iu_page_cs2/ranap_iu_page_ps2 ...................................................................... Patch Set 19: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/38946?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I1f07e96642737160d387de3e4c3f71d288d356dd Gerrit-Change-Number: 38946 Gerrit-PatchSet: 19 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 05 Mar 2025 14:30:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: filesystem: do not decode short TransRecEF records
by laforge 05 Mar '25

05 Mar '25

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/39670?usp=email ) Change subject: filesystem: do not decode short TransRecEF records ...................................................................... Patch Set 3: (1 comment) File pySim/filesystem.py: https://gerrit.osmocom.org/c/pysim/+/39670/comment/74b5f73a_309b70cb?usp=em… : PS3, Line 1231: if len(raw_hex_data) // 2 < self.__get_rec_len(): I would think this is too harsh. I would instead simply treat any too-short trailer as invalid data. At the very least we should accept shorter-than-needed trailers if they contain 0xff padding. Or can you find any specific spec reference that would mandate/require the size to be always 3*N where 3 is the size of an element? I think I know that some EFs are specified that way, but I'm not sure if that's universally true... -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39670?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib1dc4d7ce306f1f0b080bb4b6abc36e72431d3fa Gerrit-Change-Number: 39670 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Mar 2025 14:29:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in libosmo-abis[master]: trau_frame encode8_hr: simplify setting of C5 for odd parity
by laforge 05 Mar '25

05 Mar '25

Attention is currently required from: falconia. laforge has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39669?usp=email ) Change subject: trau_frame encode8_hr: simplify setting of C5 for odd parity ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: > > it will bite us in the butt if we ever want to change anything about this function, and the strang […] Acknowledged -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39669?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I30c7dfdaaadd0fd4cb084cf02c66c0f19a40ae42 Gerrit-Change-Number: 39669 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Wed, 05 Mar 2025 14:26:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[S] Change in osmo-msc[master]: vlr: extend the subscriber invalidate callback with reasons
by lynxis lazus 05 Mar '25

05 Mar '25

Attention is currently required from: neels. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38488?usp=email ) Change subject: vlr: extend the subscriber invalidate callback with reasons ...................................................................... Patch Set 8: (1 comment) File include/osmocom/vlr/vlr.h: https://gerrit.osmocom.org/c/osmo-msc/+/38488/comment/c9583429_9683b71a?usp… : PS5, Line 253: > (maybe good to describe the meaning of the cancel_by_update argument) Done. cancel_by_update got replaced by an enum -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38488?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie5b687318b106a230fcee52deba86649641004b3 Gerrit-Change-Number: 38488 Gerrit-PatchSet: 8 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Mar 2025 14:26:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: HTTP_Adapter: add missing omit qualifiers
by laforge 05 Mar '25

05 Mar '25

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39692?usp=email ) Change subject: HTTP_Adapter: add missing omit qualifiers ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39692?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I985021852cbe2bcce60b1466e8ec9c3820a0c0f8 Gerrit-Change-Number: 39692 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Mar 2025 14:23:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: HTTP_Adapter: allow requests to different hosts
by laforge 05 Mar '25

05 Mar '25

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39657?usp=email ) Change subject: HTTP_Adapter: allow requests to different hosts ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39657?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic87674f2381b3c6a1be6d0ce28a9e5403cda201b Gerrit-Change-Number: 39657 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Mar 2025 14:23:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-iuh[master]: iu_client: add ranap_iu_page_cs2/ranap_iu_page_ps2
by lynxis lazus 05 Mar '25

05 Mar '25

Attention is currently required from: daniel, laforge, neels, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-iuh/+/38946?usp=email ) Change subject: iu_client: add ranap_iu_page_cs2/ranap_iu_page_ps2 ...................................................................... Patch Set 19: (1 comment) File src/iu_client.c: https://gerrit.osmocom.org/c/osmo-iuh/+/38946/comment/c976fd40_22c262fc?usp… : PS13, Line 914: int ranap_iu_page_ps2(const char *imsi, const uint32_t *ptmsi, const struct osmo_routing_area_id *rai) > I agree, the consistent thing to is to have it in the C source file. i moved it into the c file. -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/38946?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I1f07e96642737160d387de3e4c3f71d288d356dd Gerrit-Change-Number: 38946 Gerrit-PatchSet: 19 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Mar 2025 14:23:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0