March 2025 - gerrit-log - lists.osmocom.org

[S] Change in osmo-bsc[master]: Drop use of deprecated vty is_config_node() cb
by laforge 05 Mar '25

05 Mar '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39677?usp=email ) Change subject: Drop use of deprecated vty is_config_node() cb ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39677?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I391a6fc9f7325c1770ce410d31ed2d820726225a Gerrit-Change-Number: 39677 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Mar 2025 14:52:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in libosmo-sigtran[master]: AS loadsharing: Initial routing implementation based on extended-SLS
by laforge 05 Mar '25

05 Mar '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39377?usp=email ) Change subject: AS loadsharing: Initial routing implementation based on extended-SLS ...................................................................... Patch Set 11: Code-Review+1 (1 comment) File include/osmocom/sigtran/osmo_ss7.h: https://gerrit.osmocom.org/c/libosmo-sigtran/+/39377/comment/1db3c714_82600… : PS11, Line 129: O so basically an external application cannot look routes anymore? I'm not saying it's critical, just wanting to be clear about the consequences. The way how I read the code it would still work except there was an extended linkset? Maybe mention ". This function doesn't work with extended linksets" to the deprecated msg? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39377?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I0fb4ca4959096f748a23082efa0481300de56436 Gerrit-Change-Number: 39377 Gerrit-PatchSet: 11 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Mar 2025 14:52:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[L] Change in libosmo-sigtran[master]: AS loadsharing: Introduce combined_linkset
by pespin 05 Mar '25

05 Mar '25

Attention is currently required from: osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38731?usp=email ) Change subject: AS loadsharing: Introduce combined_linkset ...................................................................... Patch Set 13: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38731?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I500ec74ba975e3c93071771027e4e5fe6000e6f3 Gerrit-Change-Number: 38731 Gerrit-PatchSet: 13 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Mar 2025 14:51:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-sigtran[master]: AS loadsharing: Implement AS loadshare, skip unavailable AS/lset when...
by pespin 05 Mar '25

05 Mar '25

Attention is currently required from: laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39391?usp=email ) Change subject: AS loadsharing: Implement AS loadshare, skip unavailable AS/lset when choosing ...................................................................... Patch Set 10: (1 comment) File src/ss7_combined_linkset.h: https://gerrit.osmocom.org/c/libosmo-sigtran/+/39391/comment/fc8b8e08_6f649… : PS10, Line 36: last_route_roundrobin > Yes, good catch, I thought I had done this but I apparently forgot 😊 It was already there in the patch actually, https://gerrit.osmocom.org/c/libosmo-sigtran/+/39391/10/src/osmo_ss7_combin… line 153. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39391?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I928fb1ef5db6922f1386a188e3fbf9e70780f25d Gerrit-Change-Number: 39391 Gerrit-PatchSet: 10 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 05 Mar 2025 14:51:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ggsn[master]: Fix Typos
by daniel 05 Mar '25

05 Mar '25

daniel has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/39699?usp=email ) Change subject: Fix Typos ...................................................................... Fix Typos Change-Id: Id39fdec016115b34453698b73aacf7be7461504b --- M gtp/gsn.c M gtp/gtp.c 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/gtp/gsn.c b/gtp/gsn.c index 2fee812..7022212 100644 --- a/gtp/gsn.c +++ b/gtp/gsn.c @@ -112,7 +112,7 @@ .desc = "Counter N3-REQUESTS holds the maximum number of attempts made by GTP to send a request message" }, { .T = GTP_GSN_TIMER_T3_HOLD_RESPONSE, .default_val = 5 * 3 /* (GTP_GSN_TIMER_T3_RESPONSE * GTP_GSN_TIMER_N3_REQUESTS) */, .unit = OSMO_TDEF_S, - .desc = "Time a GTP respoonse message is kept cached to re-transmit it when a duplicate request is received. Value is generally equal to (T3-RESPONSE * N3-REQUESTS) set at the peer" + .desc = "Time a GTP response message is kept cached to re-transmit it when a duplicate request is received. Value is generally equal to (T3-RESPONSE * N3-REQUESTS) set at the peer" }, {} }; diff --git a/gtp/gtp.c b/gtp/gtp.c index 3209a64..9f2d484 100644 --- a/gtp/gtp.c +++ b/gtp/gtp.c @@ -515,7 +515,7 @@ } else { unsigned int t3_hold_resp; LOGP(DLGTP, LOGL_DEBUG, "Registering seq=%" PRIu16 - " in restransmit resp queue\n", seq); + " in retransmit resp queue\n", seq); t3_hold_resp = osmo_tdef_get(gsn->tdef, GTP_GSN_TIMER_T3_HOLD_RESPONSE, OSMO_TDEF_S, -1); memcpy(&qmsg->p, packet, sizeof(union gtp_packet)); qmsg->l = len; -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/39699?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Id39fdec016115b34453698b73aacf7be7461504b Gerrit-Change-Number: 39699 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-bsc[master]: nokia_site: add function to unlock and reset TRXes
by laforge 05 Mar '25

05 Mar '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39652?usp=email ) Change subject: nokia_site: add function to unlock and reset TRXes ...................................................................... nokia_site: add function to unlock and reset TRXes We have a long outstanding issue with TRX RSL bootstrap, espcially with BTSes with more than one TRX. The more TRX a BTS has, the more time it takes for it get to a ready state. This commit changes the TRX bootstrap logic as the following: 1. During OML initial config, all TRXes are configured locked. This gives a better controled state of TRXes, and the BTS enough time to do internal checks, SW load etc. 2. BTS_CONF_COMPL usde as entry point for the RSL bootstrap. 3. Unlock all TRXes, and give the BCCH TRX a reset. 4. Start RSL bootstrap. Runtime tested with InSite and a MetroSite with 4 TRXes. Co-authored by: Tomcsányi Domonkos <domi(a)tomcsanyi.net> Change-Id: I9042a1e24f0932a23a26185181481db2ceddbb7c --- M src/osmo-bsc/bts_nokia_site.c 1 file changed, 73 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bsc/bts_nokia_site.c b/src/osmo-bsc/bts_nokia_site.c index ca9ea8f..4e3f63c 100644 --- a/src/osmo-bsc/bts_nokia_site.c +++ b/src/osmo-bsc/bts_nokia_site.c @@ -664,6 +664,7 @@ #define NOKIA_MSG_BLOCK_CTRL_REQ 168 #define NOKIA_MSG_STATE_CHANGED 172 #define NOKIA_MSG_ALARM 174 +#define NOKIA_MSG_CHA_ADM_STATE 175 /* some element IDs */ @@ -779,7 +780,7 @@ /* ID = 0x44 (Object current state) */ /* length = 1 */ /* [93] */ - 0x03, + 0x02, 0x7F, 0x7C, 0x0A, /* ID = 0x7C (FU BSIC) ## constructed ## */ @@ -1340,6 +1341,55 @@ return abis_nm_send(bts, NOKIA_MSG_RESET_REQ, ref, data, len_data); } +static uint8_t trx_unlock[] = { + 0x7F, 0x65, 0x0B, + /* ID = 0x65 (Obj. identity and obj. state) ## constructed ## */ + /* length = 11 */ + /* [83] */ + + 0x5F, 0x40, 0x04, + /* ID = 0x40 (Object identity) */ + /* length = 4 */ + /* [86] */ + 0x00, 0x04, 0x01, 0xFF, + + 0x5F, 0x44, 0x01, + /* ID = 0x44 (Object current state) */ + /* length = 1 */ + /* [93] */ + 0x03, +}; + +static int abis_nm_cha_adm_trx_unlock(struct gsm_bts *bts, uint8_t trx_id, uint16_t ref) +{ + /* BTS_CHA_ADM_STATE */ + /* object_identity = TRX; object_state = locked/unlocked */ + uint8_t *data = trx_unlock; + data[8] = trx_id; + int len_data = sizeof(trx_unlock); + LOG_BTS(bts, DNM, LOGL_INFO, "TRX=%d Admin state change: UNLOCKED\n", trx_id); + dump_elements(data, len_data); + return abis_nm_send(bts, NOKIA_MSG_CHA_ADM_STATE, ref, data, len_data); +} + +static uint8_t trx_reset[] = { + 0x5F, 0x40, 0x04, + /* ID = 0x40 (Object identity) */ + /* length = 4 */ + /* [3] */ + 0x00, 0x04, 0x01, 0xFF, +}; + +static int abis_nm_trx_reset(struct gsm_bts *bts, uint8_t trx_id, uint16_t ref) +{ + uint8_t *data = trx_reset; + data[5] = trx_id; + int len_data = sizeof(trx_reset); + LOG_BTS(bts, DNM, LOGL_INFO, "TRX=%d Reset!\n", trx_id); + dump_elements(data, len_data); + return abis_nm_send(bts, NOKIA_MSG_RESET_REQ, ref, data, len_data); +} + /* TODO: put in a separate file ? */ static int abis_nm_send_multi_segments(struct gsm_bts *bts, uint8_t msg_type, @@ -1833,6 +1883,28 @@ /* send ACK */ abis_nm_ack(bts, ref); if (bts->nokia.configured != 0) { + struct gsm_bts_trx *trx; + uint8_t bcch_trx_nr; + /* we first need to unlock and reset the TRX that runs BCCH */ + llist_for_each_entry(trx, &bts->trx_list, list) { + if (trx->ts[0].pchan_from_config == GSM_PCHAN_CCCH || + trx->ts[0].pchan_from_config == GSM_PCHAN_CCCH_SDCCH4 || + trx->ts[0].pchan_from_config == GSM_PCHAN_CCCH_SDCCH4_CBCH) { + /* saving the number of TRX that has BCCH on it */ + bcch_trx_nr = trx->nr; + /* unlock TRX */ + abis_nm_cha_adm_trx_unlock(bts, trx->nr+1, ref); + /* reset TRX */ + abis_nm_trx_reset(bts, trx->nr+1, ref); + } + } + /* now unlocking all other TRXs */ + llist_for_each_entry(trx, &bts->trx_list, list) { + if (trx->nr != bcch_trx_nr) { + /* unlock TRX */ + abis_nm_cha_adm_trx_unlock(bts, trx->nr+1, ref); + } + } /* start TRX (RSL link) */ struct gsm_e1_subslot *e1_link = &sign_link->trx->rsl_e1_link; struct e1inp_line *line; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39652?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I9042a1e24f0932a23a26185181481db2ceddbb7c Gerrit-Change-Number: 39652 Gerrit-PatchSet: 6 Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-bsc[master]: nokia_site: add function to unlock and reset TRXes
by laforge 05 Mar '25

05 Mar '25

Attention is currently required from: csaba.sipos. laforge has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39652?usp=email ) Change subject: nokia_site: add function to unlock and reset TRXes ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39652?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I9042a1e24f0932a23a26185181481db2ceddbb7c Gerrit-Change-Number: 39652 Gerrit-PatchSet: 6 Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: csaba.sipos <metro4(a)freemail.hu> Gerrit-Comment-Date: Wed, 05 Mar 2025 14:44:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ggsn[master]: gtp: Send RAT type IE in update context request if present
by pespin 05 Mar '25

05 Mar '25

Attention is currently required from: daniel, lynxis lazus. pespin has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/39700?usp=email ) Change subject: gtp: Send RAT type IE in update context request if present ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/39700?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Idbabd123838b88cb0a2407480ca5fab10312a547 Gerrit-Change-Number: 39700 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 05 Mar 2025 14:43:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ggsn[master]: Fix Typos
by pespin 05 Mar '25

05 Mar '25

Attention is currently required from: daniel, lynxis lazus, osmith. pespin has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/39699?usp=email ) Change subject: Fix Typos ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/39699?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Id39fdec016115b34453698b73aacf7be7461504b Gerrit-Change-Number: 39699 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 05 Mar 2025 14:43:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ggsn[master]: gtp: Send RAT type IE in update context request if present
by daniel 05 Mar '25

05 Mar '25

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/39700?usp=email ) Change subject: gtp: Send RAT type IE in update context request if present ...................................................................... gtp: Send RAT type IE in update context request if present Change-Id: Idbabd123838b88cb0a2407480ca5fab10312a547 --- M gtp/gtp.c 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/00/39700/1 diff --git a/gtp/gtp.c b/gtp/gtp.c index 5876e5f..6a21461 100644 --- a/gtp/gtp.c +++ b/gtp/gtp.c @@ -2345,6 +2345,11 @@ gtpie_tlv(&packet, &length, GTP_MAX, GTPIE_DIR_TUN_FLAGS, pdp->dir_tun_flags.l, pdp->dir_tun_flags.v); + /* new R7 fields */ + if ((pdp->version == 1) && (pdp->rattype_given == 1)) + gtpie_tlv(&packet, &length, GTP_MAX, GTPIE_RAT_TYPE, + pdp->rattype.l, pdp->rattype.v); + gtp_req(gsn, pdp->version, pdp, &packet, length, inetaddr, cbp); return 0; -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/39700?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Idbabd123838b88cb0a2407480ca5fab10312a547 Gerrit-Change-Number: 39700 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>

1 0