March 2025 - gerrit-log - lists.osmocom.org

[M] Change in osmo-sgsn[master]: Assign MME GroupId/Code to remote MMEs
by laforge 05 Mar '25

05 Mar '25

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39294?usp=email ) Change subject: Assign MME GroupId/Code to remote MMEs ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39294?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I881aeba904fb6ca815842d36e466a2459ad81913 Gerrit-Change-Number: 39294 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 05 Mar 2025 15:00:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmocom-bb[master]: trx_toolkit: fix typos in Transceiver API doc
by laforge 05 Mar '25

05 Mar '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/39605?usp=email ) Change subject: trx_toolkit: fix typos in Transceiver API doc ...................................................................... trx_toolkit: fix typos in Transceiver API doc Change-Id: I59c6c75bb2a76fa082d0ad110930a2982ee6728f --- M src/target/trx_toolkit/transceiver.py 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/target/trx_toolkit/transceiver.py b/src/target/trx_toolkit/transceiver.py index e3a457f..7d08bb1 100644 --- a/src/target/trx_toolkit/transceiver.py +++ b/src/target/trx_toolkit/transceiver.py @@ -126,9 +126,9 @@ by default, at the moment of writing this patch). In order to reflect that delay in a virtual environment, this - implementation, just like a normal transceiver (e.g. osmo-trx), - queues all to be transmitted (L12TRX) bursts, so hey remain in - the transmit queue until the appropriate time of transmission. + implementation, just like osmo-trx, queues all to be transmitted + (L12TRX) bursts, so that they remain in the transmit queue until + the appropriate time of transmission. The API user is supposed to call recv_data_msg() in order to obtain a L12TRX message on the TRXD (data) interface, so it gets queued by -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/39605?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I59c6c75bb2a76fa082d0ad110930a2982ee6728f Gerrit-Change-Number: 39605 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmocom-bb[master]: trx_toolkit: correct Tx burst advance value
by laforge 05 Mar '25

05 Mar '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/39606?usp=email ) Change subject: trx_toolkit: correct Tx burst advance value ...................................................................... trx_toolkit: correct Tx burst advance value Change-Id: I559e86a15a3a8b4ec725f9d381e7d28628ea9155 --- M src/target/trx_toolkit/transceiver.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/src/target/trx_toolkit/transceiver.py b/src/target/trx_toolkit/transceiver.py index 7d08bb1..ce71bb1 100644 --- a/src/target/trx_toolkit/transceiver.py +++ b/src/target/trx_toolkit/transceiver.py @@ -122,8 +122,8 @@ are separate processes that are not perfectly synchronized in time. Moreover, the transceiver needs some time to prepare a burst for transmission. This is why the time difference between Uplink and - Downlink is actually much higher on practice (20 TDMA frame periods - by default, at the moment of writing this patch). + Downlink is actually much higher on practice (currently 2 TDMA + frame periods for both trxcon and osmo-bts-trx). In order to reflect that delay in a virtual environment, this implementation, just like osmo-trx, queues all to be transmitted -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/39606?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I559e86a15a3a8b4ec725f9d381e7d28628ea9155 Gerrit-Change-Number: 39606 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmocom-bb[master]: trx_toolkit: correct Tx burst advance value
by laforge 05 Mar '25

05 Mar '25

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/39606?usp=email ) Change subject: trx_toolkit: correct Tx burst advance value ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/39606?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I559e86a15a3a8b4ec725f9d381e7d28628ea9155 Gerrit-Change-Number: 39606 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Mar 2025 15:00:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmocom-bb[master]: trx_toolkit: fix typos in Transceiver API doc
by laforge 05 Mar '25

05 Mar '25

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/39605?usp=email ) Change subject: trx_toolkit: fix typos in Transceiver API doc ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/39605?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I59c6c75bb2a76fa082d0ad110930a2982ee6728f Gerrit-Change-Number: 39605 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Mar 2025 15:00:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-hlr[master]: Drop use of deprecated vty is_config_node() cb
by laforge 05 Mar '25

05 Mar '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/39687?usp=email ) Change subject: Drop use of deprecated vty is_config_node() cb ...................................................................... Drop use of deprecated vty is_config_node() cb This callback was drepecated and is not ever called since libosmocore.git 70ce871532ab21955e0955d7e230eae65438f047 (release 1.3.0). See also libosmocore.git d31de237582f6fe3315d61bb9a488d4cda92654e. Change-Id: I0a77ff4c0a880230116a361651c78c77328db989 --- M include/osmocom/hlr/hlr_vty.h M src/hlr.c M src/hlr_vty.c 3 files changed, 0 insertions(+), 14 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/include/osmocom/hlr/hlr_vty.h b/include/osmocom/hlr/hlr_vty.h index 8601590..10ea8b7 100644 --- a/include/osmocom/hlr/hlr_vty.h +++ b/include/osmocom/hlr/hlr_vty.h @@ -48,7 +48,6 @@ #define A38_COMP128_KEY_LEN 16 #define MILENAGE_KEY_LEN 16 -int hlr_vty_is_config_node(struct vty *vty, int node); int hlr_vty_go_parent(struct vty *vty); void hlr_vty_init(void *hlr_ctx); void dgsm_vty_init(void); diff --git a/src/hlr.c b/src/hlr.c index a900e23..0cfa09a 100644 --- a/src/hlr.c +++ b/src/hlr.c @@ -754,7 +754,6 @@ .name = "OsmoHLR", .version = PACKAGE_VERSION, .copyright = vlr_copyright, - .is_config_node = hlr_vty_is_config_node, .go_parent_cb = hlr_vty_go_parent, }; diff --git a/src/hlr_vty.c b/src/hlr_vty.c index 4694c44..18861d2 100644 --- a/src/hlr_vty.c +++ b/src/hlr_vty.c @@ -881,18 +881,6 @@ return vty->node; } -int hlr_vty_is_config_node(struct vty *vty, int node) -{ - switch (node) { - /* add items that are not config */ - case CONFIG_NODE: - return 0; - - default: - return 1; - } -} - void hlr_vty_init(void *hlr_ctx) { cfg_reject_cause_cmd.string = -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/39687?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I0a77ff4c0a880230116a361651c78c77328db989 Gerrit-Change-Number: 39687 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[S] Change in osmo-hlr[master]: Drop use of deprecated vty is_config_node() cb
by laforge 05 Mar '25

05 Mar '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hlr/+/39687?usp=email ) Change subject: Drop use of deprecated vty is_config_node() cb ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/39687?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I0a77ff4c0a880230116a361651c78c77328db989 Gerrit-Change-Number: 39687 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Mar 2025 14:59:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ccid-firmware[master]: ccid: unbreak deinit a bit more..
by laforge 05 Mar '25

05 Mar '25

Attention is currently required from: Hoernchen. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39572?usp=email ) Change subject: ccid: unbreak deinit a bit more.. ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: better commit log comment would be great. -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39572?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I07f8e39ff0d51cf0d986645b12181b17bca345f5 Gerrit-Change-Number: 39572 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Mar 2025 14:59:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[L] Change in libosmo-sigtran[master]: AS loadsharing: Initial routing implementation based on extended-SLS
by pespin 05 Mar '25

05 Mar '25

Attention is currently required from: laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39377?usp=email ) Change subject: AS loadsharing: Initial routing implementation based on extended-SLS ...................................................................... Patch Set 11: (1 comment) File include/osmocom/sigtran/osmo_ss7.h: https://gerrit.osmocom.org/c/libosmo-sigtran/+/39377/comment/c43f0a8e_b063b… : PS11, Line 129: O > so basically an external application cannot look routes anymore? I'm not saying it's critical, just […] This function becomes deprecated because anyway it doesn't take into account all the possible route-label fields, hence it's not really useful in the general scenario. Deprecating this one indeed leaves no "public" way of looking up routes, but I acknowledge this may be updated in follow-up patches once I have this tone, see previous comment https://gerrit.osmocom.org/c/libosmo-sigtran/+/39377/4/include/osmocom/sigt… which contains further explanation. I prefer now to have this private and once I look into the specific IPA scenario from osmo-bsc I mention in the comment see what's the best set of APIs to expose. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39377?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I0fb4ca4959096f748a23082efa0481300de56436 Gerrit-Change-Number: 39377 Gerrit-PatchSet: 11 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 05 Mar 2025 14:57:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[S] Change in ...pyosmocom[master]: utils: add unrpad()
by laforge 05 Mar '25

05 Mar '25

Attention is currently required from: neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/39600?usp=email ) Change subject: utils: add unrpad() ...................................................................... Patch Set 1: -Code-Review (1 comment) File src/osmocom/utils.py: https://gerrit.osmocom.org/c/python/pyosmocom/+/39600/comment/4aebfd59_b20e… : PS1, Line 125: """unpad string on the right side -- reverse of rpad(). > hmm indeed .. […] wouldn't it be good then to add unrpad as a method to the hexstr type? Maybe also call it rstrip there to make it look like the stdlib, as that's what it basically is? -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/39600?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I48c23390926f8c9412624edb4481e7f4cd3f4b46 Gerrit-Change-Number: 39600 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Mar 2025 14:57:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0