March 2025 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-bsc[master]: nokia: Fix uninitialized access
by pespin 05 Mar '25

05 Mar '25

Attention is currently required from: csaba.sipos, domi, fixeria, laforge, osmith. Hello csaba.sipos, domi, fixeria, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/39701?usp=email to look at the new patch set (#2). Change subject: nokia: Fix uninitialized access ...................................................................... nokia: Fix uninitialized access /osmo-bsc/src/osmo-bsc/bts_nokia_site.c:1903:36: error: 'bcch_trx_nr' may be used uninitialized [-Werror=maybe-uninitialized] 1903 | if (trx->nr != bcch_trx_nr) { | Change-Id: I6bfdefb44235291a5a1f1c72e5a5149d15e19b8f --- M src/osmo-bsc/bts_nokia_site.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/01/39701/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39701?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6bfdefb44235291a5a1f1c72e5a5149d15e19b8f Gerrit-Change-Number: 39701 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: csaba.sipos <metro4(a)freemail.hu> Gerrit-Reviewer: domi <domi(a)tomcsanyi.net> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: csaba.sipos <metro4(a)freemail.hu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: domi <domi(a)tomcsanyi.net>

1 0

[XS] Change in osmo-bsc[master]: nokia: Fix unitialized access
by pespin 05 Mar '25

05 Mar '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39701?usp=email ) Change subject: nokia: Fix unitialized access ...................................................................... nokia: Fix unitialized access /osmo-bsc/src/osmo-bsc/bts_nokia_site.c:1903:36: error: 'bcch_trx_nr' may be used uninitialized [-Werror=maybe-uninitialized] 1903 | if (trx->nr != bcch_trx_nr) { | Change-Id: I6bfdefb44235291a5a1f1c72e5a5149d15e19b8f --- M src/osmo-bsc/bts_nokia_site.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/01/39701/1 diff --git a/src/osmo-bsc/bts_nokia_site.c b/src/osmo-bsc/bts_nokia_site.c index 4e3f63c..e5f2c9d 100644 --- a/src/osmo-bsc/bts_nokia_site.c +++ b/src/osmo-bsc/bts_nokia_site.c @@ -1884,7 +1884,7 @@ abis_nm_ack(bts, ref); if (bts->nokia.configured != 0) { struct gsm_bts_trx *trx; - uint8_t bcch_trx_nr; + int bcch_trx_nr = -1; /* we first need to unlock and reset the TRX that runs BCCH */ llist_for_each_entry(trx, &bts->trx_list, list) { if (trx->ts[0].pchan_from_config == GSM_PCHAN_CCCH || -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39701?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6bfdefb44235291a5a1f1c72e5a5149d15e19b8f Gerrit-Change-Number: 39701 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: Drop use of deprecated vty is_config_node() cb
by pespin 05 Mar '25

05 Mar '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39679?usp=email ) Change subject: Drop use of deprecated vty is_config_node() cb ...................................................................... Drop use of deprecated vty is_config_node() cb This callback was drepecated and is not ever called since libosmocore.git 70ce871532ab21955e0955d7e230eae65438f047 (release 1.3.0). See also libosmocore.git d31de237582f6fe3315d61bb9a488d4cda92654e. Change-Id: Ib0d0079c76a18b09cde6ef3f22dda618ff5fbc98 --- M include/osmocom/sigtran/osmo_ss7.h M src/osmo_ss7_vty.c M stp/stp_main.c 3 files changed, 5 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmocom/sigtran/osmo_ss7.h b/include/osmocom/sigtran/osmo_ss7.h index 51c1cbd..66cbfe6 100644 --- a/include/osmocom/sigtran/osmo_ss7.h +++ b/include/osmocom/sigtran/osmo_ss7.h @@ -354,4 +354,6 @@ void osmo_ss7_vty_init_asp(void *ctx); void osmo_ss7_vty_init_sg(void *ctx); int osmo_ss7_vty_go_parent(struct vty *vty); -int osmo_ss7_is_config_node(struct vty *vty, int node); +int osmo_ss7_is_config_node(struct vty *vty, int node) + OSMO_DEPRECATED("Implicit parent node tracking has replaced the use of this callback. " + "This callback is no longer called, ever, and can be left NULL."); diff --git a/src/osmo_ss7_vty.c b/src/osmo_ss7_vty.c index 8365db2..f76a69e 100644 --- a/src/osmo_ss7_vty.c +++ b/src/osmo_ss7_vty.c @@ -3042,6 +3042,8 @@ return 0; } +/* This is no longer used. The libosmocore callback was deprecated is not ever called since. + * libosmocore.git 70ce871532ab21955e0955d7e230eae65438f047 (release 1.3.0). */ int osmo_ss7_is_config_node(struct vty *vty, int node) { switch (node) { diff --git a/stp/stp_main.c b/stp/stp_main.c index d630032..2d31ef0 100644 --- a/stp/stp_main.c +++ b/stp/stp_main.c @@ -73,7 +73,6 @@ .copyright = stp_copyright, .version = PACKAGE_VERSION, .go_parent_cb = osmo_ss7_vty_go_parent, - .is_config_node = osmo_ss7_is_config_node, }; static struct { -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39679?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ib0d0079c76a18b09cde6ef3f22dda618ff5fbc98 Gerrit-Change-Number: 39679 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: sccp: Apply SLS on locally-originated transmitted Connection-Oriented...
by pespin 05 Mar '25

05 Mar '25

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39689?usp=email ) Change subject: sccp: Apply SLS on locally-originated transmitted Connection-Oriented messages ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39689?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I1956acf631867b12b647d14c10057ded20d7fa2f Gerrit-Change-Number: 39689 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Mar 2025 15:08:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in libosmo-sigtran[master]: ASP loadsharing: Implement based on VTY configuration
by pespin 05 Mar '25

05 Mar '25

Attention is currently required from: daniel, fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39408?usp=email ) Change subject: ASP loadsharing: Implement based on VTY configuration ...................................................................... Patch Set 10: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39408?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I5f47e40b70ed566034cd1533b71e21fc03e94f6c Gerrit-Change-Number: 39408 Gerrit-PatchSet: 10 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Mar 2025 15:08:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-sigtran[master]: ASP loadsharing: Pass xua_msg down to xua_as_transmit_msg
by pespin 05 Mar '25

05 Mar '25

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39398?usp=email ) Change subject: ASP loadsharing: Pass xua_msg down to xua_as_transmit_msg ...................................................................... Patch Set 11: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39398?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I70e5d33c7537dc0b72b5abced876e69018cc0829 Gerrit-Change-Number: 39398 Gerrit-PatchSet: 11 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Mar 2025 15:08:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-sigtran[master]: ASP loadsharing: Pass ownership of Rx xua_msg up the stack [2/2]
by pespin 05 Mar '25

05 Mar '25

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39397?usp=email ) Change subject: ASP loadsharing: Pass ownership of Rx xua_msg up the stack [2/2] ...................................................................... Patch Set 11: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39397?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Icf3b4dda550637f722a9fe56d0313f49c8a2964e Gerrit-Change-Number: 39397 Gerrit-PatchSet: 11 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Mar 2025 15:07:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-sigtran[master]: ASP loadsharing: Pass ownership of Tx xua_msg down the stack [1/2]
by pespin 05 Mar '25

05 Mar '25

Attention is currently required from: daniel, fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39396?usp=email ) Change subject: ASP loadsharing: Pass ownership of Tx xua_msg down the stack [1/2] ...................................................................... Patch Set 10: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39396?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I49e718e624da08510a9c3d28bdb360c59f9a65d3 Gerrit-Change-Number: 39396 Gerrit-PatchSet: 10 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Mar 2025 15:07:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: AS loadsharing: Introduce AS rate_ctr tx:msu:sls:*
by pespin 05 Mar '25

05 Mar '25

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39407?usp=email ) Change subject: AS loadsharing: Introduce AS rate_ctr tx:msu:sls:* ...................................................................... Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39407?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ia446e11ea24ecb021a3dddf5547aa2b3cdbbe60b Gerrit-Change-Number: 39407 Gerrit-PatchSet: 9 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Mar 2025 15:07:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: AS loadsharing: Introduce AS rate_ctr rx:msu:sls:*
by pespin 05 Mar '25

05 Mar '25

Attention is currently required from: daniel. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39406?usp=email ) Change subject: AS loadsharing: Introduce AS rate_ctr rx:msu:sls:* ...................................................................... Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39406?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I695bd3933a116323db45ab7f45dcf539791139aa Gerrit-Change-Number: 39406 Gerrit-PatchSet: 9 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 05 Mar 2025 15:07:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0