Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/aram-applet/+/39615?usp=email ) Change subject: AccessRuleMaster: allow locking of STORE DATA commands ...................................................................... Patch Set 2: Code-Review+1 (2 comments) File aram/src/main/java/fr/bmartel/aram/AccessRuleMaster.java: https://gerrit.osmocom.org/c/aram-applet/+/39615/comment/d9b377fc_2e443dff?u... : PS2, Line 106: ISOException.throwIt(ISO7816.SW_SECURITY_STATUS_NOT_SATISFIED);

This is part of the scheme. […] Done

https://gerrit.osmocom.org/c/aram-applet/+/39615/comment/86404513_27c7898e?u... : PS2, Line 307: this.aram_lock_status = false;

This method is called from processData() and process(). […] Ok, I was not aware that processData is ony invoked by the SD if INSTALL (for PERSONALIZATION) is requested.

The spec reference seems to be Section 5 of GPC_Spec_2_2Amendmend_A_1.0.1.pdf (GPC_SPE_007). Might make sense to add a comment above the method to remind everyone reading this code. -- To view, visit https://gerrit.osmocom.org/c/aram-applet/+/39615?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: aram-applet Gerrit-Branch: master Gerrit-Change-Id: I86437844585c22fc4280cc48b99edbb56e3159db Gerrit-Change-Number: 39615 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Attention: dexter <pmaier@sysmocom.de> Gerrit-Comment-Date: Wed, 05 Mar 2025 14:33:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge@osmocom.org> Comment-In-Reply-To: dexter <pmaier@sysmocom.de>