Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/39670?usp=email ) Change subject: filesystem: do not decode short TransRecEF records ...................................................................... Patch Set 3: (1 comment) File pySim/filesystem.py: https://gerrit.osmocom.org/c/pysim/+/39670/comment/74b5f73a_309b70cb?usp=ema... : PS3, Line 1231: if len(raw_hex_data) // 2 < self.__get_rec_len(): I would think this is too harsh. I would instead simply treat any too-short trailer as invalid data. At the very least we should accept shorter-than-needed trailers if they contain 0xff padding. Or can you find any specific spec reference that would mandate/require the size to be always 3*N where 3 is the size of an element? I think I know that some EFs are specified that way, but I'm not sure if that's universally true... -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39670?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib1dc4d7ce306f1f0b080bb4b6abc36e72431d3fa Gerrit-Change-Number: 39670 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-Attention: dexter <pmaier@sysmocom.de> Gerrit-Comment-Date: Wed, 05 Mar 2025 14:29:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No